GitLab

The new interface is called createWebAudioSourceFromMediaStreamTrack(), it is used to create one WebAudioSource for each CreateMediaStreamSource() call. By doing this, we avoid calling into the same source provider when there are multiple WebAudio audioContexts.

Note that the code in this is not hooked up to anything. We need to implement the interface in Chrome then hook the code up in AudioContext.cpp

NOTRY=true

BUG=354468

Review URL: https://codereview.chromium.org/204293007

git-svn-id: svn://svn.chromium.org/blink/trunk@169859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

consolidates that into a separate file and also updates the generated gesture
sequences to be valid.

BUG=352164

Review URL: https://codereview.chromium.org/197923006

git-svn-id: svn://svn.chromium.org/blink/trunk@169858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/210053002

git-svn-id: svn://svn.chromium.org/blink/trunk@169857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changing the allocation of the initaial SkSurface in
Canvas2DLayerBridge so that it may be taken from the GrContext
texture pool. This should improve performance for apps that
rely heavily on transient canvas objects.

BUG=351798

Review URL: https://codereview.chromium.org/196833006

git-svn-id: svn://svn.chromium.org/blink/trunk@169856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/196133031

git-svn-id: svn://svn.chromium.org/blink/trunk@169855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Getting scopes info from V8 debugger takes significant time.
Sometimes we don't need the scopes at all, thus we can save on this expensive work.
For async stacks we will be getting "fast" scope chains: up to the Local scope only (coming soon).

R=yurys

Review URL: https://codereview.chromium.org/208263015

git-svn-id: svn://svn.chromium.org/blink/trunk@169854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The issue that required this workaround was fixed in
https://codereview.chromium.org/204983002/.

BUG=328156

Review URL: https://codereview.chromium.org/209963003

git-svn-id: svn://svn.chromium.org/blink/trunk@169853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, vsevik
BUG=353916

Review URL: https://codereview.chromium.org/198713006

git-svn-id: svn://svn.chromium.org/blink/trunk@169851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added NULL check.

BUG=354958
TEST=Check there is no crashes when the minimized test case is passed to
content_shell

Review URL: https://codereview.chromium.org/201573008

git-svn-id: svn://svn.chromium.org/blink/trunk@169849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/209813003

git-svn-id: svn://svn.chromium.org/blink/trunk@169848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/208313010

git-svn-id: svn://svn.chromium.org/blink/trunk@169847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354405
R=ager@chromium.org

Review URL: https://codereview.chromium.org/209843002

git-svn-id: svn://svn.chromium.org/blink/trunk@169846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The interface describes common part of nodes as well as containment and retainment edges. It used to iterate over the elements and serialize them.

BUG=None

Review URL: https://codereview.chromium.org/209653003

git-svn-id: svn://svn.chromium.org/blink/trunk@169845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will distinguish between setting the value on a newly created Attr
object from Document.createAttribute() and setting the value on an Attr
object already attached to an Element, e.g. one from Element.attributes.

If the first case is common but the second is rare it won't be possible
to make value readonly, but it could still be possible to drop the
Element association, which is the point of making it readonly.

BUG=none

Review URL: https://codereview.chromium.org/208333014

git-svn-id: svn://svn.chromium.org/blink/trunk@169844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While distributing the extra rowspan height in rows, result of multiplication
is overflowing in integer and whole method is getting failed due to this. So
typecasted a value to 'long long' and final result of the calculation always
fits in integer range.

BUG=334652
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/131103017

git-svn-id: svn://svn.chromium.org/blink/trunk@169843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, vsevik
BUG=354853

Review URL: https://codereview.chromium.org/208223002

git-svn-id: svn://svn.chromium.org/blink/trunk@169842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The overload resolution needed for the two FormData.append() methods can
be handled directly by generated code, so drop the custom code we had
in place for this API.

Along with it, handle the conversion of append()'s DOMString arguments
per WebIDL (as it is now), removing the special treatment of null and
undefined arguments. This also aligns with how others (Gecko, Trident)
handle these arguments.

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209933002

git-svn-id: svn://svn.chromium.org/blink/trunk@169841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=305842
TBR=pfeldman

Review URL: https://codereview.chromium.org/209423003

git-svn-id: svn://svn.chromium.org/blink/trunk@169840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up on crrev.com/206793006 and also call wrap() in the code generated
for a particular constructor overloading when [Custom=Wrap] is in effect
for one or more constructors.

R=nbarth@chromium.org,haraken@chromium.org
BUG=338804

Review URL: https://codereview.chromium.org/209893002

git-svn-id: svn://svn.chromium.org/blink/trunk@169839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ElementStyleResources are only allocated as a part object of another stack allocated object so we don't need
to use persistent heap collections as the entries will be marked conservatively via the stack.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/208053004

git-svn-id: svn://svn.chromium.org/blink/trunk@169838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=355489
TBR=philipj

Review URL: https://codereview.chromium.org/209913002

git-svn-id: svn://svn.chromium.org/blink/trunk@169837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes CSSParser which failed to properly report last
parsed chunk.

BUG=329825

Review URL: https://codereview.chromium.org/208593002

git-svn-id: svn://svn.chromium.org/blink/trunk@169836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds support for constructors when there's a custom wrap.

This is split off as 2/2 bindings-only change from:
Implement ImageData constructors.
https://codereview.chromium.org/196343032/

Follow-up to:
Use wrapper_configuration consistently in bindings
https://codereview.chromium.org/199633014/

R=haraken
BUG=338804

Review URL: https://codereview.chromium.org/206793006

git-svn-id: svn://svn.chromium.org/blink/trunk@169835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TBR=eseidel

Review URL: https://codereview.chromium.org/204983014

git-svn-id: svn://svn.chromium.org/blink/trunk@169834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354849
TBR=alancutter

Review URL: https://codereview.chromium.org/209813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/200783007

git-svn-id: svn://svn.chromium.org/blink/trunk@169832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TBR=eseidel

Review URL: https://codereview.chromium.org/207453003

git-svn-id: svn://svn.chromium.org/blink/trunk@169831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Originally [LegacyImplementedInBaseClass] was intended to be short-term,
as the name suggests, for some refactoring.

However, for more complex cases of 'implements' usage,
the requirements that 'implements' puts on C++ implementation
makes it an ugly mess.
Thus allowing implementation in base class seems useful long-term,
so re-introducing.

Per:
WebGLRenderingContextBase
https://codereview.chromium.org/205243013/

Documentation:
http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-ImplementedInBaseClass-i-

Compare earlier CL removing this:
Remove support for [LegacyImplementedInBaseClass] IDL extended attribute 
https://codereview.chromium.org/169273002/

R=haraken
BUG=344224

Review URL: https://codereview.chromium.org/209663005

git-svn-id: svn://svn.chromium.org/blink/trunk@169830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=355463
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/209783002

git-svn-id: svn://svn.chromium.org/blink/trunk@169829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After the migration to the new SVG property implementation, some unused
functions were left. This patch removes the remainder of the unused
functions.

Review URL: https://codereview.chromium.org/208523005

git-svn-id: svn://svn.chromium.org/blink/trunk@169828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the bindings overuse WrapperConfiguration::Dependent.
This changes it to use WrapperConfiguration::Independent
unless Dependent is actually needed, by computing it once
in the interface context.
(Fixes one FIXME and removes some hard-coding.)

This is split off as 1/2 bindings-only change from:
Implement ImageData constructors.
https://codereview.chromium.org/196343032/

BUG=345503
TBR=haraken

Review URL: https://codereview.chromium.org/199633014

git-svn-id: svn://svn.chromium.org/blink/trunk@169827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This part of the source is fairly fragile. I had to temporarily add a
direct include to WebFrame.h because typedefs cannot be forward
declared. Unfortunately, this causes IntSize.h to be included before
Cocoa. Since Cocoa.h can set NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES,
this can cause build failures with conflicting typedef redefinitions of
NSRect. To hack around this, we temporarily move the Cocoa.h include to
the header as well.

BUG=355268

Review URL: https://codereview.chromium.org/209663002

git-svn-id: svn://svn.chromium.org/blink/trunk@169826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometimes it's 0;

BUG=331927

Review URL: https://codereview.chromium.org/207143003

git-svn-id: svn://svn.chromium.org/blink/trunk@169825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=355459
TBR=apavlov

Review URL: https://codereview.chromium.org/209683003

git-svn-id: svn://svn.chromium.org/blink/trunk@169824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is doing mechanical replacement and there's nothing non-trivial.

BUG=340522

Review URL: https://codereview.chromium.org/204743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Shadow DOM styling spec was changed.
/content/ was reverted in the spec.

Original issue's description:
> Implement /content/ combinator.
> 
> spec: shadow styling
> http://dev.w3.org/csswg/shadow-styling/#content-combinator
> 
> The added layout tests are basically the same as ::content's, because /content/ combinator should have almost the same behavior (except css text, ::content with descendant combinator).
> 
> BUG=349334
> TEST=fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html,fast/dom/shadow/content-combinator-css-text.html,fast/dom/shadow/content-combinator-dynamic-attribute-change.html,fast/dom/shadow/content-combinator-in-inert-shadow.html,fast/dom/shadow/content-combinator-scoped.html,fast/dom/shadow/content-combinator-with-cat.html,fast/dom/shadow/content-combinator-with-hat.html,fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html,fast/dom/shadow/content-combinator-with-host-pseudo-class.html,fast/dom/shadow/content-combinator.html,fast/dom/shadow/multiple-content-combinator.html,fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169085

BUG=349334
TBR=dglazkov@chromium.org,hayato@chromium.org

Review URL: https://codereview.chromium.org/205563004

git-svn-id: svn://svn.chromium.org/blink/trunk@169822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Add a test to confirm that pre-finalization hook can be implmemented with HeapHashSet<WeakMmber<T>, U>.

BUG=

Review URL: https://codereview.chromium.org/204313002

git-svn-id: svn://svn.chromium.org/blink/trunk@169821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that we don't have partial layout we can recombine these methods. No
one should be calling the other one except updateLayoutIgnorePendingStylesheets
anyway.

R=pdr@chromium.org,ojan@chromium.org

Review URL: https://codereview.chromium.org/209323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLMediaElement::beginScrubbing() would setPausedInternal(true), a mode
of pausing that is invisible to scripts. If a media controller was
detached while scrubbing, HTMLMediaElement::endScrubbing() would never
be called and the element would be stuck in this mode.

Since a user can already pause, scrub and then continue playing, making
MediaControls do the same should work just fine. Simply keep track of
the state before scrubbing and avoid updating the play button(s) as long
as we're scrubbing.

Note that the special handling of ended() is not needed, since reaching
the end of the resource pauses. This wasn't the case at the time the
code was originally written.

BUG=341813

Review URL: https://codereview.chromium.org/204803002

git-svn-id: svn://svn.chromium.org/blink/trunk@169814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Don't rely on values computed as a side effect of paint. (https://codereview.chromium.org/208203002/)

Reason for revert:
Looks like this is causing ASSERTs due to calling layout-dependent code at the wrong time: https://code.google.com/p/chromium/issues/detail?id=355277

Original issue's description:
> Don't rely on values computed as a side effect of paint.
> 
> Contrary to the assertions on the bug, the current code is correct. As
> the user changes the selection, there will naturally be a visual
> affordance to indicate the selection changes. By the time we scroll,
> RL::hasBlockSelectionGapsBounds will be current and correct.
> 
> That said, the hope is that in the future paint will have no side
> effects at all, nor do we want layout tests to require repaints during
> their execution. So even if this is technically correct it's undesirable
> on a number of levels.
> 
> This cl replaces the use of hasBlockSelectionGapsBounds with non-paint
> related code (in fact, that function could be removed entirely).
> 
> R=abarth@chromium.org
> BUG=353827
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169752

TBR=abarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353827

Review URL: https://codereview.chromium.org/209543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169813 bbb929c8-8fbe-4397-9dbb-9b2b20218538