GitLab

Otherwise, parent window can be interacted with which causes
redraw problems.

R=estade@chromium.org
BUG=284368

Review URL: https://chromiumcodereview.appspot.com/23889021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223395 0039d316-1c4b-4281-b951-d872f2087c98

Multi-line text rendering in the Chromium UI is currently done by slicing the string into multiple lines by using text metrics from cross-platform libraries and rendering text by using different RenderText instances - one for each line. This approach has poor performance and is very bug-prone.

This CL adds a cross-platform interface and data structures to RenderText to support multi-line text rendering. This CL also implements the required platform-specific bits for Windows. Support for other platforms will be implemented in subsequent CLs.

Multi-line rendering as implemented in this CL is limited. Newline characters are ignored. RTL and complex scripts are supported, while there are be issues with selection highlights. Text-space <-> view-space mappings do not support RTL/complex scripts.

BUG=248597

Review URL: https://chromiumcodereview.appspot.com/16867016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223394 0039d316-1c4b-4281-b951-d872f2087c98

Ensure tooltips are closed when their anchor views go away. Also, close the
tooltip when shelf alignment changes.

BUG=288838
TEST=added to ash_unittests LauncherViewTest

Review URL: https://chromiumcodereview.appspot.com/24141003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223393 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds code which parses the JS heap snapshot retrieved from the
Dev tools.

BUG=274456

Review URL: https://chromiumcodereview.appspot.com/24076016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223392 0039d316-1c4b-4281-b951-d872f2087c98

This patch centralizes renderer binding management in ChildProcessLauncher,
simplifying ChildProcessConnection and encapsulating the logic in a nested
class.

BindingManager becomes responsible for all tasks related to adding, removing
(possibly in a delayed way) and inspecting the state of renderer out-of-memory
bindings.

BUG=290351

Review URL: https://chromiumcodereview.appspot.com/23532058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223391 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223390 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157793:157830&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/23503061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223389 0039d316-1c4b-4281-b951-d872f2087c98

The code was sending it directly to the RenderWidgetHostImpl, which doesn't work if the surface is connected to the browser compositor. It needs to be sent to the GPU process, which can route it correctly.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223388 0039d316-1c4b-4281-b951-d872f2087c98

The script optimize-png-files.sh requires optipng, advdef, and pngout when
running at optimization levels 1 and 2, but checks for these tools only at
level 2. This CL changes optimize-png-files.sh to also check for the
required tools at level 1 optimization.

TEST=Uninstall optipng and run the script with -o1 parameter.
R=oshima@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/23757043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223387 0039d316-1c4b-4281-b951-d872f2087c98

This changes AwContents to work correctly when in a WRAP_CONTENT
layout mode.

TBR=danakj@chromium.org
BUG=246621

Review URL: https://chromiumcodereview.appspot.com/23478022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223386 0039d316-1c4b-4281-b951-d872f2087c98

BUG=289178

Review URL: https://chromiumcodereview.appspot.com/23441060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223385 0039d316-1c4b-4281-b951-d872f2087c98

Enable end to end tests for Mac OS. The timeouts should be fixed now the number of window.open calls have been reduced (https://chromiumcodereview.appspot.com/19014003/). 

Two tests are showing other errors on Mac - they have separate bugs and will be looked into separately. 

This change also:
   - adds ability to customize expected logging to a particular OS
   - disable a test for particular OS.
   - some minor cleanup to make things more readable

BUG=245594

Review URL: https://chromiumcodereview.appspot.com/23465025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223379 0039d316-1c4b-4281-b951-d872f2087c98

I'll try to re-enable the linux webrtc content browser tests and see if they've magically fixed themselves. If not I'll try switching from the embedded test server to the spawned one. I need to do this on the real bots since it doesn't reproduce locally.

R=tommi@chromium.org
BUG=281492

Review URL: https://chromiumcodereview.appspot.com/23766035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223378 0039d316-1c4b-4281-b951-d872f2087c98

Previously we didn't register dooms in the backend until after
asynchronous operations on the entry; this meant that multiple
registrations were possible if different entries were being doomed, and null dereferences abounded after doom operations. Now fixed.

This reenables DiskCacheBackendTest.SimpleCacheDoomAll.

R=pasko,clamy,ttuttle
BUG=290866,237450,289542

Review URL: https://chromiumcodereview.appspot.com/23591048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jar@chromium.org, mmenke@chromium.org

Review URL: https://codereview.chromium.org/15809005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292745
R=jered@chromium.org, jfweitz@chromium.org

Review URL: https://codereview.chromium.org/23578034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223372 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/23526052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223370 0039d316-1c4b-4281-b951-d872f2087c98

it fails with EINTR. Specifically, in this case, the FD will already have been
closed.

BUG=269623
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/23455051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223368 0039d316-1c4b-4281-b951-d872f2087c98

For the new multi login mode (ChromeOS) we only want to show the Multilogin UI when there are at least 2 suitable users known to the system (and the commandline is properly set).

BUG=291154
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/23532073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223367 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/23530058/
https://codereview.chromium.org/23440041/
for the actual changes.

BUG=279335
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/23995016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155525

Review URL: https://chromiumcodereview.appspot.com/24123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223365 0039d316-1c4b-4281-b951-d872f2087c98

Added an anonymous namespace to make a couple of methods of this testing
API private.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/24158002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223363 0039d316-1c4b-4281-b951-d872f2087c98

A small step toward generating availability for APIs at the object level.

This class is used to convert API schema data to a more usable format for finding fine-grain availability information.

BUG=233982
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23503039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223362 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionApiTest.CookiesEvents is failing intermittently, so reverting this
change.

> Wait for store flush in CookieMonster::Delete*Task
> 
> BUG=252217
> 
> Review URL: https://chromiumcodereview.appspot.com/18032002

TBR=philipj@opera.com,erikwright@chromium.org

Review URL: https://codereview.chromium.org/23530062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223359 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Do nothing unless the attached widget is active in
InputMethodBridge::OnFocus". This reverts commit r222304.

BUG=287620, 291256
R=nona@chromium.org, yukawa@chromium.org

Review URL: https://codereview.chromium.org/23749007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223358 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223357 0039d316-1c4b-4281-b951-d872f2087c98

1732: ninja: Put generated sources in front of regular sources.

BUG=280718
R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/23971010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223356 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23475049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223355 0039d316-1c4b-4281-b951-d872f2087c98

Update the 'managed user import' overlay to show an avatar selection grid when the managed user has no avatar in sync.

The selected avatar is then synced during the importing process.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23454020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223354 0039d316-1c4b-4281-b951-d872f2087c98

These are directly applied by the session manager which can not resolve them. 

It fixed an issue with the flags stored in the device settings being the flag names and not the actual switches as is required by the session manager causing the flags not to be applied to the login screen if the flag and the switch don't happen to coincide and to browser restarts even for the owner which should not happen.

BUG=280935
TEST=Unit tests + manual testing as described in the bug.

Review URL: https://chromiumcodereview.appspot.com/23983031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223353 0039d316-1c4b-4281-b951-d872f2087c98

The file build/sanitize-png-files.sh was moved to
tools/resources/optimize-png-files.sh in http://crrev.com/221030. This CL
updates chrome/app/theme/README to point to the new path.

R=oshima@chromium.org
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23440043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223352 0039d316-1c4b-4281-b951-d872f2087c98

This should be a little faster, since we don't need to start a second thread.
More importantly, it better reflects what V8VarConverter does in production code.

BUG=
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/23522043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223351 0039d316-1c4b-4281-b951-d872f2087c98

R=machenbach@chromium.org
BUG=246567

Review URL: https://chromiumcodereview.appspot.com/23456033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223350 0039d316-1c4b-4281-b951-d872f2087c98

The Service.Error property is getting cleared before the notification is
displayed; we need to pass it to the notification when we detect the
error. (ErrorDetails should not be getting cleared).

BUG=291370
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/23522050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23892003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223348 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223347 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/23506041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223346 0039d316-1c4b-4281-b951-d872f2087c98

For zero-sized values, we'd previously pass NULL to std::copy, which is
not OK though if the number of elements to copy is 0. Avoid the copy
altogether and cover this situation in the unit test.

BUG=None
R=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/23704008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223345 0039d316-1c4b-4281-b951-d872f2087c98

This fixes memory leaks in UploadFileElementReader and UploadDataStream tests.

BUG=290897
R=rsleevi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23872030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223344 0039d316-1c4b-4281-b951-d872f2087c98