GitLab

Get rid of the code duplication of driver_bug_workarounds, i.e., get rid of the hardwired workarounds.

Then apply the workarounds from json file to gl_tests.

BUG=
TEST=gl_tests,gpu_unittests
R=gman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16159004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202682 0039d316-1c4b-4281-b951-d872f2087c98

This change was made in http://crrev.com/200122, but appears to have
been lost in a merge at http://crrev.com/200407.

BUG=243275

Review URL: https://chromiumcodereview.appspot.com/16021009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/15688008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202679 0039d316-1c4b-4281-b951-d872f2087c98

This is a concrete class wrapping a string that contains the
data of a serialized WebKit::WebHistoryItem class. Previously,
we've just passed around these as strings, giving them names
like "state", "content_state" or "history_state". It has been
hard to identify all of the places in the code where these
strings get passed around. A concrete class should make usage
more apparent. Plus, instead of manipulating the strings using
methods from webkit/glue/glue_serialize.h, we can just declare
methods on the PageState class. This makes the code much cleaner.

This first pass just implements PageState in terms of glue_serialize.
It also adds content/public/renderer/history_item_serialization.h
as the home for PageState to WebKit::WebHistoryItem conversion,
which should ideally only be usable from the renderer process.
(This bit is a step toward resolving bug 237243.)

page_state.h declares operator==() to support DCHECK_EQ, which
seems consistent with the idea of PageState being a replacement
for std::string. I didn't want to litter tests with calls to
PageState::ToEncodedData(). That would get cumbersome.

Originally reviewed at:
https://codereview.chromium.org/14985014

The only difference is that page_state.cc is now split into two
pieces: page_state.cc and page_state_webkit.cc.  The second holds
the definition of all methods that depend on webkit/glue.  That way
code like Chrome Frame and the iOS port of Chromium can use PageState
without pulling in a dependency on webkit/glue at link time.

BUG=240426
R=brettw@chromium.org, grt@chromium.org, joth@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/16162003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116128
TBR=asargent@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/15929004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177394

Review URL: https://chromiumcodereview.appspot.com/15754002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202675 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new function for fetching the handles of all
children of a sync node, then puts it to use in optimizing the
GenericChangeProcessor's GetSyncDataForType() function.

Prior to the UniquePosition changes, it was simple and cheap to fetch
the ID of a successor or predecessor item.  After the change, it
requires a few expensive map lookups.  In other words, GetSuccessorId()
has gone from being O(1) to O(lg(n)).  This is a especially a problem in
code paths where we use GetSuccessorId() to iterate over all nodes in a
folder.

The UniquePosition change also makes it pretty easy to fetch all child
nodes under a given parent.  We could easily return all the EntryKernels
under a given folder.  Unfortunately, the APIs don't make it easy to
expose that functionality.  Instead, we do something less efficient, but
still much better than the status quo: return the IDs of all the
children.  The caller will need to look up each entry at O(lg(n)) cost,
but at least it didn't have to do two lookups to fetch each ID.

This change should lead to a slight performance improvement in the
ModelAssociation time of types that use the GenericChangeProcessor.

BUG=178275, 241813

Review URL: https://chromiumcodereview.appspot.com/14667013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233420
TEST=http/tests/media/media-source/webkitmediasource-errors.html LayoutTests
      now passes w/o crashing.

Review URL: https://chromiumcodereview.appspot.com/15927003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244218
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/16170002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202670 0039d316-1c4b-4281-b951-d872f2087c98

Following crrev.com/202558, android's pylib was initialized on platforms that didn't need.
Check for platform and also make it safer to use should there be problems with "which".

BUG=242960
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/15804004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243940

Review URL: https://chromiumcodereview.appspot.com/15917008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202668 0039d316-1c4b-4281-b951-d872f2087c98

TEST=compile succeeds
BUG=244464

Review URL: https://chromiumcodereview.appspot.com/16164002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202667 0039d316-1c4b-4281-b951-d872f2087c98

The execinfo.h header only provides prototypes for backtrace funcs.
These two files don't use those funcs, so the include is unused.
Punt it to make building on non-glibc systems easier.

BUG=None
TEST=trybot for linux/nacl/cros work

Review URL: https://chromiumcodereview.appspot.com/16120002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202666 0039d316-1c4b-4281-b951-d872f2087c98

This adds appropriate calls to retrieve voices from SpeechDispatcher and make it available through Chrome.

We combine all voices across all available modules into one list in order to conform to the way Chrome exposes voices.

Review URL: https://chromiumcodereview.appspot.com/15846006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202665 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates chrome/browser/* other than chrome/browser/ui which is in
another CL.

BUG=236029
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/14113053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98

It regressed a test on Blink:
* compositing/iframes/iframe-content-flipping.html
* virtual/softwarecompositing/iframes/iframe-content-flipping.html

> Add CompositingReasons to compositor layer types.
> 
> BUG=240946
> 
> Review URL: https://chromiumcodereview.appspot.com/15051011

TBR=shawnsingh@chromium.org

Review URL: https://codereview.chromium.org/16146007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202663 0039d316-1c4b-4281-b951-d872f2087c98

> Collect tab timing information for use in telementry-based startup tests
> 
> Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.
> 
> Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.
> 
> Add a new --enable-stats-collection-bindings to activate said object.
> 
> Example usage in telemtry:
> with browser.Create() as b:
>   b.tabs[0].Navigate("http://www.google.com")
>   b.tabs[0].WaitForDocumentReadyStateToBeComplete()
>   print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')
> 
> BUG=None
> 
> Review URL: https://chromiumcodereview.appspot.com/12389073

TBR=jeremy@chromium.org

Review URL: https://codereview.chromium.org/16160006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202662 0039d316-1c4b-4281-b951-d872f2087c98

The problem fixed by this patch is that this script always creates a link
to itself in the target location. That behavior was probably not intended
and caused problems when running this script several times with the same
target folder. Each run of this script would create one expected link and
one link to the script itself. Meaning that the need to use --force the
second time was needed to overwrite the "self-link" from the first run.

Even with --force there were issues if this script was run in parallel
since there can be a race condition in overwriting the "self-link".

Review URL: https://chromiumcodereview.appspot.com/16096006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202661 0039d316-1c4b-4281-b951-d872f2087c98

This change:

* Adds support for configuring IE8.

* Adds support for configuring IE8, 9, and 10 properly if the user had
  previously skipped configuration.

BUG=none
R=erikwright@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16094006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242659, 234008
TEST=Mac 64 tester bot doesn't time out

Review URL: https://chromiumcodereview.appspot.com/15840012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202659 0039d316-1c4b-4281-b951-d872f2087c98

Added tweak for running chromeos=1 builds on Linux machines.

BUG=242370
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/15713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202658 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202652 0039d316-1c4b-4281-b951-d872f2087c98

Change the NavigationTracker to assume the page is loading after Page.navigate.
BUG=chromedriver:347
R=chrisgao@chromium.org, craigdh@chromium.org

Review URL: https://codereview.chromium.org/15772009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202651 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244443,244447
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15925006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244466
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15659012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180903,238998,230464
TEST=Induce browser crash in multi-profile sessions, observe that all user sessions are restored
TEST=CrashRestoreSimpleTest, CrashRestoreComplexTest
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15929005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202647 0039d316-1c4b-4281-b951-d872f2087c98

kLoginScreen
kLoginScreenSize

kAshBootAnimationFunction2
kAshBootAnimationFunction3
kAshDisableBootAnimation2
+ related flags

See also https://gerrit.chromium.org/gerrit/#/c/56735/

BUG=244224
TEST=compiles, existing browser_tests and autotests work
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16105005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202646 0039d316-1c4b-4281-b951-d872f2087c98

ConstrainedWindow used to have clearColor as backgroundColor - which
means all underlying views had to assume that the background color
was chrome_style::GetBackgroundColor instead of just querying the
window.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/15729008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202645 0039d316-1c4b-4281-b951-d872f2087c98

This function is helpful for converting WebStrings to string16s. See
https://codereview.chromium.org/15866003/ for more context about why we need
this function defined in base rather than in Blink.

R=darin

Review URL: https://chromiumcodereview.appspot.com/15720004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202644 0039d316-1c4b-4281-b951-d872f2087c98

Before:
*RESULT third_party\WebKit\PerformanceTests\Parser\html-parser: third_party\WebK
it\PerformanceTests\Parser\html-parser= [3177.99999996,3454.00000003,3165.999999
97,3162.99999994,3190.00000006] ms

After:
*RESULT html-parser: html-parser= [3217.99999999,3337.99999999,3174.0,3397.0,320
1.0] ms

BUG=None
TEST=python tools/perf/run_measurement --browser=release blink_perf third_party\WebKit\PerformanceTests\
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/15891010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157274

Review URL: https://chromiumcodereview.appspot.com/15645004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202642 0039d316-1c4b-4281-b951-d872f2087c98

> Use totmaps if available on chromeos
> 
> We currently use statm on linux. This provides less than great results.
> We take total resident memory and subtract "shared pages" from it instead of
> using a count of pages that only this process has mapped.
> 
> On chromeos we've added totmaps which sums up the fields from the process'
> smaps.
> 
> BUG=125150
> TEST=Examine memory reports from about:memory and task manager, and compare
>      them to the sums of the results in the smaps.
> 
> R=thestig@chromium.org, willchan@chromium.org
> 
> Review URL: https://codereview.chromium.org/15779007

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/16116003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202640 0039d316-1c4b-4281-b951-d872f2087c98

We currently use statm on linux. This provides less than great results.
We take total resident memory and subtract "shared pages" from it instead of
using a count of pages that only this process has mapped.

On chromeos we've added totmaps which sums up the fields from the process'
smaps.

BUG=125150
TEST=Examine memory reports from about:memory and task manager, and compare
     them to the sums of the results in the smaps.

R=thestig@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/15779007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202639 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16069008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/16042005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202636 0039d316-1c4b-4281-b951-d872f2087c98

Simplify the month picker even more by making it locale agnostic for everything except the month names

BUG=135948

Review URL: https://chromiumcodereview.appspot.com/16023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202635 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151260:151267&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/15949003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202634 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4d9d3bc7.

BUG=234278
TBR=caitkp

Review URL: https://codereview.chromium.org/15659013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202633 0039d316-1c4b-4281-b951-d872f2087c98