- 29 May, 2019 40 commits
-
-
Xianzhu Wang authored
Enable showLayoutTree(), showTree(), showLineTree() etc. for DCHECK_IS_ON(), for convenience of using them in debugging code in a release with DCHECK build without building a slow debug build. Change-Id: Id3c4e63d35c928907160df1baae3b10ef32bc750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632666Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664439}
-
Ken Rockot authored
This eliminates the need to register out-of-process services at the Content layer, separate from their manifests. Display names for service processes are taken directly from the manifest now, including support for string resource IDs resolved to localized strings by the Service Manager at runtime. Bug: 915806, 895615 Change-Id: I585b03ceb5489ea1a11f95a1c77d9b36048068c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615882Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664438}
-
Daniel Nicoara authored
* Add rotation information to the ManagedDisplayInfo. Allows clients to be aware of the display rotation and allocate buffers in the native orientation. Buffers in the native orientation can be overlayed by the compositor. * Fix how the ManagedDisplayInfo bounds is updated. display::Display's bounds is in transformed space. ManagedDisplayInfo's bounds is in native display space. Need to un-transform the bounds to report the right information. EXO apps will use this to allocate buffers in the native display scanout orientation, allowing the compositor to skip composition and just overlay the buffer. Bug: b/132813099, b/131769446 Test: Ran wayland_fullscreen_client on device with various orientations. Change-Id: Ibef6e30bf9ce59a4004c1a179b8cefe8ab1866aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636029Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#664437}
-
Drew Stonebraker authored
The content from chromium.org/developers/androidwebview/android-webview-beta should be moved to our markdown docs at android_webview/docs/quick-start.md. That page contained some FAQ questions, which seemed a little out of place for that page anyway. This CL recreates that content in android_webview/docs. Bug: 963092 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6e1cb4e5153b9015bf17dab1889def8140689da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611367Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#664436}
-
Kevin Babbitt authored
Call AddPopupChildren() when walking the layout tree in order to ensure that popup contents for controls such as <input type="date"> are added to the accessibility tree. For testing, I wanted a tree dump that would show the contents of the popup. I tried a couple of different techniques to simulate a click on the popup button from script but none of them worked. Instead I added the ability for the tree dumper to synthesize clicks on elements after the document is loaded. Bug: 964154 Change-Id: I75b6169bfd336bd98c70e93960f4f56a6413424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616387Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#664435}
-
Madeleine Barowsky authored
Out-of-process rasterization is enabled by default on perf bots, but means the YUV decoding path will be avoided until that branch is implemented. Bug: 900264 Change-Id: Ideaa78856fc754be3436d8fecd3589b127016d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626504Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664434}
-
Yuwei Huang authored
s/Passthroguh/Passthrough/ Change-Id: Ic6630c6c83b03767dd83dce28cf9710fa280708a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635863 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664433}
-
Lutz Justen authored
Adds code so KerberosCredentialsManager can listen to the 4 Kerberos prefs and handles kerberos.enabled (removes all existing accounts). Moves the registration of 3 prefs from profile to local_state since those prefs were not per-profile, anyway, and it simplifies lifetime of KerberosCredentialsManager as it does not have to wait for the primary user to be available. Also changes lifetime from a static singleton to explicit management since KerberosCredentialsManager owns a pointer to local_state now and it would otherwise be hard to justify that the pointer is never dangling. TBR=battre@chromium.org BUG=chromium:952239 TEST=Turn KerberosEnabled policy on, navigate to chrome://settings/kerberosAccounts, add an account, Turn KerberosEnabled policy off, verify that the account vanishes. Change-Id: I3f4ed443014726d8b2c5f2cc536703badf37d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617455 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664432}
-
Sunny Sachanandani authored
VSyncThreadWin will continue posting tasks if vsync is enabled even when the thread is being joined before destruction. Disabling vsync before joining works around this. Bug: 965936 Change-Id: Ibb4b790feca5dae099ebe594802728d2571c73a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635854Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#664431}
-
Shimi Zhang authored
Test is failing on M and L bots. Bug: 968043 Change-Id: Ied66c5015d832f42d141734b8b3a272f05947f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635930Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664430}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0d66fb8be4b..16e6fd53a125 git log d0d66fb8be4b..16e6fd53a125 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 brianosman@google.com Interpreter: Fix vector/matrix equality and inequality 2019-05-29 bsalomon@google.com Specialize GrBicubicEffet for 1d kernel. 2019-05-29 egdaniel@google.com Revert "Remove call to copy in GrcontextPriv read/write pixel calls." 2019-05-29 senorblanco@chromium.org GrTessellator: fix event creation for dead boundary edges. Created with: gclient setdep -r src/third_party/skia@16e6fd53a125 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I9fba6c8992e6f3c3e10251737ce3bdbf3deb10a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664429}
-
Alexander Hendrich authored
This CL will add Oobe dialog state that is used to hide the "Add person" or "Browse as Guest" buttons when an extensions show UI through the chrome.loginScreenUi API. API proposal: go/api-login-screen-ui Design doc: go/dd-login-screen-extension-ui Bug: 957573 Change-Id: Ifcdba5c3fce5ff3cc892c3d05c4524580cabd042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588555 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#664428}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e0956a16b22d..2008c8ffefdd git log e0956a16b22d..2008c8ffefdd --date=short --no-merges --format='%ad %ae %s' 2019-05-29 spang@chromium.org Vulkan: Reuse flushImpl() from finishImpl() 2019-05-29 syoussefi@chromium.org Vulkan: Implement multisampled framebuffers Created with: gclient setdep -r src/third_party/angle@2008c8ffefdd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: Iadf49d6de2bce5780070f88f9d4b1b2b3c7ad00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664427}
-
Matthew Webb authored
In an attempt to make CLs for authenticatorBioEnrollment smaller, this CL implements the framework for bio enrollment request and response. It also implements the virtual authenticator's response for getting modality and fingerprint sensor info (CTAP2.1 §5.7.2 and §5.7.3, not standardized yet). These two commands are read-only and do not require a pin token, thus their tests are fairly simplistic. Note also that this CL introduces a new bio/ subdirectory to encapsulate all bio enrollment-related code, as the //device/fido directory is getting fairly crowded. A future CL will work towards the full lifecycle of enrolling a fingerprint, enumerating enrollments, and removing enrollments. Change-Id: Ic7a08ba025e5903c1bb7b5fccbc885089cfe0a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623530 Commit-Queue: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#664426}
-
Eric Aleshire authored
The sync service does not actually start in this test, as starting sync requires SigninEarlGreyUI among others as seen here: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/sync/utils/sync_fake_server_egtest.mm?q=testSyncCheckSameCacheGuid_SyncRestarted&sq=package:chromium&g=0&l=139 SigninEarlGreyUI is not supported in EG2 yet and these are lightweight smoke tests. So stopSync is removed and replaced with a call that confirms the server is not actually started. Change-Id: I3b340bd413a0b54c0fee7aa8944ee791cb0f335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635551Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#664425}
-
Jun Mukai authored
This reverts commit 987deaf1. Reason for revert: crash on browser_tests in linux-chromeos-dbg (see crbug.com/968255) Original change's description: > Adding fieldtrial testing config for FastBorderRadius > > This patch adds a field trial testing config for FastBorderRadius. > > Bug: 947715 > Change-Id: Iff94fdce62a195ead91bf338b40df0380a9aab5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632829 > Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664252} TBR=rkaplow@chromium.org,masonfreed@chromium.org Change-Id: I1f36b1b44df65c43e09cab18f238bc0598985146 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947715, 968255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634424Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664424}
-
Findit authored
This reverts commit 53dfd8ca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 664404 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUzZGZkOGNhYjU5NmMyYWQ2NjVhMGE1NDQ1MmViNGEzYzgwOTBjMTcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/108140 Sample Failed Step: compile Original change's description: > Add plumbing for mDNS Open Screen support > > This patch adds classes to implement the mDNS interfaces > that Open Screen expects, using the discovery system inside of > Chromium. > > Change-Id: I450b757241ff99a59ec59f5352a0b604f729b9db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590536 > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664404} Change-Id: I02547456efbfa2cd15ee7732f0467feef7d5e409 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634421 Cr-Commit-Position: refs/heads/master@{#664423}
-
Harald Alvestrand authored
This reverts commit 2229f484. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Change ICE connection state on transceiver changes" > > This reverts commit 0882bebe. > > Reason for revert: Causing flaky failures of > external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html > on Linux Tests and WebKit Linux Trusty Leak > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387 > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892 > > Original change's description: > > Change ICE connection state on transceiver changes > > > > This ensures that if the PC iceConnectionState should change > > because unused transports are discarded, the state is updated. > > > > Bug: chromium:966798 > > > > Change-Id: I09d945f5e70eec813f33c3131fbe889825613652 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254 > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#664206} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I2cbae9f1327e7aacb7022d2a823ce1e954c91b62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:966798 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635208 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664388} TBR=agable@chromium.org,hta@chromium.org,hbos@chromium.org Change-Id: I894d30a0c585245b095c27cee9d5eadaf4569654 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:966798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635512Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664422}
-
Mattias Nissler authored
BUG=chromium:967396 TEST=None Change-Id: I050af863abb83d9cdde8dce0b9ff6c294709e818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634705 Auto-Submit: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#664421}
-
Nate Fischer authored
This fixes a typo. Test: N/A Change-Id: I0e0f61a25b0cb89abf33e55086dd68ecb9e8cd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633772 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664420}
-
danakj authored
Pass by value to give ownership, pass by reference to not. R=dcheng@chromium.org Change-Id: I6e8756a31997101b5808fb6a7c494436d4c1ddb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635549Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#664419}
-
Mythri A authored
This was flaky because SetLastTime was flaky on the SimpleCache backend. This was fixed in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1409347. This test should be stable after this fix. Change-Id: Id90f73bc35c4a3240fba8e5e717ece9bc22f1e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635260Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#664418}
-
Rayan Kanso authored
Include the payload for Push Messaging, and title/body for Notifications, in the event metadata. This makes it easier to identify exactly what instance an event belongs to, as well as provide useful information for developers. Bug: 958773, 958774 Change-Id: I378d84f82fee936a0090d9230d32f2a19c9fb873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635573 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664417}
-
Gil Dekel authored
This CL adds a fuzzertest to uncover vulnerabilities in media/parsers/webp_parser. It uses media/test/data as a seed corpus and media/test/webp.dict as a dictionary. webp.dict is a copy of https://github.com/mirrorer/afl/blob/master/dictionaries/webp.dict Bug: 963697 Test: compiles and passes gn checks Change-Id: I9f5a044fbdaabcb90667ab4c23a782b72b9e5c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632923Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#664416}
-
Joe Downing authored
Change-Id: Ifd9e0398c143d5d8e1f9ecbbbdf835646f5e235d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634396Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664415}
-
Avery Musbach authored
This is a reland of 40165b9a Original change's description: > overview: Show drop target even if split view is disabled > > The purpose of the present CL is to add a drop target in a certain > workflow. As of [1], the "drag to snap" mode has become a "normal drag" > mode which is available even when split view mode is not available. For > testing, you can note that in clamshell mode, with the functionality of > [2] disabled (the current default), split view mode is not available, > but you can still do a "normal drag" from overview. There is presently > no drop target in that workflow. There is no drop target depicted in [3] > either, but I am pretty sure a drop target is actually appropriate, > because of [4] (which is assigned to me) if for no other reason. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1612121 > [2] https://crbug.com/890029 > [3] https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c33 > [4] https://crbug.com/961170 > > Test: manual > Bug: 866622, 961170 > Change-Id: I079d01c3e449b10f23a19a9993fbdd44d0c1482e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627562 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Avery Musbach <amusbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663305} Bug: 961170 Change-Id: I8696e95c5412539566464e1cefcc31c4278ae946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635207Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#664414}
-
Sami Kyostila authored
This patch introduces a ThreadPool task trait for marking tasks that should run on the thread pool as opposed to a named browser thread such as the main thread. Previously any tasks that did *not* indicate a named thread would automatically run on the thread pool, which was convenient but perhaps surprising, since these types of tasks can run concurrently which may not be expected. After a future patch, tasks will need to explicitly opt into either thread pool or named thread execution; there is no automatic default. Change-Id: I2d9cfcd8779b4af5a6ad7baece52bc6acbb7b737 Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632471 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#664413}
-
Collin Baker authored
Several pieces of code that compile on Android refer to desktop-specific classes such as Browser, BrowserList, and TabStripModel. This only works by accident (due to only referring to class names or inline methods) and is a problem. This CL makes it a compile error to include c/b/ui/browser.h or c/b/ui/tab_strip_model.h when compiling for Android. It also fixes all build errors that came up after doing so. Change-Id: I0bdafb3939a81800db524b62403733d20ca60467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631943 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664412}
-
Wei-Yin Chen (陳威尹) authored
StaticResource.getBitmap() is and should only be called once in its life cycle. This CL adds an assertion to guarantee this property. Since StaticResource.getBitmap() would only be called once, it can release the Bitmap after getBitmap() is called, and it's no longer necessary to call recycle() on the Bitmap. Bug: 965580 Change-Id: I070f9530aefea12a6dc72330a10e021103cfdd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625901 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#664411}
-
Tomasz Wiszkowski authored
This change complements the https://crrev.com/c/1592003 for search queries. We avoid differentiating search queries (matching Desktop behavior) to reduce number of different icons resembling same suggestion type. Bug: 949753 Change-Id: Id0a0a15836f2197142e9f94e1a8fb45c4165075e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635769Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#664410}
-
Tomasz Wiszkowski authored
The change currently has no effect on our users. It requires backends to start serving entity suggestions to be active. We use InMemoryImageFetcher (instead of BitmapFetcher) to - avoid paying price of exchanging data blobs between C++ and Java, - avoid caching same object twice, - get better control over object lifecycle. This change introduces image fetching and presenting for entity suggestions. We cannot start clearing cache until crrev/c/1599741 is merged. Mocks: http://gallery/projects/MCHbtQVoQ2HCZc-__giWyM2E/files/MCHtA7U1iMGr68n3lpUTe2KsSFwQKW8sMVc Slides: http://slides/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk#slide=id.g5546bf599a_5_6 Doc: https://docs.google.com/document/d/1vq_9mAU8-bg2M3iWoPWN196Y6jwmh-QIg3dWgwVDRy0 Bug: 930349 Change-Id: I6857bf90243082aa0e073940534baefc173efe02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600867 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664409}
-
Joe Mason authored
Move safe_browsing/chrome_cleaner into its own target. Add deps to //chrome/browser/extensions and //chrome/browser/ui to that target. Rename chrome_cleaner_types target to chrome_cleaner/public. Bug: 920223 Change-Id: I95dd33b5e7ecb9881436169861d4186506e942fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625325Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#664408}
-
Katie D authored
Change-Id: I1015510c4704a090c0c5b9659d543abc939d7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635436Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#664407}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f051812343eb..1b71e4533842 git log f051812343eb..1b71e4533842 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 afdx@google.com Add "split block" transformation. (#2633) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b71e4533842 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I93b4386e008d7da5343643c0da54cc32a54163ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664406}
-
Ken Rockot authored
Bug: 955171 Change-Id: I66e911a8444621a4342ecfd77787704a63529672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632895Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664405}
-
Jordan Bayles authored
This patch adds classes to implement the mDNS interfaces that Open Screen expects, using the discovery system inside of Chromium. Change-Id: I450b757241ff99a59ec59f5352a0b604f729b9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590536 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664404}
-
Maksym Onufriienko authored
Bug: 922813 Change-Id: I8d2abc2c56678eee4f7060e5169a0ed535cf08c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632915 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664403}
-
jongkwon.lee authored
Merges the temporary type LINE_BREAK_MULTILINE to LINE_BREAK and introduces new type FIELD_BREAK for edge selection. As LineSelectionModel returns EdgeSelectionModel for a single line text, there is no behavioral change. Adds some tests for FIELD_BREAK. Change-Id: I7636852f13e61a6e0b8a70ca59d4f925c1c68ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626845 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664402}
-
Ted Choc authored
BUG=966393 Change-Id: If8e1a066d327f32f7922cd7694a296ff7e2e3b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635203 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#664401}
-
Bill Orr authored
When tracking is regained, we should go back to the original origin. This means we should use an anchor rather than a SpatialStationaryFrameOfReference. Bug: 965528 Change-Id: I8183b141cf4f9931a50866da4f2f97b54d43289e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633990Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664400}
-