- 11 Sep, 2018 40 commits
-
-
Joanmarie Diggs authored
Originally landed: crrev.com/c/1163724 Reverted: crrev.com/c/1217069 The revert was due to the two new tests failing on Ubuntu 16.04, which has a newer version of ATK and thus different expectations. In order to run the same tests in both environments, prune states which are not essential to what is being tested from the state set of the expectations. This modification also eliminates the need to hand-edit new expectations which are generated on more recent systems. Original changes preserved in this re-land: * Add an event notifier in AXPlatformNodeAuraLinux for browser chrome. * Check to see if focus should follow selection. If it should, also emit state-changed:focused events. * Ensure that the correct states (focusable and selectable) wind up in the state set of elements where focus should follow selection. * Forward events from Blink content to AXPlatformNodeAuraLinux. * Create an event listener so that DumpAccessibilityEventsTest tests can be run. Add expectations for tests for which events are now emitted. At the present time, that is only focus and selected. R=dmazzoni@google.com Bug: 866340 Change-Id: I371ad0a1516aceb6c6924d0142a6f3268dfdd3ac Reviewed-on: https://chromium-review.googlesource.com/1217744Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#590209}
-
Mike Frysinger authored
Use the proper names for both of these in docs meant for public consumption. Change-Id: Ia5f56ac791e5a743a3b59c5ccef2dea6a868c2b7 Reviewed-on: https://chromium-review.googlesource.com/1217546Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#590208}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1215426. Now the test is passing and we don't need -expected.txt files. I forgot to remove these files under flag-specific/. Bug: 882477 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7e5a3bb7bb3393bfbbf0e9827daf5c8983cff41a Reviewed-on: https://chromium-review.googlesource.com/1218044Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590207}
-
Ricky Liang authored
This CL decodes the still capture frame to YUV, rotates it according to screen rotation and encodes it back. This is to fix takePhoto() result having wrong orientation on HALv1 devices. Bug: 878865 Test: Tested on reef with CCA 5.1.0 that the captured photos are correct for both front and back cameras. Change-Id: Ib3758e0736b0dbb9b145acd3716b58cf6e08ccd3 Reviewed-on: https://chromium-review.googlesource.com/1208392 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#590206}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/63aa0e5b7001..0d0fb43f34ee git log 63aa0e5b7001..0d0fb43f34ee --date=short --no-merges --format='%ad %ae %s' 2018-09-11 jmadill@chromium.org Pass unpack buffer as explicit parameter to texSubImage. Created with: gclient setdep -r src/third_party/angle@0d0fb43f34ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880906 TBR=ynovikov@chromium.org Change-Id: I83ce6ccf2c62c770845912f19ef043d6cd3c374e Reviewed-on: https://chromium-review.googlesource.com/1217815Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590205}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/867aebe10898..1bfa8980a363 git log 867aebe10898..1bfa8980a363 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@1bfa8980a363 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie61820f65ea25741a4b3084ccc917bacae0409f6 Reviewed-on: https://chromium-review.googlesource.com/1218422Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590204}
-
Alexey Baskakov authored
This is a cleanup code-health change. Bug: 774918 Change-Id: I9b73ad49874fa48210aba031d646173f1544678d Reviewed-on: https://chromium-review.googlesource.com/1209133Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#590203}
-
Lei Zhang authored
template_url_parser_fuzzer eventually calls down into code that interacts with base::CommandLine. BUG=882155 Change-Id: Id37803e2f3e67a6acc2e5686b136661d3bb0e1ea Reviewed-on: https://chromium-review.googlesource.com/1218163Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590202}
-
Daniel Cheng authored
Rather than requiring subclasses of blink::Frame to remember to call blink::frame::Detach() at the end of their overridden implementation, move the subclass logic into a separate method that is pure virtual on blink::Frame. This allows lifecycle management to be consolidated into blink::Frame::Detach(), rather than having asserts scattered throughout and hoping the subclasses managed it correctly. Bug: 838348 Change-Id: If2e26d7117af7dd890e2fa04052979438ec87cae Reviewed-on: https://chromium-review.googlesource.com/1217510Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590201}
-
Sergei Datsenko authored
There is a bug in the caching code which triggers PLOG. Suppress it to avoid log noise. BUG=chromium:882738 Change-Id: Id7effca5c24268a9862b4cad2761051b02add5c6 Reviewed-on: https://chromium-review.googlesource.com/1218482Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#590200}
-
Yoichi Osato authored
This patch fix ComputeInlineBoxPosition for the position that points after line break and no LayoutObject after that by fallback to previous position. The fallback examples: - "<br>|" to "|<br>" - "<pre>foo\n|</pre>" to "<pre>foo|\n</pre>" This change aligns legacy LocalCaretRect to NG. Bug: 789870, 812535 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icb6cd9b8bc58b56a04d01eb22bdd58bd16ad5a01 Reviewed-on: https://chromium-review.googlesource.com/1215506 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590199}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2353705f52ff..656c1c9c270c Created with: gclient setdep -r src-internal@656c1c9c270c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882510 TBR=mmoss@chromium.org Change-Id: I30b703b7204c1cf4b5cec2d9d5fdcc0194a42e68 Reviewed-on: https://chromium-review.googlesource.com/1217818Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590198}
-
Mike Dougherty authored
Bug: 881816 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I695dac7e9aa0b2c6e08d5e661d56afda12d140b8 Reviewed-on: https://chromium-review.googlesource.com/1215042 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590197}
-
Timothy Loh authored
Due to either syncing or using multi-profile, we can get into a state where synced pin state lists Crostini apps although we shouldn't be displaying them. This results in weirdness like blank-space icons for the Terminal, or penguin icons for apps with icons, when these pinned items are supposed to be hidden. Clicking the shelf icons does nothing due to https://crrev.com/c/1212373. This CL prevents these broken pinned apps from appearing. Bug: 869266 Change-Id: I13ca91b8055cf43003bf1d467ca28161eb289e29 Reviewed-on: https://chromium-review.googlesource.com/1215532Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590196}
-
Ali Juma authored
IntersectionObserver WPTs expect that intersection observations are delivered within two step_timeouts of requestAnimationFrame. This expectation holds in Blink, but doesn't necessarily hold in other engines. In WebKit, requestAnimationFrame and layout are separate tasks, so it's possible for the first step_timeout to fire in between rAF and layout, leading to test flakiness. This CL switches these WPTs to using double-rAF rather than rAF-setTimeout-setTimeout when waiting for observations to be delivered. Change-Id: Iad80943db184bc4519ab323c3bd7cfac1256e175 Reviewed-on: https://chromium-review.googlesource.com/1214176 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#590195}
-
Koji Ishii authored
r526281 added a workaround for when text-transform shorten the string, but did so only for when inline_text_box_.Start() is zero. This patch extends the workaround for when inline_text_box_. Start() is not zero. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib4536ae5aaf92352e41ef19e53c2046a4c86806c Bug: 880176, 795498 Reviewed-on: https://chromium-review.googlesource.com/1218202 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#590194}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/385a05c3d606..5604391f597d git log 385a05c3d606..5604391f597d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 hinoka@chromium.org Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""" Created with: gclient setdep -r src/native_client@5604391f597d The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ib32d0d3f7078ffd0d9c0286890c329cbfbac9b37 Reviewed-on: https://chromium-review.googlesource.com/1217812Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590193}
-
Derek Cheng authored
A previous refactoring (http://crrev.com/586985) changed the CreateRoute call in CastConfigClientMediaRouter::CastToSink to supply a null callback. This causes a crash because MediaRouter assumes the callback is not null. This patch fixes it by supplying base::DoNothing() instead. Also, added a CHECK for null callback in MediaRouterMojoImpl. Bug: 882567 Change-Id: Idaaf1ca24149dff4d0bab7228f10176e804226d4 Reviewed-on: https://chromium-review.googlesource.com/1217902Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590192}
-
Trent Apted authored
The Chrome app menu and its submenus have a max-width of 800px. Bookmarks _subfolders_ have a max-width of 400px. But this doesn't apply to the bookmarks menu itself. Currently if a bookmark has a long title and appears in the bookmarks bar top-level, it will push out the width of the `Bookmarks` submenu when accessed via the Chrome app menu to a width that feels inconsistent. Bug: 881936 Change-Id: I1535b2b27f183e4106e21799ba91a5ab40287489 Reviewed-on: https://chromium-review.googlesource.com/1215503Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#590191}
-
Christian Biesinger authored
R=kojii@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6eb59b3683c54d703b311842fe333b2590d05882 Reviewed-on: https://chromium-review.googlesource.com/1217708Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4624f2fdcfda..867aebe10898 git log 4624f2fdcfda..867aebe10898 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 chingcodes@google.com signing: add errors and add/update signers Created with: gclient setdep -r src/third_party/chromite@867aebe10898 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2df033eeaae2bde498496550e47b670d9854587b Reviewed-on: https://chromium-review.googlesource.com/1217810Reviewed-by:
-
Yuta Kitamura authored
This CL lets PpapiThread use CreateMainThreadAndInitialize() so the Platform class can create the main thread on behalf. Previously, the code does not create an WebThread instance for the main thread(!), and PpapiBlinkPlatform::CurrentThread() actually returns nullptr on the main thread(!). This is because BlinkPlatformImpl:: CurrentThread() only cares about non-main threads created with CreateThread(). This CL fixes this issue. Bug: 826203 Change-Id: Icc1319e70da2d7c2a3ccaee0adb140df80cd496d Reviewed-on: https://chromium-review.googlesource.com/1186019Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Alan Cutter authored
This is a clean up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1201507 which renames BubbleDialogDelegateView::set_arrow() to SetArrow(). This matches our style guide as SetArrow() isn't a simple getter function. Bug: 877032 Change-Id: I9d506604d74651deed45a3854356ec7b66e57bb9 Reviewed-on: https://chromium-review.googlesource.com/1203493Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#590187}
-
Trent Apted authored
The ChromeOS Gallery, video_player, and audio_player currently pick out a collection of .js files from various places inside the folder structure of the ChromeOS files App. This CL documents where that occurs, with a view to move these, shared files out to a shared "toolkit" folder higher up in the folder structure. There is already a "common" folder, but it is within the Files app subtree and hard to enforce via layering. It uses GN's "visibility" on the closure targets to detect whether new dependencies are added. Bug: 879035 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6b134ccad20c22ad46372871ab488200d3cbafa1 Reviewed-on: https://chromium-review.googlesource.com/1188735 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590186}
-
Will Harris authored
../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(58,32): warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] keyboard_layout_handles_.size(), keyboard_layout_handles_.data()); ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../../ui/events/keycodes/dom/dom_keyboard_layout_map_win.cc(75,35): warning: implicit conversion loses integer precision: 'std::vector<HKL__ *, std::allocator<HKL__ *> >::size_type' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] return keyboard_layout_handles_.size(); ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(32,44): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32] keyboard_layout_manager->GetLayout(i); ~~~~~~~~~ ^ ../../ui/events/keycodes/dom/dom_keyboard_layout_map_base.cc(33,20): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] PopulateLayout(i, dom_keyboard_layout); ~~~~~~~~~~~~~~ ^ ../../ui/events/test/event_generator.cc(673,51): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] (ui::EventTimeForNow() - base::TimeTicks()).InMicroseconds(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ ../../ui/events/win/events_win_utils.cc(257,36): warning: implicit conversion loses integer precision: 'const LPARAM' (aka 'const long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] return gfx::Point(native_event.lParam); ~~~ ~~~~~~~~~~~~~^~~~~~ ../../ui/events/event_utils.cc(112,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32] delta.InMicroseconds(), 1, 1000000, 50); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros.h(189,15): note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS' name, sample, min, max, bucket_count, \ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(128,19): note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG' name, Add(sample), \ ~~~ ^~~~~~ ../..\base/metrics/histogram_macros_internal.h(120,27): note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK' histogram_add_method_invocation, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(104,24): note: expanded from macro 'HISTOGRAM_POINTER_USE' histogram_pointer->histogram_add_method_invocation; \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../ui/events/event_utils.cc(116,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32] delta.InMicroseconds(), 1, 1000000, 50); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros.h(189,15): note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS' name, sample, min, max, bucket_count, \ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(128,19): note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG' name, Add(sample), \ ~~~ ^~~~~~ ../..\base/metrics/histogram_macros_internal.h(120,27): note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK' histogram_add_method_invocation, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(104,24): note: expanded from macro 'HISTOGRAM_POINTER_USE' histogram_pointer->histogram_add_method_invocation; \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../ui/events/event_utils.cc(120,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32] delta.InMicroseconds(), 1, 1000000, 50); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros.h(189,15): note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS' name, sample, min, max, bucket_count, \ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(128,19): note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG' name, Add(sample), \ ~~~ ^~~~~~ ../..\base/metrics/histogram_macros_internal.h(120,27): note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK' histogram_add_method_invocation, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(104,24): note: expanded from macro 'HISTOGRAM_POINTER_USE' histogram_pointer->histogram_add_method_invocation; \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../ui/events/event_utils.cc(124,41): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'base::HistogramBase::Sample' (aka 'int') [-Wshorten-64-to-32] delta.InMicroseconds(), 1, 1000000, 50); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros.h(189,15): note: expanded from macro 'UMA_HISTOGRAM_CUSTOM_COUNTS' name, sample, min, max, bucket_count, \ ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(128,19): note: expanded from macro 'INTERNAL_HISTOGRAM_CUSTOM_COUNTS_WITH_FLAG' name, Add(sample), \ ~~~ ^~~~~~ ../..\base/metrics/histogram_macros_internal.h(120,27): note: expanded from macro 'STATIC_HISTOGRAM_POINTER_BLOCK' histogram_add_method_invocation, \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/metrics/histogram_macros_internal.h(104,24): note: expanded from macro 'HISTOGRAM_POINTER_USE' histogram_pointer->histogram_add_method_invocation; \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 4 warnings generated. [22971/48339] CXX obj/ui/events/events/keyboard_hook_win.obj ../../ui/events/win/keyboard_hook_win.cc(117,25): warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] MSG msg = {nullptr, w_param, ll_hooks->vkCode, ~ ^~~~~~~ ../../ui/events/event.cc(1137,47): warning: implicit conversion loses integer precision: 'const WPARAM' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32] key_ = DomKey::FromCharacter(native_event.wParam); ~~~~~~ ~~~~~~~~~~~~~^~~~~~ BUG=879657 Change-Id: If41fb68b2e054ff4f429396e78048d48f71a3e38 Reviewed-on: https://chromium-review.googlesource.com/1214682Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590185}
-
kristipark authored
The new pill notification functions for hide/show were being called instead of the old notification functions. Bug: 881781 Change-Id: Ibc6012a1a6ef23b1405d1121941c511a58910821 Reviewed-on: https://chromium-review.googlesource.com/1217595 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#590184}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I54ee7b0993650f57e768bb979b3c8df9c7841cf0 Reviewed-on: https://chromium-review.googlesource.com/1218223Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#590183}
-
Kurt Horimoto authored
The old implementation of |updateFootersForFullscreenProgress:| just updates the height constraint for the toolbar, which isn't actually applied to the model layer until the end of the runloop. In order to animate this change, the model layer must be updated from within the animation block, so |-layoutIfNeeded| is called to commit the new constraint value to the view hierarchy. Simply calling |-layoutIfNeeded| on the toolbar view itself will only animate the height, not the positioning. Since the positioning constraint is added to BVC.view, we'd need to force a full BVC layout to also animate the position correctly. However, since BVC is a heavy-weight view, and this is called for every scroll offset, calling |-layoutIfNeeded| on BVC.view may introduce performance regressions. This CL adds a container view for the secondary toolbar that has a constant frame equal to that of the secondary toolbar at a fullscreen progress of 1.0. That way, all the constraints that need to be animated are owned by the container and its subviews, so we can just call |-layoutIfNeeded| on the container rather than the entire browser view. Bug: 880656 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia0520d4cbfb55846efa16282e5aefae6e7f11212 Reviewed-on: https://chromium-review.googlesource.com/1208713 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#590182}
-
Jongheon Kim authored
This patch simplifies conditions around the code in gpu/ Bug: 561800 Change-Id: I798f95ba388c8f6b0e5488ef053e62b763363e07 Reviewed-on: https://chromium-review.googlesource.com/1186289Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#590181}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba11264e0971..2353705f52ff Created with: gclient setdep -r src-internal@2353705f52ff The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882510 TBR=mmoss@chromium.org Change-Id: I73481705080dca9c633b1837bed690f5a29ba432 Reviewed-on: https://chromium-review.googlesource.com/1217816Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd042963. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24519 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I09c064128b48e2a90d9e8525e70b6d9f7a9848c2 Reviewed-on: https://chromium-review.googlesource.com/1217854 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590179}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f182b1fc9a95..c80faf456d4c git log f182b1fc9a95..c80faf456d4c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 dtu@chromium.org [pinpoint] Add JSON output for /api/isolate. Created with: gclient setdep -r src/third_party/catapult@c80faf456d4c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868926 TBR=sullivan@chromium.org Change-Id: I02e4eb2eb6221701bd06c4e909d8150e7089a0ab Reviewed-on: https://chromium-review.googlesource.com/1217814Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590178}
-
Tetsui Ohkubo authored
This CL changes timing of stacking notification counter to appear in UnifiedSystemTray. Combined with https://crrev.com/c/1215507, it fixes top corner artifact of ARC++ notifications in UnifiedSystemTray. TEST=manual BUG=866777 Change-Id: I57f0ca846b129c18e7500d7738375644ff82157b Reviewed-on: https://chromium-review.googlesource.com/1215602 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#590177}
-
Yuta Kitamura authored
This binary was broken by me but left unnoticed because no bot executes it. This test is simple and CreateMainThreadAndInitialize() would suffice. Bug: 826203 Change-Id: Icdf9e3941be862abbedc20086ee909447c28645f Reviewed-on: https://chromium-review.googlesource.com/1206753Reviewed-by:
-
Fady Samuel authored
Currently some invariants violation checks are in LayerTreeHost for mac but not for other platforms. This CL enables the check on other platforms. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iade0eee8322f9126a5ee7409b2e79aa00593b2d1 Reviewed-on: https://chromium-review.googlesource.com/1217598Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590175}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Iadd9cef6cec3357c3e3e66440fbcc10f31e7dd5a Reviewed-on: https://chromium-review.googlesource.com/1217746Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#590174}
-
David Bokan authored
The double-tap gesture on Aura (which causes zoom) does not respect the touch-action filter as it should. i.e., double-tapping over a region with touch-action: none should prevent zooming. This is caused by IsGestureEvent() returning false for the TAP_UNCONFIRMED event. IsGestureEvent is used in EventHandler::OnEvent to determine whether to pass the event to OnGestureEvent and meant that the TAP_UNCONFIRMED gesture would get dropped at this point. The reason this was working on Android was that Android's GestureProivderClient is RenderWidgetHostViewAndroid. When FilteredGestureProvider forwards the gesture it passes it straight back to the RWHVA which doesn't go through the IsGestureEvent check mentioned above. On Aura, the GestureProviderClient is GestureProviderAura which passes the forwarded gesture back through WindowEventDispatch before finding the RenderWidgetHostViewAura. The WindowEventDispatch call chain is where we accidentally filtered the TAP_UNCONFIRMED gesture because of !IsGestureEvent. This means the TouchActionFilter never saw this gesture, which it needs to determine whether to filter the subsequent double-tap gesture. Bug: 865090 Change-Id: I5f8932dcf8b33ec132fa946864a462610cc8413b Reviewed-on: https://chromium-review.googlesource.com/1213881Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Jared Saul authored
Usage was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1188587 but the actual feature flag was missed. This is final cleanup. Change-Id: I84537c6112eea803a991eefff9c997c7f0dce758 Reviewed-on: https://chromium-review.googlesource.com/1213923 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
dpapad authored
Removes /deep/ usage, which no longer works in Shadow DOM v1. Also fixes some test timing that caused part of the failures. Bug: 875505,860069 Change-Id: I5642105a6df148bdea2d02b8e1af8889f400c89d Reviewed-on: https://chromium-review.googlesource.com/1217026Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590171}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4d533d8ebd..5518e65d90d7 git log 3c4d533d8ebd..5518e65d90d7 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 480edb8c1d7d..63aa0e5b7001 (2 commits) Created with: gclient setdep -r src/third_party/skia@5518e65d90d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I0fe248380451033bd1a22c14682e3cc7f9bc0a6e Reviewed-on: https://chromium-review.googlesource.com/1217813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590170}
-
