GitLab

Clean up patch to move kEnableAutomaticPasswordSaving check
to SetUpMainThread().

BUG=393567

Review URL: https://codereview.chromium.org/404983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284472 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/385073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284471 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Use-after-free raised on MFYI waterfall.
BUG=395670

> Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/407493002/)
> 
> Reason for revert:
> Reverting the revert. This didn't break the tree; it's still broken without the patch. :(
> 
> Sorry for the noise!
> 
> Original issue's description:
> > Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)
> > 
> > Reason for revert:
> > Speculative revert to fix XP bots.
> > 
> > XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677
> > 
> > This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.
> > 
> > Original issue's description:
> > > Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> > > 
> > > In preparation for out-of-process iframes, move almost all accessibility
> > > functionality from RenderView to RenderFrame, and from RVHI and RWHI
> > > to RFHI.
> > > 
> > > In addition, the accessibility mode is moved to WebContents, and changing
> > > the mode triggers changing it on all frames.
> > > 
> > > BUG=368298
> > > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> > > 
> > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994
> > 
> > TBR=dmazzoni@chromium.org
> > NOTRY=true
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032
> 
> TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/407493004

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/408663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284470 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Cast: Log playout delay from receiver (https://codereview.chromium.org/401273002/)

Reason for revert:
This revert wouldn't solve the flakiness. The fix for flakiness is in CQ now. Reverting this.


Original issue's description:
> Revert of Cast: Log playout delay from receiver (https://codereview.chromium.org/401213002/)
> 
> Reason for revert:
> This patch seems to break CastStreamingApiTestWithPixelOutput.EndToEnd.
> 
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32598/steps/browser_tests/logs/EndToEnd
> 
> Original issue's description:
> > Cast: Log playout delay from receiver
> > 
> > The last refactoring in RTCP handling dropped the playout delay from
> > receiver. This change adds it back.
> > 
> > TBR=miu
> > BUG=393042
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395
> 
> TBR=miu@chromium.org,hclam@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=393042
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284411

TBR=miu@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393042

Review URL: https://codereview.chromium.org/410443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284462 0039d316-1c4b-4281-b951-d872f2087c98

> Remove kEnablePrintPreview now that the pdf plugin is part of Chromium.
>
> R=thestig@chromium.org
>
> Review URL: https://codereview.chromium.org/296453015

NOTRY=True
BUG=395687

Review URL: https://codereview.chromium.org/395363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284461 0039d316-1c4b-4281-b951-d872f2087c98

Apparently, I need to repeat myself 4 more times.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/393353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392901

Review URL: https://codereview.chromium.org/399263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284459 0039d316-1c4b-4281-b951-d872f2087c98

This is pretty straightforward, just moving the screen_unittest.cc
entries from ui_unittests.gyp to gfx_tests.gyp. gfx_unittests now has a
TestSuite that setups everything we need to run it.

BUG=331829
TEST=ui_unittests, gfx_unittests
TBR=ben@chromium.org,danakj@chromium.org

Review URL: https://codereview.chromium.org/384263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284458 0039d316-1c4b-4281-b951-d872f2087c98

... in order to have the orientation values updated before the promise
gets resolved.

BUG=162827

Review URL: https://codereview.chromium.org/405983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284457 0039d316-1c4b-4281-b951-d872f2087c98

This switch covers all state, however, some compiler may cause
errors for no return statement after switch().

BUG=395633
R=flackr@chromium.org, sadrul@chromium.org
TEST=compile

Review URL: https://codereview.chromium.org/404153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284456 0039d316-1c4b-4281-b951-d872f2087c98

Previously the malware interstitial checkbox had a white background. This CL changes the checkbox to have a red background and white outline, like the primary button.

BUG=
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/404943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284455 0039d316-1c4b-4281-b951-d872f2087c98

This should be everything except tests and examples.

R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/403023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284451 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/406683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284450 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/366383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284449 0039d316-1c4b-4281-b951-d872f2087c98

Set dump_without_crashing_function_ in chrome.dll with value of exported chrome!DumpProcessWithoutCrash.

BUG=391974
TEST=chrome://crashdump and verify crash dump appears and tab does not crash
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/371073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82385
R=rnk@chromium.org
TBR=jochen

Review URL: https://codereview.chromium.org/405123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284447 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for the eventual removal of
RootView::DispatchGestureEvent(), move an early return
out of this function and into RootView::OnEventFromSource().
This condition ignores any gesture-scroll events which were
not preceded by a ui::ET_GESTURE_SCROLL_BEGIN event.

BUG=353641
TEST=Tested by WidgetTest.GestureScrollEventDispatching

Review URL: https://codereview.chromium.org/406683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284446 0039d316-1c4b-4281-b951-d872f2087c98

Pepper plugins' requests are piped through Blink's Fetch implementation,
giving us the opportunity to make policy decisions about whether or not
they should be allowed by CSP or Mixed Content (we're currently not
using this ability).

In order to make these decisions, we need to know that the request is
for data a plugin is requesting, as opposed to a plugin itself. This
patch adds that detail to PPAPI's URL-requesting logic.

BUG=390497

Review URL: https://codereview.chromium.org/409563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284445 0039d316-1c4b-4281-b951-d872f2087c98

In theory, as of r284372 all our bots should support using C++11 language
features in target builds. (Build targets that are needed in host binaries still
can't use it yet, and library features can't be used yet either, see
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/2RzwrIxnvqM ).

To test this theory, use a C++11 feature in a file that should be used on most
platforms. If this causes problems in many places, this is easy to revert.
If your bot can't deal with this, please let me know!

BUG=none

Review URL: https://codereview.chromium.org/385743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284444 0039d316-1c4b-4281-b951-d872f2087c98

Similar to 283576 (was probably copy-pasted).

BUG=none

NOTRY=true

Review URL: https://codereview.chromium.org/403073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284442 0039d316-1c4b-4281-b951-d872f2087c98

By adding --pak out/Release/content_shell.pak at the command line
the contents of it will be added to the visual output.

BUG=370383

Review URL: https://codereview.chromium.org/380693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/398823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284439 0039d316-1c4b-4281-b951-d872f2087c98

Adds IsVisible() function to PermissionBubbleView so that the browser window
knows if it is currently being shown.  It's added to the base class, rather than
just the cocoa implementation, because similar functionality will likely be
used for views in the future.

Adds alwaysShowDropdown property to the PresentationModeController.
When set to YES, it disables hiding of the dropdown - toolbar and tab strip.

Also adds a hack to ensure the UI is drawn correctly when entering fullscreen
mode.  Specifically, for the duration of the animation, the top-level view for
the browser window has setWantsLayer set to YES.  Without this, tabStripView
is not rendered into the destination frame for the animation.  (It is a sibling of
the content view, not a subview, and I believe that the non-layer-based
render path bypasses it when the animation begins.)  I could not come up
with any other mechanism to fix this, and without it, fullscreen looks quite
bad - the toolbar displays properly, but the tab strip is missing.

BUG=384260

Review URL: https://codereview.chromium.org/390503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284438 0039d316-1c4b-4281-b951-d872f2087c98

Reenables SSLUITest.TestWSSClientCert

BUG=159985, 329735, 210525
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/406553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284432 0039d316-1c4b-4281-b951-d872f2087c98

Before this value wasn't set at all leading to crashes of the test server if tsls_client_auth was enabled.

BUG=NONE
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/407653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284431 0039d316-1c4b-4281-b951-d872f2087c98

Add sample extension code for the new Tabs Zoom API.

BUG=none

Review URL: https://codereview.chromium.org/398823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
R=bauerb@chromium.org, oshima@chromium.org
TBR=tony@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284417

Review URL: https://codereview.chromium.org/400973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284429 0039d316-1c4b-4281-b951-d872f2087c98

The deadline scheduler in the Chrome compositor relies on runtime estimations of
various stages in the rendering pipeline. This patch adds the actual and
estimated runtimes of these stages to RenderingStats so they will be available
in tracing output. This will allow us to tune the estimators.

BUG=243459

Review URL: https://codereview.chromium.org/363003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284428 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't use the dynamic library loader if the SDK has libxpc.dylib, and
instead just relies on libSystem to load it.

BUG=395364
R=mark@chromium.org

Review URL: https://codereview.chromium.org/403193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394028
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284426 0039d316-1c4b-4281-b951-d872f2087c98

Inlining the assignment and copy constructor for a class
like ExplodedFrameState exploded the machine code in stl::vector.

gcc:
Total change: -14969 bytes
==========================
  2 added, totalling +504 bytes across 1 sources
  1 removed, totalling -3387 bytes across 1 sources
  0 added, totalling 0 bytes across 0 sources
  3 shrunk, for a net change of -12086 bytes (14716 bytes before, 2630 bytes after) across 2 sources

It also helps for clang which normally ignores programmers hints to inline anyway:
clang:
Total change: -918 bytes
========================
  1 added, totalling +263 bytes across 1 sources
  3 removed, totalling -1098 bytes across 2 sources
  2 grown, for a net change of +161 bytes (1822 bytes before, 1983 bytes after) across 1 sources
  1 shrunk, for a net change of -244 bytes (1401 bytes before, 1157 bytes after) across 1 sources

BUG=

Review URL: https://codereview.chromium.org/400923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284424 0039d316-1c4b-4281-b951-d872f2087c98

This change:
- allows for proper docking testing (including toolbox);
- removes all test friends from DevToolsWindow;
- unifies testing approach to use load callback instead of notifications;
- adds simple toolbox tests.

BUG=393566

Review URL: https://codereview.chromium.org/395783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284423 0039d316-1c4b-4281-b951-d872f2087c98

(No semantic change.)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284422 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284421 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/407733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284420 0039d316-1c4b-4281-b951-d872f2087c98

> Move default user profile images strings and resources out of src/chrome.
> 
> BUG=387614
> R=bauerb@chromium.org, oshima@chromium.org
> TBR=tony@chromium.org
> 
> Review URL: https://codereview.chromium.org/400973002

TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/408833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
R=bauerb@chromium.org, oshima@chromium.org
TBR=tony@chromium.org

Review URL: https://codereview.chromium.org/400973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284417 0039d316-1c4b-4281-b951-d872f2087c98

There had some CLs landed before to try fixing the flakiness of those webrtc tests on Android bot. But since the flakiness only happens on bots but not locally, so I enabled it again to see if those CLs help or not.

If any of the WebRTC tests still flake on bots, this CL should be reverted.

BUG=343604
TEST=bots

Review URL: https://codereview.chromium.org/408463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284413 0039d316-1c4b-4281-b951-d872f2087c98

Blink doesn't use the arguments anymore, the promise is always resolved
with undefined.

BUG=162827

Review URL: https://codereview.chromium.org/406883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284412 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This patch seems to break CastStreamingApiTestWithPixelOutput.EndToEnd.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32598/steps/browser_tests/logs/EndToEnd

Original issue's description:
> Cast: Log playout delay from receiver
> 
> The last refactoring in RTCP handling dropped the playout delay from
> receiver. This change adds it back.
> 
> TBR=miu
> BUG=393042
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395

TBR=miu@chromium.org,hclam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393042

Review URL: https://codereview.chromium.org/401273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284411 0039d316-1c4b-4281-b951-d872f2087c98