- 03 Dec, 2019 40 commits
-
-
Trevor Perrier authored
This CL adds the list android_bundle_locales_as_resources which formats all locales for .xml resource outputs. It then uses this new list in all the android output list in all build targets that used have .xml outputs. In addition the following two .grd files were missing .xml outputs for the most recently added locales on Android. And these were updated. - chrome/android/features/keyboard_accessory/internal/java/strings/ android_keyboard_accessory_strings.grd - chrome/browser/touch_to_fill/android/internal/java/strings/ android_touch_to_fill_strings.grd No new locales were added to apk bundles. Bug: 812837 Change-Id: Ib9587def0aceb6894b27a8b3dc39ce920c768377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940949 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#721054}
-
Armando Miraglia authored
To reduce the risk of issues by posting WTF::String objects, this CL postpones the conversion to when the result is available in std::string rather than before posting the closure. Bug: 1028536 Change-Id: I6560f788d76973551f66041af7abe85965cddd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944674 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721053}
-
Dominic Farolino authored
Current spec discussion is heading in the direction of ultimately not considering a request's initiator origin when determining the referrer, and instead preferring Chrome's old behavior. We need a resolve by the branch point (12/05), so this CL preemptively reverts, for the last time, the previous referrer changes introduced in crrev.com/c/1808663, restoring the referrer-computing logic in //net and Blink to the original behavior. A future CL will change the WPT expectations so that Chrome passes the tests, since it seems we will change the spec to match Chrome's old behavior here. R=yhirano@chromium.org TBR=caseq@chromium.org,kinuko@chromium.org,lizeb@chromium.org Bug: 1021908 Change-Id: I9ffeb3e3982b141a101242d2fc7004b753a6e681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946861Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#721052}
-
Oleg Davydov authored
Historically we've computed extension resources' hashes in ContentHash::CreateHashes, but logically it's a job for ComputedHashes class, so now we do it in ComputedHashes::Compute method. In the future this will allow us to reuse ComputedHashes::Create for other purposes (eg. testing or computing hashes upon installation for self-hosted extensions). Bug: 796395, 958794 Change-Id: Ie16c53ee682a4b8066dd2e929e13cbbc5be2d6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913415 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721051}
-
Jonathan Backer authored
Official builds remove logging on CHECKs to save space. Plus, we should remove the CHECK before branch. Instead we should lose the context. Bug: 1026629 Change-Id: Ifa8c1ff1bdfad10d5f7535fa680f41197708aaa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948520 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721050}
-
Takumi Fujimoto authored
This reverts commit d065c828. Reason for revert: Suspected to be a culprit for a webkit_layout_tests failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/49404 https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/49405 Original change's description: > Rebaseline GPU raster image tests after opaqueness tracking change > > Bug: 1028116 > Change-Id: I06e931ff71384883181db349dc269cd324da6975 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940447 > Auto-Submit: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#720956} TBR=bsalomon@google.com,robertphillips@google.com Change-Id: I18c368734f65de7e818fe029afaa1d2e960ebab1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947600Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721049}
-
jongdeok.kim authored
This CL adds 'explicit' to gfx::Insets constructors to prevent from unexpected construction. Change-Id: I2cd049ba3c1f5446014301ede13c79fe71e1b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943648 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721048}
-
Peng Huang authored
Bug: 1012401 Change-Id: I579ae08f993073049b9677e90efc42239cd76490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948521Reviewed-by:
-
Balazs Engedy authored
Given that we are going to provide users with a checkbox on chrome://settings/content/notification to directly turn on quiet prompts if they so choose, there is no need to expose options on chrome://flags to force the quiet prompt UI. In addition, QuietNotificationsPromptConfig::Activation no longer makes sense. Activation::kNever and Activation::kAlways now have the same semantics as the checkbox on chrome://settings/content/notification, but clearly, the user decision should take precedence, so it is pointless to have those activation states in the first place. The state Activation::kAdaptive previously had the semantics of gating the quiet prompt UI on AdaptiveNotificationPermissionUiSelector's result but now we have three different ways to turn on the quiet UI, so this lacks sufficient granularity today. Instead, it should always be possible for the user to turn on/off quiet mode manually, and there should be two boolean variation parameters that gate whether 1) the quiet state will be turned on adaptively by three consecutive denies, or by Safe Browsing. This CL implements the first for now. Bug: 1028642 Change-Id: I7a1c216c4ec121110023e1e1ac0f3ed4baa76b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945822 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721046}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/392bb2bdc686..a61151f11cbe git log 392bb2bdc686..a61151f11cbe --date=short --first-parent --format='%ad %ae %s' 2019-12-03 perezju@chromium.org [tracing] Add khokhlov to relevant OWNERS files 2019-12-03 khokhlov@google.com [py_trace_event] Clear global state at the end of the trace session Created with: gclient setdep -r src/third_party/catapult@a61151f11cbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008,chromium:990304 Tbr: sadrul@google.com Change-Id: Ib56ae34dfcddfbbbd9a449c677f40d3b777b88ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721045}
-
Egor Pasko authored
The Memory.Experimental.Renderer2.Malloc is unreliable on Windows (equally for other processes: Browser2.Malloc, Extension2.Malloc, etc.) Clarified this in a comment to the histogram suffix, with a reference to related past discussion in crbug. Bug: None Change-Id: If9efb446fd76c74daa327869daa01f2530f4a9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948439 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#721044}
-
Markus Handell authored
Instead of passing the video encoding on creation, pass it on each frame instead. This enables the muxer to be created before the encoding of the stream is known. Bug: 1013590 Change-Id: If33ba3f7ac3633d2c3e9de16f0e027d6605006ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893853 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721043}
-
Joe Downing authored
This CL removes the ChromotingTestDriver and associated classes. These were used as a sort of native C++ Webapp stand-in but our backend has changed so much that none of this code will run w/o being rewritten. The FTL Playground is a better, working utility so we should just use that for now. Change-Id: Ic3dda75516a5a3486f2daf9a273b4a9fd588557a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946733 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721042}
-
Sorin Jianu authored
This CL refactors the implementation of the recovery component action handler for Windows so that most of the code can be reused in the future for macOS recovery component. It also adds a unit test. Bug: 1029953 Change-Id: Iead0b562ae311560b3ca0eacd8d417bedd007331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946020Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721041}
-
Yun Liu authored
This CL should after https://chromium-review.googlesource.com/c/chromium/src/+/1918719 Bug: 985581 Change-Id: Ib8731e21db5f4d93f44da36eaddfe755b95c53f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918639 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721040}
-
Kevin McNee authored
TabStripModel::kNoTab is static const member that is declared and initialized, but never defined. This causes linker errors when attempting to use this in test assertions. We provide the necessary definition and update tests that were working around this by using CHECKs instead of proper test assertions. Bug: None Change-Id: Ifc47e86815d6f71b6c337ea0634d109e841fb85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721039}
-
Mugdha Lakhani authored
to silently succeed when called for an unactivated service worker. Registration requires an activated service worker, so if unregister is called on an inactive service worker, we can assume there's no periodic sync registration and silently succeed. Bug: 1030237 Change-Id: I90d574b0a951b0908ba000e77db6ff9f70c7ddc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948440 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#721038}
-
Yun Liu authored
PowerMock depends on 2.5+ Bug: 512198 Change-Id: I38e27bbafa5699ad75403c9139d983b75be10337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947626Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b64fbfec4dcd..8ffeadb66ea7 git log b64fbfec4dcd..8ffeadb66ea7 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 srisser@google.com Make Vk::Stringify return std::string Created with: gclient setdep -r src/third_party/swiftshader@8ffeadb66ea7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20acfa01c566a293dc786c6ae8e2958a4539233e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948620Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 509 512 513 87 lines were removed and 16 lines were deflaked by consecutive results since 498. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4da63b288c1e1071d57fb15c3089f7f4dda386da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948366Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#721035}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I4ded091c29d29dd48bbd2b18a0d381395cb3f5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948927 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721034}
-
Mikhail Khokhlov authored
We are going to start adding first TBMv3 metrics to benchmarks and running them on FYI bots. Because proto trace generation is still an experimental feature and is not enabled everywhere, some bots will see TBMv3 metrics defined but no proto traces. So we make this only a warning for the time being. Bug: 990304 Change-Id: I9eee37e315bb8e82eae42b0ad4de8a3fcfee9942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948926Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#721033}
-
Christopher Cameron authored
Suppress the watchdog for 60 seconds, then let it kill the GPU process. Bug: 974219 Change-Id: I509896195b15a4016736a529034a3d97328643fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947949Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721032}
-
Mihai Sardarescu authored
This CL ensures that all ChromeIdentities objects are not retained by the global autorelease pool when they were forgotten. This is needed as relying on the global autorelease pool has as a side effect the fact that the underlying GTMSessionFetcher objects was also retained and this confused the EarlGrey infrastructure that believed that a network request was still on-going during the tear down phase. Bug: 1011798 Change-Id: Ica44d3a26d4f37d30928e9a53c104aed7bd59e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948436 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#721031}
-
Juan Antonio Navarro Perez authored
And remove perezju. Bug: 1029008 Change-Id: I4fc67136b7816b687ff1c902d5b7b75e176e766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944471Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721030}
-
Roman Aleksandrov authored
Make user menu adjust to the height of virtual keyboard and tray. Bug: 1012499 Change-Id: Idd58cd4943998e60d3008d9e8210cf8bfb8853fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943173Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#721029}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dac0d8216b2..db2e7641bed8 git log 9dac0d8216b2..db2e7641bed8 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 brianosman@google.com Particles: SkImageBinding to allow sampling an image from script Created with: gclient setdep -r src/third_party/skia@db2e7641bed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I09b0b89f33d56af9441525ae647d95cdb0ba1fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948619Reviewed-by:
-
David Roger authored
This is a reland of f21f4c91 The CL is the same as the one that was reverted. The failing Sync test was modified in the meantime by CL https://chromium-review.googlesource.com/c/chromium/src/+/1948890 and should now pass. Original change's description: > [signin] Don't clear unconsented primary account on cancelling Sync dialog > > The unconsented primary account doesn't necessarily change when the Sync > confirmation dialog is cancelled. > In particular this is the case when PrimaryAccountMutator::ClearPrimaryAccount > is called with RemoveAccountOptions::kKeepAll. > > This CL stops resetting the unconsented primary account as part of the signout > process. > The unconsented primary account is recomputed anyway when GoogleSignedOut is > called. > > > Fixed: 1029701 > Change-Id: Id46bb468952efe63170a13872519fcaded076cb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944862 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Monica Basta <msalama@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720502} TBR=msalama Fixed: 1029701 Change-Id: I26e872f140db99d723037c16dc55219df5a0c706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947647Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721027}
-
Yi Gu authored
Bug: None Change-Id: I0746696dbc76058c86c21b27611a3a479584f021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948740Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721026}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLObjectElement> and DynamicTo<HTMLObjectElement> as new downcast helper 2. Use IsA<HTMLObjectElement>(element) in place of IsHTMLObjectElement(element) Bug: 891908 Change-Id: I1fedbe9efc9e44cd101f9467bc15b6b785f9a316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948398Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#721025}
-
Matt Menke authored
Link Doctor fetches suggestions for certain errors when trying to navigate to an HTTP site. This CL temporarily disables it due to a bug in the (currently unowned) server side service. Further down the line, we'll either need to find an owner (both for the server side code and the Chrome side code) or remove the code for this. This CL also fixes a bug in errorpage_browsertest.cc. Way back when, the mock suggestion service switched from using a suggestion URL served by the error page to a fixed URL. ExpectDisplayingNavigationCorrections() was updated to reflect this URL, but ExpectDisplayingLocalErrorPage() was still checking for a URL served by the EmbeddedTestServer. This CL updates ExpectDisplayingLocalErrorPage() to check for the correct fixed URL. Bug: 1011893, 1030281 Change-Id: I2195ff8e97ea32f408edd45e7a16770ce56ccfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946705 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721024}
-
Dave Tapuska authored
Clean up some old TODOs. BUG=695622 Change-Id: I2b4526efafd77782270e4d7086a5f9fd09b9d5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940494Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#721023}
-
Antonio Gomes authored
... in favor calling the ctor directly. BUG=787254, 939691 R=guidou@chromium.org Change-Id: I523d0b23d94152ce815e5ac8ab1099da307b0728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944368 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Builder hasn't worked for a long time, and is no longer needed. Bug: 1029016 Change-Id: I5b29851a48052e0ddf4e89dfd5ccb15a3fe59fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945813 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#721021}
-
Peng Huang authored
There are three problems: * DisplayResourceProvider shouldn't return resource to client when resource is still used by overlay. * SkiaRenderer should Unlock overlay resources with sync token which will be released when the SwapBuffers() is done on GPU thread. * On Windows, SkiaRenderer should release overlay resources when next SwapBuffers is done instead of current SwapBuffers. Bug: 1029556 Change-Id: I91c22106bacf51b28eded4de7a11426b095e6ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944319Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721020}
-
John Chen authored
Add some workaround code while setting browser window to fullscreen mode, to work around an issue in DevTools fullscreen command. In particular, call document.documentElement.requestFullscreen() to ensure that document.webkitIsFullScreen returns the correct values. All WPT tests related to fullscreen now pass. Also made an adjustment to WPT set_window_rect/set.py test_fully_exit_fullscreen, which was using a width below the minimum supported by Chrome. Bug: 982071 Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947816Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721019}
-
Mounir Lamouri authored
This CL makes sure video track disabled by video background track optimization is re-enabled when entering Picture-in-Picture. Bug: 949265 Change-Id: Id0cca141f262537672f49f8cdc8bc6db5c10e3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556837Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#721018}
-
David Benjamin authored
chlily@ pointed out that some of the SameSite tests needed to use localhost and 127.0.0.1, and then even spin up separate servers because the names aren't one certificate. This is a little goofy. Add an example_domains.pem file where we can add names as needed to support testing cross-origin and cross-domain behavior. Start with a.example and b.example. Bug: 984685 Change-Id: Ibf545293a49f9b54ba1ebf356d72c978c330ff56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910345 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#721017}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f205775e90f3..efedd6739684 git log f205775e90f3..efedd6739684 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rharrison@google.com Create spvc specific return codes and use them (#918) Created with: gclient setdep -r src/third_party/shaderc/src@efedd6739684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I519169e453b757a2b5fdad6d4cd8b92c7e61816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948796Reviewed-by:
-
Jun Mukai authored
Bug: none Test: none Change-Id: I24891e76992cfbec3eaa8caa82ee881d2a50e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940564Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#721015}
-
