GitLab

BUG=343166

Review URL: https://codereview.chromium.org/160563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251834 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/163943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251833 0039d316-1c4b-4281-b951-d872f2087c98

The debugging code unfortunately did not produce any results.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/169283010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251832 0039d316-1c4b-4281-b951-d872f2087c98

We're currently in the process of enforcing that SkPaint effects can only be
allocated on the heap. That involves making constructors non-public and
providing factory methods instead. Until all the changes on the Skia side have
been rolled into Chrome and the callsites have been changed, we use a define to
guard the visibility of the constructors.

BUG=skia:2187

Review URL: https://codereview.chromium.org/168173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251831 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/163673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251830 0039d316-1c4b-4281-b951-d872f2087c98

GTM isn't necessary for iOS's breakpad client.

BUG=339495
TEST=None

Review URL: https://codereview.chromium.org/139203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251829 0039d316-1c4b-4281-b951-d872f2087c98

Existing galleries that have scan results should get updated if the value stored in preferences is different than the value found - even if the value found is zero.

BUG=NONE

Review URL: https://codereview.chromium.org/167863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251828 0039d316-1c4b-4281-b951-d872f2087c98

Previously this was being set for all .c[c] files on Mac.

BUG=336480
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/164193009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251827 0039d316-1c4b-4281-b951-d872f2087c98

Hide/Show the URL based on various triggers if origin chip is enabled.

Specifically:
 * Hide URL if location bar loses focus.
 * Hide URL if location bar is focused via mouse click.
 * Hide URL on navigation.
 * Display URL after click on origin chip. (NOT IMPLEMENTED YET)
 * Display URL after Cmd-L.

Also, show a hint text if no text is currently entered.

BUG=338563

Review URL: https://codereview.chromium.org/165853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334379

Review URL: https://codereview.chromium.org/154463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=187570
TEST=RenderFrameHostManagerTest.* passes on Android

Review URL: https://codereview.chromium.org/163753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251822 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to have the default value vary according to other parameters. This is what we need in many cases, so having this restriction just made things more complicated.

The getenv function will allow us to replace some Python scripts with a fast native function call.

The use of rebase path is pretty annoying. 99% of all callers want the "from" directory to be the current one. I reordered the parameters to move the from directory later so we can have a default value for it.

This will require a patch to change all current callers of rebase_path when new deps are pulled.

BUG=342937
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/161783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344038
NOTRY=true

Review URL: https://codereview.chromium.org/167893011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251820 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251819 0039d316-1c4b-4281-b951-d872f2087c98

This just moves the files and adds needed dependencies.

BUG=344456
TBR=atwilson@chromium.org,rvargas@chromium.org

Review URL: https://codereview.chromium.org/170313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251818 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
r1854: Cache Xcode version at the module level
r1853: ninja: Let TOC code use $lib instead of ${lib}.

BUG=https://code.google.com/p/gyp/issues/detail?id=408
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/170833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344502

Review URL: https://codereview.chromium.org/167003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251815 0039d316-1c4b-4281-b951-d872f2087c98

This changes the test to make sure it doesn't expect animations to
be frozen after EndTest(), since after this point we allow draws to
succeed.

BUG=344078

Review URL: https://codereview.chromium.org/170593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251813 0039d316-1c4b-4281-b951-d872f2087c98

When the function reaches this point in the code, then
url.SchemeIs(kExtensionScheme) was false.
So the condition will remain false in GetExtensionOrAppByURL,
which makes this method equivalent to GetHostedAppByURL.
Save some cycles by calling GetHostedAppByURL directly.

Contributed by Rob Wu <rob@robwu.nl>

BUG=

Review URL: https://codereview.chromium.org/167493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343576

Review URL: https://codereview.chromium.org/167393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251809 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Causing win 7 dbg failures:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%285%29

Original issue's description:
> Blink roll 167304:167337
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167337&mode=html
> TBR=
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251783

TBR=eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/171183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344582
TBR=atwilson@chromium.org, dewittj@chromium.org

Review URL: https://codereview.chromium.org/170763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251807 0039d316-1c4b-4281-b951-d872f2087c98

When a navigation entry changes (which contains data that should be
serialized to disk such as form text field state and scroll offset),
TabBase.java needs to hear about it so that it so that it can be written
to disk later.

NOTRY=true
BUG=323094

Review URL: https://codereview.chromium.org/164183013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251806 0039d316-1c4b-4281-b951-d872f2087c98

Have chromedriver use chrome/common/chrome_constants.cc directly rather than having to hardcode a copy or depend on the full target itself.

akin to https://codereview.chromium.org/163763004/

BUG=343692

Review URL: https://codereview.chromium.org/165053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251804 0039d316-1c4b-4281-b951-d872f2087c98

There have been issues with the way forced-incognito causes some things to behave and various menu items to appear.  We now follow the ChromeOS model (merging several instances of conditional ChromeOS code) of simply using the incognito profile when opening the window.

This change should fix some of the issues being seen in the field, simplify Guest profiles going forward, bring Desktop and ChromeOS experience closer together, and generally reduce Technical Debt from special-case scenarios.

BUG=103846

Review URL: https://codereview.chromium.org/164333007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251803 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to nuke DockInfo soonish. This is a step in that direction.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/168733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251799 0039d316-1c4b-4281-b951-d872f2087c98

Guests shouldn't be setting Chrome as the default browser.  Some settings make sense but this one does not.

BUG=285347

Review URL: https://codereview.chromium.org/167783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251798 0039d316-1c4b-4281-b951-d872f2087c98

TLS Lite generates RSA signatures by converting a large integer that
holds the signature to a byte string. It does not apply any padding so
that if the signature starts with sufficiently many zero bits, the byte
string will be shorter than expected (it should have the same length as
the key's modulus).

This bug was fixed in trunk TLS Lite but is still present in our fork. The
fix in trunk TLS Lite was spread over two commits:

* Add a |howManyBytes| argument to the numberToBytes() method:
https://github.com/trevp/tlslite/commit/
    4278f558c2c519684ab35e9fc84887c15a11ea16
* Specify |howManyBytes| when generating an RSA signature:
https://github.com/trevp/tlslite/commit/
    0b8b2b4122109f22900ec929432308dd685f1d45

BUG=331761
TEST=Manual

Review URL: https://codereview.chromium.org/168903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163931
TBR=erg

Review URL: https://codereview.chromium.org/157713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251796 0039d316-1c4b-4281-b951-d872f2087c98

This will enable displaying the BWE debug stats on chrome://webrtc-internals.
The JS is updated to special case the propagation delta value because the
value of the stat is a list and its timestamp is in the value of stat
receivedPacketGroupArrivalTime.

BUG=338380

Review URL: https://codereview.chromium.org/139473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251795 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251794 0039d316-1c4b-4281-b951-d872f2087c98

> roll skia DEPS to 13482
> 
> Chromium base revision: 251714 / 7fcea678
> Old Skia revision: 13441
> New Skia revision: 13482
> Control CL: https://codereview.chromium.org/169283009
> 
> This CL was created by Skia's roll_deps.py script.
> 
> Bypassing commit queue trybots:
> NOTRY=true
> R=reed@google.com
> 
> Review URL: https://codereview.chromium.org/170093002

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/170923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251793 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
https://crash.corp.google.com/samples?q=reportid=%2702eaaf63ed6fdda9%27
https://crash.corp.google.com/samples?q=reportid=%272ac5bc4dd7c49ced%27

Original issue's description:
> Fix posix IPC channel hanging problem.
> 
> If a channel closes right before a send call, listeners might not be notified of
> the problem, which can cause hangs. This CL fixes that and adds a test that makes
> sure that this does not happen in the future.
> 
> This is cl/30133002 + a memory leak fix.
> 
> BUG=338709
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250964

TBR=shess@chromium.org,cpu@chromium.org,hubbe@google.com
NOTREECHECKS=true
NOTRY=true
BUG=338709

Review URL: https://codereview.chromium.org/170863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334309, 161119
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/166673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/167403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251787 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342525
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/157363007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251786 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251784 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167337&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/170233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251783 0039d316-1c4b-4281-b951-d872f2087c98

Previously the error message is shown in a dialog box, but it was broken and
currently there are no errors. The CLs shows the error message in the progress
center.

BUG=341400
TEST=manually

Review URL: https://codereview.chromium.org/163083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251782 0039d316-1c4b-4281-b951-d872f2087c98