- 18 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34d993b62a5..f91aeb259e09 git log c34d993b62a5..f91aeb259e09 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 egdaniel@google.com Move a bunch of gpu files out of include/private and into src/gpu. 2019-06-18 borenet@google.com [infra] Fix Go builds 2019-06-18 fmalita@chromium.org [skottie] Add support for motion tile phase 2019-06-18 rmistry@google.com [skottie-wasm-perf] Command line application to measure perf 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ed2c978cdeef..d7303797becf (1 commits) 2019-06-18 rmistry@google.com [skottie-wasm-perf] Date.now() has millisecs precision, we need microsecs Created with: gclient setdep -r src/third_party/skia@f91aeb259e09 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I268282c25f891873ae426e2180a3c800fdb76232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670118}
-
Jérôme Lebel authored
-[SigninInteractionControllerTestCase testDismissSigninFromSettings] -[SigninInteractionControllerTestCase testDismissAdvancedSigninSettingsFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromBookmarks] -[SigninInteractionControllerTestCase testDismissAdvancedSigninBookmarksFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromRecentTabs] -[SigninInteractionControllerTestCase testDismissSigninFromRecentTabsFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcher] -[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcherFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase assertOpenURLWhenSigninFromView:tapSettingsLink:] Related to: crrev.com/c/1626860 Change-Id: Ice0e675926141d2a6b59fdeba3a3f80d8215bd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664551Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#670117}
-
Matt Falkenhagen authored
Removes: * ServiceWorker.URLRequestJob.FallbackedRequestMode * ServiceWorker.URLRequestJob.MainResource.Result * ServiceWorker.URLRequestJob.MainResource.StatusZeroError * ServiceWorker.URLRequestJob.Subresource.Result * ServiceWorker.URLRequestJob.Subresource.StatusZeroError This is dead code following the launch of S13nServiceWorker. Bug: 975818, 975435, 975331, 926114 Change-Id: Ia75a4627e7c0d7bc872e9e2f4bccb4fdd1abecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663458 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670116}
-
Pavel Yatsuk authored
Currently sync state is requested from AndroidSyncSettings. This class only reflects local Android sync settings and doesn't get updated if sync is disabled for dasher account by domain administrator. ProfileSyncService#canSyncFeatureStart is the correct method to check if sync is enabled. Correspondingly IdentityDiscController should observe sync state through ProfileSyncService.SyncStateChangedListener. BUG=976089 R=mastiz@chromium.org,twellington@chromium.org Change-Id: Ibe1913c6743d1c6438945f0391ac8a21bfb03f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663376Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#670115}
-
Jarryd authored
Change-Id: I711684a8eb8d87a512851b7d2165ec15d7001775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663372 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#670114}
-
Bryan McQuade authored
Now that amp_page_load_metrics_observer has been updated to use the new loading behavior based logic, we can migrate the custom AMP UKM observer back into this file, so all AMP metrics are tracked in a single location. This is just a cleanup/refactor, with no change in logic. Change-Id: Id50bbbddd4301f8f852f3ea16c3e50ef0eb8b4ba Bug: 939333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643649 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#670113}
-
Vasilii Sukhanov authored
The password manager team doesn't look at it. Bug: 975214 Change-Id: I96117b5e082f70a4b2860ba17ce02737b57a58ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664146 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Antonio Gomes authored
Driven by CL. The removed whitelisted files seem not needed anymore. BUG=None R=blundell@chromium.org Change-Id: I53dc5264c6bf4faa1da6e1b74e2be8ff4c9627f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664570 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#670111}
-
Kristyn Hamasaki authored
Updated protocol and CSSAgent to send matched style to the front end from UI Devtools. This will allow for the feature of grouping properties in the elements pane. Bug: 973698 Change-Id: I3895a6c0b5beaf3c988e20afcf3cf90d50541560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657352Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#670110}
-
Lei Zhang authored
Defer to M77, as we will evaluate the entire PrintPreview.PageCount family of histograms. BUG=965239 Change-Id: I83af8b4e297283cfed05aa47be47d234b2254426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663557Reviewed-by:
-
Yi Su authored
//ios/web/web_state/ui/favicon_util* are responsible for parsing the js message that contains favicon URLs. This CL moves them into //ios/web/favicon. Bug: 942244 Change-Id: I9c326d924d2915b5a851590e39c13133793363c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663508Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#670108}
-
Nicolas Ouellet-payeur authored
All the histograms are set to expire in 1 year. Since most histograms didn't have an expiry date yet, this CL also adds one. Bug: 975169 Change-Id: I6294b0c47795a96d3f131e94f1151c689d01480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664513Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#670107}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/27c30ec671..8f11724067 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/27c30ec671..8f11724067 Manual change: Abseil is migrating to ABSL_ prefixed thread annotations, in order to do so, a backwards compatible absl/base/internal/thread_annotations.h has been created (with unprefixed thread annotations). This file is excluded from this CL because unprefixed thread annotations are problematic to Chromium and they were in fact prefixed by [1] during every roll. [1] - https://cs.chromium.org/chromium/src/third_party/abseil-cpp/rename_annotations.sh?l=130-165&rcl=0ec2bec15811f730af0ad00cb3a30b9bc86d821d Bug: None Change-Id: Idc60ee93f6354f70e1d24114836d8b4ce8ea9179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663135 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#670106}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59919fb1..17007c11 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55900a8d12d19e9db7e795eb50660d47e5f7043b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663889Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670105}
-
Adam Raine authored
RegisterMainThreadDocumentPaint definition now handles the case where a definiton registered on the worklet thread is different from a definiton on the main thread with the same name. In this case, the reference in document_definiton_map_ is set to null. Bug: 948761 Change-Id: Ic969e2faf09c66013d79ab9ae8966befdf263432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662531 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670104}
-
Devlin Cronin authored
These metrics are useful in tracking general extension usage, and serve as user and ecosystem signals. They should never expire. Mark the following histograms as never-expiring: Extensions.HasPermissions_Install3 Extensions.HasPermissions_Load3 Extensions.IncognitoAllowed Extensions.InstallType Extensions.LoadAll Extensions.LoadApp Extensions.LoadAppExternal Extensions.LoadExtension Extensions.LoadExtensionExternal Extensions.LoadExternal Extensions.LoadHostedApp Extensions.LoadPackagedApp Extensions.LoadPlatformApp Extensions.ManifestVersion Extensions.NonWebstoreLocation Bug: 975615, 975602, 975508, 975464, 975451, 975413, 974957 Change-Id: I33f98aa1753c197b171415cc28ffdd13cbfb870b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663319Reviewed-by:
-
Vasilii Sukhanov authored
The histogram shows if someone uses import. Bug: 975614 Change-Id: I63f8288449e11d1cd8e2a0f48dd380c5dcc99e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663418 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL sets two histograms of LargeIconService to never expire as these histograms proved to be really useful when planning UX changes in the past. The favicons landscape in the wild changes constantly and thus it is better to keep recording this to have up-to-date measurements. Bug: 975727 Change-Id: Iedf282fbfb4d16435776111f3e37f5e6d77eb3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663130Reviewed-by:
-
Daniel Vogelheim authored
Bug: 933300 Change-Id: I58e72faa9f5cdbd0390c84842cc5d5641d0b7d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634880Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#670100}
-
Ryan Sleevi authored
This histogram was introduced when it was not guaranteed that the Android trust store would be available at the "AndroidCAStore" KeyStore, which was needed for determining if a given CA was part of the system base image. The combination of CTS, plus Chromium moving to use the //net/data/ssl/root_stores index as a cross-plat way of determining known root largely obviates the concerns. BUG=975152 Change-Id: If9211e6ed22f45042380bcce25b9ccd28057b707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663078Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#670099}
-
Scott Haseley authored
The recently added (crrev.com/c/1435840) frame scheduler best effort task queue was missing a couple initialization steps, namely the frame scheduler was not associated with the task queue and the FrameTaskQueueController::TaskQueueCreated was not called on the task queue. This can prevent frame scheduler policy changes from being applied to this task queue and potentially other subtle bugs. This CL adds the missing initialization steps and adds test coverage for initialization of this task queue and the recently added inspector task queue. Change-Id: Iedb2c1e1bc778bce51c5d72748eb743dc3dd6f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639544Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#670098}
-
Sky Malice authored
Bug: 974861 Change-Id: Ib56b8f6e260e1fd4d7c1f3ad3732450fe55eb2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663019Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#670097}
-
Stephen Chenney authored
Updating scroll offsets from CC to Blink leads to mismatched offsets when the property tree is not actually committed, as is the case when deferring commits for Paint Holding. Disable scroll offsets when not committing to avoid this issue. Bug: 952585 Change-Id: Ief8fa51386d856d9c7fca7283900c94f397531c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663378Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#670096}
-
Henrique Nakashima authored
These metrics are still needed and will be needed for the upcoming experiment of OfflinePrefetch in Reduced Mode, which should be in M77. Bug: 974915 Change-Id: I74ed0c3761657685dadba1f122d4a3c9c10bff8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663033 Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Bug: 973441 Change-Id: Ie3c81ca941d4fca2673c230ea12539fc9482b127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663360 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#670094}
-
Hirokazu Honda authored
VideoPixelFormatToGfxBufferFormat() crashes if a given pixel format is not supported by the function. The function should allow to be called with an unsupported pixel format because Chrome may try to create NativePixmap with VideoPixelFormat that doesn't have equivalent gfx::BufferFormat. Bug: chromium:971943 Test: None Change-Id: Ia7a9761352919e891e1589e26c4deaab2f66ccf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655568 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#670093}
-
Erik Anderson authored
Bug: 773279 Change-Id: I94755a278ef07f49d5449e96bc0451bc77966237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657350Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Erik Anderson <Erik.Anderson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670092}
-
rbpotter authored
Bug: 949585 Change-Id: Id66af9a42d395992d8c6a40aee3f30c252bc6327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566627Reviewed-by:
-
Michael van Ouwerkerk authored
Peter and I have not worked on this for some time. Change-Id: I3c63d8d8859463e1c936baef9cee2a3ded71c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663145Reviewed-by:
-
Yusuke Sato authored
This CL allows unit tests to inject failures to the ConciergeClient method for better code coverage. BUG=b:120577015 TEST=try Change-Id: I129404f9ec81f8536d6e33081a645d2ee6a80465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663174 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09ab0ffc7c04..a8103e5d2c64 Created with: gclient setdep -r src-internal@a8103e5d2c64 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: Id868ef6ba517d8d0708abb6268439bb9b8743005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664415Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670088}
-
Peter E Conn authored
Bug: 975468, 975632 Change-Id: I3ce4ac8e43cf3bcfff5341fec2fa3bbd00ed10f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663501Reviewed-by:
-
Olga Gerchikov authored
Changes made: - ScrollTimeline interface is enabled under its own ScrollTimeline flag. - Animation class now has member variable timeline_ of type AnimationTimeline instead of DocumentTimeline. - Document and scroll linked animations are now attached to their document global document timeline. TODO: reconsider this approach. Bug: 916117 Change-Id: I5f0c3d22fdb0c9b9763f5a2400c2e3d5af32e896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597286 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#670086}
-
Lily Chen authored
RenderFrameHostImplBrowserTest.SameSiteCookieDeprecationMessages was failing on Marshmallow and older. Disabling for now until bug is solved. Bug: 974701 Change-Id: I0ccfa375c42c21825e8f35148827fee106bf027b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663111Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#670085}
-
Michael van Ouwerkerk authored
We're very close to wrapping up this project but not quite there yet. Bug: 967493 Change-Id: Idd518e74dcea0d0aa254cf9fbd70f38e383318ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664143 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#670084}
-
Francois Doray authored
This is important because BEST_EFFORT tasks are now preempted during Chrome startup (see https://chromium-review.googlesource.com/c/chromium/src/+/1642732). Bug: 973244, 887407, 924416 Change-Id: I5393417803ff53241c832363ab92eb057e7393e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662728 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#670083}
-
Mike Dougherty authored
Bug: None Change-Id: If31646e2a1ca383fd53d751f66b38ee6296ea5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662851Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670082}
-
Sebastien Lalancette authored
We shouldn't allow saving Autocomplete values that are only made of whitespaces. When that happens, the user would see an empty dropdown appearing, which is very confusing and not helpful at all. I added logic here to prevent saving further entries like these. I didn't add logic to prevent showing them, as that would be temporary logic (tech debt) added for something that the user can clean-up themselves (shift-delete, or delete from cache). Testing: Manually tested on AF Smoketest website, Added a unit test. Bug: 912882 Change-Id: I35ec67a24523d9e204fe0f3f95d5abff039842bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660831 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670081}
-
David Bienvenu authored
Bug: 972247 Change-Id: I745c71f15d5dd3642b1a4935aea0f9c4882fcab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653905Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#670080}
-
Jérôme Lebel authored
Adding ChromeIdentityService::PresentAccountDetailsController() API. Related: crrev.com/i/1397457 Adding new implementation crrev.com/c/1663505 Switching to the new API crrev.com/i/1397458 Removing old implementation crrev.com/c/1663417 Removing old API Bug: 858845 Change-Id: Ibbef7e91f68798a03ca096ac704940b1af34f8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664078Reviewed-by:
-
