- 03 Dec, 2018 40 commits
-
-
Xing Liu authored
This CL hides detail like download file size or percentage for in progress download notification. Now we only show "Downloading" in the notification text. Bug: 901393 Change-Id: I25a2f660c9004e6e5aafd671cfae291cea6bd5bd Reviewed-on: https://chromium-review.googlesource.com/c/1359053Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#613292}
-
Meilin Wang authored
Add an accessible window title called "Assistant" for Assistant container view, thus ChromeVox can read the window title when invoking multilayered shortcut:Search + a > w. Bug: 910559 Test: local compile and manually test. Change-Id: Ia71e08567cf448abce1e9a5d59b9fe50f34be8a2 Reviewed-on: https://chromium-review.googlesource.com/c/1357650 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#613291}
-
François Doray authored
Prior to this CL https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> was the address of a static member variable of WebContentsUserData<T>. Storage had to be allocated for that static member variable. Unfortunately, it was not possible to allocate the storage if T was an exported class. Since https://chromium-review.googlesource.com/1093015, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a local static variable in a static method of WebContentsUserData<T>. Unfortunately, since the method is defined in a header file (it has to because it is part of a templated class), it can be instantiated multiple times and return different values if it is referenced from different components (e.g. in a component build). With this CL, the UserDataKey of a class T derived from WebContentsUserData<T> is the address of a static member variable of T. This solution works fine with exported classes, but it requires adding macros to declare/define the static member variable in T. TBR=avi@chromium.org Bug: 589840 Change-Id: Ie618c09f1ab5db1e11ac3e7a86405577872e932f Reviewed-on: https://chromium-review.googlesource.com/c/1354402 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7808a519be73..d87b09662ee8 git log 7808a519be73..d87b09662ee8 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 joenotcharles@google.com More context when _load_codereview_impl asserts Created with: gclient setdep -r src/third_party/depot_tools@d87b09662ee8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:908466 TBR=agable@chromium.org Change-Id: Iaccfc54f9a3362befb6c1bc7cad0b7a020634f31 Reviewed-on: https://chromium-review.googlesource.com/c/1358764Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613289}
-
Mike Reed authored
Bug: 899689 Change-Id: Ie69dda53e3be3b2ec1113cea5f763e2e016f26bd Reviewed-on: https://chromium-review.googlesource.com/c/1358693 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613288}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c10a023a66f2..66f0d2c1e7b5 git log c10a023a66f2..66f0d2c1e7b5 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 jmadill@chromium.org Make Framebuffer attachments angle::Subjects. Created with: gclient setdep -r src/third_party/angle@66f0d2c1e7b5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I59224d226ee6fcd3829c7e66663a8239eccf813e Reviewed-on: https://chromium-review.googlesource.com/c/1358808Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2677 Change-Id: I77946071bac5c924e2c56745f93309cada417fae Reviewed-on: https://chromium-review.googlesource.com/c/1358510Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#613286}
-
Giovanni Ortuño Urquidi authored
On real devices, AdapterPropertyChanged is called for each property in the adapter before AdapterAdded is called. During this, the adapter should be included when returning GetAdapter and all its properties should be accessible (though they will be empty). Changes TestBluetoothAdapterClient to match this behavior but instead of calling AdapterPropertyChanged for all properties, we call it for the two that are used in tests "Powered" and "Discovering". Bug: 870192 Change-Id: I501cfb8ad2665aee27314188e5a7f667e2209ebf Reviewed-on: https://chromium-review.googlesource.com/c/1358101Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613285}
-
Scott Violet authored
This way Window::GetBoundsInScreen() returns screen coordinates. BUG=none TEST=covered by tests Change-Id: I701247ec7005b3f8bcedacbe7345154b51287a67 Reviewed-on: https://chromium-review.googlesource.com/c/1359305Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#613284}
-
Kristi Park authored
[NTP] Determine shortcut title direction by the first strong character and adjust RTL for edit shortcut dialog fields Determine text direction using the first strong character instead of whether the text contains any RTL character. Also add direction support in the edit shortcut dialog fields LTR browser: https://screenshot.googleplex.com/11Z58bTugPV.png https://screenshot.googleplex.com/ne61RSr24qg.png https://screenshot.googleplex.com/fr28i5Zzceh.png RTL browser: https://screenshot.googleplex.com/ZEGVSdiOsTS.png https://screenshot.googleplex.com/cNtF8s6htp9.png https://screenshot.googleplex.com/RHoZu97GL8y.png Bug: 910385 Change-Id: I842c1479e3a3003e218d58d5ccfa511fdddc4963 Reviewed-on: https://chromium-review.googlesource.com/c/1357637 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613283}
-
Dale Curtis authored
Apparently zero byte, nullptr packets can still be attached to memory, who knew! BUG=852093,910896,910898,910928 TEST=local run shows no leaks. R=tmathmeyer Change-Id: Iff90057b02e37cb67b9d443ffeb92695e6e5c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/1359060Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613282}
-
Sebastien Marchand authored
Bug: 863441 Change-Id: Icd11498ed8f396c5506ae995da34d375af8f7655 Reviewed-on: https://chromium-review.googlesource.com/c/1355989 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#613281}
-
Ovidio Henriquez authored
This change implements two new helper methods for site settings that organize the chooser exceptions in a way that allows their corresponding site exceptions to be grouped under the same exception. The structure of the objects returned by GetChooserExceptionListFromProfile(), described in jsdoc notation, is the following: { chooserType: string, displayName: string, object: Object, sites: Array<!SiteException> } The objects in the sites array follow the same structure as the non-chooser exceptions. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I92a654da2ef9d1d0f045df0a35eaf70a1940b44e Reviewed-on: https://chromium-review.googlesource.com/c/1357605 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#613280}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d80259d35e66..0c172a6b74fc git log d80259d35e66..0c172a6b74fc --date=short --no-merges --format='%ad %ae %s' 2018-12-03 dneto@google.com Allow Float16/Int8 for Vulkan 1.0 (#2153) 2018-12-03 stevenperron@google.com Validate uses of ids defined in unreachable blocks. (#2146) 2018-12-03 dneto@google.com Set expected version number for cpp interface test (#2154) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0c172a6b74fc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5db1b8128d90e2c2e38f3b1156d74859c780205e Reviewed-on: https://chromium-review.googlesource.com/c/1358762Reviewed-by:
-
Mike Wasserman authored
Register Ash's root windows and aura::Env in single-process mash. Keep a warning & TODOs for multi-process Mash ui_devtools support. Encapsulate server init and the switch and port definitions. An earlier CL was incorrect and caused a crash (uploaded here as PS1): https://chromium-review.googlesource.com/c/chromium/src/+/1324373 Bug: 896977 Test: ui_devtools works well on Chrome OS single-process Mash. Change-Id: Ie962343b1e121529933b5118791b767e80507684 Reviewed-on: https://chromium-review.googlesource.com/c/1334006 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#613278}
-
Thomas Guilbert authored
This CL turns on the new RemotePlayback pipeline by default. There are still some issues to address, but none of them are blocking. Due to the relatively small use of this feature, it is best to turn the feature on by default, to get the coverage we need. The extended period of time between M72 branch cut and M72 stable cut will be used to merge back any unforeseen regressions that pop-up. NOTE: This change might lead to regressions or improvements of various tests. Bug: 790766 Change-Id: I3e2ed2073da6a28b5ec6cb1ee6d2dd1851df1fde Reviewed-on: https://chromium-review.googlesource.com/c/1338887 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613277}
-
Roger McFarlane authored
This CL adds unittests which validate that a collection of independent randomized encodings of a given input string can be decoded to recover the portions common to most/all users. Bug: 896719 Change-Id: Ibe3305b62ddcf643bef6979589a1011427cfcbd2 Reviewed-on: https://chromium-review.googlesource.com/c/1357642 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#613276}
-
Eric Karl authored
Fixes two small issues preventing SkiaRenderer from running on Android: - Enablment flags not forwarded via RendererSettings. - gles2::FeatureInfo not available on SkiaOutputSurfaceImplOnGpu. Bug: 809726 Change-Id: I66de6c577eaa4d4b1eb6e6ae45c5036ae0b098f0 Reviewed-on: https://chromium-review.googlesource.com/c/1352248 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613275}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I9ffe55a11ba54c6c56694b166b762254cc19d4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1355919Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#613274}
-
Antoine Labour authored
Bug: None Change-Id: Icb435aae59f43ace9c52af6a67ddcb331181ad91 Reviewed-on: https://chromium-review.googlesource.com/c/1359318Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613273}
-
Brian Sheedy authored
This reverts commit 06b8660d. Reason for revert: Hitting DCHECK: [FATAL:latency_tracker.cc(399)] Check failed: (event_timestamp - last_event_timestamp_).InMilliseconds() >= 0 Original change's description: > Use mocked VR controller for scrolling > > Switches all VR instrumentation tests for scrolling using the Daydream > controller to use the Chrome-side controller mock instead of the > VrCore-side emulation via intents. The latter has always been somewhat > flaky, so this should help reduce VR test flakiness. > > Bug: 902938 > Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 > Reviewed-on: https://chromium-review.googlesource.com/c/1341061 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613107} TBR=vollick@chromium.org,cjgrant@chromium.org,bsheedy@chromium.org Change-Id: I40d8cf660d35a14ee4269010f5da749a2e91daad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902938 Reviewed-on: https://chromium-review.googlesource.com/c/1359311Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613272}
-
Bailey Berro authored
This change removes the attached method override from the smb-share-dialog component. Bug: chromium:887135 Change-Id: Id6a7b06a2b2b9ea4d0da5dc04cb14f7143c0c312 Reviewed-on: https://chromium-review.googlesource.com/c/1340860 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613271}
-
Gauthier Ambard authored
This CL removes the cap on the font size used to display the instructions on the empty TableView background in ReadingList. Bug: 911174 Change-Id: Iaadd7cd0e9d070a0052847daa513e3f1ae1b50b7 Reviewed-on: https://chromium-review.googlesource.com/c/1358465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613270}
-
Lei Zhang authored
PrinterCapabilitiesTest is in printer_capabilities_unittest.cc inside components/, but is not built as part of components_unittests. Instead, it it built as part of components_browsertests, but does not appear in the list of tests. Fix the build rules so it builds in components_unittests as a proper test. Move printer_capabilities_unittest.cc next to printer_capabilities.cc. Change-Id: I6be9606a97968e26de5528ee395e044d92f1ed9c Reviewed-on: https://chromium-review.googlesource.com/c/1357616Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613269}
-
Jinsuk Kim authored
https://crrev.com/c/1135874 left out checking gamepad events by mistake. This CL fixes it by adding the check against GenericMotionEvent in the content ui event handler. Tested on https://html5gamepad.com with a USB gamepad. Bug: 906347 Change-Id: I2bd0890f2533e70a772dbb0b005d69bf086d1595 Reviewed-on: https://chromium-review.googlesource.com/c/1356727Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#613268}
-
rbpotter authored
- Delete ticket items and other unused files in data/ - Complete TODOs in handler - Remove unused strings Bug: 908705 Change-Id: Ie02a00ad6b8ada56b3d327d75e2ad841e534cb9f Reviewed-on: https://chromium-review.googlesource.com/c/1357527 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613267}
-
braveyao authored
This checkbox is set as checked by default at present. With some new features, as getDisplayMedia and dynamic change capture source, it's more reasonalbe to set it as unchecked by default. Also it will help to count the requirement of audio capture during presenting. Bug: 892201 Change-Id: I36c253bf1c862a31d99927be79c2072332cb1622 Reviewed-on: https://chromium-review.googlesource.com/c/1356713Reviewed-by:
Qiang Chen <qiangchen@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613266}
-
Danyao Wang authored
This makes it more clear which WebStateObserver callbacks are called when. This change does not contain any function changes. Bug: 903497 Change-Id: Ie774c191ffc2681a7cf1df90089ea25e90a381ac Reviewed-on: https://chromium-review.googlesource.com/c/1359296Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#613265}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1684ef61ea6..eec53b64a610 git log f1684ef61ea6..eec53b64a610 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 djmm@google.com Update luci schedule with M72 branch info Created with: gclient setdep -r src/third_party/chromite@eec53b64a610 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6e1cf287cd77d28501648600c530f725c6569d4 Reviewed-on: https://chromium-review.googlesource.com/c/1358807Reviewed-by:
-
jonross authored
RenderWidgetHostViewBrowserTestBase.CompositorWorksWhenReusingRenderer was disabled due to high flakiness on Android. However the bug report is older, and the logs are all gone. I cannot reproduce the flakes locally. Going to speculatively re-enable to see if the flakes are gone. If not I'll at least have error stacks to go off of. TBR=samans@chromium.org TEST=RenderWidgetHostViewBrowserTestBase.CompositorWorksWhenReusingRenderer Bug: 896466 Change-Id: Ifa2abecc2c429641a10519c866294edce5354820 Reviewed-on: https://chromium-review.googlesource.com/c/1359050Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#613263}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/056f9738bf7a..ec0f45be1144 git log 056f9738bf7a..ec0f45be1144 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 solenberg@webrtc.org Revert "Remove CodecInst pt.1" 2018-12-03 gustaf@webrtc.org AEC3: Fix ENR threshold for WebRTC-Aec3UseLegacyNormalSuppressorTuning Created with: gclient setdep -r src/third_party/webrtc@ec0f45be1144 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:911141 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd7032f0791826747a1499fd8112dafb701551ef Reviewed-on: https://chromium-review.googlesource.com/c/1358761Reviewed-by:
-
Jan Krcal authored
This CL adds two more sync integration tests for autofill wallet sync. Bug: 894001 Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7 Reviewed-on: https://chromium-review.googlesource.com/c/1358508 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613261}
-
Mohamed Amir Yosef authored
Bug: 911232 Change-Id: I4813401d73ae6281fd044882c8e61869223c0911 Reviewed-on: https://chromium-review.googlesource.com/c/1359034 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613260}
-
Lei Zhang authored
Give setup() a more distinctive name, and add a missing <html> tag. Change-Id: I81e42c231afdce5cf574e14927621a959c19c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1357728Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies the people section to only show the "Manage other people" row on Chrome OS. On other platforms this option will still be accessible from the Profile Chooser. Bug: 907035 Change-Id: I7c2ab9ee97658e37a11f9d9a6d9ac0736ed2a1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1349336Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2eb15071cfa..1fbed8388ab1 Created with: gclient setdep -r src-internal@1fbed8388ab1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I07138aaaa4a8026fd7403d0288acf6c2d3c5bde8 Reviewed-on: https://chromium-review.googlesource.com/c/1358760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613257}
-
sczs authored
- Renames TableViewAccessoryItem/Cell to TableViewImageItem/Cell, and adds a property that makes the chevron optional. - Adds tests for the new behavior. - Uses this new property to hide the chevron on Show Full History in Recent Tabs. Bug: 910738 Change-Id: I9aeee17ebab52cbfcedb1c56b5e54221a5d7b2dd Reviewed-on: https://chromium-review.googlesource.com/c/1358967Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#613256}
-
Christopher Cameron authored
This is a step toward supporting shortcut keys and menu interface items in PWAs. This breaks the function -[BrowserWindowCommandHandler validateUserInterfaceItem] into two parts - The part to look up the browser command and to update the interface item still remains in BrowserWindowCommandHandler (which will be in the in the PWA process). - The part to access the Browser*, which will be in the browser process, which is - routed through mojo to the BridgedNativeWidgetHostImpl - to the NativeWidgetMac - which is subclassed as BrowserFrameMac - which calls BrowserWindowCommandHandlerValidateUserInterfaceItem to implemented the parts that used to be in BrowserWindowCommandHandler Also add required interface to look up a BridgedNativeWidgetImpl from an NSWindow. Bug: 895169 Change-Id: Ie81a1e5a44537b07183d4c29b89d2da1951137c0 Reviewed-on: https://chromium-review.googlesource.com/c/1357829 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#613255}
-
Ivan Sandrk authored
Locked fullscreen is supposed to be a secure mode where the user cannot do anything outside of the current browser window, but ARC apps can currently draw on top of it. To fix this, we disable ARC when entering the mode, and we re-enable it upon exiting the mode. Bug: 888611 Change-Id: I84cda87a260a42108f1ef6c4767c174bc8b1fb61 Reviewed-on: https://chromium-review.googlesource.com/c/1356813Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#613254}
-
Chris Palmer authored
A foolish consistency is the hobgoblin of little minds. #welp Bug: None Change-Id: Ia174e3fa99252a7931429c22d769872bc2f0c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1357625 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#613253}
-
