- 30 Jul, 2020 40 commits
-
-
Ayu Ishii authored
Bug: 1007643 Change-Id: I41633b19505c54698737009400e27d72607950ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315421Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#793242}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1ca8d87239f1..378a948e0d84 2020-07-30 titovartem@google.com Roll chromium_revision 72280394..f4c74ea1 (791192:792888) 2020-07-30 titovartem@google.com Fix "Assignment had no effect." error during chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5709651f78d608cd8f874bbe51fdcb8dd4ebcb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793241}
-
Sammie Quon authored
Test: ash_unittests InkDropHostViewClippingTest.* Bug: 1056490 Change-Id: If2cc7d01363c40fcc46133d598f4b636eecc8303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327860 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793240}
-
Adenilson Cavalcanti authored
It was revealed by a new clang flag (i.e. basic-aa-recphi) that chunkcopy_safe could hit a scenario of undefined behavior with the use of 'restrict' modifier when the 'from' and 'out' pointers overlapped during decompression. This patch targets to address this issue and unblock the enablement of the aforementioned compiler flag. Credit for the original investigation and the new unit test stressing the failure scenario goes to Hans Wennborg. Performance implications: initial numbers point to a slight improvement for ARM big cores@64bit (i.e. 2% to 3.6%) and x86-64 (i.e. up to 7.5% for Intel i7) but a regression otherwise for 32bit (i.e. between 2.3% to 3% big.LITTLE respectively). Bug: 1103818 Change-Id: I9b7d2c1e47caaf498cd539fd6b77c4b949cb0dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309041Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#793239}
-
David Benjamin authored
Now that we are using views on Mac, we can use the same client certificate selector used on CrOS, Linux, and Windows. This means less code to maintain, and it also avoids a host of bugs with the tab-constrained sheet logic which has become increasingly buggy as Chrome and macOS have evolved. (See associated bugs.) This retains tab-modality, so sites cannot prevent tab switching or tab closing, but it switches us from the native sheet to our own UI. Screenshots: https://drive.google.com/drive/folders/1YlVAWm-xL8ZDP9k-amdBb4l18nh08rJZ?usp=sharing This should leave parts of components/constrained_window and ClientCertIdentity::sec_identity_ref unused. A follow-up CL will unwind that logic. Bug: 983451, 1020622, 1078158, 1098786 Change-Id: I9b2ea99a91e63e45934725dead6bade35ec3ca4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314036Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793238}
-
Xiyuan Xia authored
WebMediaPlayerMSCompositor::SetCurrentFrame considers rotation when checking for video frame size change. Otherwise, size is not handled properly when a new frame with a different rotation has the same pre-rotation frame size of the current frame. Bug: 990682 Change-Id: I022923a51697ed56dc036d955f94161906a2cd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327458Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793237}
-
Daniel Classon authored
DeepLinkingBehavior was beefed up to handle more of the logic. Updated the Reset Page to use the new methods. Bug: 1084154 Change-Id: I7234d0f5d9162614aa22e2eb03328ecabdd7fe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318002 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793236}
-
Rakina Zata Amni authored
The flag was accidentally deleted in the RenderViewHost->WebContents move. See https://chromium-review.googlesource.com/c/chromium/src/+/2266917/11/content/browser/renderer_host/render_view_host_impl.cc Bug: 1085003. Change-Id: Ifdfa90eb02117c5a599ab12bc5b2375e966c704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329951 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793235}
-
Fabian Sommer authored
Replace two instances of $(setCertificates) with $(ref:setCertificates) Bug: 1078761 Change-Id: I23d3be5c8ffb04c7aa7f47e1333c55304bc54cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329535 Auto-Submit: Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#793234}
-
Guido Urdaneta authored
Prior to this CL, the method ContentBrowserClient::ShouldSandboxAudioService() returned false, which made the sandbox disabled by default for embedders that do not override this method, like content_shell. Instead, this should return true if the AudioServiceSandbox feature is enabled. This was a regression introduced in http://crrev.com/790723 Bug: 1111349,1109346 Change-Id: Ib38c02e63ee039e6550707026cf15a1ce8739575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329891Reviewed-by:
-
Michael Crouse authored
This change adds plumbing to allow the LiteVideo optimization to observe when rebuffer events occur so that all throttling can be stopped. A future change will record the even in the user blocklist and record the event in UKM. Bug: 1082554 Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793232}
-
Mikel Astiz authored
This is intended to be used as an indication to the UI that the user should take action to improve recoverability of the sync-ed data. This patch introduces basic plumbing in TrustedVaultClient with TODOs to address platform-specific implementations in later patches. Meanwhile, StandaloneTrustedVaultClient is extended with test-only APIs for integration tests. Change-Id: Ic255e502d9e33b145272903dc2b7c3a7ec2a1cd8 Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329751Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793231}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/976db5baa78b..23b75a4d658c 2020-07-30 fmayer@google.com Build standalone client using static STL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160400319 Tbr: perfetto-bugs@google.com Change-Id: I2050ebf60808819262707912a799529de3a70319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330031Reviewed-by:
-
Vasiliy Telezhnikov authored
GrContext still need device queue in dtor, so we need to delete it before. Bug: 1110245, 984955 Change-Id: Ia6c53ade66c8636dc3fcee897c2ff6c286168b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329933Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793229}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bcdec7d7076c..976db5baa78b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8f6383dac422b9e4b9f361bf62337d3d55766013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329990Reviewed-by:
-
Lindsay Pasricha authored
Also add coverage for ios13 and ios14 on the ios14-sdk bot. Ignore-CQ-Freeze: fyi bot only Bug: 1110858 Change-Id: Iecde449afa5b1a9ae4035c61be82efb2b9bbc3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327615 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#793227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/52a98ac3af69..bf47d2ef673b 2020-07-30 mmortensen@google.com BuildAPI: Implement UnmountPath method in sdk/service. 2020-07-30 vapier@chromium.org cros_sdk: preserve sys.executable usage when reexecing 2020-07-30 uekawa@google.com arc: remove vmpi pfq. 2020-07-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-29 lamontjones@chromium.org api: freshen compiled protos 2020-07-29 vapier@chromium.org wrapper3: include more info in version check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6388f09d758f43cf561de9f5b10da3816ded5254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329061Reviewed-by:
-
minch authored
NewWindowDelegate::OpenFeedbackPage can only be used to open the feedback dialog in the active user session. SigninScreenHandler::HandleSendFeedback is used to open the feedback dialog in the login screen. Due to the effort to create the instance of SigninScreenHandler, this cl triggers the same handler associated with the feedback accelerator from the login screen to bring up the feedback dialog. Bug: 1107188 Change-Id: I847f96a958f50b1ebbea6f5413e80e0002155042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325274 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#793225}
-
Bin Du authored
We have noticed performance regressions on MatchVlogPattern as mentioned in b/77729987#comment29. Specifically, since BOY of 2019, based on data collected from CrOS user devices, the CPU cycles spent on this MatchVlogPattern function has increased by 3X, mainly due to increased logging and increased chrome --vmodule flags added by default. The presence of any --vmodule pattern makes this pattern matching to run on every VLOG. Thus, temporary --vmodule patterns used for debugging but no longer needed have been removed in https://crrev.com/c/2305853. This CL is to change the pattern matching function to a greedy approach. Some benchmarks have been done in b/77729987#comment32, comparing the original recursive approach vs the updated greedy approach. More updated details on the benchmarks can be found in the comments below. Bug: 77729987 Change-Id: Idd0160b02f7bc9404fadf9238bc10b1a5dcee71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327275 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793224}
-
Emily Stark authored
If we animate to the simplified domain on mouse clicks, it can create a weird experience when clicking on links (as described in bug). Also, sometimes users just vacantly click on the web contents while browsing a page, but it doesn't signal any real intent to interact with the page. We'll therefore exclude mouse clicks from counting as user interactions that trigger URL elision to the simplified domain. Bug: 1104280 Change-Id: I3fca27e171b8f8f48b980f85580bd958fb6a4e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327289Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#793223}
-
Varun Khaneja authored
Also removes the corresponding histograms. This code was added to remove lists that were in use previously but are no longer in use. The code to delete the lists was added in 2018 and we wanted to leave it in for a few releases to ensure that it is removed from all users' machines. http://screen/VCRd5VUL1B7 shows those stores exist on disk for an extremely small proportion of users. Fixed: 1089439, 695081 Change-Id: I274707f312ec1c1c2baedf8997643ac3b95f1ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327850Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#793222}
-
Clark DuVall authored
I verified SafeBrowsingApiBridge_onUrlCheckDone is now in weblayer_jni_registration.h. Bug: 1111082 Change-Id: I739ee83c69bbd145bb51b2816799ef83e72aedf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329914 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793221}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596106614-c0cf678d73b5b04fadad07393187258d17226466.profdata to chrome-win32-master-1596109918-16bc7f13ad29419585998ed9064c276de22544b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I552063e17e4560f81fe1df4b47a425d22a615ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329060Reviewed-by:
-
Avi Drissman authored
Bug: 1105907 Change-Id: I0bfeb0d96f9d1c8671b81d7165d7fd95363dae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328343 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#793219}
-
Ravjit Singh Uppal authored
Bug: 1111350, 1096944 Change-Id: I8749caa24c7ef51c4410b5793777e68bdfbcf889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329851 Auto-Submit: Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#793218}
-
Dave Tapuska authored
In order to move all handling of visual properties in blink we are progressively moving functionality into blink. BUG=1097816 Change-Id: Ib51ec0440ba821e2db160039b4143d4bcfb38f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314684 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Andrew Xu authored
This CL creates a test case to verify that the duplicate copy-and-paste data are handled as expected. The test case would fail before @dmblack's fix (https://crrev.com/c/2317714). Bug: 1109292 Change-Id: I724118eb830b64b769166a031f7e507c7d639964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317733 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793216}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Iae96aa49bf0f80020dce8783b5343901df2909f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328341Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793215}
-
Tommy Li authored
This CL just adds a base::Feature to guard the "clobber" as ZeroSuggest entrypoint. Adds it to about:flags too. Bug: 1106096 Change-Id: I63f3dbdb60a986dd0fde58d8da3007603d8f2349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327844Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ffea8a6a6482..899893a60cc5 2020-07-30 jacktfranklin@chromium.org Migrate animation to devtools_entrypoint 2020-07-30 janscheffler@chromium.org Migrate `front_end/inspector_main` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Migrate `front_end/emulation` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16809af54b5e8688555070919cf77e156b74a66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329062Reviewed-by:
-
Trent Begin authored
This change adds a callback to wait until the dbus service is available to start the bootstrapping process. Since the cros_healthd service is now boostrapped on startup, the dbus service is not always immediately available. Bug: chromium:1057739, chromium:1110386 Change-Id: Idd61dce38796e76156561cba455f5932cf475c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324162 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793212}
-
Haiyang Pan authored
This reverts commit c3dc2201. Reason for revert: nestedLinkClickTest is flaky in android-pie-x86-rel. See screenshot https://screenshot.googleplex.com/t1wYwrBqarg Original change's description: > [Paint Preview] Add multi-frame tests > > This CL adds multi-frame tests for > > - Scrolling > - Scaling > - Link clicks > > Bug: 1106035 > Change-Id: I09eb3e008701204ac55b2cd60fb97a206d88cb4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324489 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792869} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: Ia844c2792a265dbb369bf807bebb46d1dd97e884 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329994Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#793211}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I0ed06905274893105e16bbc6c9343d6a30d5423d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328334Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update ExtensionHost::GetURL() to be ExtensionHost::GetLastCommittedURL(), and to use WebContents::GetLastCommittedURL() internally. The only places that used this were security decisions and tests, so the last committed URL is more appropriate. Bug: 237908 Change-Id: Ib875416bb92c06de4c9dcff99a59ad121df3b685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327853Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793209}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45f583aecc0..bcdec7d7076c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2eca75542111199c137d2c99767e013ce79b4119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329058Reviewed-by:
-
Dan Harrington authored
The server expects a value here for infinite feed to work. Bug: 1044139, b/162375361 Change-Id: I9fb7b0085040db871ae1a497a17e6125ecd97095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325081 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#793207}
-
Chris Hamilton authored
This migrates workers to use WorkerTokens instead of the now deprecated DevToolsToken. A further CL will wire in tokens for service workers. BUG=1085129, 1096617 Change-Id: Ic85b0264d72d53a9a673bdc0d82211972bdccac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326430 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#793206}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I9ef37d35c24a3d1babd1549fb67127a0c3ab3341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328337 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#793205}
-
Pavol Marko authored
That bug is archived and has had no activity for ~2 years, so remove these logs. Stumbled upon them while investigating something else. Bug: 882545 Change-Id: Id367bf1d2b5237e11e1b287a48f8a14acd41f4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316201Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793204}
-
Reilly Grant authored
This change fixes the implementation of policy control over the USB guard permission so that the settings are updated when a new policy is pushed, and adds tests for this behavior. Change-Id: Ifd86a5ed63efef6093179baff7c08407bd195cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328210 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793203}
-
