- 03 May, 2017 40 commits
-
-
morlovich authored
split between queuing delay and synchronous portion. (there is already an end-to-end stat that covers both ops, and one for sync portion of open only). Made the sync portion of open histogram split by cache_type like every other SimpleCache statistic. Also add synchronous portion metrics for Write/Close as both of these seem to have opportunities for improvement, so it makes sense to measure them directly, at least short-term. BUG= Review-Url: https://codereview.chromium.org/2853263002 Cr-Commit-Position: refs/heads/master@{#469038}
-
nednguyen authored
|benchmark_sharding_map| is always non None, hence the branching to use |bot_utils.GetDeviceAffinity| when it's None is now dead code. BUG=713357 TBR=eyaich@chromium.org Review-Url: https://codereview.chromium.org/2854413002 Cr-Commit-Position: refs/heads/master@{#469037}
-
alito authored
BUG= Review-Url: https://codereview.chromium.org/2856073002 Cr-Commit-Position: refs/heads/master@{#469036}
-
dimich authored
The proposal includes a request for a public (chromium.org) discussion group, so we've started offline-dev@chromium.org. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal BUG=NONE Review-Url: https://codereview.chromium.org/2854253004 Cr-Commit-Position: refs/heads/master@{#469035}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/15b8a2e9d520..b77ce91e0576 $ git log 15b8a2e9d..b77ce91e0 --date=short --no-merges --format='%ad %ae %s' 2017-05-03 simonhatch Dashboard - Reduce bisect retries to 1. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I92a9304e26b6a6c4ca34c8d33def9e983935e698 Reviewed-on: https://chromium-review.googlesource.com/493780 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469034}
-
donnd authored
When a Tap selection is present, a second tap shows the pins, and the Bar should keep showing. However this seems to currently be flaky. This CL adds a check when a Tap is recognized to see if we're already showing a Tap-selection. We were incorrectly starting a Tap sequence in response to this second tap but that's not needed since we'll soon get a message for the Long-press gesture when the pins show. BUG=717942 Review-Url: https://codereview.chromium.org/2853393003 Cr-Commit-Position: refs/heads/master@{#469033}
-
dtapuska authored
Check that the position is correct when executing the GPU benchmark Tap request if it isn't throw an exception. BUG=683503 Review-Url: https://codereview.chromium.org/2838393002 Cr-Commit-Position: refs/heads/master@{#469032}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f45ade3a0af9..1e5a98afd195 $ git log f45ade3a0..1e5a98afd --date=short --no-merges --format='%ad %ae %s' 2017-05-03 npm Use enum class GifDecodeStatus instead of integers in fx_gif Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ief3b6967612c1f57d0d9070d73067204d6b752e2 Reviewed-on: https://chromium-review.googlesource.com/493874 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469031}
-
yolandyan authored
This CL convert all the ChromeActivityTestCaseBase direct children tests to JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored to directly calling TouchCommon. For more on JUnit4 migration, check src/testing/android/docs/junit4.md Previous landing CL: https://codereview.chromium.org/2831823003 BUG=640116 Review-Url: https://codereview.chromium.org/2858933002 Cr-Commit-Position: refs/heads/master@{#469030}
-
jdonnelly authored
This treats URLs the same way they are treated in the omnibox text field: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm?l=528&rcl=5bd9e2fd296b774e34d04cddfb09893525a79c04 BUG=712919 Review-Url: https://codereview.chromium.org/2854893002 Cr-Commit-Position: refs/heads/master@{#469029}
-
fdoray authored
These methods are not used anymore. BUG=667892 Review-Url: https://codereview.chromium.org/2853403002 Cr-Commit-Position: refs/heads/master@{#469028}
-
rch authored
Review-Url: https://codereview.chromium.org/2854363003 Cr-Commit-Position: refs/heads/master@{#469027}
-
jdufault authored
This CL forks login code which is most likely to change with the new UI. This allows us to make breaking changes to the login screen without worrying about the previous UI. This adds an `isMd` boolean variable in the global scope that can be dynamically queried if we need to make changes in a file and it is not trivial to fork it. Otherwise, there are no code changes besides loading different assets. BUG=717779 NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2855883005 Cr-Commit-Position: refs/heads/master@{#469026}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=steel@chromium.org Review-Url: https://codereview.chromium.org/2773473002 Cr-Commit-Position: refs/heads/master@{#469025}
-
mike authored
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-frame-resource.html This test is equivalent to the upstream version. - third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-inscope.html - third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-outscope.html These tests are roughly equivalent to the upstream versions. Because the upstream versions only differ in the inclusion of additional assertions, the Chromium-specific versions can be safely removed. BUG=688116 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2859653002 Cr-Commit-Position: refs/heads/master@{#469024}
-
riajiang authored
BUG=none, follow-up of https://codereview.chromium.org/2854663002/. TEST=aura_unittests Review-Url: https://codereview.chromium.org/2858633005 Cr-Commit-Position: refs/heads/master@{#469023}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4916264..5aa79437 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2860763002 Cr-Commit-Position: refs/heads/master@{#469022}
-
msramek authored
TBR=sky@chromium.org BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Original-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#469021}
-
rtoy authored
Manually converted tests to use new Audit. BUG=704967 TEST= StereoPanner/stereopannernode-no-glitch.html StereoPanner/stereopannernode-panning.html Review-Url: https://codereview.chromium.org/2788793004 Cr-Commit-Position: refs/heads/master@{#469020}
-
timav authored
This is the maximal amount of characters from the left and from the right taken together, i.e. there is 120 on each side. BUG=717619 Review-Url: https://codereview.chromium.org/2862503002 Cr-Commit-Position: refs/heads/master@{#469019}
-
bsalomon authored
The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel BUG=651829 Review-Url: https://codereview.chromium.org/2436813005 Cr-Commit-Position: refs/heads/master@{#469018}
-
agrieve authored
This eliminates the chance of a diff coming up where the symbols do not sum up to the entire section delta Other misc changes here: * Improves the size summary messaging. * Kills nm subprocess upon exit (rather than letting process finish) * Allows linker maps to not have a Common Symbols section BUG=714180 Review-Url: https://codereview.chromium.org/2858793002 Cr-Commit-Position: refs/heads/master@{#469017}
-
dyaroshev authored
This check returns false for the first part of the loop and returns true for the second one. We split this loop in two and remove this check. Review-Url: https://codereview.chromium.org/2807933002 Cr-Commit-Position: refs/heads/master@{#469016}
-
davidben authored
BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2853383003 Cr-Commit-Position: refs/heads/master@{#469015}
-
timvolodine authored
Move threat_details* to the safe_browsing component and update build files and dependencies. BUG=700351, 688629 Review-Url: https://codereview.chromium.org/2836103002 Cr-Commit-Position: refs/heads/master@{#469014}
-
dfalcantara authored
There's a race condition that's causing a tab to finish loading before onStartWithNative has successfully run. It's not entirely clear where the race condition lies because the startup pathway is complicated, so prevent deferred startup from running until native has loaded. BUG=711708 Review-Url: https://codereview.chromium.org/2855043002 Cr-Commit-Position: refs/heads/master@{#469013}
-
erikchen authored
base::SharedMemory used to support synchronous transport of handles into other processes using base::SharedMemory::ShareToProcess. This required base::SharedMemoryHandle to also track whether the OS resource belonged to the current process. ShareToProcess has been removed, so all the pid tracking is no longer necessary. BUG=716206 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng TBR=wfh@chromium.org Review-Url: https://codereview.chromium.org/2849243002 Cr-Commit-Position: refs/heads/master@{#469012}
-
rtoy authored
Manually converted to use new Audit. BUG=704967 TEST=constructor/stereopanner.html Review-Url: https://codereview.chromium.org/2832493005 Cr-Commit-Position: refs/heads/master@{#469011}
-
thakis authored
See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&type=cs BUG=675877 Review-Url: https://codereview.chromium.org/2861743002 Cr-Commit-Position: refs/heads/master@{#469010}
-
alph authored
NOTRY=true Review-Url: https://codereview.chromium.org/2856203002 Cr-Commit-Position: refs/heads/master@{#469009}
-
fdoray authored
To prevent races, make sure that code that runs after TaskTracker::Flush() sees memory changed by all tasks it was waiting for. BUG=717527 Review-Url: https://codereview.chromium.org/2857613002 Cr-Commit-Position: refs/heads/master@{#469008}
-
kbr authored
Because the first MakeCurrent call against a virtual GL context leaves the real context state indeterminate (since the GLES2Decoder isn't initialized and by definition neither is the GLStateRestorer), force it to be made current again after initialization. This fixes a longstanding bug where if the next GLES2Decoder to do significant work was the same one that was just created, it would do this work with the majority of the real GL context state set to that of the previous virtual GL context. BUG=694359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2862443002 Cr-Commit-Position: refs/heads/master@{#469007}
-
robertshield authored
(patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ ) This reverts commit 9fb1c8b9. It relands the original patch by fixing an uninitialized read in the related browser test. BUG=685905,717315 Review-Url: https://codereview.chromium.org/2857663002 Cr-Commit-Position: refs/heads/master@{#469006}
-
mmenke authored
This CL makes ProxyScriptFetcherImpl use highest priority and LOAD_IGNORE_LIMITS, and adds an OnShutdown method to ProxyService, which must be called before teardown when the ProxyService makes requests using a URLRequestContext that it is also used with. No consumer currently uses the new functionality. I plan to switch IOThread/ProfileIOData to using it in another CL, and add a call in URLRequestContextStorage's destructor. May also be worth making it mandatory as well, though that will involve more changes. BUG=715697 Review-Url: https://codereview.chromium.org/2845643003 Cr-Commit-Position: refs/heads/master@{#469005}
-
stkhapugin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2820383002 Cr-Commit-Position: refs/heads/master@{#469004}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/131154be103d..e188f8b14b6a $ git log 131154be1..e188f8b14 --date=short --no-merges --format='%ad %ae %s' 2017-05-03 ethannicholas Revert "Revert "eliminated GrGLSLExpr"" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I970c03546e108b49912be7694fd60ee56b5d9f1f Reviewed-on: https://chromium-review.googlesource.com/493842Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#469003}
-
ortuno authored
Two changes: 1. Call setBluetoothFakeAdapter('') to clean up any adapters left by legacy tests. 2. Change 'available' to 'supported' to match the functions name. BUG=569709 Review-Url: https://codereview.chromium.org/2859673003 Cr-Commit-Position: refs/heads/master@{#469002}
-
vasilii authored
A class with virtual methods should have a virtual destructor. BUG=697810 Review-Url: https://codereview.chromium.org/2858683005 Cr-Commit-Position: refs/heads/master@{#469001}
-
johnme authored
WebRestrictionsResourceThrottleTest.WillStartRequest_Subresource is flaking heavily on most Android bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=WebRestrictionsResourceThrottleTest.WillStartRequest_Subresource NOTREECHECKS=true NOTRY=true BUG=718066 TBR=aberent@chromium.org Review-Url: https://codereview.chromium.org/2854423003 Cr-Commit-Position: refs/heads/master@{#469000}
-
rhalavati authored
Network traffic annotation is added to network request of components/policy/core/common/cloud/device_management_service.cc components/policy/core/common/cloud/external_policy_data_fetcher.cc components/policy/core/common/cloud/user_info_fetcher.cc BUG=656607 Review-Url: https://codereview.chromium.org/2800653002 Cr-Commit-Position: refs/heads/master@{#468999}
-