- 14 May, 2019 40 commits
-
-
sczs authored
Adds an identifying IconButton to passwordItem that toggles the Masking/Unmasking of the password. Bug: 945478 Change-Id: I6b5d05728342f19fdf2d8f7907ce8012ae31fd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611221Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659553}
-
Koji Ishii authored
This patch puts LayoutNG line cache under a new runtime flag which is not enabled by default. There have been discussions on this, for its cost/risk and benefits. As we approach to ship, more risk cases were found. Also with recent normal layout caching work by ikilpatrick@, we're hoping to find better integration of line caching with block caching. It is known that this hinders the performance on appending micro benchmarks and in editing. We will probably need to revisit in post-phase 1, but we can polish it better with the data and the experiences we've got so far. Bug: 962008, 962141 Change-Id: Iee162be41b36ce5462a89efbbdd7abe796c3a14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611068Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659552}
-
jonross authored
We would like to experiment with newer versions of Ubuntu on the GPU bots. As a first step we are pinning the non-experimental mixin to target Ubuntu-14.04. Bug: 953535 Change-Id: I2237861e6074b2e67b4999e02d1fe1f494055e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611283Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#659551}
-
Ali Juma authored
In http://crrev.com/c/1554352, the logic for loading error pages on back/ forward navigation was changed to do a full placeholder load instead of directly loading the error page, to workaround WebKit caching a blank error page. However, when navigating back to a page which previously loaded successfully but is no longer accessible (e.g., because of being in airplane mode), a full placeholder load destroys forward history. This CL modifies that change to rewrite the current URL to a placeholder URL using loadHTMLString, rather than doing a full placeholder load. This preserves the previous fix while also preserving forward history. The bug that the previous CL fixed was caused by the following sequence of loads on forward navigation to an inaccessible page: (1) A successful placeholder load, caused by forward navigation to an item whose URL is a placeholder. (2) An empty loadHTMLString with the actual URL caused by ErrorRetryState::kRetryPlaceholderNavigation. (3) An attempt to reload the actual URL, cause by ErrorRetryState::kNavigatingToFailedNavigationItem. (4) A loadHTMLSring with the actual URL, to load the error page. In the above sequence, the failed load step (3) would invalidate the PageCache entry for the current navigation item. At this point, the item still has a placeholder URL, so the load in (4) is considered to be a Standard load, causing the existing content to get added to PageCache for this item. The URL in the PageCache is that of the DocumentLoader for the existing content (from (2)), so it's the actual URL. After (4), navigating away from the page (e.g., going Back) doesn't update the PageCache, since the item doesn't have a PageCache entry. Then, on the next forward navigation to this item, WebKit loads the cached content from (2) along with the actual URL, so when we get the didFinishNavigation call for this load, we're in case ErrorRetryState::kDisplayingWebErrorForFailedNavigation and can't tell whether the page was loaded successfully or not, so assume that it was and leave it up to the user to reload. At this point the blank content from (2) is displayed. The previous CL solves this by doing a full placeholder load after (3). The problem is that if the page had previously loaded successfully before, this is a Standard load in WebKit (because it's a loadRequest with URL that doesn't match the current one), so Forward history is destroyed. The test added in that CL (ErrorPageTest.BackForwardErrorPage) doesn't catch this, because the page with the error never has a successful load. This CL rewrites the URL to a placeholder URL using loadHTMLString rather than loadRequest. This prevents forward history from being destroyed. It also still fixes the caching bug: In the sequence above, there will now be a step (3.5) for the loadHTMLString with empty content and the placeholder URL. This is the content that will be cached by WebKit. So this item's URL will still be the placeholder URL on futurue visits, meaning the ErrorRetryStateMachine will no longer wind up in a state where it can't tell whether the page has loaded successfully; instead, since the URL is a placeholder, it will wind up in ErrorRetryState::kNavigatingToFailedNavigationItem. Bug: 950489 Change-Id: Ib9437578a84e564fc87702e3a344454baae39029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610480Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#659550}
-
sczs authored
There's no UI functionality changes, but this opens the possibility to tap on this icon later on. It will be used to mask/unmask a password in the Password InfobarModal Bug: 945478 Change-Id: I67398a5a001056164db1d2ec2a2d0b927244158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607434 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Guohui Deng authored
To enable the extended shutdown feature, when a new video decoder is requested, old backend that uses video decoder must be revoked so the video decoder is available for the current active application. Bug: b/69180616 Test: 1. Successive flings (different URLs) can now success even with ENABLE_EXTENDED_SHUTDOWN feature flag enabled. 2. Cast youtube and GPM without issues. Change-Id: I49331b047168b7f73c0fc7eb592b077cad143b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1415301 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#659548}
-
Greg Kerr authored
Bug: 961005 Change-Id: Ifa23d9c6d9c58444af9ab8d8fe052e2923cd3781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611638 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#659547}
-
Dana Fried authored
Needed to take the reason for bubble closing into account - if focus passed to another window we shouldn't reset the focus. Bug: 962411 Change-Id: Ic88a1151706613287e3f1bcb2f3c8dff39feb9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610307Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#659546}
-
Abigail Klein authored
To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example. Get foreground opacity from mac settings and apply it to the text color of the WebVTT caption HTML element. Bug: 897730 Change-Id: If3d14db0a1eeabbc335d6a801f22d2a9e80e80dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611784 Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Patrick Noland authored
Bug: 961939 Change-Id: I9c9917db89662ae9f7a707b35173d07b79104e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606801Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#659544}
-
Justin Tervay authored
Bug: 962958 Change-Id: Id471869ddae0382ed54c96bf4ed0716cee2a069f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611902Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Justin Tervay <tervay@google.com> Cr-Commit-Position: refs/heads/master@{#659543}
-
Ryan Hansberry authored
Bug: 961053 Change-Id: Ic70034f021943c316f5f922b4c75d4cb7952ded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611084 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659542}
-
Alex Ilin authored
This CL disabled the test only on Android K where it's flaky. TBR: mvanouwerkerk@chromium.org Bug: 962974 Change-Id: I6c4c4ce318dc2d1a31d9caf3e39048e0bc20a10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611978Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659541}
-
Ehsan Karamad authored
With MimeHandlerViewInCrossProcessFrame, input should be directly routed to the GuestWebContents; it does not do the round trip to embedder's renderer any more since it does not rely on BrowserPlugin. Bug: 961786 Change-Id: Ib9a326fb61a42b359bc9d3fb97bee84fcbcbd330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610027 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#659540}
-
Ehsan Karamad authored
Currently, any MimeHandlerViewGuest created by MimeHandlerViewEmbedder is considered to be a full page plugin. This is not true when the MHVG was created due to appending an <embed> or <object> with a relevant MimeHandlerView MIME type. This CL fixes the issue which would then make the tests PDFExtensionTest.TabTitle* all pass with MimeHandlerViewInCrossProcessFrame. Bug: 961786 Change-Id: Ib6500082fbff39c6fa58a278852a53b839fc7014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610753Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659539}
-
Emil A Eklund authored
NGBoxFragmentPainter::HitTestTextFragment calculates the border rect for the TextFragment, relying on BorderEdges which is undefined for all text fragments. This is both incorrect and unnecessary as NodeAtPoint handles clipping for rounded borders/edges by calling HitTestClippedOutByBorder. Remove the unnecessary logic and move the BorderEdges and other specific methods relying on box-only data to the NGPhysicalBoxFragments subclass. Bug: 961977 Change-Id: I950876872b32efc882939085684cddfd63d50652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610652Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#659538}
-
Yann Dago authored
Bug: 961303 Change-Id: I1b73df97c0290a71f9f28f45068aead17ae3964c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603487 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#659537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69d66c506c56..491b47da442e Created with: gclient setdep -r src-internal@491b47da442e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I648e0d3edaba9208dd7f10f6316a45b5abb3a899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659536}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: None Change-Id: I0545b944e0569fc2f82f587f71247fcb405a1b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611888 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#659535}
-
Alex Ilin authored
Tbr: bsazonov@chromium.org Bug: 962976 Change-Id: I4646e89f55eb88ef3a2e0a48a87227bbb228eade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611895Reviewed-by:
-
Shivani Sharma authored
This CL does not change any functionality. In preparation for cache key to be computed in a higher layer and passed to the URLRequest, this CL does the following refactoring: 1. Adds a member for cache key in URLRequest and HttpRequestInfo. This is currently not getting filled anywhere. 2. The function to compute the cache key is refactored out to HttpUtils so that it can be invoked in a URLRequest's creation layer. Bug: 910708 Change-Id: I935f4f7f8b8d9822cb47681683b56bbb8b220ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605221 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659533}
-
Tatiana Buldina authored
Bug: chromedriver:546 Change-Id: Ica57610c6a178549d2f9a504d70b2a6ffd2c1275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610081Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#659532}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: Ia1746a73a38d8e53e08a307a9f6134136e102d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611890Reviewed-by:
-
Dave Tapuska authored
Inspector uses a V8 interrupt and a nested event loop to pause workers. Extract this functionality out of the worker thread debugger and add it to the worker thread itself. Call these pause/resume functions for dedicated workers when a frame freeze's itself as well. Test this new functionality in unit tests. BUG=907125 Change-Id: I9cd2c27803ecf30ad8e6ac780b05a055234e3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582265 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#659530}
-
Morten Stenshorne authored
Due to the complicated behavior of ::first-letter elements, where the placement of the ::first-letter DOM node in the DOM tree doesn't correspond with where we place the LayoutObject in the layout tree, it's tricky to figure out whether it's part of a subtree that requires us to force legacy layout or not. So just skip checking. The ::first-letter element itself can never force legacy layout on its own, so we'll just do whatever the parent layout object does. Solution developed together with futhark@chromium.org Bug: 962090 Change-Id: Ie112561bbd58c0c6f822f500247dbbaa1c8a8118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611602 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659529}
-
Liquan(Max) Gu authored
Currently, FCP++ has no way to communicate to Telemetry when a candidate is reset. Because of this issue, we write this CL to inform Telemetry of the resetting. We use a new trace event to represent that the candidate is nullified. The trace event for image and text, respectively, are named "LargestImagePaint::NoCandidate" and "LargestTextPaint::NoCandidate". This CL also mixes in with changes to refactor TextPaintTimingDetector. It mainly includes: * Refactor the PerformanceTiming updating logic * Refactor text-paint-timing candidate updating logic * Remove the candidate stored in TextPaintTimingDetector, because PaintTimingDetector already has this information. Bug: 960365 Change-Id: I4d94af0d098af7491ff2294bd57ed9aa2099ebb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610566 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#659528}
-
Xiaocheng Hu authored
The DCHECKs were added to verify correctness in visual left/right caret movements. Now that the visual movements are removed, the DCHECKs are stale, and hitting them doesn't mean any harm. So this patch removes the DCHECKs. Bug: 959500 Change-Id: I3bf975ef89b53f700c3957b64fa898df03d7cf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611138 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Kristi Park authored
Add the base DOM for the shortcuts menu panel. This does not include styling for option selection. LTR: https://screenshot.googleplex.com/hHK2yjYZDH3.png RTL: https://screenshot.googleplex.com/X0EhZycowWq.png Bug: 953822 Change-Id: Iabe9627b96ada3520b2732ac83cedc0b42696d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610485 Auto-Submit: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659526}
-
Henrique Nakashima authored
u1.reset(u2.release()) is almost equivalent to u1 = std::move(u2), but worse in that it has undefined behavior with custom deleters. Change-Id: Ife7d9582442ba021243c9df5911284a6bde3375e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579766Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#659525}
-
Kurt Horimoto authored
- Adds OverlayPresenter::Observer::RequestCancelledByQueue(). OverlayPresenterImpl uses this callback to cancel overlay UI for requests cancelled by the queue. - Adds OverlayRequestQueueImpl::RequestCanceller, which uses WebStateObserver callbacks to cancel requests in a queue for navigation events. Bug: 941745 Change-Id: Ia5f78e22fe4a0397aa1530bf41cb0fb1b434e398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598287 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659524}
-
Elly Fong-Jones authored
This also deletes the backing feature. Bug: None Change-Id: Ibf9ef57e04ade6716188b3f82ca9cda0d95d4374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610710 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659523}
-
Alex Oldemeier authored
This adds additional defensive checks for whether PluginVm is allowed to run for the current profile. Without these checks in rare cases where a launcher icon is still visible although PluginVm has been disabled the setup dialogue would have shown unintended behaviour. Bug: 950909 Test: browser_tests --gtest_filter="PluginVm*" && unit_tests --gtest_filter="PluginVm*" Change-Id: I63bf9a9ef4a6c5669c30f34c643c4145608f400b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583732 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#659522}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f8c0cf3. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I80e3bf01044c287d6aee78aecb3e58a50781184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611285Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659521}
-
Jeffrey Cohen authored
Adding send_tab_to_self::kSendTabToSelfHistory which will gate near-term-experimental work for enabling a user flow to revisit shared tabs. Bug: 961913 Change-Id: I5365816dfc1c2fe6f05931c30386052f63e4ce61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610219 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#659520}
-
Takuto Ikuta authored
export header is used only for constants. This CL reduced total include for ip_address_space.mojom-blink-forward.h from 0.010MB to 0.001MB. Bug: 862064 Change-Id: I1afcc5a7a6dc75e8ff7b9e83dfcf8b5355f90477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611057 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#659519}
-
Charlene Yan authored
http://crrev.com/c/chromium/src/+/1553595 added a TabstripRegionView as a container to hold the Tabstrip. The TabStrip offset should include the offset of the TabStripRegionView relative to its parent. Bug: 959201 Change-Id: I34086fdeda218d2c853b8ec39f320ad8b93cc984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610527 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#659518}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I8baa2025d8d0cd7ad8b7d5aefe83763055d1e8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#659517}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9cbdd437..4a82ea5d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f6fdd5cfed2705d8f544ef014fd82ecd9c225eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611504Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659516}
-
Michael Lippautz authored
This is not correct wrt in construction state as it does not use the MakeGarbageCollected bottleneck and properly mark an object as constructed. Remove as it is just used in testing code and does not fit GC patterns. Bug: 945806 Change-Id: Ib83c3024ca456c3b3cd0ebb8cbdba86ea7cc767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611822 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659515}
-
Matt Menke authored
It was using UnescapeURLComponent(), which, unlike UnescapeBinaryURLComponentSafe(), leaves certain characters escaped. The options passed in left spaces, path separators, control codes, "special characters", and UTF-8 sequences unsafe to display in the omnibox escaped. Since the string passed in is created by EscapeQueryParamValue(), however, none of that should be needed. UnescapeBinaryURLComponentSafe() escapes all input characters, but fails on path separators and control codes. Unclear if the failing behavior matters here, but since the previous code left path separators escaped, seems the safest option. This CL is part of a project to clean up uses of UnescapeURLComponent(), as it's been used for wildly disparate purposes, and much of its logic is only suitable for cases where we want to format a URL for safe display to the user. We want to make it leave more weird characters escaped, but need to eliminate usage of it in other contexts before we can do that. UnescapeBinaryURLComponent() should be used instead in most cases, particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use, as all consumers of that option seem to either be slightly buggy, or don't actually need to leave any characters unescaped. The primary cases where switching to UnescapeBinaryURLComponent() may cause problems (without additional checks), are cases where unescaping path separators or funky characters (like %01) is a problem. In those places, we should generally fail instead of partially unescaping a URL. Bug: 849998 Change-Id: I498e0471a95f183c18c34eec5e3732804dbc225a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600085Reviewed-by:
-
