- 13 Jun, 2018 40 commits
-
-
Jialiu Lin authored
1. Change IDS_SAFE_BROWSING_SCOUT_REPORTING_TITLE and IDS_SAFE_BROWSING_SCOUT_REPORTING_SUMMARY in android_chrome_strings.grd to match unified consent strings 2. Update IDS_FEEDBACK_SERVICE_DIALOG_EXPLANATION_SCOUT to match unified consent string, and move it from google_chrome_strings.grd and chromium_trings.grd to generated_resources.grd. 3. set localized "safeBrowsingEnableExtendedReporting" and "safeBrowsingEnableExtendedReportingDesc" to unified consent strings unconditionally. Bug: 837857 Change-Id: If659d187c5fd3a4a587c090997b2db8db9127e57 Reviewed-on: https://chromium-review.googlesource.com/1097556 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#566683}
-
Bret Sepulveda authored
Some tests would create an instance of OmniboxViewViews, but without a location bar. Refresh tries to access the location bar to set the placeholder text, and this would crash. This patch moves that code into Init and guards it by checking that location_bar_view_ is defined. Bug: 846410 Change-Id: I0a1aec21f515dcc441e52c92c0c1adc58163348f Reviewed-on: https://chromium-review.googlesource.com/1098141Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#566682}
-
Yuki Awano authored
- When window is maximized, Android content is rendered without considering caption bar. We need to adjust accessibility node bounds to consider it. window in maximized state. Confirm that accessibility focus rect is shown in the right place. Bug: 850427 Test: Enable chrome caption bar and spoken feedback. Open any Android Change-Id: I82a6020135623d73f0f5905ef49ce44328470108 Reviewed-on: https://chromium-review.googlesource.com/1090598Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#566681}
-
Josh Pratt authored
At the startup of the CrostiniRegisteryService (at login), this records the number of Crostini apps in the registry. The histogram uses UMA_HISTOGRAM_COUNTS_1000. Bug: 703927 Change-Id: I12ddd7bebc0b735ce76ad3a1b23a63eab0886103 Reviewed-on: https://chromium-review.googlesource.com/1080429 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#566680}
-
Darren Shen authored
Whenever KeyboardController is created/destroyed, observers need to be re-registered. KeyboardObserverRegister was introduced to simplify this process. However, with the new KeyboardController lifetimes, we only create/destroy the KeyboardController once, so we don't need to use KeyboardObserverRegisters anymore; we just need to register once at the beginning and unregister once at the end. We don't need to check whether KeyboardController is enabled when adding an observer, as none of the observer events are raised when the KeyboardController is disabled. Bug: 845780 Change-Id: I2bba7919ad7330649209fe3b6f44f74d26b650e3 Reviewed-on: https://chromium-review.googlesource.com/1075841 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#566679}
-
Ken Rockot authored
Enables the onAuthRequired WebRequest event to fire (and potentially block) as expected when the Network Service is enabled. Bug: 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia8d13bf8465438dee780de36f6b34bcdc681f1a7 Reviewed-on: https://chromium-review.googlesource.com/1081659 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#566678}
-
Charlie Reis authored
Filesystem and blob URLs don't have a chrome-extension:// scheme according to GURL, but do according to url::Origin. BUG=851503, 840857 Change-Id: Ia5e4cf5f9c3d04dff07d4f31da6d774d574af653 Reviewed-on: https://chromium-review.googlesource.com/1093402 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566677}
-
Scott Chen authored
Bug: 828333 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If101939b46697c7da6e9c0a0fc4f7219c83f11c1 Reviewed-on: https://chromium-review.googlesource.com/1095641 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#566676}
-
Parastoo Geranmayeh authored
Multiple address fields may belong to multiple sections on a form, and may not mean different address lines, and thus may not need rationalization. Also, multiple address fields may be hidden/visible pairs, and not different lines. While rationalizing address fields, one should consider the sections identified by the heuristics (DetermineHeuristicTypes). These sections are based on the types predicted by heuristics. This way we are merging the two sources of type predictions. Examples are included in the tests. Bug: 835975 Change-Id: I9f3680e69162b6b7d01203bd89773a99e5ca8af7 Reviewed-on: https://chromium-review.googlesource.com/1093796 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566675}
-
Xing Liu authored
When download location change feature is disabled, we always use default location, in case the feature is enabled and disabled that the user may stuck at SD card location when the feauture is turned off. Bug: 848136 Change-Id: If4a444a8f9c89734a45aee43c8eb98fec5862d18 Reviewed-on: https://chromium-review.googlesource.com/1095860 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566674}
-
Xing Liu authored
Currently we check externally removed flag to block opening file. This logic is not mostly used. 1. On primary storage, we delete the db record when the file is externally removed. 2. On SD card storage, this logic will block user to open the file when reinserting the SD card. So we should delete this logic and always try to open the file Bug: 850307 Change-Id: Ibbd2c3e7c8bf0b2f69263a406cfa5b4240bf0097 Reviewed-on: https://chromium-review.googlesource.com/1096660Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e4d09ae7af1..47fd204aa6c0 git log 8e4d09ae7af1..47fd204aa6c0 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 benjaminwagner@google.com Remove remaining references to G930A. Created with: gclient setdep -r src/third_party/skia@47fd204aa6c0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I55bc27521d2833cf87c4e2536eb68f95becd36be Reviewed-on: https://chromium-review.googlesource.com/1097878Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566672}
-
Antoine Labour authored
After https://crrev.com/c/1089695, while using ProduceTextureDirect, it is not possible any more for a client to: 1- reassign an existing mailbox to another texture 2- unlink a mailbox from a texture TakeFrontBuffer can technically still do (1), but ReturnFrontBuffer is a good place to unlink the mailbox service-side. This allows some simplification of the MailboxManager implementations, as well as the decoders. Bug: 847674 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I422b7ba8bcb762d1a5aea63f59dc833002f3d6b3 Reviewed-on: https://chromium-review.googlesource.com/1097696 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#566671}
-
Sunny Sachanandani authored
A number of fixes to make underlays work with non root render passes: 1) Transform clip rect to display space so that it works correctly for transformed non-root render passes. 2) Use the RPDQ clip for solid color quad behind the RPDQ. 3) Clip the punch through rect using the video quad's clip rect, and propagate the clipped value up the stack. 4) Do not propagate video quad or RPDQ opacities as that doesn't work correctly. 5) Do not overwrite underlay rect or occlusion if there are multiple underlays in a frame. 6) Lots of comments! Bug: 843814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib62bd3834e7e7856c02d9f304b2b4e4f594fd9cd Reviewed-on: https://chromium-review.googlesource.com/1087774 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566670}
-
dpapad authored
Polymer 2 automatically converts <template is="dom-if"> to <dom-if><template>, so the query selector needs to be updated. Also the way to get cached <template> contents is slightly different. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5625295e4138fa92a6a4b728123a7f58e3e06c0e Reviewed-on: https://chromium-review.googlesource.com/1096476Reviewed-by:
-
Bence Béky authored
Since there can be at most one ping in flight, change member type from integral to Boolean, and change name from plural to singular. This is a follow-up to https://crrev.com/c/1093561. Change-Id: Ie7b6b7a1236ee69d8cab32c0c543f61fba1a1cad Reviewed-on: https://chromium-review.googlesource.com/1097212Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566668}
-
Bence Béky authored
Change return value callback method from CompletionCallback to CompletionOnceCallback in all TestCompletionCallbackBase derived classes except for TestCompletionCallback, and use BindOnce instead of Bind. Remove CompletionCallback private members and bind at method call time instead of construction time. Bug: 807724 Change-Id: I2931d7a0ff5086a8733b8a27a7940d90f95ae683 Reviewed-on: https://chromium-review.googlesource.com/1097200Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566667}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If4aab3855e1147358506acb85a5ec5458fd9e349 Reviewed-on: https://chromium-review.googlesource.com/1098388Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#566666}
-
Adrienne Walker authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic1c231d599204a8592667793c4d016052c7ea031 Reviewed-on: https://chromium-review.googlesource.com/1097811Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566665}
-
Orin Jaworski authored
The drop cursor at a particular text location implies dropped text will be inserted there, and that remains true when dragging selected text from within omnibox itself (existing edit behavior remains intact). But when dragging text from elsewhere (no omnibox text selected), the new behavior will outline omnibox text indicating that the drop will replace current text. Drop cursor logic remains the same, only the meaning of the drop is indicated with a more intuitive render effect. Bug: 329319 Change-Id: I8aa76a497f857c0c418b9bdd7a350a597169165c Reviewed-on: https://chromium-review.googlesource.com/1091297 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#566664}
-
Joel Hockey authored
Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba58be17fcb5b5150677c535f5affd43d3b452c9 Reviewed-on: https://chromium-review.googlesource.com/1096932Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566663}
-
Scott Chen authored
Now that settings/ doesn't use any paper-input, this CL removes any mention of it, including unused styles and closure compile. Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c1db7537958276851cd097fae3a558cd51230a2 Reviewed-on: https://chromium-review.googlesource.com/1098144Reviewed-by:
-
Muyuan Li authored
Bug: b/78943493 Test: Manual Change-Id: I571c310f4ff49902a52c10e978ea13add1ebe74d Reviewed-on: https://chromium-review.googlesource.com/1098032Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#566661}
-
Junbo Ke authored
Bug: internal b/77732025 Test: None Change-Id: Ie2ff3535c3e560bf667f10d25b16922beaeba0f9 Reviewed-on: https://chromium-review.googlesource.com/1072871Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566660}
-
Matt Falkenhagen authored
- Remove some unused values. - Document the rest. Bug: 762357 Change-Id: Id32abd4474b58c9577c12757944fb879319673c8 Reviewed-on: https://chromium-review.googlesource.com/1096514 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566659}
-
Scott Violet authored
Specifically ScheduleEmbed(), ScheduleEmbedForExistingClient() and EmbedUsingToken(). BUG=837702 TEST=covered by test TBR=tsepez@chromium.org Change-Id: I5a7922ec0c14cf3f0c3b6632794eb2a6f6a9963a Reviewed-on: https://chromium-review.googlesource.com/1096662Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
David Black authored
This involved: - Adding icons for keyboard and voice input states. - Modifying DialogPlate view hierarchy (see details in bug). - Removing spacing between child views in AssistantMainView. - Modifying suggestion chip alignment within container. As a result of the new spec, much of the complexity in ActionView is no longer needed as it no longer needs to account for a keyboard input modality state. That will be cleaned up in a follow up CL. See bug for additional details/demos. Bug: b:110061195 Change-Id: I087014029c0c590d3965cd1d4bb47b0332c30cc5 Reviewed-on: https://chromium-review.googlesource.com/1096661 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566657}
-
Ryan Daum authored
Add method to the CastContentWindow::Delegate to receive notification when a swipe from the left is released before resulting in a completed back. Bug: internal b/109888887 Test: manual Change-Id: I73a451efa0c02d1f0f0d4b0e7d92268c061ea483 Reviewed-on: https://chromium-review.googlesource.com/1098075Reviewed-by:
-
Hirokazu Honda authored
A VDA client should not ReusePictureBuffer() on a dismissed picture buffer. VDA doesn't have to handle this case. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia3bc2534684b5448c01fdc86d7efc7db4389c21c Reviewed-on: https://chromium-review.googlesource.com/1063890Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#566655}
-
Christopher Lam authored
This CL fixes an issue where closure compilations may not rebuild if only their externs files change. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie18c5e658742e4025658d082477a9ab87291e065 Reviewed-on: https://chromium-review.googlesource.com/1096809Reviewed-by:
-
Eric Karl authored
TestInProcessContextProvider was not calling context is lockable. This change updates TestInProcessContextProvider to optionally support locking, and set up the ContextCacheController if locking is requested. ContextCacheController: :SetLock, which is required in cases where the Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I54d1de3768bf958dea944101565fefb99ff2602e Reviewed-on: https://chromium-review.googlesource.com/1097945Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#566653}
-
Xi Cheng authored
Bug: 851163 Change-Id: I2537e17a74492375c78ab210dfbdb56652040eb7 Reviewed-on: https://chromium-review.googlesource.com/1098034 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566652}
-
Robert Sesek authored
Rather than directly linking Content Shell and Content Shell Helper agasint the Content Shell Framework, to be loaded by dyld, this change has the executables dlopen the framework at runtime. This is done to match how Chrome is loaded, which is a prequisite for using the V2 sandbox in Content Shell. No-Presubmit: True Bug: 850735 Test: Build content_shell and //content test suites. Both launch and pass. Change-Id: Id843d99877166fbf91d0df55d9976f6019149da8 Reviewed-on: https://chromium-review.googlesource.com/1093569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#566651}
-
Scott Violet authored
It's never used. BUG=none TEST=none Change-Id: If4677c56c51f33fe58eb97a4f03a72c087af8297 Reviewed-on: https://chromium-review.googlesource.com/1097949Reviewed-by:
-
Bret Sepulveda authored
The suite needed to be a subclass of ChromeViewsTestBase to access the correct LayoutProvider. Bug: 846410 Change-Id: I51952fd6451b4efcfe26de14ffe73480f1892705 Reviewed-on: https://chromium-review.googlesource.com/1098218 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566649}
-
Sasha Morrissey authored
Also added integration tests, and moved existing delete tests to be in one file specific to testing context menu items (context_menu.js). Test: browser_test --gtest-filter="ContextMenu/FilesApp*" Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c8d2e71697ecdc273f8d41d9b919b5be12b1519 Reviewed-on: https://chromium-review.googlesource.com/1068769Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#566648}
-
Jao-ke Chin-Lee authored
BUG=731417,731456 Change-Id: I9fbb2c34f149380a9b98dfc1bfc7ad56041f6fd6 Reviewed-on: https://chromium-review.googlesource.com/1098307Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#566647}
-
Jiaquan He authored
Bug: 733662 Change-Id: Id2697199199a67c022d4661e1142c9a237ed8f25 Reviewed-on: https://chromium-review.googlesource.com/1096684Reviewed-by:
-
Yuanyao Zhong authored
Bug: b/74442987 Test: build cast_shell Change-Id: Id8b10f928176682ac940dffdaadbbe2853e41cca Reviewed-on: https://chromium-review.googlesource.com/1096354Reviewed-by:
-
Dirk Pranke authored
In order to simplify how we configure tests, it would be good if every test target was invoked the same way on every platform. Today, on Android, CrOS, and Fuchsia, we generate wrapper scripts for every test target and put them in $root_build_dir/bin; these scripts are responsible for setting up the environment (devices, VMs, etc.) and invoking the test directly. This CL continues this pattern and generates wrappers that will work on Linux, Mac, and Win following the same pattern (on Windows, the wrappers will be bin/run_base_unittests.bat instead of bin/run_base_unittests). As a proof of concept, this CL switches url_unittests to run via the wrapper. Assuming this change lands and sticks, in follow-up changes we'll convert the others as well. This design should also help us eventually get rid of gn_isolate_map.pyl; in order to do that, we will also need to not translate between ninja target names and GN labels, but that will require changes to GN. Bug: 816629 Change-Id: I66f8ca78472564ee46cc8d3d012591a275566d1f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/736162 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#566644}
-
