GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9d21429..27e517a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1147463002

Cr-Commit-Position: refs/heads/master@{#330027}

Crash on the compositor thread is too late to debug effectively,
so cause crashes earlier.

BUG=485324
TEST=none
TBR=xhwang

Review URL: https://codereview.chromium.org/1145553002

Cr-Commit-Position: refs/heads/master@{#330026}

The cast mode popover has been removed and the cast mode list now appears in lieu of the sink picker when toggled by the arrow button. Since there is no immediate cast action that someone can take while viewing cast modes (unlike the sink picker or route details), any issues that arise will not appear while they are still in the cast mode list. Once they toggle back to the sink picker or select a cast mode, will the UI show any issue that has been set.

Other changes:
- Removes transparent overlay.
- Removes cast-mode-picker custom polymer element.
- Replaces cast-mode-picker content with core-menu and paper-items.
- Shows (new) localized "Select cast mode" string when showing the cast mode list.
- Update comments.

Review URL: https://codereview.chromium.org/1140823003

Cr-Commit-Position: refs/heads/master@{#330025}

This is a reland of https://codereview.chromium.org/1132013004/

Polling is now an important component of sync health, as it can sometimes be
the only time we'll query for certain datatypes. As such, the following
has changed:
- Polls that fail will be retried (with backoff).
- As such, the logic to force a poll after an auth error isn't needed anymore
- The last successful poll time will be persisted in the sync prefs.
- On startup, schedule the first poll for last_poll_time + poll_interval
  (or Now(), whichever is latest).
- Receiving a new poll interval from the server will update the poll timer
- The poll timer is now a one shot timer, and only restarts on success
- Some code cleanup to make the above more straightforward

BUG=482154

Review URL: https://codereview.chromium.org/1144543004

Cr-Commit-Position: refs/heads/master@{#330024}

Android TypeFace object doesn't provide chrome too much information on font family.
And the font family is needed for blink to override the subtitle css.
This change adds all the font families that are used by the CaptioningManager.

BUG=457850

Review URL: https://codereview.chromium.org/1135583003

Cr-Commit-Position: refs/heads/master@{#330023}

Show any connection errors during startup in the LoadingWindow rather
than creating a new error window for the error.

This cl also adds a new updateErrorMessage method to the MessageWindow
to update the message and reset the message window as appropriate for
an error message (disabling the spinner, updating the button label).

BUG=

Review URL: https://codereview.chromium.org/1139543002

Cr-Commit-Position: refs/heads/master@{#330022}

Compile the Data Reduction Proxy into Cronet only if the gyp
variable enable_data_reduction_proxy_support is set to 1.
By default, it is set to 0.

BUG=461910

Review URL: https://codereview.chromium.org/1112513003

Cr-Commit-Position: refs/heads/master@{#330021}

That way other targets that depend on it don't have to specify ":application".

Review URL: https://codereview.chromium.org/1136763003

Cr-Commit-Position: refs/heads/master@{#330020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dc02170..49b6b99

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1142573002

Cr-Commit-Position: refs/heads/master@{#330019}

Revert of Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (patchset #6 id:160001 of https://codereview.chromium.org/1131753003/)

Reason for revert:
Broke Linux GN clobber:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/258/steps/compile/logs/stdio

Original issue's description:
> Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid.
>
> This completes the path from the secure surface preference, through requestMediaKeySystemAccess() and finally to CDM creation on Android where secure codecs are enabled. With this change, configs requiring secure codes are rejected without the preference and the CDM is only configures to use hardware-secure codecs if the config requires it.
>
> There is a separate bug (http://crbug.com/478185) for implementing similar plumbing for the use of secure surfaces.
>
> BUG=467779
>
> Committed: https://crrev.com/9ce0a551c7f1d79dea793b5691473ef9d5fb9326
> Cr-Commit-Position: refs/heads/master@{#330008}

TBR=ddorwin@chromium.org,jrummell@chromium.org,gunsch@chromium.org,nasko@chromium.org,gunsch@google.com,sandersd@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467779

Review URL: https://codereview.chromium.org/1132773003

Cr-Commit-Position: refs/heads/master@{#330018}

VideoFrame can carry YUV native textures.
After crrev.com/1127423006 VideoResoucesUpdater will create the
appropriate VideoFrameExternalResources.
This change makes VideoLayerImpl deal with a VideoFrame with a
NATIVE_TEXTURE format and a TEXTURE_YUV_420 texture format.

BUG=485859

Review URL: https://codereview.chromium.org/1125303005

Cr-Commit-Position: refs/heads/master@{#330017}

TEST=manual

Review URL: https://codereview.chromium.org/1144433003

Cr-Commit-Position: refs/heads/master@{#330016}

Rather than having to manually define each function in Window.Callback
and forward it along, instead use reflection to automatically forward
all calls that aren't interesting.

BUG=487378

Review URL: https://codereview.chromium.org/1139913005

Cr-Commit-Position: refs/heads/master@{#330015}

QueryResultManager allows the Media Router dialog to query for sets of media sinks compatible with specific media sources.  Each media source is in a correspondence to a cast mode (a specific action/button the user can take to
initiate casting).

NOTE: The mock_media_router.{h,cc} files will be put later into a proper test_support target for the media_router.

BUG=464216

Review URL: https://codereview.chromium.org/1131913003

Cr-Commit-Position: refs/heads/master@{#330014}

Disable flaky tests on Mac: PlatformChannelPairPosixTest.SendReceiveFDs and PipeCount/MultiprocessMessagePipeTestWithPipeCount.PlatformHandlePassing/2

TBR=viettrungluu@chromium.org
BUG=488260,488258

Review URL: https://codereview.chromium.org/1126293008

Cr-Commit-Position: refs/heads/master@{#330013}

Before, the TransportConnectJob simply inferred that, if the main socket
failed to connect, the address it was using was the last address in the
list. With this change, the TCPClientSocket actually tracks all of the
connection attempts made (as it tries each address in the list), and the
TransportConnectJob copies the attempts from both the main and fallback
sockets and records all of them in the ClientSocketHandle in
GetAdditionalErrorState.

BUG=480565
TBR=jam

Review URL: https://codereview.chromium.org/1096203006

Cr-Commit-Position: refs/heads/master@{#330012}

HttpResponseInfo contains a "network_accessed" flag that is currently
set when HttpNetworkTransaction finishes sending the request. This is
not entirely accurate; it ends up false for requests that don't send a
request but do touch the network in other ways (e.g. DNS resolution
fails, or TCP connection is terminated before we finish sending the
request).

This flag is used only by Domain Reliability for checking whether a
request touched the network, and by ServiceWorker for histograms.
horo says ServiceWorker won't be affected, and I would prefer these
semantics for Domain Reliability's use, so I'm changing it.

Note that this also changes several instances of GetResponseInfo
to stop returning NULL.

See also for context:

https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/Wtn65jGyot0

BUG=480565

Review URL: https://codereview.chromium.org/1072423005

Cr-Commit-Position: refs/heads/master@{#330011}

Review URL: https://codereview.chromium.org/1135823008

Cr-Commit-Position: refs/heads/master@{#330010}

Revert of Media Router GYP/GN cleanup (patchset #14 id:260001 of https://codereview.chromium.org/1136623003/)

Reason for revert:
Broke Linux bots on Chromium waterfall, see

http://build.chromium.org/p/chromium/builders/Linux/builds/62091
http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=3231

The error in gclient runhooks is:

gyp: Key 'dependencies' repeated at level 3 with key path 'targets.3' while reading /b/build/slave/Linux_x64/build/src/chrome/browser/media/router/media_router.gyp

Not sure why this didn't show up on other bots or trybots.

Original issue's description:
> Media Router GYP/GN cleanup:
>
> - Refactor GYP and GN files to share source lists.
> - Extract a proper test_support target.
> - Fix upstream files with new target structure.
>
> BUG=461815,464199,464205
>
> Committed: https://crrev.com/9c5e5781517823c18144b0bb5b66b66a1afd6733
> Cr-Commit-Position: refs/heads/master@{#330002}

TBR=brettw@chromium.org,kmarshall@chromium.org,mfoltz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461815,464199,464205

Review URL: https://codereview.chromium.org/1140183002

Cr-Commit-Position: refs/heads/master@{#330009}

This completes the path from the secure surface preference, through requestMediaKeySystemAccess() and finally to CDM creation on Android where secure codecs are enabled. With this change, configs requiring secure codes are rejected without the preference and the CDM is only configures to use hardware-secure codecs if the config requires it.

There is a separate bug (http://crbug.com/478185) for implementing similar plumbing for the use of secure surfaces.

BUG=467779

Review URL: https://codereview.chromium.org/1131753003

Cr-Commit-Position: refs/heads/master@{#330008}

BUG=b/19776978

Review URL: https://codereview.chromium.org/1131853004

Cr-Commit-Position: refs/heads/master@{#330007}

Lo-Fi directives were added to the Chrome-Proxy response header.
Adding testing of these responses in the Lo-Fi integration test.

BUG=487879

Review URL: https://codereview.chromium.org/1131063005

Cr-Commit-Position: refs/heads/master@{#330006}

BUG=485649
TEST=PartialScreenShotTest.VisibilityTest
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/1128933009

Cr-Commit-Position: refs/heads/master@{#330005}

Bugs 237703 & 168933 have been closed, adjusting comment to reflect
that reality

TBR=mpearson@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1139773004

Cr-Commit-Position: refs/heads/master@{#330004}

Plus a few other small clang-format fixes.

BUG=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1131683003

Cr-Commit-Position: refs/heads/master@{#330003}

- Refactor GYP and GN files to share source lists.
- Extract a proper test_support target.
- Fix upstream files with new target structure.

BUG=461815,464199,464205

Review URL: https://codereview.chromium.org/1136623003

Cr-Commit-Position: refs/heads/master@{#330002}

This includes:
* Creating CmaRenderer and its dependencies (most of the renderer-side),
  stubbing out at the IPC level.
* Moving FakeDemuxerStream to media/base/ to allow use outside of //media

R=servolk@chromium.org,xhwang@chromium.org

Review URL: https://codereview.chromium.org/1137263002

Cr-Commit-Position: refs/heads/master@{#330001}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1130163005

Cr-Commit-Position: refs/heads/master@{#330000}

This works the same way as NativeAppWindowCocoa by inserting a colored
NSView into the window's contentView's superview.

This also adds a test that checks for correct frame colors when active and
inactive.

BUG=459877

Review URL: https://codereview.chromium.org/1053303003

Cr-Commit-Position: refs/heads/master@{#329999}

MessageLoopProxy is deprecated.
This basically does a search and replace of:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

MessageLoopProxy -> SingleThreadTaskRunner

BUG=391045

Review URL: https://codereview.chromium.org/1124153005

Cr-Commit-Position: refs/heads/master@{#329998}

Treat a delay of under 1 millisecond in MessagePumpDefault as a signal that the corresponding delayed task needs to execute

On Windows for e.g. the lowest resolution we can get on the system clock is 1 ms or 4 ms depending on whether the machine
is powered by AC or battery. The OS default is 15ms. So that effectively means that if a delayed task is waiting to execute
for a delay of under 1 ms would cause the underlying OS WaitForSingleObject call to return immediately effectively spinning
a tight loop with a kernel mode context switch.

Fix is to treat a delay of under 1 ms as a signal that the task is ready to execute for all platforms.

BUG=487724

Review URL: https://codereview.chromium.org/1137453006

Cr-Commit-Position: refs/heads/master@{#329997}

There are two ways of accessing IsReadyToDraw and NeedsRaster. One is
via tile->IsReadyToDraw(), the other is via
tile->draw_info().IsReadyToDraw(). The first one is actually does the
same thing as the second one. This patch removes the shortcut and
makes all uses of this functionality consistent.

R=enne

Review URL: https://codereview.chromium.org/1139673008

Cr-Commit-Position: refs/heads/master@{#329996}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/0e5c45a...e53550b.

BUG=484833

Review URL: https://codereview.chromium.org/1128743004

Cr-Commit-Position: refs/heads/master@{#329995}

Revert of vea_unittest: Calculate per-frame encode latency (patchset #16 id:300001 of https://codereview.chromium.org/1117853002/)

Reason for revert:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/X86%20%28chromium%29/builds/4667

chromium-os builders went red. Looks like there's a signed/unsigned comparison.

Original issue's description:
> vea_unittest: Calculate per-frame encode latency
>
> Calculates per-frame encode latency, which is basically the time delay from
> input of each VideoFrame (VEA::Encode()) to output of the corresponding
> BitstreamBuffer (VEA::Client::BitstreamBufferReady()).
>
> It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.
>
> Also fix a wrong comment.
>
> BUG=345181
> TEST=Check "Encode latency for the 50%/75%/95%" in output logs.
>
> Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86
> Cr-Commit-Position: refs/heads/master@{#329819}
>
> Committed: https://crrev.com/738487a69f150975376c36e214c64a77b1ff0cc6
> Cr-Commit-Position: refs/heads/master@{#329838}

TBR=owenlin@chromium.org,posciak@chromium.org,wuchengli@chromium.org,jchuang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=345181

Review URL: https://codereview.chromium.org/1145543002

Cr-Commit-Position: refs/heads/master@{#329994}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/e3ef0c4c8e...aa79b394e7

Picked up changes:
aa79b39 Strip bgcolor attribute from all table elements
ec27418 Show distilled page in Chrome Extension
1f211a4 Simplify testImageWithSrcset
b9e2b72 Update doc about Developing on Mac OS X
270058c Shuffle tests in continuous integration
f5070fd Properly restore test environment between tests
7a0544c Support running jstests repeatedly
fa4d011 Support running tests in random order
a03cbd2 Disregard "comment" appearing in className when too many classes
0650d41 Never regard HTML elements as comments
31359c2 Allow test.filter to begin with a dash
d4854eb Catch errors in continuous integration script
8a6e619 Skip tests using URL() in continuous integration
af015b9 Update document about filter syntax in jstest
b27ab2b Replace create_standalone_js.py with a custom GWT linker
10bc28c implement validations of pagination URLs
1ec32c2 Strip color attributes from font tags
772dbda Add script for landing CLs on behalf of external authors.
c0edaeb Find Python using 'env' in protoc plugin
9ae05a4 Fix regression in srcset handling

BUG=382993,436226,437113,464123,483036,483149,483172

Review URL: https://codereview.chromium.org/1130823004

Cr-Commit-Position: refs/heads/master@{#329993}

Do not run list these tests to run on Android for now.

BUG=486220
TBR=sky@chromium.org
TEST=mojo/tools/apptest_runner.py mojo/tools/data/apptests out/android_Debug passes.

Review URL: https://codereview.chromium.org/1122373003

Cr-Commit-Position: refs/heads/master@{#329992}

Three basic tests added:
1) DamageTriggersSwapBuffers
2) NoDamageDoesNotTriggerSwapBuffers
3) LockingResourcesDoesIndirectlyCauseDamage

The last test is a regression test to make sure we
don't accidentally damage the root surface every frame.
It fails with the following patch applied, which
got reverted:
https://codereview.chromium.org/1073323002

BUG=476544

Review URL: https://codereview.chromium.org/1124273004

Cr-Commit-Position: refs/heads/master@{#329991}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1141153002

Cr-Commit-Position: refs/heads/master@{#329990}

When Chrome's ETW tracing is enabled it can consume more than half
of the total CPU time in the process, which means it is distorting
the results it is trying to measure. It also puts a lot of data into
the trace which cannot be viewed.

The biggest consumer of CPU time, by far, is AppendAsTraceFormat, which
consumes over 95% of the CPU time in TraceEventETWExport::AddEvent. Because
all categories are enabled this ends up creating many large buffers. The
cc::LayerTreeHostImpl events have been seen up to 22,500 bytes and
cc::Picture payloads have been seen up to 3,200,000 bytes! Ironically
the WPA trace viewer can't view payloads larger than 4094 bytes so all we
see for this effort and overhead is "Unable to parse data".

Truncating the payloads would let us see the partial data but would still
leave the distortion of execution time. The long-term solution is to
specify what categories are enabled in order to manage the volume of data.
Until then the prudent thing to do is to disable calls to AppendAsTraceFormat.

In addition, there is no reason for phase_string to be a std::string. This
overhead is relatively minor but measurable. It's worth fixing because the
fix is clean and simple.

The net effect is to drop the CPU overhead from 33-50% down to 1-7%.

This change makes Chrome's ETW tracing much more usable.

R=primiano@chromium.org
BUG=488257

Review URL: https://codereview.chromium.org/1140843003

Cr-Commit-Position: refs/heads/master@{#329989}

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1125213007

Cr-Commit-Position: refs/heads/master@{#329988}