GitLab

The underlying cause described in r180096 wasn't correct; update the
FIXME comment to make it more accurate.

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/461373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8WindowShell is an implementation of "WindowProxy" in the spec
(http://www.w3.org/TR/2009/WD-html5-20090423/browsers.html#windowproxy).
We should rename it accordingly.

Review URL: https://codereview.chromium.org/451013003

git-svn-id: svn://svn.chromium.org/blink/trunk@180146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092
NOTRY=true

Review URL: https://codereview.chromium.org/464813002

git-svn-id: svn://svn.chromium.org/blink/trunk@180145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=316092
NOTRY=true

Review URL: https://codereview.chromium.org/461383002

git-svn-id: svn://svn.chromium.org/blink/trunk@180144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SPEC: http://dom.spec.whatwg.org/#dom-range-deletecontents

Unlike extractContents, deleteContents doesn't throw error.
So this CL modified implementation as per specified.

Behavior in other browsers.
*)FF: PASS
*)IE: PASS

In addition 4 failed cases will be passed with this CL in
http://w3c-test.org/dom/ranges/Range-deleteContents.html

TEST=LayoutTests/fast/dom/Range/deleteContents-doctype.html

Review URL: https://codereview.chromium.org/451403002

git-svn-id: svn://svn.chromium.org/blink/trunk@180143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The primary output is lextab.py, but since it is imported, Python also
writes lextab.pyc. Listing it too as an output means it won't be left
around by "ninja -t clean" (and not much else, I think.)

Prior to the patch
  https://codereview.chromium.org/425953002/
the result of not having lextab.pyc listed as an output and running
"ninja -t clean" was a tree that would build correctly, but that would
always rerun all the IDL code generation scripts, and thus never become
"clean".

BUG=397909

Review URL: https://codereview.chromium.org/463063003

git-svn-id: svn://svn.chromium.org/blink/trunk@180142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are tests for the Chromium patch r288994:
https://codereview.chromium.org/413063004

Our current shortcomings are:
- New-scope registration overrides the existing registration. This is an
existing bug: https://code.google.com/p/chromium/issues/detail?id=398355
- register() should wait before resolving if docs are using an unregistered
registration. This is a new spec requirement.
- We don't do "early-rejection" described by
https://github.com/slightlyoff/ServiceWorker/issues/396. Also a new spec
requirement.

BUG=388095

Review URL: https://codereview.chromium.org/416003003

git-svn-id: svn://svn.chromium.org/blink/trunk@180141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402766, 403121
NOTRY=true

Review URL: https://codereview.chromium.org/463413002

git-svn-id: svn://svn.chromium.org/blink/trunk@180140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If WorkerThread::stop is already called, WorkerThread::initialize should return immediately without starting the thread execution.

BUG=403179
TEST=none (it's timing-dependent)

Review URL: https://codereview.chromium.org/462423003

git-svn-id: svn://svn.chromium.org/blink/trunk@180139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function is only implemented by blink_web, but not called by
anyone, anywhere.

There are not callers of it on Blink nor on Chromium.

This fixes the TODO in WebView.h

BUG=None
TEST=None
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/469693003

git-svn-id: svn://svn.chromium.org/blink/trunk@180138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to reduce duplicated functions between V8Binding.h and
ScriptPromise.h, this CL adds arity error creation functions to V8Binding.h
and deletes arity error throwing functions from V8Binding.h and
ScriptPromise.h.

BUG=359411

Review URL: https://codereview.chromium.org/460923002

git-svn-id: svn://svn.chromium.org/blink/trunk@180137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL renames all of the repaint methods in core/rendering/svg to be
paintInvalidation.

BUG=338691

Review URL: https://codereview.chromium.org/463883003

git-svn-id: svn://svn.chromium.org/blink/trunk@180136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The directory was added recently and needs to be here so that
the right thing is uploaded to appengine.

TBR since this breaks pushing to appengine.

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/469633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of driving the blend mode computation from
updateDescendantDependentFlags, this CL drives the blend mode computation from
CompositingInputsUpdater. Using this approach lets us remove a bunch of
bookkeeping because CompositingInputsUpdater does all the bookkeeping for us.

Because CompositingInputsUpdater happens during the compositing update, we need
to add some code to the compositing update to run the CompositingInputsUpdater
even when compositing isn't available (e.g., SVGImage and InspectorOverlay).

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/466193002

git-svn-id: svn://svn.chromium.org/blink/trunk@180133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180119

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/465173002

git-svn-id: svn://svn.chromium.org/blink/trunk@180132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems this one is no longer needed, just
the one in HTMLCollection is used.

Review URL: https://codereview.chromium.org/461213002

git-svn-id: svn://svn.chromium.org/blink/trunk@180131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previous implementation had three CoreInitializer methods: initEventNames,
initEventTargetNames, and initBindings, which were never called, and
ModulesInitializer contained identically named methods which were a
superset of the base class implementation. This change removes duplication
and separates core and modules initialization for a cleaner implementation.

This change doesn't fix 393728, but is a necessary refactoring for the
actual fix.

BUG=393728

Review URL: https://codereview.chromium.org/464043002

git-svn-id: svn://svn.chromium.org/blink/trunk@180130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A recent CL to Promises changed when JavaScript is run when a promise
is resolved. In the past the JS ran immediately -- now it is run
using a microtask. For EME code, the "message" event is generated right
after creating the session. It relies on the JS running and binding
an event handler. With the recent CL, it is possible for the event to
be generated before the handler is bound, so the event is lost. This
change delays posting the "message" event if there are no event handlers
registered.

BUG=402766,403121
TEST=Disabled EME browser_test passes

Review URL: https://codereview.chromium.org/465053002

git-svn-id: svn://svn.chromium.org/blink/trunk@180128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems these are not used (anymore).

Review URL: https://codereview.chromium.org/463173003

git-svn-id: svn://svn.chromium.org/blink/trunk@180127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes unnecessary blink:: prefixes.
Also it merges *namespace blink{}* blocks.
Also correcting blink presubmit errors in the changed files.

BUG=

Review URL: https://codereview.chromium.org/467573002

git-svn-id: svn://svn.chromium.org/blink/trunk@180126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This converts the remaining ui test suites, besides the two that are currently failing (ct-failure-card, ct-failure-stream).

BUG=400387
R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/464163002

git-svn-id: svn://svn.chromium.org/blink/trunk@180125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, it was possible to read stale data from
hasSelfPaintingLayerDescendant. After this CL, we clean out the dirty bit
automatically when you read this state. In order to make this work, this CL
separates hasSelfPaintingLayerDescendant from updateDescendantDependentFlags.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/468633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid importing net.html in the top level and instead have the files that
use it importing it themselves.

NOTRY=true

Review URL: https://codereview.chromium.org/467013002

git-svn-id: svn://svn.chromium.org/blink/trunk@180123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A recent CL (Blink revision 179922) changed the way JavaScript is run
after resolving a promise (used to run immediately, now run by a
microtask later). encrypted-media-lifetime-mediakeysession-reference.html
started failing as it expected the PromiseResolver object to be around
and counted. Fixing the test as the PromiseResolver object is gone by the
time the JavaScript executes after resolving a promise.

BUG=374772,378245
TEST=failing test passes

Review URL: https://codereview.chromium.org/465833003

git-svn-id: svn://svn.chromium.org/blink/trunk@180121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't want to pass strings into the browser process for conversion
into URL objects; we should validate input when creating data from
JavaScript.

This patch adjusts {Local,Federated}Credential objects to throw exceptions
in their constructors if URL validation fails, and changes both Web*Credential
and Platform*Credential objects to accept WebURL/KURL objects rather
than strings.

BUG=400674

Review URL: https://codereview.chromium.org/464783003

git-svn-id: svn://svn.chromium.org/blink/trunk@180120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In some obscure code paths (e.g., printing, drawing drag images), we would
paint without calling updateLayoutAndStyleForPainting, which means we skip some
important steps in the DocumentLifecycle.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/457973003

git-svn-id: svn://svn.chromium.org/blink/trunk@180119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

described here: 
http://lists.w3.org/Archives/Public/public-css-testsuite/2014May/0000.html

Review URL: https://codereview.chromium.org/311673002

git-svn-id: svn://svn.chromium.org/blink/trunk@180118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I broke sheriff-o-matic by not updating the link to scripts/net.js when
I transitioned it to lib/net.html. Updating fixes the UI.

NOTRY=true

Review URL: https://codereview.chromium.org/465093002

git-svn-id: svn://svn.chromium.org/blink/trunk@180116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=180095

BUG=401954
TBR=adamk@chromium.org

Review URL: https://codereview.chromium.org/462263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The InspectorOverlay does a bunch of manual poking and prodding of the layout
state machine. Instead, InspectorOverlay should just use
updateLayoutAndStyleForPainting like the regular engine does.

R=esprehn@chromium.org, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/465033002

git-svn-id: svn://svn.chromium.org/blink/trunk@180114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code is dead. This CL also removes a bunch of other related dead code.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/465983003

git-svn-id: svn://svn.chromium.org/blink/trunk@180112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the "isolatesBlending" string from render tree dumps. When we
compute render tree dumps, this state is not always up-to-date, which means
we're getting stale information in the render tree dumps. We don't include
other descendant-dependent flags in render tree dumps for this reason.

This CL costs us some test coverage, but the appropriate way to regain that
test coverage to use reference tests to ensure that the pixels we draw are
correctly blended rather than hard-coding internal state from the engine into
test results.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/466943002

git-svn-id: svn://svn.chromium.org/blink/trunk@180111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To keep us abreast of all the changes going on in sheriff-o-matic
code and keep us from stepping on each others' toes, I'm adding
a watchlist and putting all the folks currently actively working
on it on the list.

NOTRY=true

Review URL: https://codereview.chromium.org/461233002

git-svn-id: svn://svn.chromium.org/blink/trunk@180110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec tells us that if an element has a title attribute, its value
should be returned as its tooltip/advisory information:

  http://www.whatwg.org/specs/web-apps/current-work/#the-title-attribute

Align with how other browsers behave for <foo title> and return the
empty string rather than consult the parent element.

R=
BUG=399255

Review URL: https://codereview.chromium.org/462073003

git-svn-id: svn://svn.chromium.org/blink/trunk@180109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We shouldn't ever ASSERT a condition and then handle its negation. If we can
get here with layout dirty, we should crash so we can fix those cases.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/466063002

git-svn-id: svn://svn.chromium.org/blink/trunk@180108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_dirtySourceRect is duplicating the paint invalidation logic
by storing the exact same information.

On top of that, FilterEffectRendererHelper::prepareFilterEffect
already gets the invalidation rect from |dirtyRect|.

This change is covered by css3/filters/filter-repaint-*.html
that were added with m_dirtySourceRect in
https://bugs.webkit.org/show_bug.cgi?id=80323.

Review URL: https://codereview.chromium.org/453033005

git-svn-id: svn://svn.chromium.org/blink/trunk@180107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup namespace usage in Source/core/modules/[battery/* to indexeddb/*]

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary  blink:: prefixes
- Make blank lines consistent

BUG=None

Review URL: https://codereview.chromium.org/466813003

git-svn-id: svn://svn.chromium.org/blink/trunk@180106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup namespace usage in Source/core/modules/[mediasource/* to websockets/*]

- Merge multiple |namespace blink {}| blocks
- Remove unnecessary  blink:: prefixes
- Make blank lines consistent

BUG=None

Review URL: https://codereview.chromium.org/461163002

git-svn-id: svn://svn.chromium.org/blink/trunk@180105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bug fixed on the Chromium side, just adding a layout test as well
for full coverage.

BUG=395472
R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/462153002

git-svn-id: svn://svn.chromium.org/blink/trunk@180103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Let RenderObject::canUpdateSelectionOnRootLineBoxes() return false
if the renderer is in an orphaned render tree, to prevent
RenderSelectionInfo from calling selectionRectForPaintInvalidation()
which would cause the crash.

BUG=396596
TEST=editing/selection/move-node-in-selection-crash.html

Review URL: https://codereview.chromium.org/452293004

git-svn-id: svn://svn.chromium.org/blink/trunk@180102 bbb929c8-8fbe-4397-9dbb-9b2b20218538