GitLab

Case 1: When a image is loaded as a subresource, loading is stared by
ImageResource::fetch() in ImageLoader::doUpdateFromElement().
Case 2: When a image is loaded as a main document, the start of the loading is
emulated by setImage() in ImageLoader::updateFromElement() and
ImageDocumentParser will do the subsequent loading steps.

However in Case 2, |m_hasPendingLoadEvent| is set to false
(in setImageWithoutConsideringPendingLoadEvent()), causing |imageStillLoading|
to be false and ensureFallbackContent() to be called in
HTMLImageElement::selectSourceURL(), and thus a box indicating a broken image
is displayed during loading instead of the image displayed progressively.
This is regression since https://codereview.chromium.org/1879793003.

This CL makes the behavior of Case 1 and 2 consistent, by moving what is done
in Case 1 to setImagePending(), and makes Case 1 and 2 both to call
setImagePending().

This CL also adds a layout test to confirm that an image is displayed
progressively when loaded as a main document.

BUG=632495

Review-Url: https://codereview.chromium.org/2208073004
Cr-Commit-Position: refs/heads/master@{#414008}

As requested by kinuko-san in https://codereview.chromium.org/2124693002/

BUG=

Review-Url: https://codereview.chromium.org/2267373004
Cr-Commit-Position: refs/heads/master@{#414007}

When parsing <position>, consumePosition() always attempted to consume
four values, even when it was not possible for the next value to
legally appear in the current <position>.

For example, if the first value is a <percentage> or <length>, the
second value (if present) may only be
  top | center | bottom | <percentage> | <length>
and no third or fourth values are possible.

If the second value is center, no third or fourth values are possible.

left | right  may never be followed by  left | right.

BUG=638055

Review-Url: https://codereview.chromium.org/2256593002
Cr-Commit-Position: refs/heads/master@{#414006}

This CL makes Resource's SharedBuffer always locked and never unlocked by
removing SharedBuffer::unlock(), and
propagates the change by removing the following:
- Resource::lock(), unlock() (does nothing and returns always true)
- Resource::isPurgeable() (always false)
- Resource::isSafeToUnlock() (no longer called)
- SharedBuffer::lock(), unlock(), isLocked() (always true)
- PurgeableVector::lock(), unlock(), isLocked() (always true)
- Unit tests related to SharedBuffer/PurgeableVector::lock()/unlock() from
  PurgeableVectorTest and ResourceTest.

After this CL, the SharedBuffer is still allocated as discardable memory.
The SharedBuffer will be turned into non-discardable by
https://codereview.chromium.org/2247073007/.

BUG=603791, 569162

Review-Url: https://codereview.chromium.org/2253853002
Cr-Commit-Position: refs/heads/master@{#414005}

https://pdfium.googlesource.com/pdfium.git/+log/e07edce5b253..0dadcc6fdab7

$ git log e07edce5b..0dadcc6fd --date=short --no-merges --format='%ad %ae %s'
2016-08-23 weili Fix page leaks in an embedder test

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2272943002
Cr-Commit-Position: refs/heads/master@{#414004}

Add a presubmit check that warns when new source files are
not added to GN or gypi files.

BUG=112371

Review-Url: https://codereview.chromium.org/2252043004
Cr-Commit-Position: refs/heads/master@{#414003}

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2268243002
Cr-Commit-Position: refs/heads/master@{#414002}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fa742d7b..4857fef5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2275713003
Cr-Commit-Position: refs/heads/master@{#414001}

BUG=634445
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2266733002
Cr-Commit-Position: refs/heads/master@{#414000}

BUG=613883

Review-Url: https://codereview.chromium.org/2269503002
Cr-Commit-Position: refs/heads/master@{#413999}

TEST=policy_test_cases
BUG=629945
TBR=isherman@chromium.org

Review-Url: https://codereview.chromium.org/2267653002
Cr-Commit-Position: refs/heads/master@{#413998}

Bridge::initialize() should be merged into Bridge::connect() so that we can
reduce the number of inter-thread synchronous function calls.

BUG=640088

Review-Url: https://codereview.chromium.org/2270693002
Cr-Commit-Position: refs/heads/master@{#413997}

Some ARM platforms may require 128-byte alignment for physical buffers.
Modify veatest to align to 128 bytes instead of 64 and use a constant
for alignment size. Also, don't require this alignment on other
architectures.

BUG=None
TEST=veatest on ARM platforms

Review-Url: https://codereview.chromium.org/2270713002
Cr-Commit-Position: refs/heads/master@{#413996}

The BudgetDatabase already had a basic AddBudget method which would add a fixed
amount of budget. This CL adds an engagement based budget increment which takes the
SES score and adds a percentage of the score to the budget based on when the last
award grant was added. For instance, if the budget was last added a day ago, then
AddEngagementBudget will add 1/3 of the SES score to the budget. This functionality
required adding another parameter to the database, which is the last time the
budget was incremented with engagement-based budget.

This CL also adds SpendBudget, which will reduce the budget by the amount requested
if it is available, and will invoke the callback with false otherwise.

BUG=617971

Review-Url: https://codereview.chromium.org/2255813002
Cr-Commit-Position: refs/heads/master@{#413995}

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277543003
Cr-Commit-Position: refs/heads/master@{#413994}

BUG=webrtc:6233

Review-Url: https://codereview.chromium.org/2273583002
Cr-Commit-Position: refs/heads/master@{#413993}

If --enterprise-enable-zero-touch-enrollment is present on the command line, attestation-based will be tried. If it fails, the user will be allowed to fall back to the regular flow unless the flag was passed as --enterprise-enable-zero-touch-enrollment=forced, in which case they cannot exit from the attestation-based enrollment unless it is successful.

Depending on whether enrollment was requested by the user (CTRL+ALT+E) or the system or not, the user who exits from the attestation-based enrollment flow will be presented the enrollment screen or the login screen, as before.

Additionally, wires in the call to the attestation flow class to request a registration certificate. An error is forced at that point until we also wire in the new DM server registration call needed to use the certificate.

BUG=624187
TEST=browser tests

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2186623002
Cr-Commit-Position: refs/heads/master@{#413992}

Add UseCounter to count InvalidStateError by input.selectionStart, selectionEnd, and selectionDirection getters.

We'd like to remove this InvalidStateError.

BUG=622679
R=isherman@chromium.org, kojii@chromium.org

Review URL: https://codereview.chromium.org/2272913002 .

Cr-Commit-Position: refs/heads/master@{#413991}

The errors in the order of RawResourceClient callbacks potentially leads to
CORS bypassing, especially in DocumentThreadableLoader.
This CL introduces RawResourceClientStateChecker to check the order of
RawResourceClient callbacks, assuming that the RawResourceClient is added
to at most one RawResource, and applies it to DocumentThreadableLoader.

BUG=633696, 640291

Review-Url: https://codereview.chromium.org/2020313002
Cr-Commit-Position: refs/heads/master@{#413990}

Also adds a callback for when the task has finished.

BUG=620421

Review-Url: https://codereview.chromium.org/2256373002
Cr-Commit-Position: refs/heads/master@{#413989}

This will help us understand what CDM interface versions are being
used. This can help us decide whether the support of an old CDM
interface version can be dropped.

BUG=570216
TEST=Check that the histogram is successfully generated.

Review-Url: https://codereview.chromium.org/2265893003
Cr-Commit-Position: refs/heads/master@{#413988}

This is a step toward replacing Shelf with WmShelf, which has a more sensible
lifetime. It does not change shelf behavior.

* Migrate the various getters and setters.
* Before the shelf is constructed (after login) default the alignment to
bottom-locked. After construction default to bottom. This is weird, but matches
what we had before.
* Add Shelf::wm_shelf() and use it in pieces of code that we know we'll have to
refactor anyway (chrome, some ash/wm pieces we're not converting).
* Move ShelfView::OnShelfAlignmentChanged() call into ShelfWidget. In general
I'm trying to reduce outside access into ShelfView.
* Convert Shelf* to WmShelf* where possible in tests.
* Make AshTestBase::GetPrimaryShelf() public so it can be used in test utility
functions outside of test classes.

BUG=615502
TEST=ash_unittests, chrome unit_tests
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2272793005
Cr-Commit-Position: refs/heads/master@{#413987}

This CL reimplements the UMA actions and histograms that were in the old
history page.

The HistoryPage.RemoveEntryPosition histogram will only register
removals via the 'Remove from history' menu button.

BUG=614609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2255033002
Cr-Commit-Position: refs/heads/master@{#413986}

Adds many missing dependencies, makes some build files expose more deps as
public, refactors //apps's BUILD file.

Renames //ui/chromeos:ui_chromeos to //ui_chromeos with an output_name for style consistency.

Adds TOOLKIT_VIEWS checks in windows_event_router. These were changed from TOOLKIT_VIEWS to !OS_MACOSX to make them not work on Mac in https://codereview.chromium.org/773303005/, but this doesn't match the definition of TOOLKIT_VIEWS (which currently excludes cast and "check" flags the mismatch).

Review-Url: https://codereview.chromium.org/2261253003
Cr-Commit-Position: refs/heads/master@{#413985}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b742785..fa742d7b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2274803002
Cr-Commit-Position: refs/heads/master@{#413984}

This changes the style of the sign-in button to better match the mocks,
and changes font-sizes across the page to percentage-based, so they can
resize according to user preferences.

BUG=640422
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2269423002
Cr-Commit-Position: refs/heads/master@{#413983}

https://pdfium.googlesource.com/pdfium.git/+log/8252bc1e5a42..e07edce5b253

$ git log 8252bc1e5..e07edce5b --date=short --no-merges --format='%ad %ae %s'
2016-08-23 dsinclair Make indirect object holder private.
2016-08-23 dsinclair IndirectObjectHolder API updates

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2272863003
Cr-Commit-Position: refs/heads/master@{#413982}

Now PostSendDataTask() posts to the bound task runner, and ensures that constructor/destructor and InvokeClosure() are called on the same thread.

R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2262043002
Cr-Commit-Position: refs/heads/master@{#413981}

Clean up some duplicate code in sysroot-creator.sh to make it easier to
implement pulling in packages from precise-updates for the (future) precise
sysroot.

BUG=638394

Review-Url: https://codereview.chromium.org/2273813003
Cr-Commit-Position: refs/heads/master@{#413980}

BUG=None.
TEST=manually.

Review-Url: https://codereview.chromium.org/2269923002
Cr-Commit-Position: refs/heads/master@{#413979}

This allows retrieving of CSSNumberValue typed properties from the
StylePropertyMaps, but does not allow setting.

BUG=545318

Review-Url: https://codereview.chromium.org/2274463002
Cr-Commit-Position: refs/heads/master@{#413978}

BUG=524114
TEST=manually

Review-Url: https://codereview.chromium.org/2275843002
Cr-Commit-Position: refs/heads/master@{#413977}

* Update the "Download Page" asset to be centered.

* Open the Download Home instead of the Android Download Manager
  when it's disabled.  This opens as a tab if the user is in
  ChromeTabbedActivity on a tablet, and as an Activity otherwise.

* Try to account for there not being a tab available when the
  DownloadManagerService tries to open Download Home.

* Change various "Save ..." strings to "Download ..." strings.

* Fix the hostname being the wrong color.

* Fix the progressbar being invisible on JB and KK by adding a
  new Drawable.

BUG=616324

Review-Url: https://codereview.chromium.org/2269293002
Cr-Commit-Position: refs/heads/master@{#413976}

This patch just updates the string since the previous string was confusing.

BUG=640091

Review-Url: https://codereview.chromium.org/2273603002
Cr-Commit-Position: refs/heads/master@{#413975}

In my cl: https://codereview.chromium.org/2258043002/, I combined updating
removing warning message for both desktopUser and non-owner User into one
function. However, for desktopUser build, it is done in a callback. To isolate
these two platform warning message updates, the updating removing warning
message function is divided into two functions.

BUG=639737
TEST=tested on both browser build and chromeOS build, the bug is fixed.

Review-Url: https://codereview.chromium.org/2265133003
Cr-Commit-Position: refs/heads/master@{#413974}

BUG=640429
TEST=No more ClassifyNavigation crashes.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2273613003
Cr-Commit-Position: refs/heads/master@{#413973}

Fix for bug that caused the viewport_to_dip_scale not being updated
when a new compositor host was being instantiated.

BUG=633806
COMPONENT=Pepper, Chrome OS

Review-Url: https://codereview.chromium.org/2262323002
Cr-Commit-Position: refs/heads/master@{#413972}

This CL has no behavior changes.

BUG=596760

Review-Url: https://codereview.chromium.org/2274573004
Cr-Commit-Position: refs/heads/master@{#413971}

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG=632269

Review-Url: https://codereview.chromium.org/2254763002
Cr-Commit-Position: refs/heads/master@{#413970}

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2277583002
Cr-Commit-Position: refs/heads/master@{#413969}