- 14 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15d4c9308d6b..e245d1a20821 git log 15d4c9308d6b..e245d1a20821 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jacktfranklin@chromium.org Include `test/e2e` in ESLint checks. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e245d1a20821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1bd57ed6d148fe1d991612375edccdf7ac9bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741425}
-
Maks Orlovich authored
This avoids code dupes and properly handles the case where experimental web platform features are turned on but the particular feature is disabled. Change-Id: Ic2d5394d1380d129b04f2c5f0dda059c2570a510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053127Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#741424}
-
Tom Anderson authored
The preference native_notifications.disabled has been renamed to native_notifications.allowed (and is not logically negated) since policies cannot have "Disabled" appearing in their name. This fixes a presubmit check of the form: Error: Boolean policy NativeNotificationsDisabled uses negative polarity, please make new boolean policies follow the XYZEnabled pattern. See also http://crbug.com/85687 The new policy maps to the native_notifications.allowed preference. R=thestig Bug: b/72535204 Change-Id: Ib57a6f5c95e89213f507f496e3ca1904694ad965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055391 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741423}
-
Stephen Nusko authored
We also change to using HeapBuffered to prevent forgetting to finalize the message which caused msan errors. git log f440b92c2422..02808dc0a181 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Add configuration for TrackEvent" 2020-02-12 fmayer@google.com Merge "Roll trace_to_text to pick up aosp/1232924" 2020-02-12 skyostil@google.com Merge "TrackEvent: Implement dynamic categories" Created with: gclient setdep -r src/third_party/perfetto@02808dc0a181 Bug: 1052142 Change-Id: I9c646c586ff6ea86426d88d383219e23f80239eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056725 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741422}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4adc7359f66e..379d0c30470e Created with: gclient setdep -r src-internal@379d0c30470e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I759f90d6b64332ca92c814e83aa3f7908ba48689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741421}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e9b53763fee..eaff904e7260 git log 2e9b53763fee..eaff904e7260 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits) 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits) Created with: gclient setdep -r src/third_party/angle@eaff904e7260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ib140dfa76e2afe8cc26e2a5b7a565805af3706e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056984Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2e26f01..142ac8d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36c51fb5bbbf683e98a527a7e3a39a51ab10ea25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057004Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741419}
-
Olivier Li authored
The time bomb is never armed since https://crrev.com/c/2042292 and even back the the results had been discarded for years. There is no plan to reactivate it. This is the process of of being replaced by HangWatcher. Bug: 1034046 Change-Id: I40d7c874000abc04ba327c0c483733ee4795460f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054044Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#741418}
-
Stephen McGruer authored
This reverts commit 1d73a2eb. Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) Original change's description: > Worker: Add data URL tests for nested dedicated workers > > This CL renames data-url.html to data-url.any.js in order to run the > tests on a dedicated worker. Previously these tests only ran on window. > > Bug: n/a > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741367} TBR=nhiroki@chromium.org,shimazu@chromium.org Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: n/a Bug: 1052322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741417}
-
Stephen McGruer authored
This reverts commit 2117f1ba. Reason for revert: Suspecting of causing CRASH failures on Linux MSAN/ASAN bots - crbug.com/1052328 Original change's description: > Ash Tray: Add more observer callbacks to notifications for metrics collection. > > This CL adds more hooks into MessageView and MessagePopupCollection > to log when certain user actions occur, so we can log them. > > BUG=1050809 > > Change-Id: Ic2e23d0c8169e588d2d86556685f0e4549ed128c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045191 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741354} TBR=peter@chromium.org,tengs@chromium.org,holte@chromium.org,amehfooz@chromium.org Change-Id: Ie1a07268ff021b55ac57cc56e0a830e1559675f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050809 Bug: 1052328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057103Reviewed-by:
-
Henrik Boström authored
TBR=zmo@chromium.org Bug: 1045339 Change-Id: I59415b03778f89edbae331c9a0a0197257133f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056724Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741415}
-
Rayan Kanso authored
Since each related app is checked in its own background thread, the order they are merged in might be scrambled. Rather than fix this on the test end, I made sure the order is preserved to be spec compliant. Also re-enable the flaky test. I ran the test with --gtest_repeat=50, it is no longer flaky. Bug: 1051557, 1043970 Change-Id: I5746f3c4c00c0bd281b9edfb37c66c6234abc945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054947 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#741414}
-
Nico Weber authored
Bug: none Change-Id: I0959f2efe5d9ff3da67615c25faaa3061bd702ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052064 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#741413}
-
Josh Karlin authored
What: Make AsyncTaskId non-copyable/non-movable Why: The address of an AsyncTaskId is what's used to keep track of them. So if they move after they've been registered then corruption ensues. How: This is a trivial change. I did have to make a small change to XrFrameRequestCallbackCollection to prevent the AsyncTaskId from being copied. Bug: 1051938 Change-Id: Idf751369c831a9130462b4eb2aa83be121df1fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053409Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741412}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055065 TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I2d422e89822b13b136e012c459036f7fc12132c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056804Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741411}
-
Joel Hockey authored
Test neds ThemeChangeWaiter to ensure DidChangeThemeColor is invoked across renderer to browser in AppBrowserController. Flake revealed in crrev.com/c/2045278 TBR=pkasting@chromium.org Bug: 1033339 Change-Id: Ifba4671d4ca0e25159d3cd257b60744b658d3d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056505Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#741410}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27a4c55af35c..15d4c9308d6b git log 27a4c55af35c..15d4c9308d6b --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jacktfranklin@chromium.org [Unittests] Tidy up Karma config variables Created with: gclient setdep -r src/third_party/devtools-frontend/src@15d4c9308d6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3f95c0f088ec8106191d1e11197d6630ea18ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056983Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts FrameHostMsg_UpdateRenderThrottlingStatus to RemoteFrameHost blink interface. It removes UpdateRenderThrottlingStatus from WebRemoteFrameClient. Bug: 1047362 Change-Id: Icc479058169016353dc58039aa4f311c5d1534da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053872Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#741408}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I58f077854bed11eebd70849ac1477b41ec1a4ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054983Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741407}
-
Marijn Kruisselbrink authored
When using the new origin scoped permission model this makes sure to revoke permissions if no top-level tabs remain with that origin open. Every time a tab/window is navigated away from an origin we start a timer to check if that was the last tab/window for that origin, and if so revoke all its permissions. Bug: 984769 Change-Id: I3840f1885f3a8794baa09316ab1930068e808baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028179 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741406}
-
Hazem Ashmawy authored
Filling up the WebView package/version field in the crash bug report template, thus shortening the length of the URL query field to solve the URL redirection problem. Fixed: 1015923 Bug: 991594 Test: Manually test that url redirects to the bug opening page after signing in Change-Id: I2018d74dce443174d0974a5c7fea4c3f8b599d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054885 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741405}
-
sreejakshetty@chromium.org authored
This is a reland of 7466ee73 Original change's description: > [bfcache] Record NextPaintTime on bfcache restore > > Add "BackForwardCache.Restore.NextPaintTime" histogram to > record next paint time on restoring a page from > bfcache. > > Update RecordContentToVisibleTimeRequest to include parameter > |show_reason_bfcache_restore|. > Bug: 1034353 > Change-Id: I0b4d63b787017efe40caed9af7f3742b11cb43f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968977 > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741037} TBR=altimin@chromium.org Bug: 1034353 Change-Id: Icbcb141bf4ba23bccfdac10074af89487feecb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055204 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741404}
-
Swapnil authored
UploadAppInstallReport method was used for AppInstall Reporting so that DMServerJobConfiguration is created and events are reported to Chrome Reporting API using DM server as a proxy. Now the events are reported directly to Chrome Reporting API. UploadAppInstallReport is no longer used. Bug: 1051464 Change-Id: Ic13f334fa207499852f52d433b08c083799975fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049861Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#741403}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4416f6a. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I252837e5ebd88bebdc6492eb9d9888c760a7aef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056643Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741402}
-
Alex Danilo authored
Reflects the classes applied to the search box up to the wrapper element around the search button and search box as a prerequisite for styling the wrapper itself. Bug: 992823 Change-Id: I41d91a06f456c9f9bc27524fa61a3a1388decf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054473Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741401}
-
Clemens Arbesser authored
This will let the backend know whether the UI was shown to the user or not. Change-Id: I836fba76d322fc5989919323ccb4a50947a498e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056545 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#741400}
-
Alex Danilo authored
This changes the placeholder text color to make it visible with a light background. Changes the non-focussed underline color as a temporary fix, this will be replaced by styling the entire search area with a grey box in a follow up CL. Bug: 992823 Change-Id: I5d97ccd700950f995309afd54888ebfb60036a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054655Reviewed-by:
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PaymentRequestImpl class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I799acc986566e41846fe0ea7d71c14990ae72bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050373Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd356bb63f57..4adc7359f66e Created with: gclient setdep -r src-internal@4adc7359f66e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1686d7db7f51e6ced8351cbb367e5099907479f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056483Reviewed-by:
-
Christian Dullweber authored
Add a toggle and description for 3p cookie blocking to PageInfo. Screenshot in https://crbug.com/1040091#c9 Note: Placement in PageInfo is temporary, see slides in bug for future plans. Bug: 1040091 Change-Id: Ibda0d763d71c115054129d3131ff9400107a0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014935 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#741396}
-
Jose Lopes authored
Both the success and failure callback / closure are called at most once in: https://cs.chromium.org/chromium/src/media/blink/key_system_config_selector.cc?rcl=7a882550cb3fd8a53875fc66c905ff161cc34d21&l=894 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I931487e25ce4c5d7c1b40bfe32c4846c155688c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035952 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#741395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b24890e5d8d3..27a4c55af35c git log b24890e5d8d3..27a4c55af35c --date=short --first-parent --format='%ad %ae %s' 2020-02-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@27a4c55af35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d6bde5bacd4a1ab1591e29655fbd7d5ca5c5caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056743Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c5eb20997895f270dd785d0b907a2196094568e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056484Reviewed-by:
-
David Grogan authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2055794 . Looks like external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html wasn't fixed by this. Change-Id: I14c34662b6750a528e6b60a01ba68b58e419f359 Bug: 1052029, 1042329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055794Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#741392}
-
Tobias Sargeant authored
This is a reland of 786379ee Original change's description: > [proguard] Include proguard info in sourcefile attribute. > > Instead of setting the sourcefile to PG when obfuscating Java, set it > to chromium-{mapping file}-{channel}-{version code} so that > > a) We can recognise chrome/webview stack frames by this string > b) The information required to uniquely identify the proguard mapping > file in question is directly available in stack traces. > > Bug: 1044585 > Change-Id: Ib4fabccfb7693e5e97edc6f29be1cd6cb61fa1e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036091 > Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740625} Bug: 1044585 Change-Id: Ib4f24fdd8a71e3048254000a525b82f5fbe3b4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054110Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741391}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d5861a68d9f7..2e9b53763fee git log d5861a68d9f7..2e9b53763fee --date=short --first-parent --format='%ad %ae %s' 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 30794ac2f91b..73d377fae66e (2 commits) Created with: gclient setdep -r src/third_party/angle@2e9b53763fee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I6ae653bab8620e3d57ee6d92ef2a14cddb425a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056208Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a skeleton for a BulkLeakCheckServiceAdapter, which is supposed to be used by the settings page to interact with the bulk leak check service. Bug: 1047726 Change-Id: I587a4f0511e8b9b197d4a79bac81ca90a6979215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054155 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741389}
-
Colin Blundell authored
This CL implements the feedback from boliu@ that the Activity is more suitable than the ApplicationContext for launching external Intents. This change should also make it easier to add an integration test of launching external Intents in WebLayer. A couple notes on the implementation changes: - I explored various ways to change the API but ended up just passing the Java Tab from content_browser_client_impl.cc to the static Java method that implements intent launching. Given the fact that the content_browser_client_impl.cc callsite needs to interact with the JNIEnv object after making the call, this seemed like the most straightforward change. - It's debatable what action to take if the Activity is not available: bail out or use the ApplicationContext? In this CL I decided on the former; if we find any evidence that there are user flows for this use case we could change it to the latter. Bug: 1031465, 1029710 Change-Id: I23f3006422d47818e3873678fa936b3350cd4b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054864Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741388}
-
Alice Wang authored
This CL added two signout and wipe data integration tests. This is a refactoring of the current SigninTest. Bug: 1038326 Change-Id: I50bffddc3fef8819e617d2b925d0b9f8733f7d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027410 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#741387}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I09c7ac3589b2d9f7c0b63a7f4f96a2682ff542e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056194 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741386}
-
