- 11 Sep, 2019 40 commits
-
-
Lambros Lambrou authored
This updates the MacOS signing script to ignore any options it doesn't understand. This will allow our internal signing job to pass extra parameters (as needed for Apple notarization). This also removes the legacy option-handling, now that our internal tooling has been updated. Bug: 999406 Change-Id: Ifb31ee785b859cf345e7c774069096111b1e485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797384 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695636}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b2f1e4bfc51f..6b8d5911e8f4 git log b2f1e4bfc51f..6b8d5911e8f4 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 ilkos@google.com Add AppendedData to the trace protos Created with: gclient setdep -r src/third_party/perfetto@6b8d5911e8f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0a8ee409715aa501377a629557d64ac95505ed77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695635}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9fafe62237ad..f27abc1aaeea git log 9fafe62237ad..f27abc1aaeea --date=short --no-merges --format='%ad %ae %s' 2019-09-11 thestig@chromium.org Rename FPDFText_GetTextRenderMode() to FPDFTextObj_GetTextRenderMode(). Created with: gclient setdep -r src/third_party/pdfium@f27abc1aaeea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I0211277aeec02b58c69ad3c92dc4dc336afd30b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798205Reviewed-by:
-
Anna Malova authored
- Media query only - Force dark unless page supports dark mode via meta tag and media query - Always force dark (disable media query). Bug: 1001516 Change-Id: Ida620311e8b4811f6fddffbeaf9d7f40b427493e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798349Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#695633}
-
Matt Reynolds authored
This updates the expiry date for two Geolocation histograms used to evaluate the effectiveness of the network location provider position cache: Geolocation.PositionCache.CacheHit Geolocation.PositionCache.CacheMiss BUG=993080 Change-Id: I90605adef05a862e89967fa731fa39685f3fadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797133 Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695632}
-
Tanmoy Mollik authored
As this feature is rolled out it is important to make sure sync does not break for existing syncing users. These metrics should help measure possible regressions. Design doc: go/clank-safe-advanced-sync-flow Bug: 996276 Change-Id: I23082e1be6ef4a5042a08c519dd0c6ee4547fdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764193 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#695631}
-
Marc Treib authored
These aren't needed anymore. Bug: 995531, 995534, 995529, 995528 Change-Id: I64df7aa0d77c20637ac4780520e9bbb3a0af109d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793062 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Alexandre Frechette authored
Should have been removed as of https://crrev.com/c/1655995 when kImprovedGeoLanguageData became unnecessary. Change-Id: I0bdce7a2766491b8c468295dfcd9cf9d184197ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773181 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
-
Pawel Pluciennik authored
Code review contains measurements that dead code stripping on (-Wl,-dead_strip) doesn't seem to affect linking performance. See https://chromium-review.googlesource.com/c/chromium/src/+/1792702. Dead code stripping seems to save about 50% binary size. For protoc binary it's 5.6MB vs 4.2MB. Bug: 1002023 Change-Id: I361d66b8fca26262a003bc2c143cb1871cdc4d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792702 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695628}
-
Brian Ho authored
Original CL: https://chromium-review.googlesource.com/1794142 The original CL was reverted due to using VK_VERSION_1_1 instead of VK_API_VERSION_1_1 which causes Vulkan on Chrome to break for users with Vulkan 1.0 or lower. This CL reapplies the changes in the original CL but updates both the new code and existing code with the proper version number. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1796527 BUG=996470 TEST=run ozone_test on a machine using Vulkan 1.0 Change-Id: I4fb7de01c6e7c24f88c3736c129bc08f822ba9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797245 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695627}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2864f46. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I8dba70d3b344a4da4c794713d9afc9d8178dde77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798265Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695626}
-
Alex Chau authored
- We can only get correct data in adapter after native is initialized, which is needed to correctly decide if empty view should be shown - This will result in a mask being shown full screen (instead of zero state view) while native is loaded - Before: https://drive.google.com/file/d/1b6tKuRSj7LPOLr7O5h7XrWqfK4tJfJp9 - After: https://drive.google.com/file/d/14Nd650D85TwMjCJgtQmalgmB3uCt0kNg Bug: 1002852 Change-Id: I6626865cbee2e9e9eee5664ae83139d428b7d0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798322Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#695625}
-
Miyoung Shin authored
This CL converts BatteryMonitor{Ptr, Request} in chrome, chromeos, content, services and blink to the new Mojo type. Bug: 955171, 978694 Change-Id: I0b7ae1d0158125d0a55a73a057c55b99a5fb1cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787797 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695624}
-
Nate Fischer authored
No change to logic, only class documentation. This moves the documentation to the top of the class (it used to be under the Copyright header) and rewords the content. Test: N/A Change-Id: If1ea8f8a0a5ef0e11de31760ef33939b8b3d714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797083 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#695623}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9a91161b9f65..0ba1705c6af4 git log 9a91161b9f65..0ba1705c6af4 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 jakobi@webrtc.org Increase allowed jitter buffer size in ScenarioAnalyzerTest.PsnrIsLowWhenNetworkIsBad. 2019-09-11 ilnik@webrtc.org VP9 screenshare: use CONSTRAINED_FROM_ABOVE_DROP mode 2019-09-11 titovartem@google.com Store timestamp for each sample to be able to plot them in future 2019-09-11 kron@webrtc.org Add field-trial parameter to enable tests simulating a slow decoder 2019-09-11 sprang@webrtc.org Reland "Improve performance of RtpPacketHistory" Created with: gclient setdep -r src/third_party/webrtc@0ba1705c6af4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none,chromium:None Change-Id: Ibc49931536f4ff3b12ca52ae397c2bd40386826f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798458Reviewed-by:
-
Miyoung Shin authored
This CL converts GeolocationPtr and GeolocationRequest in services, content and components to the new Mojo type. Bug: 955171 Change-Id: I442b1fdd699d7199a38c71331801292e9c5ac094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792473Reviewed-by:
-
Sigurdur Asgeirsson authored
Move all external clients to the public API and kill the include rule that exposed the impl. Bug: 910288, 958115 Change-Id: I10232b3c003e1ae9e16246dc74e30ecbca6db082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796446 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#695620}
-
Gabriel Charette authored
Found while writing docs that this was grammatically incorrect and inconsistent with other "ValidTraits" around. TBR=fdoray@chromium.org (for side-effects outside //base) Bug: 1002654 Change-Id: Ia8974f79d91021cc258775cdf57b18fe2edc9800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795990 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#695619}
-
Miyoung Shin authored
This CL cleans up TRequest that is left in only DataDecoderService class with the conversion to new mojo types Bug: 955171 Change-Id: I28cd8a4f75c66df03a7bccffc922ce6a749a62ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794323 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695618}
-
anthonyvd authored
This reverts commit 3cb21f50. Reason for revert: This change appears to be causing failures on some bots (see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8902604840241120592/+/steps/compile/0/stdout) Original change's description: > bind-gen: Implement the first step of the new bindings generator > > Implement a "do almost nothing" bindings generator. > bindings/core/v8/v8_example.cc is generated > purposelessly. > > Bug: 839389 > Change-Id: I39445cd361677d5a78d96a2d45589c571802b63c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782212 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695608} TBR=peria@chromium.org,yukishiino@chromium.org,agrieve@chromium.org Change-Id: If3dd4dec18b3347f204ffec4da1fb7f2b93b446e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798525Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the WebBluetoothCharacteristicClient and WebBluetoothScanClient. blink: :mojom::WebBluetoothService, WebBluetoothServerClient, Change-Id: Iabe080e7a8ca3b6486aa262e78063463ad02356b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776543 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695616}
-
Julie Jeongeun Kim authored
This CL converts ChunkedDataPipeGetterPtr to new Mojo types. It also updates traits for ChunkedDataPipeGetterPtr in services/network and third_party/blink. Bug: 955171, 978694 Change-Id: I35f97f08a40c9a9fce6ef19d863f1c34c03a2c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787757 Commit-Queue: Julie Kim <jkim@igalia.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#695615}
-
Sigurd Schneider authored
The devtools network tab receives a notification via "requestWillBeSent" that corresponds to the time when the browser process queues a network request. This enables the network tab to calculate how long the task was queued. The timeline (performance) panel does not receive a corresponding tracing event, and hence does not know how long a task was queued. This results in different times being reported as totals in the network vs the performance panel if the task was initiated from the browser (and not from the renderer). This CL adds a tracing event to the browser that indicates that a network request will be queued, and processes the event in DevTools so that the network access time reported in the performance tab matches the time reported in the network tab for requests initiated in the browser. For requests initiated in the renderer, the ResourceSendRequest tracing event already has the time when the request gets queued (up to a few 1/100 ms). Bug: chromium:865066 Change-Id: I1edfac4ec7ada8407b5dd931920e26e139b4f8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771398 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695614}
-
Peter Kasting authored
Bug: none Change-Id: If9aa04d802ea9e89bddf2d879cd6996a4fa5648d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795309 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#695613}
-
Miyoung Shin authored
This CL converts FingerprintPtr and FingerprintRequest in chrome, services and ui to the new Mojo type. Bug: 955171 Change-Id: I17f91e608d749fe868c4a50c5483e573237cd461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792466Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Peter Wen authored
SystemClock#uptimeMillis is better for interval timing since it stops counting when the system enters deep sleep, which would otherwise greatly inflate our module installation metrics. Details: https://developer.android.com/reference/android/os/SystemClock Bug: None Change-Id: I58ce7f1b64ae1dbfbf6402f0380eafd76a161555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776706Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695611}
-
Jérôme Lebel authored
Adding -[SigninEarlGreyUI signinWithIdentity:isManagedAccount:]. And removing a call to TapButtonWithLabelId(). Bug: 684817 Change-Id: I8951ec6ec36ac9fd6c8b976d1e72ff1dd65fb486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793090 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695610}
-
Mohamed Amir Yosef authored
The new API will be used by password manager code within the effort of Butter4Passwords TBR=vasilii@chromium.org Change-Id: I1b0bc300fce37e3695f579aaabbbc7c5bfba4796 Bug: 1002000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795323 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#695609}
-
Yuki Shiino authored
Implement a "do almost nothing" bindings generator. bindings/core/v8/v8_example.cc is generated purposelessly. Bug: 839389 Change-Id: I39445cd361677d5a78d96a2d45589c571802b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782212Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c13cb6e62441..d96ef09317d6 git log c13cb6e62441..d96ef09317d6 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 benjaminwagner@google.com Add Pixel3a (sargo) jobs Created with: gclient setdep -r src/third_party/skia@d96ef09317d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ic2ecb68405ccdae73831157eaf71dad3e57469b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798203Reviewed-by:
-
Alex Chau authored
Bug: 1001098 Change-Id: I71a8f2c664e6ff525656e48b80f23d1b551f32a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789383Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#695606}
-
Abhijeet Kandalkar authored
This CL converts interface Coordinator to uses new Mojo types. Bug: 955171, 978694 Change-Id: Iba377d93282198bccc27d6c071d9697e9d0aa28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789216Reviewed-by:
-
Abhijeet Kandalkar authored
This CL converts interface AgentRegistry and port AgentPtr to uses new Mojo types. Bug: 955171, 978694 Change-Id: I99b583e0582bc81243075b14945a2abfbfe4469b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789215Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL changes the background color in dark mode according to the elevation level. Screenshots before and after are attached to the linked bug. Bug: 1002594 Change-Id: Icaabb2b6468a11adaf580015ef994029e9552422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798348Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695603}
-
Sam Maier authored
Change-Id: I462a66af6934bfd5ca3f2e20bdf4e2cb6c929842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795760Reviewed-by:
-
Brian Sheedy authored
Switches views_perftests to use PerfResultReporter instead of PrintResult directly and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I7e4b90b136aa554be6effa479e5d286f6f78e0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797339 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695601}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fcfeefe03386..9a91161b9f65 git log fcfeefe03386..9a91161b9f65 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 kisicmar@webrtc.org Fixing way of printing logs because RTC_LOG() on Android has limit on printing 1024-60 characters in line. 2019-09-11 nisse@webrtc.org Trim dependencies in modules/video_coding/ 2019-09-11 danilchap@webrtc.org Stop using rtc_event.h forward header Created with: gclient setdep -r src/third_party/webrtc@9a91161b9f65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I256229973ba686f746eb94bfc5ebce07fcaa2fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798204Reviewed-by:
-
Anton Bikineev authored
This option disables checks whether a class needs to inherit from GarbageCollectedFinalized or to have a manual finalize-dispatchers. This is needed to eventually remove GarbageCollectedFinalized from Blink. Bug: 990913 Change-Id: Ib1f1c3c85f77333648aaaf08f5708cce2d35b267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796365 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695599}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/sync_file_system. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tzik@chromium.org Bug: 891670 Change-Id: I3485baef3e82ab552590b6a60c644611dccf4685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787072 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Robbie Gibson authored
For the launch screen, I think there may be an Apple bug with xibs and system colors. In my custom project, when the deployment target was 13, the launch screen supported dark mode fine, but when I switched to 12, it didn't any more. To fix this, I instead used our named color "background_color" in the xib. This sidesteps the issue because named colors are supported on both iOS 12 and 13 and it's actually a better experience than having the background be solid black. This color doesn't show up in Interface Builder in Xcode because the color isn't defined in an xcassets collection, but it does work. The other changes are changing the first-run experience to also use this background color instead of systemBackgroundColor/black. The ChromeSigninViewController remains black by default because it is also presented from settings, which uses the standard Apple color palette. Bug: 997170 Change-Id: Icd71fa2aedf1f3828fa2cefb5382deacc964cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795905 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695597}
-
