- 09 Jan, 2014 40 commits
-
-
zmo@chromium.org authored
Currently it's anything equal or newer than 9.2.1 BUG=332596 TEST= R=kbr@chromium.org Review URL: https://codereview.chromium.org/130153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243940 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (public) functions. BUG=322682 TEST=covered by existing unit tests Review URL: https://codereview.chromium.org/129293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243939 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
There were three issues: 1. a silly bug in the fullscreen change check; 2. there was no guarantee that the window would be actually focused; 3. changing the fullscreen state might come with an animation during which key events will not be received. Note that 2 and 3 are a problem on MacOS only. BUG=None Review URL: https://codereview.chromium.org/116023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243938 0039d316-1c4b-4281-b951-d872f2087c98
-
petewil@chromium.org authored
Some components of a 32 bit build of chrome for Windows need to be built as Win64 Dlls. To allow those components to use base, we make a Win64 build of the base library even when building chrome 32 bit. This is needed by the Chrome Desk Band code. crbug.com/327435. https://codereview.chromium.org/79173004/ BUG=327435 Review URL: https://codereview.chromium.org/103333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
BUG=288562, 332034 Review URL: https://codereview.chromium.org/128373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243933 0039d316-1c4b-4281-b951-d872f2087c98
-
dongseong.hwang@intel.com authored
If the sync point is retired, the scheduler already executed all gl calls before the sync point, so OnWaitSyncPoint() does not need to do anything. Currently, OnWaitSyncPoint() always sets the scheduler off and then on. This CL makes OnWaitSyncPoint() be able to return early. BUG=332401 Review URL: https://codereview.chromium.org/128123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243932 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This fails on other configurations. The new behavior matches the GYP build. R=scottmg@chromium.org TBR=scottmg Review URL: https://codereview.chromium.org/130923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243930 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://historyhshi@chromium.org authored
Apply aria-haspopup attribute to actions buttons. BUG=320753 TEST=ctrl+alt+z, tab to actions button and hear "action pop-up button". R=xiyuan@chromium.org Review URL: https://codereview.chromium.org/130093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243929 0039d316-1c4b-4281-b951-d872f2087c98
-
halyavin@google.com authored
BUG= none TEST= none Review URL: https://codereview.chromium.org/124523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243928 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/131593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243925 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243924 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
r1833 Speculative fix for OOM on win ninja builders TBR=robertshield@chromium.org Review URL: https://codereview.chromium.org/131463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243923 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Arguably more importantly, make data pipe producers not writable during two-phase writes and consumers not readable during two-phase reads. This allows multiple threads to simultaneously use the two-phase APIs in a sane way; they can respond to a "busy" error by waiting. (Why not "should wait" instead of "busy"? Because waiting is only an appropriate response if you know that someone else is going to end the two-phase read/write -- e.g., if a two-phase read/write is happening on another thread.) Also refactor the waiter-awakening stuff so that it's taken care of by the DataPipe superclass, rather than the LocalDataPipe implementation subclass. Note that a two-phase write will only discard if "all-or-none" is requested. Otherwise, as usual, it'll provide as much space as available. R=darin@chromium.org Review URL: https://codereview.chromium.org/129163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243920 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
This makes unwind support consistent on Linux (used by base::debug::StackTrace). A combination of arch-specific toolchain defaults and arch-specific cflags made the previous behavior inconsistent. Unwind tables are useful for development and much cheaper than debuginfo, so enable them for all non-official builds. TEST=build for ia32, x64, arm (compared defaults & official) BUG=180975 Review URL: https://codereview.chromium.org/129283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243919 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/131453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243918 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/131553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243917 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243915 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/131523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243908 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
- Remove GetNext* methods. - Add GetAll* methods, returning a vector of Params/Msg pairs. BUG= Review URL: https://codereview.chromium.org/127243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243907 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
> Android: moves jni_generator samples to use long for JNI. > > BUG=317523 > > Review URL: https://codereview.chromium.org/131543003 TBR=bulach@chromium.org Review URL: https://codereview.chromium.org/131913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243905 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
The video muting test didn't force iSAC correctly. Also added some lightweight log statements to make it easier to see how far we get when the test fails. BUG=332765 TBR=wjia@chromium.org Review URL: https://codereview.chromium.org/131613005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243904 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
Missed updating the MockSurfaceFactoryOzone implementation in content_unittests when I modified the GetVSyncProvider function. TBR=piman@chromium.org NOTRY=true BUG= Review URL: https://codereview.chromium.org/131893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243903 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
There can be multiple streams calling OnData() when the users setup multiple getUserMedia with WebAudio and microphone. We have no way to avoid this situation since it is a valid user cases from the JS perspective. But unfortunately webrtc does not support it since it has one global transmit mixer, and it will crash when more than 1 stream getting into its resampler. This CL introduces a lock to sequence the calls to avoid the racing, which should fix the crash. BUG=332126 TEST=https://devpool-13.talkgadget.google.com/hangouts, go to setting page and play the rington, verify no crash and sound good. Or go to https://x20web.corp.google.com/~xians/multiple_sources.html, start the call, AddWebAUdio, then Playout a clip, verify the audio sounds good and no crash. Review URL: https://codereview.chromium.org/131213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243902 0039d316-1c4b-4281-b951-d872f2087c98
-
amogh.bihani@samsung.com authored
Review URL: https://codereview.chromium.org/120693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243900 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
We need to initialize ResourceBundle otherwise we can't call views::CreateDesktopScreen(). We will also need a gfx::Screen, otherwise we won't have any surface to show any thing. BUG=119759,139313,141187 TEST=views_examples_exe runs and does not crash. R=ben@chromium.org Review URL: https://codereview.chromium.org/108513015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243898 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
BUG=317523 Review URL: https://codereview.chromium.org/131543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243896 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
gfx::PutARGBImage already has code for doing the conversion, so use that. BUG=332026 Review URL: https://codereview.chromium.org/130773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243895 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
for using the class in other platforms outside Chrome OS. BUG=312566 Review URL: https://codereview.chromium.org/130753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243894 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
Use this pattern to replace existing methods in BrowserPluginGuestManager. This CL is just a refactor, there is no change in functionality. BUG=330843 Review URL: https://codereview.chromium.org/128563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243893 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
As described in the bug, on some pages we observe a chain of redirections between the sign-in and the final landing form, during which the "save password" infobar is prematurely destroyed. This CL overrides the ShouldExpire method for "save password" infobars to survive page transitions which are redirects. BUG=26186 Review URL: https://codereview.chromium.org/127973004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243889 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=run ./out/Default/gn, it should reporte the elapsed time without no regressions. R=brettw@chromium.org Review URL: https://codereview.chromium.org/124803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243888 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
This is only fixing packaged apps, the bug is not affecting hosted apps. BUG=314803 Review URL: https://codereview.chromium.org/123733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243887 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
It does not build entirely yet, but get us closer. ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp: In constructor 'WebCore::OriginAccessEntry::OriginAccessEntry(const WTF::String&, const WTF::String&, WebCore::OriginAccessEntry::SubdomainSetting, WebCore::OriginAccessEntry::IPAddressSetting)': ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86: error: no matching function for call to 'blink::WebPublicSuffixList::getPublicSuffixLength(WTF::String&)' ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86: note: candidate is: ../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20: note: virtual size_t blink::WebPublicSuffixList::getPublicSuffixLength(const blink::WebString&) ../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20: note: no known conversion for argument 1 from 'WTF::String' to 'const blink::WebString&' BUG=328717 TEST=gn, ninja -C out/Default blink_platform R=brettw@chromium.org TBR=darin Review URL: https://codereview.chromium.org/119723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243886 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243883 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/131433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243882 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch removes fullPaths from the file views, by using the volume manager and the getLocationInfo() method instead. BUG=320967 TEST=Tested manually. Review URL: https://codereview.chromium.org/130533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243881 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
code base. R=rch@chromium.org Review URL: https://codereview.chromium.org/130003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243880 0039d316-1c4b-4281-b951-d872f2087c98
-
ncbray@chromium.org authored
BUG=332301 Review URL: https://codereview.chromium.org/129723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243879 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
The actual command-line switch was renamed to this in SVN 230100. This just fixes about:flags so it shows the correct name. BUG=332323 Review URL: https://codereview.chromium.org/129703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243878 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
which is extremely slow. BUG=248032 R=yoz@chromium.org Review URL: https://codereview.chromium.org/129603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243877 0039d316-1c4b-4281-b951-d872f2087c98
-