- 25 May, 2018 40 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/710fa99b0bd2..d4d645abecec $ git log 710fa99b0..d4d645abe --date=short --no-merges --format='%ad %ae %s' 2018-05-25 rharrison Reserve space for code words when creating encoder context Created with: roll-dep src/third_party/pdfium BUG=chromium:846027 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I26d090f4a72bd512979b45a7799106a90ad1cc68 Reviewed-on: https://chromium-review.googlesource.com/1073680 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562014}
-
Matt Reynolds authored
The W3C Gamepad spec says that gamepad timestamps should be returned as DOMHighResTimeStamps relative to the navigationStart attribute of the PerformanceTiming interface. This CL modifies the internal Gamepad buffer to store the timestamp as a 64-bit signed integer count of milliseconds since the base::TimeTicks origin. When returning the value to the page, the value is converted to a DOMHighResTimeStamp relative to navigationStart. Additionally, all gamepad data fetchers are modified to set the last-update timestamp using the base::TimeTicks clock. This is a reland of commit: 2464a382 The first attempt broke OculusGamepadDataFetcher and was reverted: https://chromium.googlesource.com/chromium/src/+/fb0674220c41322d99ba8a08347356af20061bbd BUG=398642 Change-Id: I1a77881be388d91131443d93e22395e3f5a78363 Reviewed-on: https://chromium-review.googlesource.com/1070996Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#562013}
-
Weidong Guo authored
Background: New specs require that an item can be dragged to next page without having to fill up the current page. However, all items in launcher currently are laid out linearly and no gap is allowed between items. And the item's visual index (e.g. (i, j) means ith page and jth slot.) can be calculated by it’s model index (index of the item view in |view_model_|) via formula: visual_index.page = model_index / max_items_per_page visual_index.slot = model_index % max_items_per_page However, this formula does not work for new specs, so we need a new view structure to map from model index to visual index. Changes: 1. Add a view structure to represent the item view's structure we show to users. 2. Add functions to operate on the view structure: load, save, sanitize, move, remove, add, etc. 3. Create a new page if the user drag an item to the end of last page. 4. Put everything behind a home launcher flag because it is part of home launcher feature. Design doc: go/applist-gap BUG=837871 Change-Id: I9718bfca0ebf31da5a5d63aa73c4a6f1fb20459a Reviewed-on: https://chromium-review.googlesource.com/1058715 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562012}
-
David Trainor authored
Restructure new download home code to pull out the list specific information from the DownloadManagerCoordinator. This will make it easier to separate the rest of the code (things like undo snackbars, etc.) from the list specifics, and allows us to just expose the list coordinator to keep the interfaces clean. Bug: 842345 Change-Id: Id2bf042f3e2af865ee741dfce18cd6427aea5b66 Reviewed-on: https://chromium-review.googlesource.com/1072152Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#562011}
-
Kevin Bailey authored
The tab switch button wasn't quite vertically centered in the GM2 style result view, and the icon was being clipped. This CL makes provisional size changes to make them fit. Bug: 780835 Change-Id: Ia72cb406088f50c2e22c0929e9e0acdb8d0db31e Reviewed-on: https://chromium-review.googlesource.com/1069569Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562010}
-
Jennifer Apacible authored
Currently, resizing sometimes doesn't always adhere to the aspect ratio when the window also moves (origin point updates) alongside it. OnNativeWidgetMove() is called in these cases. With this change, if the sizes of the previous and new bounds are the same, the window was only moved rather than resized. This change will make OnNativeWidgetSizeChanged() handle the updates for |current_bounds_|. BUG: 829677 Change-Id: Id7df25c0a888efa4b2a7cad39cf83105aa03a759 Reviewed-on: https://chromium-review.googlesource.com/1071125Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#562009}
-
Ted Meyer authored
Omitting kNoClockless allowed the renderer to pull frames quickly rather than trying to ratelimit them at the video fps. This was causing the video to finish playback in the short timespan between being resumed and suspended, causing the 'WaitUntilOnEnded' call to incorrectly return early, as the 'ended_' attribute on the PipelineIntegrationTest had been set to true. This ended_ boolean is only reset on a seek or a resume, none of which had come after the suspend. This was flaking because sometimes the video _wouldn't_ finish before the Suspend call, leaving the pipeline test in an unended state. Bug: 836785 Change-Id: I89d4382354e4cfcd6593b69f6cc02d6821492e41 Reviewed-on: https://chromium-review.googlesource.com/1072955 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#562008}
-
rbpotter authored
Since the InputChanged_ observer was tracking both validity and the input string, it generated intermediate states in which validity was true and the setting value was set to an invalid value, as the input value had not been updated. Fix this issue. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb35e8e825c3d4177d4c99a59dc6dcd5275969a6 Reviewed-on: https://chromium-review.googlesource.com/1072697Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#562007}
-
Kevin McNee authored
DevToolsEmulator::HandleInputEvent handles the case of a gesture pinch being handled on the main thread. Since touchscreen gesture pinch events are all handled on the compositor thread, this workaround is no longer needed. Bug: 787924, 734201 Change-Id: I3499c1129b0ee529a8d218a652c69e258fa93fc0 Reviewed-on: https://chromium-review.googlesource.com/1073401Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562006}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8933c795ce0eb05ab54ef5bf92342cd21c2299c8 Reviewed-on: https://chromium-review.googlesource.com/1073678Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562005}
-
Jennifer Apacible authored
Per UX feedback, add some space between the close button and the edge of the window. BUG: 836389 Change-Id: Id527c868b6beef25e7278e737faa2e0aff4ea469 Reviewed-on: https://chromium-review.googlesource.com/1071233 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#562004}
-
Wenzhao Zang authored
This CL is exactly the revert of the diff between patch 6 and 7 of CL 1013211: https://chromium-review.googlesource.com/c/chromium/src/+/1013211/6..7 It was assumed that GURL and std::string are equivalent for this use case. However GURL converts spaces in urls to "%20", therefore wallpaper_manager.js fails to use the url to find the currently set wallpaper. It's observed that this issue is only reproducible for wallpapers whose urls have space. Think it makes sense to use std::string since the url is not used for downloading purpose. (Using url as wallpaper id is not the best solution IMO, but changing it is a separate task.) Bug: 846264 Change-Id: Ie83b6d9e95dccbe44dd8fca8c0843a85fcfd9758 Reviewed-on: https://chromium-review.googlesource.com/1072700Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562003}
-
Brian Salomon authored
Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I759a98701d50bad4347ae5f44e49a11a3b9cdd45 Reviewed-on: https://chromium-review.googlesource.com/1054526 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#562002}
-
Pavel Feldman authored
Change-Id: Iac5d986f51b86b5c43b20d9cbf1f742684aa610b Reviewed-on: https://chromium-review.googlesource.com/1072790 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#562001}
-
Marc Treib authored
CanEngineStart specified the required conditions for creating the SyncEngine object: CanSyncStart() plus a refresh token being available. The refresh token condition was there because creating the engine will trigger a request for an access token. Previously, that request would fail in unhelpful ways if the refresh token wasn't loaded yet. Now however, PrimaryAccountAccessTokenFetcher handles that situation just fine, it'll simply wait for the refresh token. So this CL removes the refresh token condition from ProfileSyncService. Bug: 825190, 842697 Change-Id: Ica57945f93efcdf8597c1bdfdbda19a0b879e6d9 Reviewed-on: https://chromium-review.googlesource.com/997796 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562000}
-
Mustaq Ahmed authored
Bug: 846405 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I83be26f39db7175b2726052a98311e120bd3a2ee TBR: jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1073398 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561999}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13f43437558c..faaf41e886aa $ git log 13f434375..faaf41e88 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 agable Remove PatchChrome command Created with: roll-dep src/third_party/chromite BUG=chromium:770408 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I12953870db5d4be3b20d54bbbd523559e053ea40 Reviewed-on: https://chromium-review.googlesource.com/1073661Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561998}
-
liberato@chromium.org authored
Includes "null check for encryption info", reviewed here: https://chromium-review.googlesource.com/1072163 This CL does not roll to origin/master, since that is currently in a broken state (merge from upstream fails on the bots). Instead, 1da9c3346d8 has origin/merge-m68 as a parent. Created with: roll-dep src/third_party/ffmpeg BUG=832852, 846009 Change-Id: I09714fed74c90c6173a9fc8c33db7458fc26b38f Reviewed-on: https://chromium-review.googlesource.com/1072520 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561997}
-
Greg Thompson authored
BUG=846623 TBR=tapted@chromium.org Change-Id: Iafb9b3b179e35f4847d87c887a58b143524d0ce0 Reviewed-on: https://chromium-review.googlesource.com/1073372Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561996}
-
Wez authored
The implementation was wrapped with a DCHECK_IS_ON() condition by https://codereview.chromium.org/2653073002/ but the DCHECK_IS_ON() check inside the implementation was not removed. Remove it to make the macro a little easier to read. Bug: 684105 Change-Id: Ia0e923f89432b31fc2ec32b7438e5e6c416433bf Reviewed-on: https://chromium-review.googlesource.com/1072455 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561995}
-
Sadrul Habib Chowdhury authored
Instead of having a 'frame token' for communicating with the embedder, and a separate 'presentation token' for getting presentation token, use a single 'frame token', with explicit 'send_frame_token_to_embedder' and 'request_presentation_feedback' flags. BUG=811961 TBR=reveman@ for trivial changes in fast_ink and exo Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I40765f62d27908f3f999487333113bbb096ae7cc Reviewed-on: https://chromium-review.googlesource.com/1072702 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#561994}
-
Fady Samuel authored
This CL renames DelegatedFrameHost::SynchronizeVisualProperties => DelegatedFrameHost::EmbedSurface. RenderWidgetHostImpl::SynchronizeVisualProperties makes sense because it sends across a set of VisualProperties and a viz::LocalSurfaceId to the child whereas the DelegatedFrameHost method actually embeds that viz::LocalSurfaceId that's being sent to the renderer. This CL renames that method to something more appropriate and less confusing. Bug: 672962 Change-Id: Icc9b5a1438c9efaab9ddb5f4f37f0ff62e1d5df1 Reviewed-on: https://chromium-review.googlesource.com/1073654Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561993}
-
Bence Béky authored
Change most of arguments of type CompletionCallback by constant reference to CompletionOnceCallback by value, and change most const or non-const CompletionCallback type members to non-const CompletionOnceCallback in //net/proxy_resolution, and in some other places as necessary. This is part of //the larger transition effort described on the bug. In addition to changing type, also: * avoid move to local variable when unnecessary; * remove unused MockAsyncProxyResolver::callback() method; * inline ProxyResolutionService::InitProxyResolver::DoCallback() and PacFileDecider::DoCallback(), both only called once; * include completion_callback.h in //chromeos where CompletionCallback is used but was only transitively included. Bug: 807724 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib9e08f54988abb6655f2efd68fc6169ff12e9b20 Reviewed-on: https://chromium-review.googlesource.com/1066291Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561992}
-
Patrick Noland authored
This will use the canonical URL specified in the <link rel="canonical"> element when it exists instead of the actual URL. Most notably this gets the canonical URL for AMP pages. Since this means there are potentially two separate URLs per page, we add a canonical URL to the readiness state object. Bug: 844123 Change-Id: Ib5e99fdd284006a7402136d78ea89cca31181f32 Reviewed-on: https://chromium-review.googlesource.com/1067679 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561991}
-
wutao authored
This cl adds the handling of OnSpeechLevelUpdated and sends the level to ActionView. It is a preparation work in order to make LogoView update the dots amplitudes based on the speech level in kUserSpeaks mode. Bug: b/80259367, b/78191547 Test: manual. Change-Id: I9547437fd129d0cb2056fcdd2ba5d37e580e9b8c Reviewed-on: https://chromium-review.googlesource.com/1072421 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#561990}
-
Xiaocheng Hu authored
In https://crrev.com/c/924027, we blocked copy command if selection is hidden, but also incidentally broke copying on image documents because: - We don't have visible selection on image document - Copying on image document is done via a fast path that doesn't check selection at all, but the CL blocked the fast path This patch moves the fast path before checking selection visibility, so that the original copy behavior on image documents is recovered. Bug: 845957 Change-Id: I920198d13ab3aa387f550c5c213fcbadc42fd43e Reviewed-on: https://chromium-review.googlesource.com/1072730 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561989}
-
Vikas Soni authored
Implement a new video decode path using Android Image Reader API which is available from OREO+. Using android image reader, both GL and Vulkan textures can be created from video frames which is the main motivation behind this new path. Existing SurfaceTexture based path will be the used for android versions < OREO. Bug : 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib44ac6128340b1419c2bdcc786e3d9d59614e462 Reviewed-on: https://chromium-review.googlesource.com/963506Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561988}
-
Jordy Greenblatt authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I12984e9adc10508f27e06b7c220f8d55dbdb33a3 Reviewed-on: https://chromium-review.googlesource.com/1070608 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561987}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2e8bfffdbd..f16fdf3165b8 $ git log 4d2e8bfff..f16fdf316 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6be3d4642866e686d3bc68d62b95042a523fe3a4 Reviewed-on: https://chromium-review.googlesource.com/1072463 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561986}
-
David Tseng authored
TBR=michaelpg@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2709c5930c61238b325a26f859dee390dcad1a1 Reviewed-on: https://chromium-review.googlesource.com/1064739Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561985}
-
Robbie McElrath authored
The deviceorientationabsoluteevent WPT test currently asserts that the 'absolute' property of the deviceorientationabsolute event is false. The spec states that: https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientationabsolute "The deviceorientationabsolute event is completely analogous to the deviceorientation event, except additional sensors like the magnetometer can be used to provide an absolute orientation. The absolute property must be set to true." This updates the test to assert that absolute is set to true. Bug: 774183, 802815 Change-Id: I3694e2b774aa0e4a8a9f7d0328e2aad8b37775e6 Reviewed-on: https://chromium-review.googlesource.com/1062650 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561984}
-
Robbie McElrath authored
The rest of the tests will be migrated in upcoming CLs. This only does one test to get feedback on the overall approach. Bug: 802815 Change-Id: Icce6ac6a1055b699daca5a7e4c091d3e33754885 Reviewed-on: https://chromium-review.googlesource.com/1062777 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561983}
-
Katie D authored
Tested to ensure that the values are the same magnitude as before the change. Bug: 844195 Change-Id: I8f884e1535037741bc34186edcfb80ac3f96a2bd Reviewed-on: https://chromium-review.googlesource.com/1066225Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#561982}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/da060ba107fb..710fa99b0bd2 $ git log da060ba10..710fa99b0 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 thestig Mark CPDF_Object pointers in pattern code as const. 2018-05-25 dsinclair [xfa] Generate CXFA_EventParam.newText dynamically 2018-05-25 dsinclair [xfa] Add missing xfa.event.cancelAction property 2018-05-25 dsinclair [xfa] Clamp selStart, selEnd values in CJX_EventPseudoModel Created with: roll-dep src/third_party/pdfium BUG=chromium:1066,chromium:1066,chromium:1066 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I81ca482708c0a39b45eadf412a89ce864199a1ad Reviewed-on: https://chromium-review.googlesource.com/1073635Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561981}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fcd16760. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18567 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: Iad92620ea5cf712901994ef0deccb57b01f9c62c Reviewed-on: https://chromium-review.googlesource.com/1073627 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561980}
-
kylechar authored
The test failures from using GLES2DecoderPassthroughImpl have been fixed. Re-enable viz_screenshot_sync_tests on Win7 GPU FYI bots now that it passes. Bug: 825906 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0da7271ecdfa65de3c767dffbda96fa6b80979c4 Reviewed-on: https://chromium-review.googlesource.com/1070329Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#561979}
-
Calder Kitagawa authored
This is part of a series of Fuzzers to be added to Zucchini for security review. This tests the full patch generation logic exercising the patch writer and gen process. It covers ~44% of code in 100000 runs. The remaining code is split between ZTF Apply Fuzzer (~30%) and the aggregate of DEX Disassembly (not in launch scope), patch serialization (trusted input), and other testing/debugging/error handling code which isn't triggered. With the supplied seed corpus the fuzzer reaches approximately 4000 execs/s. The file format for the seed is a FilePair proto of a ZTF base file and a ZTF updated file as used in Raw Gen. Also fix bug where wrong fuzzer was running for apply. Bug: 835341 Change-Id: Ib99dd70ba01820b874d72fecb2b543ea7082f649 Reviewed-on: https://chromium-review.googlesource.com/1072229 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561978}
-
Maksim Sisov authored
This CL is a part of Wayland gpu/ui split effort, which fixes the Ozone/Wayland and makes it functional when the gpu service is running off the browser process. The patch does not bring any functionality changes, but rather prepares Ozone/Wayland dmabuf based approach, which uses ozone/drm code, to be landed in the upstream. In particular, drm_util is partly moved to ui/ozone/common/linux and implements drm format conversion methods, which are used by Ozone/drm and are going to be used by Wayland with dmabuf approach. Bug: 820047 Change-Id: I024fd1f6a57b9e9693864e62d5cb8a443afd9e2a Reviewed-on: https://chromium-review.googlesource.com/1071792Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#561977}
-
Eric Orth authored
Split everything in the net/dns directory off into its own BUILD.gn file in that directory with separate source_sets depended on by the main //net target. Control access external to the network stack using public/private headers with whitelisted access via friend lists. The main HostResolver API is public, and everything else is whitelisted to just network (and network service) code and current external usage. This will block most external code from adding new includes of anything except HostResolver. Note: There are some parts of chromium where the restrictions are not enforced (eg //third_party/* and some large parts of //chrome/*), but I checked that there are no current violations (by enabling enforcement in src/.gn for everything and searching the results for "net/dns"). Circular dependencies between //net and //net/dns were too ingrained to be resolved. Configured to allow such dependencies and locked the dns build rules (via visibility) to only allow direct dependency through the //net target. Very reasonable since dns code should still live in the net.dll component. Bug: 846454 TBR: allenvic@chromium.org,thestig@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b6eb60741a7910013b0f7897127c5153cff3f15 Reviewed-on: https://chromium-review.googlesource.com/1060304 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561976}
-
Devlin Cronin authored
Take steps to make it harder to mess up extension_function_histogram_value (which can happen if the enum is ever reordered). Do this in two ways: * Add explicit values to the enum values. This makes it much more difficult to accidentally insert an enum in the middle, because it is clear that they are all increasing. What's more, adding one with a duplicate value will cause ExtensionFunctionRegistrationTest.CheckForDuplicateEntries to fail. * Add a unittest that compares the values in the C++ enum to the values specified in the enums.xml file. To do this, hijack the code to read and parse the enums.xml file from about_flags_unittest.cc and put it in a common place in base/test/enum_test_util. Between the two of these, it should hopefully be very difficult to accidentally reorder the histogram. Bug: None Change-Id: I8932c7da32af8121ec94ef89bf591365e93ce575 Reviewed-on: https://chromium-review.googlesource.com/1062201Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561975}
-