- 19 May, 2020 40 commits
-
-
Side Yilmaz authored
This CL fixes wrong usages of profile at EditorDialog and unsafe usages of profile at PaymentRequestImpl. Currently, both classes uses regular profile always that is not correct, while by this CL regular or incognito profile will be used. Since settings always runs with regular profile, all setting classes use |Profile#getLastUsedRegularProfile|. For other classes, profile is created by WebContents that may give regular or incognito profile depending on the context. Bug: 1041781, 1048632, 1075562 Change-Id: If1bf77dd5a5b0c0bae5a73a38c05863d8ce3cbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201597Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770104}
-
David Bienvenu authored
This is needed for Mohnstrudel. Bug: 229301 Change-Id: I1181c510e8d42635a697666b9254481d9452dad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207935Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770103}
-
Andrew Grieve authored
Rather than silently not deobfuscating things. Bug: 1081438 Change-Id: I263956d55b819db8a5c0dce269687e9d44c56d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204969Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770102}
-
Andrew Grieve authored
This reverts commit aedd4a45. Reason for reland: Use imap() rather than imap_unordered() Original change's description: > Revert "Android: Use non-dummy multiprocessing in compile_resources.py" > > This reverts commit fbbdb5fe. > > Reason for revert: Causing badging issue: crbug.com/1082741 > > Bug: 1082741 > > Original change's description: > > Android: Use non-dummy multiprocessing in compile_resources.py > > > > Will be more relevant if we use more arsc filters. > > Even so, speeds up command on my machine: 10.3s -> 7.7s > > > > Bug: 636448 > > Change-Id: I9b3db23782282e3e13c613b0b64ff1375fb1422d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186756 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#766469} > > TBR=huangs@chromium.org,agrieve@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 636448 > Change-Id: I46916d8d8dbc4e00b004883734924bf49c01c1d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202520 > Reviewed-by: Ben Mason <benmason@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768919} Bug: 1082741, 636448 Change-Id: Ib66cd41cf2d31dd57c5e6462d5c1a2d40f0455f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204966Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770101}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d077e6a3d013..ca76920e7875 2020-05-19 bsalomon@google.com Split bleed GM into two: one tests kStrict and tests kFast. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I7122736c087eef16d44ef84d84ca929d0365b89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770100}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/612fae5937af..90ec1ccfec93 Created with: gclient setdep -r src-internal@90ec1ccfec93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: I9cbcc96055985b70449b159f1ea1b6d44a1e14a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208668Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770099}
-
Pavol Marko authored
This CL makes CertificatesHandler handle the refreshCertificateProvisioningProcesses and triggerCertificateProvisioningProcessUpdate commands from the certificate manager webui. CertificatesHandler collects information about the in-progress certificate provisioning processes and passes them to the Web UI using the "certificate-provisioning-processes-changed" event. Bug: 1045895, 1081396 Change-Id: Id9745caa63020e9c950c0fe3a5c64cf4258f8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199463Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770098}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I81bd4927aff86683d834df4f7ae2d0b2d0c7b331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185400Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#770097}
-
ckitagawa authored
While there was a NewApi lint outage a new method was added to MultiWindowUtils that should have been annotated with TargetApi. This CL adds the missing annotation and adds a check to make sure this won't cause a crash if called from a pathway on a lower API version. Bug: 1081242 Change-Id: Idd54a73d849daadd5ab915158d10be43f5dc6fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199718Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Piotr Tworek authored
The code in checked_ptr_unittest.cc uses INT_MIN but fails to include climits header file. In case of stack_copier_unittest.cc the code uses std::memcpy which is declared in cstring header. This leads to build failures on Linux when using libstdc++ instead of bundled libcxx. Change-Id: Ie8a0daca3b9c95759c43e8457abfa74727244d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205998Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#770095}
-
clamy authored
This CL marks one form control test as flaky. Bug: 1084502 Change-Id: I792e656f54a779d79665fc951ed27dabd7d83ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208973 Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770094}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/409784d0c423..48b827981322 git log 409784d0c423..48b827981322 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 terelius@webrtc.org Refactor/reimplement RTC event log triage alerts. 2020-05-19 danilchap@webrtc.org In modules/audio_device replace mock macros with unified MOCK_METHOD macro Created with: gclient setdep -r src/third_party/webrtc@48b827981322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I64226bc74fb4bb3cc37bca0aac3f5fd689c2ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208951Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "insert-3800346-fix.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I74536a79def06820cbb1f0fddddc18a222e766eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208162 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#770092}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3e704e961865..9e4db33a563e git log 3e704e961865..9e4db33a563e --date=short --first-parent --format='%ad %ae %s' 2020-05-19 tvanderlippe@chromium.org Remove tsbuildinfo determinism monkeypatch 2020-05-19 tvanderlippe@chromium.org Add section on the legacy debug_devtools GN flag 2020-05-19 tvanderlippe@chromium.org Add dispatcher object notation types to Closure Created with: gclient setdep -r src/third_party/devtools-frontend/src@9e4db33a563e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054494,chromium:1081686 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I272398316fce3186361679f70bef931a487d77ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208667Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "delete-line-010.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ia0cfd97891a446371363f8cc574005b27d7cf1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206527 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Viktor Semeniuk authored
In this change some cross platform logic for Password Check was added to CompromisedCredentialsProvider from PasswordCheckDelegate. Also CompromisedCredentialsProvider is renamed to CompromisedCredentialsManager. Bug: 1075494 Change-Id: Idb8efbc79f5381c8fe5aa884921e041f0f0d8de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190217 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770089}
-
Sylvain Defresne authored
Some of the additional plist needs to be generated based on some build configuration, so add a new variable to control the list of targets to add as dependency of the tweak_info_plist. This variable will be overridden downstream with the list of targets needed to generate the plist files. Bug: 1083995 Change-Id: I73d9caad5e38e94c7c2fea43d6b59f97aec6e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207532Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#770088}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0f7837f61de5..0b5f3df1f97e git log 0f7837f61de5..0b5f3df1f97e --date=short --first-parent --format='%ad %ae %s' 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 7f2b55ced2ce..67eac5116ba3 (14 commits) Created with: gclient setdep -r src/third_party/angle@0b5f3df1f97e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I5ed4e0de2d952cf5035b93ee8c713377796c5534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208664Reviewed-by:
-
Maksim Sisov authored
If seat is not available, and Chromium tries to create a popup window (like in browser tests), Wayland will drop the connection with a protocol error. Thus, add additional check for that. Also, create "CanGrabPopup" method so that the same condition is shared between xdg-unstable-v6 and xdg-stable. Test: WaylandWindowTest.DoesNotGrabPopupIfNoSeat Bug: 578890 Change-Id: If47d9044c45b37e149fae1d67b244c54a99ee4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207378Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#770086}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff2478c2..efeaf3d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6533081cfb9ddf753df239e5baf8a630d828d189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208913Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770085}
-
Rune Lillesveen authored
Bug: 1084007, 753671 Change-Id: I087dc9d802d5d3d0e4c6228ad94a2c3577c59c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207204Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#770084}
-
Nick Diego Yamane authored
Change-Id: Ie8e73af16468a708e2f928ba945f8804bdf9607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207490Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#770083}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fde94a72d1e4..409784d0c423 git log fde94a72d1e4..409784d0c423 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 handellm@webrtc.org FakeEncoder: remove lock recursions. Created with: gclient setdep -r src/third_party/webrtc@409784d0c423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8abe2ff4f7312206fb6351996550be852d40cfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208743Reviewed-by:
-
Saurabh Nijhara authored
This is a reland of 0adda52e The test was failing because an entry in the cache was being inserted before the extension cache was ready. Hence, the code returned from PutExtension(...) without insertion, due to which the subsequent GetExtension(...) call on the cache was failing. Now, inserted a run_loop before PutExtension(...) to wait if the cache is not yet ready. Verified the fix locally with the gn args of the failed build. Original change's description: > Fix extension cache inconsistency for version and Id mismatch > > When saving the CRX file to the cache, we have assumed(before this CL) > without any check that its extension id and version are the same as we > expect from the update manifest. If the time of update request on the > client is close to the extension version update, we may encounter the > issue of cache inconsistency: save cache entry marked with one version, > while in fact it's another. > > This CL fixes this problem by inserting in the cache only when the crx > meets the expected requirements from the manifest. This insertion logic > has hence, been moved extension_downloader to the extension_updater > which sets |expectations_passed_callback_| in the crx_installer. This > callback is invoked when the crx passes the expectations and inserts > a new entry in the cache. It also holds the responsibility to delete > the crx file in case cache does not exist or insertion fails. > > Browser tests are also included in the CL to verify this fix. A new > update manifest file has been added for testing which mentions an > incorrect version for the contained crx file. > Also fixed the existing tests that fail due to having incorrect > extension version for their crx file. > > Bug: 1047637 > Change-Id: I6bc291b3f5d21e536a5d8350d34d3dcc222c8f5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179543 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Commit-Queue: Saurabh Nijhara <snijhara@google.com> > Cr-Commit-Position: refs/heads/master@{#769585} Bug: 1047637 Change-Id: I2014bab000bd3a93f86908b93e1b7d43c164f158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207160Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#770081}
-
Maks Orlovich authored
Bug: 1083764 Change-Id: If248b3cc60df331aa008c1562d857a8d7bf9eade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207506Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#770080}
-
Sigurd Schneider authored
Bug: chromium:1051466 Change-Id: Ic5a8b171896ad0083f3f3adc57e111d9ed003cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162827 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#770079}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 615411c4. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 0096ff7d "webrtc wpt: s/doSignalingHandshake/exchangeOfferAnswer/g" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I04cbee13598877791856209d23755ce2265e17fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208274Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770078}
-
sandromaggi authored
This test performs an Autofill and fills a JS driven dropdown on top of it. This filling consists of two clicks which, for slower phones, may cause flaky timeouts. Bug: 1084324 Change-Id: I5010a7edb72a61901195f1bd43c3fe5231425aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207380Reviewed-by:
-
Sigurd Schneider authored
This change prepares test expectations for landing https://crrev.com/c/2194877 Re-enabling CL: https://crrev.com/c/2207382 Bug: chromium:1011811, chromium:1079233 Change-Id: Ic8e8308179a82def63d85e77669eb64c64d34ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207203Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#770076}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: I01dd45c8077dd9a40e2ec5351ec8fe160c7d13db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208665Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770075}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/949f1e45f1dc..9b54466be408 git log 949f1e45f1dc..9b54466be408 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 brandon1.jones@intel.com Descriptor Residency 1: Add Pageable and ShaderVisibleDescriptorHeap Created with: gclient setdep -r src/third_party/dawn@9b54466be408 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4e46abbac2abb34efdbb6234ac0d90aa02f91007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208742Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0e7344726f6..612fae5937af Created with: gclient setdep -r src-internal@612fae5937af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: If7499260eef7909a08185b5d7ea22ec17d52f4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208733Reviewed-by:
-
Yuichiro Hanada authored
For the details, please look at go/arc-key-event-dispatch. Bug: b:148193316 Change-Id: If055711408545b746db04bd30079dbcbe1e95c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206856Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#770072}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a7e5e973577c..3e704e961865 git log a7e5e973577c..3e704e961865 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 tvanderlippe@chromium.org Add Dispatcher base-interface to enforce type-safety Created with: gclient setdep -r src/third_party/devtools-frontend/src@3e704e961865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1081686 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67e97eb0dbe0ed09116f9cd31c3617f77e07714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208739Reviewed-by:
-
Wez authored
TBR=ddorwin,dalecurtis Bug: 1084476 Change-Id: I7986ed8c7db576668e2d3a10c9f7b24b8c45274d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207202Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#770070}
-
clamy authored
This CL marks one compositing web test as failing. Bug: 1084448 Change-Id: I62cbe6ab6678b20537a11d175e5244b446e42dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207200 Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Eric Willigers authored
We enable the flag DesktopPWAsWithoutExtensions. Desktop PWAs now use the new web_app:: system instead of relying on Extensions. Bug: 877898 Change-Id: I1ddd8fb46325626bd55e7bfecf117c739b81a19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208319Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770068}
-
Alexey Baskakov authored
We have a logical race: 1) The bookmark app object arrives from the server. It doesn't create any registry entries but only enqueues full web application installation (loading url, manifest, icons etc). It gets queued 1st. 2) The web app object arrives from the server. It immediately creates |is_in_sync_install| web app placeholder with all the sync data committed to in-memory registry and leveldb database. Then it enqueues full web application installation (loading url, manifest, icons etc). It gets queued 2nd. 3) The bookmark app task finishes full install first with a success. |FinalizeInstall| overwrites the |is_in_sync_install| web app placeholder with real data from the web site. WebAppInstallManager proceeds to next task in the queue. 4) The web app task fails to load the url. It tries to do a fallback install: it does |FinalizeFallbackInstallAfterSync| instead of |FinalizeInstall|. DCHECK fails because the web app entry was overwritten at step 3. This is tested in SyncRace_InstallBookmarkAppFullThenWebAppFallback unit test. In next CLs: Fix other races and scenarios. Add unit tests. Bug: 1084392 Change-Id: I7196e74e289bfa516a0ca4e455084a7ea6ca8932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208790 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770067}
-
Maksim Moskvitin authored
Deleted tests cover Directory behavior and either have analogous or cover Directory-specific scenarios. Bug: 1083924 Change-Id: I168f01337fc5bbd2bffe940b75c21a658450182a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207188Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#770066}
-
Jana Grill authored
Since Crostini is only allowed for the primary profile and there is an additional check for it in code, it makes sense to change the value for 'per_profile' to False for all Crostini-related policies. Bug: 1067189 Change-Id: I7e5bfc13a917793ecc7a5a21466800b37c256898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207312Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#770065}
-
