- 12 Jun, 2018 40 commits
-
-
Cathy Li authored
Change-Id: I26e290a3c63bee05e83ad269a0234b229c585ca8 Bug: 852075 Reviewed-on: https://chromium-review.googlesource.com/1091226Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#566619}
-
Steve Kobes authored
This removes methods and paths in LocalFrameView that depend directly on scrollbar existence. Since RLS, LocalFrameView never has scrollbars. Bug: 823365 Change-Id: I691480e4cad9239f12c50aa868c5d13571d45b2f Reviewed-on: https://chromium-review.googlesource.com/1097540Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#566618}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27bacf89..51345cbe Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6606a446c2cc1144e6f6da7b9251d6079f443a4a Reviewed-on: https://chromium-review.googlesource.com/1097205Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#566617}
-
David 'Digit' Turner authored
As described by the corresponding bug entry, trying to run the chromium linker test failed badly, due to a combination of Python and Java related errors. This CL fixes it, i.e.: - Change the GetTests() call in linker/test_case.py, avoiding a runtime TypeError exception. - Add a missing call to Test.setTestRunnerClassNameForTesting() to properly setup the Linker class for testing (avoid a Java runtime assertion failure later in LibraryLoader.ensureInitialized()) - Add a 'false' parameter to the ActivityWindowAndroid() constructor call, in order to avoid a runtime assertion in ApplicationStatus later. The 'false' value prevents registering for listening to activity state changes, which is not needed by this test. + Remove the obsolete --use=legacy-linker command-line flag passed to the test APK, since there is now only one linker in use. + Update documentation in test_case.py on how to run the test, it is simply: out/Release/bin/run_chromium_linker_test_apk now. BUG=851899 R=agrieve@chromium.org, pasko@chromium.org, yfriedman@chromium.org, tedchoc@chromium.org Change-Id: I67d21faa2d7a3976ea342688d8366a25b52170ef Reviewed-on: https://chromium-review.googlesource.com/1097125Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#566616}
-
Dirk Pranke authored
This CL adds the `is_regression` per-test field (though it won't yet be set by anything), and adds a bunch of text clarifying the differences between failures, unexpected results, and regressions. It also does some general editorial cleanup, fixing typos and re-sorting some of the enumerated values. BUG=822078, 837047 Change-Id: If78f6ef66c01d7c2924bfd98589832fe9299968f Reviewed-on: https://chromium-review.googlesource.com/1096486 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#566615}
-
Luna Lu authored
Recently verified the measurement align, cases with very different counts are due to OOPIF. Moving the CSS histograms to page load metrics. Tests RecordingFeatures, RecodingCSSProperties, RecordingAnimatedCSSProperties are removed because there are browser tests testing the browser side histograms already. Test MutedDocuments is removed but the page load metrics takes care of internal pages, non http/https url, ntp, etc Test InspectorDisablesMeasurement is being tested in inspector layout test instead. Bug: 818684 Change-Id: I822b412cf34e5ccb9bda13b26ba33cbe05217ea3 Reviewed-on: https://chromium-review.googlesource.com/1089031 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#566614}
-
Chris Lu authored
Sepcifically for ClearBrowsingDataListType enum. Change-Id: Iafc969966230515dad4f8caf6b93a1ff927bcfea Reviewed-on: https://chromium-review.googlesource.com/1097992 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566613}
-
David Black authored
Adds resource strings to ash/ash_strings.grd. Bug: b:77638210 Change-Id: I9c9b5bdc99f3fd394fc74099f6138802078842af Reviewed-on: https://chromium-review.googlesource.com/1091162 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566612}
-
Nate Chapin authored
Change-Id: Icb4d82dbd8d370cb143a1925b5fc5f059ef9d083 Reviewed-on: https://chromium-review.googlesource.com/1097598Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#566611}
-
Karan Bhatia authored
r548269 disallowed implicit file url access for extensions with activeTab. This CL ensures that the file access toggle is visible for extensions using the activeTab permission, hence providing a way for these extensions to be used on file urls. BUG=850643 TEST=Install an extension with activeTab permission. (E.g. https://chrome.google.com/webstore/detail/page-redder/difbeimhegehkihppkgdlpongficimep?hl=en). Ensure that "Allow access to file URLs" checkbox is shown for the extension. Change-Id: I777c8edb29666343f2e5a6e7a1a06a32746178a8 Reviewed-on: https://chromium-review.googlesource.com/1096352 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#566610}
-
Steven Bennetts authored
Bug: 814274,784804 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I50c412d8ff26b5c78fb48834215d0d43277996a6 Reviewed-on: https://chromium-review.googlesource.com/1091804Reviewed-by:
Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566609}
-
Tommy Martino authored
This CL adds the disambiguation information and the credit card network icon to the accessible data, when these fields are present. Change-Id: I198e0af4d058290f4a572d2534aec2bbd56beda3 Bug: 847586 TBR=avi@chromium.org Change-Id: I198e0af4d058290f4a572d2534aec2bbd56beda3 Reviewed-on: https://chromium-review.googlesource.com/1077335 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566608}
-
Jun Cai authored
Some major changes in this CL: 1. Adds an extra parameter "array<string>? to_be_removed_request_headers" to URLLoader::FollowRedirect() so that the browser can pass in this information. 2. Adds a ModifyHeaderURLLoaderThrottle class which can add http headers through WillStartRequest() and remove http headers through WillRedirectRequest(). 3. Adds an extra parameter "std::vector<std::sgring>* to_be_removed_headers" to the WillRedirectRequest() so that subclass can pass in the http headers to be removed. 4. Adds a member variable |to_be_removed_request_headers_| to ThrottlingURLLoader so that ThrottlingURLLoader::OnReceiveRedirect() can store the to be removed headers there, and ThrottlingURLLoader::FollowRedirect() can use that to remove headers by calling URLLoader::FollowRedirect(). The design doc is at: https://docs.google.com/document/d/1XAa0V_lKmiZWW7eBCcqdr4DCJSrPjhnvuqispxBGkUw/edit?pli=1 Bug: 841309 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I99b80811986714c21f17833b9ccb438f175d9939 Reviewed-on: https://chromium-review.googlesource.com/1086219 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566607}
-
Jiaquan He authored
Bug: 733662 Change-Id: I51fe8bbfa79e409ab9b0aeb35820c01d577afc35 Reviewed-on: https://chromium-review.googlesource.com/1097587Reviewed-by:
-
Siddhartha authored
|sCachedApplicationState| is set to null before updating sActivityInfo and getApplicationState can be called from any thread. This means that the sActivityInfo can be accessed from some other thread when being updated and |sCachedApplicationState| can have wrong values. Fix |sCachedApplicationState| to be updated synchronously with |sActivityInfo| and the state is always consistent. BUG=846871 Change-Id: Id658cc816d422f98240111fbdfa3b3475af1146b Reviewed-on: https://chromium-review.googlesource.com/1094143 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566605}
-
Tarun Bansal authored
The minimum proxy timeout is set to 8 seconds on Android and iOS; and 30 seconds on desktop. The maximum proxy timeout is set to 30 seconds on Android and iOS; and 60 seconds on desktop. It's still possible to change the minimum and maximum timeout values remotely using field trial. Bug: 704339 Change-Id: Id738215406ea80d63c0f1a0b350f4ac03b1711f3 Reviewed-on: https://chromium-review.googlesource.com/1092040Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#566604}
-
Shakti Sahu authored
Currently we don't resize the infobar container if the new container height is higher than the old container and if it is partially hidden from the screen. With this CL we are trying to fix this issue by snapping up the container anytime an infobar is added in front of the existing ones. Change-Id: I6fd0615315814affbdfa4e9eafb1b1bb1c33c40f Bug: 851132 Reviewed-on: https://chromium-review.googlesource.com/1093521Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Ben Pastene authored
Bug: 851753 Change-Id: I091358d649a991c66cf12ea059ba06c7998e185d Reviewed-on: https://chromium-review.googlesource.com/1097503Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#566602}
-
Christian Fremerey authored
This reverts commit 4610d04f. Reason for revert: Forgot to update the CL description. Will reland to avoid a quite confusing/misleading CL description. Original change's description: > Define enum media.mojom.VideoPixelFormat instead of using native enum > > A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795 > caused a regression by introducing a new mojo enum VideoCapturePixelType and > typemapping it to media::VideoPixelFormat, see Bug 839742. > > The motivation for that change was to make the video capture service API, > which had a dependency on the native enum VideoPixelFormat in media_types.mojom, > compatible with an older version of Mojo used on ChromeOS. This older version > does not support native enums. > > This CL replaces the bad solution from the CL above with the following: > * Instead of using a native enum VideoPixelFormat in media_types.mojom, declare > a Mojo enum and move it to a separate file. > * Add typmapping from the Mojo enum to the native enum. > * Have the video capture service API mojoms depend on only the new file > containing the Mojo enum for VideoPixelFormat. This way we avoid the API > depending on any file that uses native enums. > > Bug: 839742, 847598 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Ifcff064b1f0eb95579119916b757dc6512f49a15 > Reviewed-on: https://chromium-review.googlesource.com/1050489 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566543} TBR=xhwang@chromium.org,rockot@chromium.org,sandersd@chromium.org,rsesek@chromium.org,chfremer@chromium.org,lasoren@chromium.org Change-Id: Iab9f2c00a6e5aa8ffd167b4d89f294691b37d456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839742, 847598 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1097900Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#566601}
-
Eric Karl authored
Currently, Android OOP-D uses a synthetic begin frame source. This patch causes Android OOP-D to use the same Android OS driven BFS which non-OOP-D uses, by sending the signals over an IPC to the Viz process. A future CL will read this signal directly in the Viz process, but as this is a riskier change, I wanted to land this first. Bug: 811967 Change-Id: I49ace83aa0a9f27ec18f1ca3527bed4666a9ebaa Reviewed-on: https://chromium-review.googlesource.com/1093520 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566600}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7ce4a15115cb..9c0e3063ddb1 git log 7ce4a15115cb..9c0e3063ddb1 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 ynovikov@chromium.org Fix several of PointSpritesTest Created with: gclient setdep -r src/third_party/angle@9c0e3063ddb1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8744437fd68be8d3cee4dd66f5fcda8f13bc72e8 Reviewed-on: https://chromium-review.googlesource.com/1097815Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566599}
-
Qiyu Hu authored
Convert properties and permissions from android to bluez. Support permissions in gatt characteristics. A relevant patch is crrev.com/c/1053126 BUG=b:78593133 CQ-DEPEND=CL:1079668 TEST=Pass CtsVerifier test on gatt server permissions Change-Id: Ia4a5f63bebd8a52d24511ddbc93a72870ae44b16 Reviewed-on: https://chromium-review.googlesource.com/1037196Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#566598}
-
Sean Topping authored
This mirrors the logic in CastWebViewDefault, where load errors will forcibly stop and restart the page. In particular, this allows us to handle network changes when we're in the middle of loading an extension page. Bug: internal b/79432754 Test: Test device in bi-interface mode, verify UI page properly reloads on network change. Change-Id: I004db712b6a016f0f16bf3341399f800da069d77 Reviewed-on: https://chromium-review.googlesource.com/1096657 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#566597}
-
Oscar Johansson authored
When building with Jumbo, unnamed namespaces gets merged. Constants with the same name within those namespaces conflict. This commit renames those constant to something more file specific. Bug: 850484 Change-Id: If04a32cbf9ce544d852b1297f229d24d96845c59 Reviewed-on: https://chromium-review.googlesource.com/1096757 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#566596}
-
Adrienne Walker authored
Because Skia samples these extra texels past the edge of painted content, they need to be included both for partial and full raster. This was broken by this patch, which removed that behavior: https://chromium-review.googlesource.com/c/chromium/src/+/888078 Bug: 849227 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac6a01b94daa78f2ce48537c53fb2f4aea0812d8 Reviewed-on: https://chromium-review.googlesource.com/1097552Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566595}
-
Tommy Steimel authored
This CL completely removes the buffering animation from the timeline. Instead, we will show the centered loading spinner that we currently show during metadata load. Bug: 839095, 839093 Change-Id: I6a87b7060e25861e4996203e0807a62b87d8606f Reviewed-on: https://chromium-review.googlesource.com/1091291 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#566594}
-
David Black authored
This CL aims to make AssistantCardRenderer more generic so that it can be reused for rendering Assistant Settings, Reminders, and other remotely hosted content. As such, this CL: - Renames AssistantCardRenderer to WebContentsManager. - Refactors to remove "Card" references in favor of "WebContents". - "Assistant" terminology has also been removed so that we can promote this class to a more generalized location in a follow up CL. It can then be used outside Assistant as needed. Still TODO: Handle Mash mode. Bug: b:109888552 Change-Id: Ia7ba6686c5347387a13dc40b1ee9c61f71191065 Reviewed-on: https://chromium-review.googlesource.com/1091914Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#566593}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: I5dea7d08ad0366eb0031a2e89b74f711e89a68c7 Reviewed-on: https://chromium-review.googlesource.com/1096729 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#566592}
-
Ashley Enstad authored
Bug: 713357 Change-Id: I88006945277d7081ca71b33dac183e7619d29b82 Reviewed-on: https://chromium-review.googlesource.com/1097233Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#566591}
-
Xiaohan Wang authored
Also update 'media_mojo' and 'eme' watchlist. R=liberato@chromium.org Change-Id: I8b8d00131456ee12b85507cfe85be65320c92370 Reviewed-on: https://chromium-review.googlesource.com/1092313Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#566590}
-
Iker Jamardo authored
When requesting a session and after the camera permission is confirmed to have been granted, check if ARCore is installed and if the version used in Chromium is compatible with it. If ARCore is not installed or an update is required, a prompt will be shown. Bug: 838954 Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240 Reviewed-on: https://chromium-review.googlesource.com/1074494Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566589}
-
Victor Costan authored
Add a blink analogue for net::CanonicalCookie. This is initially used by the CookieStore. Once the RestrictedCookieManager is ready, Document cookie/setCookie can be changed to it directly instead of a parallel pipeline to the browser with redundant security checks. A mojo type mapping is introduced. net::CanonicalCookie is not used directly due to std::string vs. WTF::String uncertainty, but we may revisit this in the future. Bug: 729800 Change-Id: I1492379bee98d44f13470e32da794616b905260b Reviewed-on: https://chromium-review.googlesource.com/1062599 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566588}
-
Xiaohan Wang authored
These codecs are used to support HW_SECURE* robustness levels, and in KeySystemConfigSelector we already use "HwSecure" in many places. Note that "secure_codecs" on Android is not renamed because these correponds to ".secure" decoders. But a comment is added that all ".secure" decoders are hardware-based and support HW_SECURE* robustness levels. So they are translated to "HwSecureCodecs". Bug: 848532 Test: No functionality change. Change-Id: I7a73ff8de27e75bd3128b9e55e025db7d32e072e Reviewed-on: https://chromium-review.googlesource.com/1096681 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#566587}
-
Jacob Dufault authored
There have been a significant number of additional buttons added. Update the UI so every button is usable. Change-Id: I31b542c3e83adada2ba1c5613e5fd820df785deb Reviewed-on: https://chromium-review.googlesource.com/1086157 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Xing Liu authored
The current string for download location prompt didn't match the UI design, this CL changes the string. Bug: 852006 Change-Id: I69116729d5048f59ebfd82970d0b96fe8584d2b2 Reviewed-on: https://chromium-review.googlesource.com/1097563Reviewed-by:
-
Robert Liao authored
BUG=841271 Change-Id: I39556cc73d4aa9705eed1d63e07a6e8a2c8eb726 Reviewed-on: https://chromium-review.googlesource.com/1095560Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566584}
-
Owen Min authored
Refactor the class to move most of MachineLevelUserCloudPolicy related code into its own class. Bug: 846742 Change-Id: I7d548a1d1e96de7ebbecf48a7e4e29d1cc033c12 Reviewed-on: https://chromium-review.googlesource.com/1089922Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566583}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/82c730bf83c7..a3843c99e7a6 git log 82c730bf83c7..a3843c99e7a6 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 tsepez@chromium.org Remove some #ifdef XFA in favor of runtime checks. Created with: gclient setdep -r src/third_party/pdfium@a3843c99e7a6 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id886b5d57b0bd261c031b7d40123eceb69e0515b Reviewed-on: https://chromium-review.googlesource.com/1097381Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566582}
-
Katie D authored
The ARC++ voice is built-in, so it does not have an extension ID. It also lacks a default language. Handle voices without adefault language in the TTS settings page by adding a drop-down to select a default voice when no particular language is specified. Handle voices without extension ID by not making an empty extension ID in a voice something that keeps a match from occuring in tts_controller_impl::VoiceMatches. Bug: 850702 Change-Id: Ia06c485ee3e90b7bbb0c13bcae0a30d234e0abd6 Reviewed-on: https://chromium-review.googlesource.com/1092071Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#566581}
-
Emily Stark authored
Bug: 839969 Change-Id: Ib677bf13f737e5cc2fb5cd5b43466f2d6b796f69 Reviewed-on: https://chromium-review.googlesource.com/1096370Reviewed-by:
-
