- 19 Mar, 2018 40 commits
-
-
Tommy Steimel authored
This CL changes the CSS to show the timeline and overflow button before preload on the modern media controls. This exposes the download button so that the user can download a video without preloading. Bug: 814509 Change-Id: I7993204dc6d0bc38ef77e18a14ae1cfa07ab3ca8 Reviewed-on: https://chromium-review.googlesource.com/930334Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#544103}
-
Jinho Bang authored
This adds the content setting page for the new PaymentHandler API and the UI plumbing. The page is chrome://settings/content/paymentHandler. This is behind the kServiceWorkerPaymentApps feature flag. Bug: 665949 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie388940363c7efda57e66ba16dbf6edcf0f5a31c Reviewed-on: https://chromium-review.googlesource.com/934741 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544102}
-
Jan Krcal authored
Bug: 782237 Change-Id: Ic1f84717cd457218cc91dc08f57af0c138d5b36b Reviewed-on: https://chromium-review.googlesource.com/859762Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544101}
-
Dan Harrington authored
There is a need to fetch images without decoding them, so the ImageFetcher's API was modified to allow callbacks for image data and/or the decoded image. This made the ImageFetcherDelegate superfluous and confusing, so it was removed. Bug: 794828 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I809a692f5ee55fbe101adbb33210f456a4fdb27d Reviewed-on: https://chromium-review.googlesource.com/955958 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#544100}
-
John Z Wu authored
This fixes a DCHECK in ApplicationContext::GetApplicationLocale(). Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I80408547edef582b184a64d703eb8b9584115634 Reviewed-on: https://chromium-review.googlesource.com/969094Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#544099}
-
Elly Fong-Jones authored
This change: 1) Makes ZoomBubbleView behave correctly in Polychrome Cocoa mode, by using the Cocoa code paths there; 2) Factors out some of the messy ifdef logic into even messier (but encapsulated!) ifdef logic 3) Marks one test (NonImmersiveFullscreen) as requiring a Views browser window, although this test currently fails in that mode on Mac. This change fixes all the ZoomBubbleBrowserTest, ZoomBubbleDialogTest, and ZoomControllerBrowserTest tests for polychrome. Bug: 817408 Change-Id: I3ecfa3aa98fb27ab32ac389c4be4955c3933b35c Reviewed-on: https://chromium-review.googlesource.com/960801 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#544098}
-
Esmael El-Moslimany authored
Bug: 810636 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie72810052b3b379f2b5d6bc26d5c6e08a00c330b Reviewed-on: https://chromium-review.googlesource.com/959238Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp:154:3: error: declaration of ‘blink::WebCallbacks<void, const blink::WebString&>* blink::{anonymous}::DocumentWebSocketChannelTest::WebCallbacks()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h:53:0, from ../../third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp:5: ../../third_party/WebKit/public/platform/WebCallbacks.h:53:7: error: changes meaning of ‘WebCallbacks’ from ‘class blink::WebCallbacks<void, const blink::WebString&>’ [-fpermissive] class WebCallbacks<void, T> { ^~~~~~~~~~~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |WebCallbacks()| method can change the meaning of references to the outside type in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetWebCallbacks()|. Change-Id: I418cf7d941d9ed3be030be2fda93690d3be76468 Reviewed-on: https://chromium-review.googlesource.com/968624Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544096}
-
Charles Harrison authored
Added a high level overview as well as descriptions of key components, with important ownership highlighted. Bug: 817427 Change-Id: Iaad43832f08402ca8a7d73708e0f005359d9d31a Reviewed-on: https://chromium-review.googlesource.com/961269 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544095}
-
Katie D authored
This mostly reverts the commit, "Adds user setting to allow speech to continue after text goes away." (commit 80d1057b) However, the private variable readAfterClose_ was kept in order to by default keep reading, but make it easy to change this functionality later. After UI review, it was determined that the setting is unnecessary. We will just always speak after text goes away. This may be confusing for novice users but should get better once we have the on-screen UI. Bug: 818835 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I04a36b717251ef88283570a690e42366c035dded Reviewed-on: https://chromium-review.googlesource.com/967241Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#544094}
-
Katie D authored
Some voices are missing callbacks Select-to-Speak needs. Those voices shouldn't be displayed to the user in Select-to-Speak settings, or available from select-to-speak at all. Bug: 822440 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If998f430fcc0854052b7d9bb1ed89c41b0069fb8 Reviewed-on: https://chromium-review.googlesource.com/967266Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#544093}
-
https://chromium.googlesource.com/angle/angle.git/+log/3761dc7bf683..e3dc5dd0cb16 $ git log 3761dc7bf..e3dc5dd0c --date=short --no-merges --format='%ad %ae %s' 2018-03-16 lucferron Vulkan: Add 2 features to StreamingBuffer Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I4b9fe7d5050c7dfd9e09237553d3f72aec94b19e Reviewed-on: https://chromium-review.googlesource.com/969119 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544092}
-
Alexander Timin authored
Measure the amount of work coming from a worker depending on the type of the frame which requested the creation of the worker. R=rkaplow@chromium.org Change-Id: I51559e8973483c041d8555ca979927b19550860b Reviewed-on: https://chromium-review.googlesource.com/966226 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#544091}
-
Elly Fong-Jones authored
The CreateNativeWebModalManager shim is necessary in polychrome unit tests, not just regular-Cocoa tests. Bug: 817408 Change-Id: I431d7616ebb70a7812cd2f4e860ccb9f8e117933 Reviewed-on: https://chromium-review.googlesource.com/969107Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544090}
-
Paul Jensen authored
Original motivation for this change was to make our dex-count monitoring perf tests get a more accurate result that is like what Cronet users will see. For example prior to this change crrev.com/542392 showed no improvements, but with this change the improvement should be visible. As I implemented this change it made other benefits visible: Our cronet_impl_native_proguard.cfg file wasn't properly updated for crrev.com/542392, indicating a gap in our testing...we didn't have any tests for the final products we were putting in the cronet/ output dir. The main change in this test is to make the Cronet sample app depend on the jars in the cronet/ output directory rather than the intermediate jars. This required some related changes: 1. The Cronet sample app could no longer be used to generate Cronet's JNI registration as the JNI registration generation searches for Java source files to parse and they were no longer visible as the sample app now depends on some copied jars, not android_libraries. This was fixed by adding a simple app providing the visible Java files. 2. The Cronet sample test is an instrumentation test which means it's built combined with the Cronet sample. Previously the Cronet sample app had visible dependencies on //base and //net Java targets, but these are now built into the jars in the cronet/ output dir. This means that sample test build would include them again resulting in proguard duplicate errors. To avoid this I removed test deps on //base and //net. 3. In a number of ways this change ran afoul of the target name whitelist in build/config/android/internal_rules.gni that determines which targets must have build_configs generated. I had to be careful in how I named my targets and in the case of copy_java8_jars explicitly generate a build_config. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I3706a768b0c2fc7261660dc0db4826b17dc81a61 Reviewed-on: https://chromium-review.googlesource.com/960583 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#544089}
-
Aaron Leventhal authored
Bug: 819350 Change-Id: I75abdd3988c0c6ff3e73e67bc8fdef30e05b6aae Reviewed-on: https://chromium-review.googlesource.com/964246 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#544088}
-
Christopher Grant authored
This change adds an initial, non-functional overflow menu. It can be summoned, looks like an overflow menu, and has buttons and items. It does not yet: - Trigger any actions on clicks - Appear when hovering the overflow button - Update according to tab state - Expand to fit translated text These additions will come in follow-on changes. BUG=817614 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I837f7a3b4cb0b151e9370ba3d7e2f2de00bd34bc Reviewed-on: https://chromium-review.googlesource.com/967256 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544087}
-
Joe Mason authored
R=csharp, ftirelo Change-Id: I0e747d59f2a04b743283b69d0d5f55b56dc162b1 Reviewed-on: https://chromium-review.googlesource.com/966543 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544086}
-
Filip Gorski authored
This updates ownership: * Adds fgorski and pnoland to NTP code * Adds pnoland to Feed Change-Id: Ie9f6ac87c6e14aa051c457b7c5c2a8a2987db5da Reviewed-on: https://chromium-review.googlesource.com/967881Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#544085}
-
Alexey Kozyatinskiy authored
.. and Emulation.setScriptExecutionDisabled as well. R=pfeldman@chromium.org Bug: chromium:820640 Change-Id: I72d245cf78d80ad0444a036d29220562f787b585 Reviewed-on: https://chromium-review.googlesource.com/957820 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544084}
-
edchin authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I808e52f47db5dbc9ddc609b123be1e10dabde996 Reviewed-on: https://chromium-review.googlesource.com/967889Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544083}
-
https://skia.googlesource.com/skia.git/+log/8d2ba44c9cba..c9a642edf2d1 $ git log 8d2ba44c9..c9a642edf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 bsalomon New read pixels implementation that is simpler but does all conversions on CPU. 2018-03-19 reed handle divide by zero in paint 2018-03-19 herb Remove a ctor from SkAutoGlyphCache; removal continues. 2018-03-19 egdaniel Make sure we set stencil layout when doing copy as draw 2018-03-19 robertphillips Fix GrTextureStripAtlasManager cleanup order bug 2018-03-16 kdonev Support x86 build with VS 2015 2018-03-14 kjlubick [skpbench] Use android's perf settings for Pixel C 2018-03-19 kjlubick Avoid bad alloc in SkReadBuffer 2018-03-19 angle-skia-autoroll Roll skia/third_party/externals/angle2/ dfebe9b2d..3761dc7bf (1 commit) 2018-03-19 caryclark fix op fuzz Created with: roll-dep src/third_party/skia BUG=chromium:820703 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6e098e7b7056791ccf28d22a30e854bc24312c1e Reviewed-on: https://chromium-review.googlesource.com/969117 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544082}
-
Qiang Xu authored
Bug: 818364 Test: manual test Change-Id: I2ca24231dd40478e3ad269d04bde02b613073fc3 Reviewed-on: https://chromium-review.googlesource.com/966490Reviewed-by:
-
erikchen authored
This CL is a refactor and has no intended behavior change. * Rename REFRESH_TYPE_MEMORY_DETAILS to REFRESH_TYPE_SWAPPED_MEM. * Remove MemoryUsageStats and replace with int64_t. Change-Id: I75276508cbdbc67cb6b2d6642e0285733ebcca01 Reviewed-on: https://chromium-review.googlesource.com/965104 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544080}
-
Emily Hanley authored
Bug: 779634 Change-Id: I3ee375b4118b29a1080f5c0859d617e4c4bb624a Reviewed-on: https://chromium-review.googlesource.com/959053Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#544079}
-
edchin authored
This CL pulls a non-trivial amount of code out of TabGridViewController and encapsulates it in a separate UIView subclass. This CL also changes the layout based on orientation for the empty state. Bug: 804557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic1f03445b014a331bdf383e999b522fcbe1b3143 Reviewed-on: https://chromium-review.googlesource.com/967731Reviewed-by:
-
Daniel Bratell authored
Both the new and old code use an identical ClientImpl test class. In jumbo builds those end up in the same translation unit and it won't compile. This patch moves the class to a shared file WorkerFetchTestHelper.h Bug: 680046 Change-Id: Iabe58f2f2c93e4d77fb36c8c454952af994d302c Reviewed-on: https://chromium-review.googlesource.com/968363 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#544077}
-
Matt Mueller authored
Unused since f0747fdc. Change-Id: Ibe0d24c416107f754bf3e835fd1a63000a37a42d Reviewed-on: https://chromium-review.googlesource.com/964983Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#544076}
-
Kai Uwe Broulik authored
R=mukai@chromium.org, thomasanderson@chromium.org Change-Id: Ibacf61f28fde4e6e1e0b52a65c3412118eb96e49 Reviewed-on: https://chromium-review.googlesource.com/955323 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544075}
-
John Budorick authored
This reverts commit 3ee20833. Reason for revert: crbug.com/323342. This only partially removed harfbuzz-ng/src, resulting in weird overlays of files from src.git and harbuzz.git Original change's description: > Manage HarfBuzz dependency using DEPS mechanism > > Remove src/ from Chromium repo and retrieve HarfBuzz sources from the > mirror at [1]. > > Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to > refs/heads/chromium/ of [1]. > > This was tested and confirmed working in:: > https://chromium-review.googlesource.com/c/chromium/src/+/937502 > > [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ > > Bug: 814305 > Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531 > Reviewed-on: https://chromium-review.googlesource.com/928761 > Reviewed-by: Ben Wagner <bungeman@chromium.org> > Reviewed-by: Behdad Esfahbod <behdad@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544043} TBR=bungeman@chromium.org,eae@chromium.org,drott@chromium.org,behdad@chromium.org Change-Id: I1fb32862c33154ac91d6475e8c1b6416fbc330ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814305 Reviewed-on: https://chromium-review.googlesource.com/969185Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544074}
-
Karan Bhatia authored
BUG=812296 TBR=sergeyu@chromium.org Change-Id: I7992566c41b6ab650738d190a6980c8640b29487 Reviewed-on: https://chromium-review.googlesource.com/969096 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544073}
-
jonross authored
Currently RenderFrameMetadata is communicated from the renderer to the browser. The messages are processed right away, even if Viz may have not yet completed the processing of the frame associated to the data. This is racy. This change adds a FrameToken to all of the RenderFrameMetadata messages. The browser side then uses FrameTokenMessageQueue to synchronize these messages. They will now be processed once Viz has completed processing the frame and has notified the browser. TEST=existing viz_content_browsertests TBR=piman@chromium.org Bug: 775103 Change-Id: I52e6d023be5591946c589400374236a2a8e979d6 Reviewed-on: https://chromium-review.googlesource.com/962711Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544072}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c71ecd04. With Chromium commits locally applied on WPT: 78822c6d "Fix sizing of orthogonal elements with percentage margins" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14189 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing TBR=kereliuk No-Export: true Change-Id: I24f2885853158fa3717e0e572c2a1613169f94d2 Reviewed-on: https://chromium-review.googlesource.com/969021 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544071}
-
https://chromium.googlesource.com/catapult.git/+log/fa0f0f2dd7e9..d0c8b3b7d24c $ git log fa0f0f2dd..d0c8b3b7d --date=short --no-merges --format='%ad %ae %s' 2018-03-17 malets Properly handle benchmarks disabled with no named reason. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I4f2b1a7a567ba0b75ecec8d59085eb75f25627ac Reviewed-on: https://chromium-review.googlesource.com/968667 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544070}
-
Sorin Jianu authored
Since the UpdateContext is now a ref counted type, using the iterator adds an unnecessary level of obfuscation. Also, to implement task cancellation, a mechanism is needed to relate the update task and its context, and the iterator is not appropriate for that. TBR: waffles Bug: 822990 Change-Id: I8db51b24e4ef0f9b30f434820fa6d3bd1b066e98 Reviewed-on: https://chromium-review.googlesource.com/966966 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544069}
-
Julia Tuttle authored
Change-Id: I8cfdb966b329d62aed531e0d22be98424e1928c4 Reviewed-on: https://chromium-review.googlesource.com/957165 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/9fa35e528528..d2c8332e2b03 $ git log 9fa35e528..d2c8332e2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib212b904fc2c7a61b831fddb0a713b07f3f7e01f Reviewed-on: https://chromium-review.googlesource.com/968710 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544067}
-
jonross authored
The usage of RenderFrameSubmissionObserver in TouchActionBrowserTest is racy. This change updates the ownership of the observer to avoid that. Bug: 760181 Change-Id: I23eaab201d478a6a8948893f10158e8c9c4c4d44 Reviewed-on: https://chromium-review.googlesource.com/964241Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544066}
-
Stephen McGruer authored
This CL aligns Chromium with the URL spec, such that we consider '#' to mark the end of the content and the start of the fragment section only. GURL::GetContent was updated to reflect this, with a special case for javascript URLs specifically (as their spec mentions including '#' in the URL content). Bug: 123004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 TBR: boliu@chromium.org, pfeldman@chromium.org, thakis@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7 Reviewed-on: https://chromium-review.googlesource.com/738395 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#544065}
-
Jan Krcal authored
This reverts commit 2464913f. Reason for revert: crasher due to semantic changes between nano and lite and lacking unit-tests (crbug.com/822845) Original change's description: > [protobuf] Convert serialized_invalidation from nano to lite > > Bug: 782237 > Change-Id: I030322a93c71eec70fc4a53a4cb21458c63678ee > Reviewed-on: https://chromium-review.googlesource.com/856796 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543322} TBR=nyquist@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782237 Change-Id: Id448b779470070a5e0e2f55708f1a1a194064d02 Reviewed-on: https://chromium-review.googlesource.com/968961Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#544064}
-
