- 24 Aug, 2016 40 commits
-
-
johnme authored
Behind --enable-experimental-web-platform-features flag. Not yet hooked up on Android. Intent to implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discussion Screenshot: https://imgur.com/a/mUdgu BUG=614456 Review-Url: https://codereview.chromium.org/2261283002 Cr-Commit-Position: refs/heads/master@{#414177}
-
lfg authored
If a frame that contains the focused plugin is destroyed, we leave a dangling pointer in the RenderWidget. BUG=640733 Review-Url: https://codereview.chromium.org/2276053002 Cr-Commit-Position: refs/heads/master@{#414176}
-
rbyers authored
BUG=611981 Review-Url: https://codereview.chromium.org/2266353005 Cr-Commit-Position: refs/heads/master@{#414175}
-
garykac authored
BUG= Review-Url: https://codereview.chromium.org/2270063004 Cr-Commit-Position: refs/heads/master@{#414174}
-
zakerinasab authored
Adding nullability support for the ImageBitmap parameter passed to ImageBitmapRenderingContext.transferImageBitmap BUG=588243 Review-Url: https://codereview.chromium.org/2251493003 Cr-Commit-Position: refs/heads/master@{#414173}
-
dcastagna authored
GbmBuffer::CreateBuffer assumed that the buffers allocated by minigbm contained only one plane. This patch let GbmBuffer::CreateBuffer create multi-planar buffers. BUG=618516 TEST=gl_unittests. crrev.com/2262353002 for a YUV test. Review-Url: https://codereview.chromium.org/2279553002 Cr-Commit-Position: refs/heads/master@{#414172}
-
einbinder authored
This is in preperation for CodeMirror-based console BUG=607690 Review-Url: https://codereview.chromium.org/2269183003 Cr-Commit-Position: refs/heads/master@{#414171}
-
jsbell authored
Although key path evaluation is always done against clones (so getters are flattened into simple data properties), property lookups were not restricted to inherited properties, allowing getters on prototypes to be executed. This allows evaluation to be observable, and cause side effects. Restrict the lookup to own properties, and introduce special-case code for those non-own values identified in the spec[1] as special cases. [1] https://w3c.github.io/IndexedDB/#key-path-construct BUG=637963 R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2255413004 Cr-Commit-Position: refs/heads/master@{#414170}
-
yamaguchi authored
Chrome has been using the readonly field returned by GetDeviceProperties in cros_disks API to tell whether a disk device is wriatble or read-only. However, the field is based on the physical writablilty of the block device, not reflecting the "ro" flag passed to the mount command. This will be an issue once we introduce read-only mount policy. DiskMountManager needs to remember it because neither the "mount completed" and "disk profile got" DBus messages doesn't convey that information at the moment. TEST=chromeos_unittests, and manually see that Files app shows no-entry icon when you drag a file to an external storage device from Drive. Apply patch 2248033003 locally to simulate the external_storage_read_only option. BUG=629945,640579 Review-Url: https://codereview.chromium.org/2230713003 Cr-Commit-Position: refs/heads/master@{#414169}
-
dcheng authored
BUG=none Review-Url: https://codereview.chromium.org/2250883003 Cr-Commit-Position: refs/heads/master@{#414168}
-
janeliulwq authored
On MD user menu, vertical spacings in the profile card used to be hardcoded, hence causing some display problems on certain locales (see first bug for how Hindi names would get chopped off). This CL calculates the spacing needed given the height of the profile name label and/or username label in the profile card, hence fixing the chopped-off problem - see a new screenshot here: https://screenshot.googleplex.com/FHK5snyG0PH. BUG=636321 BUG=615893 Review-Url: https://codereview.chromium.org/2230963004 Cr-Commit-Position: refs/heads/master@{#414167}
-
dgrogan authored
They only flake on mac_chromium_rel_ng. I couldn't reproduce locally. BUG=632816 Review-Url: https://codereview.chromium.org/2277893003 Cr-Commit-Position: refs/heads/master@{#414166}
-
bajones authored
Temporary code path that invokes fullscreen in lieu of proper VR presentation. Also includes VRDisplayEvent and related code + casing change to VRPose "timestamp" attribute to match spec. BUG=389343 Review-Url: https://codereview.chromium.org/2265053004 Cr-Commit-Position: refs/heads/master@{#414165}
-
dalecurtis authored
This restriction is artificial; or at least I can't make it fail when the profile changes. The hardware decoders I've tried (Android, Windows, Mac) don't seem to care if the profile actually changes. In fact, MSE has always lied about the h264 profile (!), it always specifies H264PROFILE_MAIN regardless of the actual profile. The only parser sending this information correctly is the TS parser used by Chromecast -- which then hits this check. If the profile is actually unsupported we will still fail during the check of SupportedProfiles. BUG=640269 TEST=http://storage.googleapis.com/dalecurtis/mse_profile_change.html Review-Url: https://codereview.chromium.org/2273793002 Cr-Commit-Position: refs/heads/master@{#414164}
-
qyearsley authored
This is a refactoring change that shouldn't affect behavior. Pros: - Removes a method; makes set-up of Command classes simpler. - Net decrease in lines of code. Cons: - Requires explicitly setting self._tool in all subclasses of AbstractRebaseliningCommand in the execute method. Review-Url: https://codereview.chromium.org/2276713002 Cr-Commit-Position: refs/heads/master@{#414163}
-
fgorski authored
* Adding observer of Request Coordinator (as user data) * Forwarding the notifications from observer to OPNotificationBridge * Making RequestCoordinator capable of supporting user data * Minor fixes to interfaces (virtual destructors added) BUG=630817 R=dimich,petewil Review-Url: https://codereview.chromium.org/2260963003 Cr-Commit-Position: refs/heads/master@{#414162}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae022b60c580..5bcf2c70f4dd $ git log ae022b60c..5bcf2c70f --date=short --no-merges --format='%ad %ae %s' 2016-08-24 nednguyen Show trace's url in CSV output formater. 2016-08-24 oysteine Added a demo mapper for the trace processor 2016-08-24 rmcilroy [memory-metric] Extract v8:code_and_metadata from all memory dumps 2016-08-24 erikchen Add CPU metrics for Chrome on Mac. 2016-08-24 petrcermak [merge-traces] Support multiple sub-traces in a vulcanized HTML trace 2016-08-24 benjhayden Fix single-sample Histogram sample diagnostics 2016-08-24 nednguyen [Telemetry] Add browser_test_runnner.LoadAllTestsInModule method BUG=640054,636153 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2277473005 Cr-Commit-Position: refs/heads/master@{#414161}
-
justincohen authored
BUG= Review-Url: https://codereview.chromium.org/2275843003 Cr-Commit-Position: refs/heads/master@{#414160}
-
eugenebut authored
s/stringResultHandler/completionHandler BUG=None Review-Url: https://codereview.chromium.org/2272133002 Cr-Commit-Position: refs/heads/master@{#414159}
-
rnephew authored
BUG=615157 Review-Url: https://codereview.chromium.org/2198613002 Cr-Commit-Position: refs/heads/master@{#414158}
-
fsamuel authored
Prior to ArrayDataView, during deserialization, we read latency components outs into a mojo::Array and then read the mojo array out into LatencyInfo's latency_components_. This results in an unnecessary extra copy and is not compatible with usage in blink. This CL moves us towards using ArrayDataView. BUG=629566 Review-Url: https://codereview.chromium.org/2276743002 Cr-Commit-Position: refs/heads/master@{#414157}
-
rickyz authored
Also adds some basic integer overflow checking and fixes undefined pointer arithmetic in preexisting bounds checks. BUG=631375 Review-Url: https://codereview.chromium.org/2182873003 Cr-Commit-Position: refs/heads/master@{#414156}
-
hcarmona authored
BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2275753002 Cr-Commit-Position: refs/heads/master@{#414155}
-
jinsukkim authored
Makes sure ScopedAnchorView::Reset() removes the anchor view from its container view through JNI. This prevents potential leaks when the destructor fails to do the cleaning job. Not apparently related to the bug, but it helps avoid any issues that may happen in the future. Also deleted a method declaration of |SetWindowAndroid| sneaked in by mistake. BUG=635515 Review-Url: https://codereview.chromium.org/2272673003 Cr-Commit-Position: refs/heads/master@{#414154}
-
jaydasika authored
And use it to update transform animations directly instead of routing the updates through layers. This CL also changes element_layers_maps to hold layer_id instead of layer so that we can get the property tree index for animation update without accessing LayerImpl BUG=638297 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2269143003 Cr-Commit-Position: refs/heads/master@{#414153}
-
qyearsley authored
If android_blink_rel is included in the list of try bots, then using git cl try with all of the try bots including that one will fail. Some alternative possible solutions: - Make an explicit special case for android_blink_rel, starting that one in a separate command. - Remove android_blink_rel from the list of builders again. - Remove android_blink_rel only from the list of builders triggered here. Review-Url: https://codereview.chromium.org/2269253002 Cr-Commit-Position: refs/heads/master@{#414152}
-
ivanhernandez authored
The script will be loaded at the start of the program and hang until it is needed later on in the unpacking step. Review-Url: https://codereview.chromium.org/2243863003 Cr-Commit-Position: refs/heads/master@{#414151}
-
aluo authored
BUG=627916 Review-Url: https://codereview.chromium.org/2142413004 Cr-Commit-Position: refs/heads/master@{#414150}
-
pkotwicz authored
For instance, an upgraded WebAPK should not be requested if the Web Manifest was updated to no longer have a start_url BUG=627824 TEST=ManifestUpgradeDetectorTest.testWebManifestNotWebApkCapableShouldNotUpgrade Review-Url: https://codereview.chromium.org/2262583002 Cr-Commit-Position: refs/heads/master@{#414149}
-
estevenson authored
Previous: https://codereview.chromium.org/2271673002/ Currently, all resources are included in PAK files when Chrome is built locally. Only official_buildbot.sh uses a resource whitelist. This CL enables local builds to use resource whitelisting by setting the enable_resource_whitelist_generation gn flag to true, or by building an official build. This will allow developers to more easily monitor the changes in APK size for each commit they make. However, a large amount of output is generated (_pragma is used to create warnings to allow whitelisted resources to be listed), so for now the whitelist will only be generated for official builds. This change results in a ~1.5 mb difference when calculating the APK size with resource_sizes.py. BUG=632385 Review-Url: https://codereview.chromium.org/2272713004 Cr-Commit-Position: refs/heads/master@{#414148}
-
jkarlin authored
Blink objects were storing cache objects so that they could be returned quickly on subsequent open calls. This is problematic as there can be many contexts (different windows, workers, service workers, and dev tools) opening/deleting caches. If one of them deletes the cache then all of the others need to be invalidated. Rather than synchronize the various contexts, for now just remove the stored caches from Blink. BUG=639034 Review-Url: https://codereview.chromium.org/2270413003 Cr-Commit-Position: refs/heads/master@{#414147}
-
denniskempin authored
This pointer type can be used by graphics tablets, frequently the back-side of a stylus. BUG=636458 TEST=Use rubber tool and watch generated mouse events. Review-Url: https://codereview.chromium.org/2235933002 Cr-Commit-Position: refs/heads/master@{#414146}
-
kylechar authored
GLImageOzoneNativePixmap was previously moved from //ui/gl to //ui/ozone/gl. The related tests were not moved at the same time. This CL moves the tests to a new target //ui/ozone/gl:ozone_gl_unittests. The exists ozone_unittests target does not have an appropriate TestSuite for running GL tests, so a different target is required. The existing TestSuite for GL tests is placed in a source_set so it can be used by both gl_unittests and ozone_gl_unittests. Add the new ozone_gl_unittests target to the Ozone Chrome OS trybot. Finally, remove some unneeded DEPS rules now that the tests have been moved. BUG=611142 Review-Url: https://codereview.chromium.org/2254303002 Cr-Commit-Position: refs/heads/master@{#414145}
-
erikchen authored
Previously, GL state set by render pass drawing would be carried over. BUG=640151 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2273473003 Cr-Commit-Position: refs/heads/master@{#414144}
-
pkotwicz authored
The check is already done in InstallableManager. BUG=None TEST=InstallableManagerBrowserTest.CheckManifestCorruptedIcon Review-Url: https://codereview.chromium.org/2274273002 Cr-Commit-Position: refs/heads/master@{#414143}
-
jamescook authored
This is a step towards eliminating ash::Shelf. Also remove ash::shell::ShelfDelegateImpl so we don't have to maintain multiple stub implementations. BUG=615502 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2279533002 Cr-Commit-Position: refs/heads/master@{#414142}
-
yuweih authored
Currently the touch feedback animation texture is a intricate radial gradient which doesn't look very good under the new OpenGL renderer. This CL changes to use a simpler texture design that is consisted of a dark circle inside a white ring, which would further match the ink ripple spec of material design. BUG=638425 Review-Url: https://codereview.chromium.org/2272793003 Cr-Commit-Position: refs/heads/master@{#414141}
-
vakh authored
Also add an entry for hash prefix map generation. BUG=543161 Review-Url: https://codereview.chromium.org/2261173006 Cr-Commit-Position: refs/heads/master@{#414140}
-
cbiesinger authored
This patch does a few things: - Adds and uses an NGFragmentBuilder to create fragments - Code style/variable and function naming cleanup in NGFragment - Use the structs from ng_units in NGFragment to store sizes R=eae@chromium.org,ikilpatrick@chromium.org BUG=635619 NOTRY=true Review-Url: https://codereview.chromium.org/2270983002 Cr-Commit-Position: refs/heads/master@{#414139}
-
dougarnett authored
so that TabAndroid::GetBookmarkId will work with only Downloads UI feature flag and no other offline pages feature flags enabled. BUG=639802 Review-Url: https://codereview.chromium.org/2277003002 Cr-Commit-Position: refs/heads/master@{#414138}
-