GitLab

These are directly applied by the session manager which can not resolve them. 

It fixed an issue with the flags stored in the device settings being the flag names and not the actual switches as is required by the session manager causing the flags not to be applied to the login screen if the flag and the switch don't happen to coincide and to browser restarts even for the owner which should not happen.

BUG=280935
TEST=Unit tests + manual testing as described in the bug.

Review URL: https://chromiumcodereview.appspot.com/23983031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223353 0039d316-1c4b-4281-b951-d872f2087c98

The file build/sanitize-png-files.sh was moved to
tools/resources/optimize-png-files.sh in http://crrev.com/221030. This CL
updates chrome/app/theme/README to point to the new path.

R=oshima@chromium.org
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23440043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223352 0039d316-1c4b-4281-b951-d872f2087c98

This should be a little faster, since we don't need to start a second thread.
More importantly, it better reflects what V8VarConverter does in production code.

BUG=
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/23522043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223351 0039d316-1c4b-4281-b951-d872f2087c98

R=machenbach@chromium.org
BUG=246567

Review URL: https://chromiumcodereview.appspot.com/23456033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223350 0039d316-1c4b-4281-b951-d872f2087c98

The Service.Error property is getting cleared before the notification is
displayed; we need to pass it to the notification when we detect the
error. (ErrorDetails should not be getting cleared).

BUG=291370
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/23522050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23892003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223348 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223347 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/23506041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223346 0039d316-1c4b-4281-b951-d872f2087c98

For zero-sized values, we'd previously pass NULL to std::copy, which is
not OK though if the number of elements to copy is 0. Avoid the copy
altogether and cover this situation in the unit test.

BUG=None
R=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/23704008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223345 0039d316-1c4b-4281-b951-d872f2087c98

This fixes memory leaks in UploadFileElementReader and UploadDataStream tests.

BUG=290897
R=rsleevi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23872030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=289130
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/23819066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223343 0039d316-1c4b-4281-b951-d872f2087c98

For Android and Cras, returning just the default device matches
current behavior for input devices, although this may need to be
improved in the future. For OpenBSD, the current code seems to rely on
the device names list being empty, so just removing the NOTREACHED() in
AudioManagerBase's empty implementation does the trick there.

Note that audio_input_device_unittest.cc really should be named
audio_manager_unittest.cc since AudioManager is the interface it tests.
I will do this rename in a separate follow-up change to better
preserve change history.

TBR=vrk@chromium.org
BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23475037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223342 0039d316-1c4b-4281-b951-d872f2087c98

 - race on IPC::SyncChannel::ReceivedSyncMsgQueue::lazy_tls_ptr_ (issue 273047)
 - race in the PostponeInterruptsScope ctor (issue 290964)
 - races on CommandLine::current_process_commandline_ (issue 268946)

BUG=273047,290964,268946
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/23503059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223341 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows the ExternalPolicyDataUpdater and ResourceCache classes to
be used in the blocking pool. It is a prerequisite for CL 22562003 which
will add code to downloading and caching of external policy data that runs
in the blocking pool and uses these classes.

BUG=256635
TEST=Updated unit tests

Review URL: https://chromiumcodereview.appspot.com/23868021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223340 0039d316-1c4b-4281-b951-d872f2087c98

Disable the EXT_discard_framebuffer extension on ARM GPUs (e.g., Nexus
10) as it is causing dropped frames and flickering.

This patch also exposes the EXT_discard_framebuffer extension on
pre-OpenGL ES 3.0 drivers which support it.

Tested on Nexus 10, Nexus 4 and Galaxy S4.

BUG=290876

Review URL: https://chromiumcodereview.appspot.com/23629043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223338 0039d316-1c4b-4281-b951-d872f2087c98

Use the base/ wrapper instead.

BUG=290232

Review URL: https://chromiumcodereview.appspot.com/23597042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223336 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4c136fe1.

This CL was causing some layout tests to fail, so reverting until it is fixed.

TBR=abarth@chromium.org

BUG=

Review URL: https://codereview.chromium.org/23483044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223335 0039d316-1c4b-4281-b951-d872f2087c98

Add a method ManagedUserSyncService::UpdateManagedUserAvatar to update the avatar of an existing managed user.

Update ManagedUserRegistartionUtility::Register to call the above method when a managed user is being imported and updating his avatar is required.

BUG=292415

Review URL: https://chromiumcodereview.appspot.com/23691045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223333 0039d316-1c4b-4281-b951-d872f2087c98

Once EME stuff has moved from content/ to chrome/ one method was renamed everywhere except for one place that is only compiled on the official release Android bots (with branding=='Chrome' and OS=='android').

BUG=None
TBR=ddorwin
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23503055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223332 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg
BUG=282712

Review URL: https://chromiumcodereview.appspot.com/23902027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223330 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223328 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dslomov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23958009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223327 0039d316-1c4b-4281-b951-d872f2087c98

This implementation obsoletes PolicySchema and its existing users will be refactored.

This implementation has the advantage of allowing compile-time static data to be generated and quickly loaded at runtime. That will allow building the Chrome policies schema without impact on startup.

BUG=270667
TBR=joi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23851022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252217

Review URL: https://chromiumcodereview.appspot.com/18032002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223324 0039d316-1c4b-4281-b951-d872f2087c98

Delay discovery service restart by 10 sec.
Added IPs VLOG.

TBR=noamsml
BUG=284673

Review URL: https://chromiumcodereview.appspot.com/23709010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223322 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of the plan to support gfx::FontList in UI components. 
https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/edit

BUG=265485
TEST=Ran message_center_unittests

Review URL: https://chromiumcodereview.appspot.com/24084003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223321 0039d316-1c4b-4281-b951-d872f2087c98

Add the supervised user placholder icon. It will be displayed on the managed user import overlay for managed users with no stored avatar.

BUG=291021
R=oshima@chromium.org, sergiu@chromium.org

Review URL: https://codereview.chromium.org/23477069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223319 0039d316-1c4b-4281-b951-d872f2087c98

Move the rest of chrome/common/extensions/extension_manifest_constants to
extensions/common/manifest_constants.
s/extension_manifest_[values|errors]/extensions::manifest_[values|errors]

Remove include of manifest constants in ~20 files that didn't use it.
Fixed small nits when I found (taking out unnecessary extensions::, etc).

TBR=davemoore@chromium.org (c/b/chromeos/)
TBR=pkotwicz@chromium.org (c/b/themes/)
TBR=thakis@chromium.org (c/b/ui/cocoa/, c/renderer/)
TBR=dimich@chromium.org (c/b/ui/panels/)
TBR=sky@chromium.org (c/b/ui/views/)
TBR=finnur@chromium.org (c/b/ui/webui/extensions/)

BUG=159265

Review URL: https://chromiumcodereview.appspot.com/23744004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223318 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223315 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a bug wherein a non-fatal crash report would prevent subsequent (fatal or non-fatal) crash reports in the same browser process from being counted in the histograms.

It has been further expanded to define separate histograms for crashing, non-crashing and total-number-of attenoted crash reports.

R= cpu, jar, rvargas, grt
BUG= 290196

Review URL: https://chromiumcodereview.appspot.com/23453032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223314 0039d316-1c4b-4281-b951-d872f2087c98

The previous approach did not work, not sure why. Here we take the more
standard approach.

It fails with Aura enabled, but it is the only one to do so and only on XP.

BUG=292299
TBR=mpcomplete

Review URL: https://codereview.chromium.org/23503054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223313 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223312 0039d316-1c4b-4281-b951-d872f2087c98

1731: ninja: Add .a files in a deterministic order to link lines.

BUG=280718
TBR=scottmg

Review URL: https://codereview.chromium.org/23965005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223311 0039d316-1c4b-4281-b951-d872f2087c98

We switched to Aura on Windows and its bigger, the chrome.dll size. By about 1.6 megs.

Not sure what I am doing, the command was

python update_perf_expectations.py -f xp-release/sizes/chrome.dll/chrome.dll --reva 223293 --revb 223296

Where 223293 was the revision were it got larger.


BUG=none
TEST=none
TBR=maurel

Review URL: https://codereview.chromium.org/23547014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/23498031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223309 0039d316-1c4b-4281-b951-d872f2087c98

This makes the keyboard button actually hide the keyboard. Note that we achieve this by exposing the hide keyboard functionality as an extension API. This is stubbed in for WebUI but is not yet implemented.

Note that this leaves a known issue where tapping a text field, hiding a keyboard, and retapping that already-focused text field does not deploy the keyboard a second time (you'd have to unfocus the text field first).


BUG=236925

Review URL: https://chromiumcodereview.appspot.com/20526005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223308 0039d316-1c4b-4281-b951-d872f2087c98

Merge Allocate+Start, Stop+DeAllocate. 

Move the non-IO thread parts of VideoCaptureController, which were 
precisely the VideoCaptureDevice::EventHandler implementation, into a 
new class VCC::VideoCaptureDeviceClient, which retains only a WeakPtr 
to the VCC. 

Change the contract between VideoCaptureDevice and its client so that 
(1) The Start+Allocate, and Stop+DeAllocate phases of VCD are merged, 
and (2) the VCD owns its EventHandler*; which is to say, the VCD owns 
the VideoCaptureDeviceClient. 

The merging of the phases is justified because it will eliminate 
intermediate states from the 6+ implementations of the 
VideoCaptureDevices. 

The new VCD::EH ownership model is justified because it will enable 
some of the impls (MFWin, desktop capture, and tab capture, at least) 
to eliminate locks protecting the EventHandler* from being 
synchronously removed at the DeAllocate() step. 

Rather than make deep changes to each VCD implementation with this 
change, the interface changes to VideoCaptureDevice are effected 
through a new shim class, VideoCaptureDevice1, which bridges the old 
and new interfaces. Follow-on changes will eliminate this shim class, 
one VideoCaptureDevice implementation at a time. 

BUG=285562, 285569
TEST=unittests,basic webcam interaction

Review URL: https://chromiumcodereview.appspot.com/24133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223307 0039d316-1c4b-4281-b951-d872f2087c98

For Android renderer processes, base::i18n::SetICUDefaultLocale was not
called. So base::i18n::IsRTL() returned incorrect value which made
offline error html page's text direction incorrect. Therefore, call
base::i18n::SetICUDefaultLocale on renderer process initialization.

BUG=288371

Review URL: https://chromiumcodereview.appspot.com/24127003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223306 0039d316-1c4b-4281-b951-d872f2087c98

This CL plumbs pointers from the inner/outer-viewport layers and page scale
layer into CC from Blink. At present this has no effect on CC unless
--enable-pinch-virtual-viewport is specified on the command line.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23922006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223305 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23629032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223304 0039d316-1c4b-4281-b951-d872f2087c98