- 10 Nov, 2020 40 commits
-
-
Ilya Nikolaevskiy authored
Bug: chromium:1134073 Change-Id: I8caa32dcc0443519981e3f8206701c2649819385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529356 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825893}
-
Yue Li authored
Bug: b/159670857 Test: Run existing tests Change-Id: I93e809c9f96e8a8c705cc43b144ecf2ae4d86625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518724Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#825892}
-
spdonghao authored
Bug: 1083428 Change-Id: I3f920bc0669b7e87c3b266e342ac85adff503695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519208Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#825891}
-
Eric Robinson authored
I've also declared a few histograms as obsolete where it seemed appropriate to do so and removed the corresponding code and tests. Bug: 1143730 Change-Id: I28f75c9e25f6daab4dceeb20ed4f6fc90d6260a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424064 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#825890}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011100600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/6EdcOM96U0hrdmIp_UAwPgUiN6Cs86TLI-B-7wQAFR0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159267911,b/172616107,b/172775363,b/172811994 Tbr: media-app@grotations.appspotmail.com Change-Id: Idee6fdcba8bcf103ab6fa47febcde99e88bffa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825889}
-
Mike Wasserman authored
Move WebContentsDelegate Bluetooth interface to BluetoothDelegate (RunBluetoothChooser and ShowBluetoothScanningPrompt) Make callers use the ContentBrowserClient's BluetoothDelegate instead. Consolidate android/desktop/extension impls into Chrome delegate. WebView continues not implementing this functionality. Remove unused CastWebView delegation layer. Wire up test delegates and ContentBrowserClients as needed. Move Shell impl/delegation for web test to FakeBluetoothDelegate. Bug: 1048325 Test: No regressions of Web Bluetooth functionality. Change-Id: I0f39a46dbea386ed5ad8e461d7dc25ec81806fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520216 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#825888}
-
Devlin Cronin authored
There's a check in ExecuteCodeFunction that extension()::id() is non-empty, but this is unnecessary. Every extension object necessarily has a non-empty extension ID, and if that ever changed, many, many other things would explode long before this check were reached (for instance, we wouldn't be able to associate the extension with the function, since it's retrieved by ID). Bug: None Change-Id: Id967398b43885e21792c5679fdfd236179157434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518118 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825887}
-
Manuel Rego Casasnovas authored
The method was getting the |container_content_size| as argument, but it was only used to compute the |container_physical_content_size|. The callers have already computed the |container_physical_content_size| before calling this method, so we can simply pass it and avoid recomputing it here. BUG=1098231 Change-Id: I254256dd67123094086f3caa523735893a7b754e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529163 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825886}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/952ef3e06472..8da8bcdf92fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I716169e11285ac7f1c08abb0d8462c6eb71d60c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825885}
-
Shrek Shao authored
The newly added clientRenderingAPI metrics is missing from ukm dashboard Adding <enumeration/> tag should fix the issue. Bug: 1147230 Change-Id: Ia9ee0ec673fec3db8daaacbdc6fa1ff1558fa121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527565Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#825884}
-
Joshua Peraza authored
Bug: chromium:912138 Change-Id: Ifee9197731789b3a113ebefe188f95447c126187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526946Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#825883}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604987499-9d0e7b1f2ad8a8a8d61e84a818ba5c2f2988369e.profdata to chrome-win64-master-1604998756-dde3841da8adecb7243697161fbddafddb9cdeef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic151f4dc56bf1c5b876e5cfe4494a8fcc6ce4fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529177Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1143666 Change-Id: I17ea892172fd2cad26cf711f4313b7385c1de4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529551Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#825881}
-
Mason Freed authored
This test takes almost the full 6s (or longer depending on the build) timeout available. It recently started causing flaky CQ retries, so I'm moving it to SlowTests. If it continues hitting the timeout, it likely needs more direct intervention (fixing the test). Fixed: 1145716 Change-Id: I160b3a8192e43fd53f4552d484313fb63b9792cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529571 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825880}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2517220 This CL makes sure that the build is run on a Windows machine, so that a Windows binary is produced. Otherwise, attempting to run a test on a Windows machine will fail. Bug: 1121427 Change-Id: Iebc07694b09f943b65fe0b89480e9dcf512fef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526642 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825879}
-
Kartik Hegde authored
Add the HttpFirewall routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied HttpFirewall changes and successfully ran the HttpFirewall routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=http_firewall). Change-Id: I15c568de9f4c5c55258240862b6e76a84ea96434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482085Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#825878}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6c4690e0c59f45c077b5093f82109887aaf23483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528578Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825877}
-
kylechar authored
With CrOS unified desktop the unified display skips drawing and instead the physical displays embed the unified display surface. This means that surface and hit test data aggregation happens for the physical displays. However, hit testing still happens on the unified display in the browser process. For OOPIF content the hit test data is missing and events are routed to the wrong renderer process. As a result, OOPIFs never receive events. This CL fixes OOPIF hit testing on the unified display by ensuring surface and hit test aggregation happens there and hit test data is sent back to the browser process. Bug: 1085860 Change-Id: I2e0809bf58d2c9fd949f815d59f3f0056d6f9590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523417 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825876}
-
chrome://nearbyCurt Clemens authored
Parse query string parameters such as chrome://nearby/share?text=hello and use them to create a text attachment. Facilitates testing of text attachment types. File attachments will be covered in a followup CL. Bug: 1145684 Change-Id: I9cd6ddc881143300f8bef7d1abf4a4cd8339ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528310Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#825875}
-
danakj authored
The browser clipboard code receives SkBitmaps from 3 sources: - mojom::ClipboardHost::WriteImage() mojo IPC from the renderer - mojom::ImageDecoder::DecodeImage() mojo IPC reply from the renderer - ImageSkiaRep which can hold an SkBitmap set elsewhere Note also that mojom::ImageDecoder::DecodeAnimation() also receives SkBitmaps from the renderer, and we generate ImageSkiaReps from them. The windows drag+drop code receives SkBitmaps from: - mojom::FrameWidgetHost::StartDragging - ImageSkiaRep which can hold an SkBitmap set elsewhere Various drag and drop, and clipboard code then either assume the SkBitmap is an N32 (aka ARGB8888) format, or convert the SkBitmap into that format. But it's very easy to miss doing this correctly. On windows, the Clipboard and DragAndDrop code both convert the SkBitmap into an HBITMAP. The Clipboard code was converting the SkBitmap to an N32 type, while the DragAndDrop was just assuming it would be correct. We improve the robustness of this code by immediately converting (or checking and failing), when receiving an SkBitmap from the renderer that will be going into Clipboard or DragAndDrop, that the image is the correct color type. About HBITMAP interactions: The native HBITMAPs that we create and use with SkBitmaps are backed by 32bpp XRGB (or ARGB in the V4 case) buffers. These buffers do not have any padding past the end of each row. XRGB refers to the high-order 8 bits being ignored, as V3 HBITMAPS do not have an alpha channel: https://docs.microsoft.com/en-us/previous-versions/dd183376(v=vs.85) We expect any SkBitmaps that we use with HBITMAPs to match the same format, to have the same component order and size. A mismatch in order would result in bad image data. A mismatch in size can lead to a buffer overflow if the SkBitmap has larger components than the HBITMAP and is copied into it. We clarify by adding the format to the helper function names, and we add an overload for making an HBITMAP header from an SkBitmap directly which can CHECK that the bitmap is correct. Other callers will see the expectation clearly in the function name, and should check accordingly. We also remove PlatformCanvasStrideForWidth() as it always uses 32bpp with no padding on each row. This is an abstraction that is not used (any longer?). This makes it easier for the code to know when values are actually hard-coded constants and act accordingly. R=sky@chromium.org Bug: 1144462 Change-Id: Ice9090aae633b805f3f0fe0f94b10f014b9c3ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518931Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#825874}
-
James Vecore authored
Previously for testing purposes Nearby Share was enabled by default. This was starting to cause problems with testing once the zero state (no visibility selection by default) was introduced because the feature would be enabled with no valid visibility setting. Change-Id: I51be16d557d0802ac1dfe77dced128a7dfd7fa34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527571 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825873}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8da8bcdf92fb..81e9301838fc 2020-11-10 treehugger-gerrit@google.com Merge "Remove idle page checker." 2020-11-10 lalitm@google.com Merge "tp: implement refcounting of packet sequence generations" 2020-11-10 skyostil@google.com Merge "debian: Run tracing service under a dedicated user" 2020-11-10 treehugger-gerrit@google.com Merge "Add trace metric to root cause jank in SysUI CUJs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icb0a844cdf21fafb49b3c8632bb9e08d04a3f1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529194Reviewed-by:
-
spdonghao authored
Allow active layout to be null in LayoutManagerChromePhone#tabCreating. Bug: 1140406 Change-Id: Ic4104a29689892bbe9101ad3f7d3b4d4018aaece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527684Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This will be responsible for aggregating freezing votes and upstreaming a voting decision to a voting consumer (the FreezingDecorator in practice). Bug: 1144025 Change-Id: I052fb9d4728ae05943231f326e73906d03f6361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505591 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#825870}
-
Jeffrey Kardatzke authored
BUG=chrome:1146654,chrome:1146790,chrome:1146796,chrome:1147124 TEST=Fuzzer passes repro test cases Change-Id: Id36ad705e101279dad47c2d8fdb7ab1f59adec36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527902Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#825869}
-
Chris Sharp authored
Clarify the DeviceBatteryChargeCustomStartCharging and DeviceBatteryChargeCustomStopCharging description Try to clarify that these policies are based on the battery charge percentages BUG: b:172840601 Change-Id: I9df5a4a43043600372a777a2c80b9c1375998334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527908Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#825868}
-
Joe Downing authored
This CL adds a structure which contains the interesting fields in an ETW EVENT_TRACE along with some helper functions to parse and display it. Future CLs will add the logic to redirect the output to a new location (likely based on registry settings). I've kept that out of this CL to keep it on the smaller side. Bug: 1144185 Change-Id: I24c419227f7360424c6809db6409cf367aaf7eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527364Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#825867}
-
Swapnil authored
When a force installed extension fails to install with error CRX_HEADER_INVALID and it is an offstore extension which is downloaded from the the server, it should be considered a misconfiguration as the extension developers are serving bad CRX. Bug: 1067602 Change-Id: I5a9be2c0695740cf1fce6670c32d2218e8bfbc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507657 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#825866}
-
Weilun Shi authored
Register EntropySourceProvider in ios_chrome_metrics_service_client so that all iOS reports will have low entropy source values populated. Bug: b/172461970 Change-Id: Ib216094ed532824fde69f97c7c772bf7bbabd25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528308Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#825865}
-
yilkal authored
This cl updates the default terms of service version number to the first Google3 cl number that contains all the terms of service strings for the EduCoexistence flow. Bug: 1134682 Change-Id: Icd4fc4f3d17b6cb83612a8c43fa61b9b24ce76d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527758Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Peter E Conn authored
This is a follow up from questions left in: https://chromium-review.googlesource.com/c/chromium/src/+/2510271 Chrome previously expected the TWA shell to provide it with appropriate values for the SKU value (a string with the currency sign removed) and the purchase time (in microseconds, not milliseconds). With this CL we standardise on this, expecting that the response code is in the mojo format instead of a Play Billing one. This is because the TWA shell may not get that information from Play Billing (it coule be using a different store), so it doesn't make sense for other stores to have to convert their codes to Play Billing codes first. Change-Id: I0d11eefdacc085b629373ba3bc7dc2568583577a Bug: 1139795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521819 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#825863}
-
Lijin Shen authored
Use ButtonCompat instead to represent a text button. Bug: 1123947 Change-Id: Ibe75a7fc47d602a3a61625aa0a24fe35d7ba0c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524963 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#825862}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I4370b4f1305a721a911804ccce830cde4c6052ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527887Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825861}
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the content_settings::Observer Bug: 1134547 Change-Id: I2bbb133b29cd274de62faab5ba5db9eb330341ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526084 Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#825860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7c5d0ecc59d..1bc8d7d3cf8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hbos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hbos@google.com Change-Id: I2725777a3c49c94dd6ee4ac396ede8fe0550a6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528619Reviewed-by:
-
Paul Moy authored
The diagnostics portion of cros_healthd's Mojo API will soon need access to nullable primitives in order to make routine parameters like urandom's uint32 length_seconds parameter optional. Factor out the existing nullable primitives from the probe API, and create a common file for nullable primitives. Bug: chromium:1131609 Change-Id: I33a3847966eafe3a77ae25437b4d4296120be656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477422Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011100600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Ly_iBRyRFPeLm1Uv4G-1csjeI7KpsnlQ81ABJEDJRdcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159960286 Tbr: help-app@grotations.appspotmail.com Change-Id: Ifc795ff59e7348a3fb8127282c95c1f70232d9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529184Reviewed-by:
-
Clemens Arbesser authored
This change moves the Autofill Assistant settings into a separate screen and adds a new toggle for proactive help. The Autofill Assistant sub-section is now initially visible to all users (as opposed to before where it would just appear after the first use). Other smaller changes: - the link to the settings in the assistant's bottomsheet now points to the new page - Rejecting the onboarding now leaves the preference unset instead of setting it to false. Bug: b/168178344 Change-Id: I76f419a46598cddb003d95ac8be317c21de72a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505875 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825856}
-
Gayane Petrosyan authored
Bug: None Change-Id: I308907a247ab9c7ba99f354eedab7672e4fb8a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527681Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Split networks list into default and cellular - Cellular contains eSIM, SIM and Tether networks - Add new string describing each network Screenshot: https://screenshot.googleplex.com/7EE62daLS47D2Y2.png Design: https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g9091f1bab9_0_26 Bug: 093185 Change-Id: I4545cb272b086dfe7e9f64037a51465fc5ff80a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505937 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825854}
-
