GitLab

SymbolizationLoop.process_line() has been factored out and can now be used to symbolize the reports line by line.

BUG=235466
NOTRY=true

Review URL: https://codereview.chromium.org/397983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283547 0039d316-1c4b-4281-b951-d872f2087c98

In order to track UMA accurately we only need to track it when there is an actual prompt for permission, not when the permission was saved for the domain. I have re-purposed the PermissionDecided method for this which was essentially doing nothing before.

BUG=392145
TBR=fgorski,tommi

Review URL: https://codereview.chromium.org/371933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283546 0039d316-1c4b-4281-b951-d872f2087c98

The previous code writes the parsed metadata to |metadata| dictionary
remembered in |this.rootParser_|, but this is wrong.

The parser class is shared among multiple parses, so to correctly
distinguish concurrent parsing activity, it cannot store states
in the member fields.

BUG=172989

Review URL: https://codereview.chromium.org/391313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283545 0039d316-1c4b-4281-b951-d872f2087c98

|willRequestAfterPreconnect| was removed from blink::WebFrameClient at
blink r178134, thus this override is never called.

BUG=386888

Review URL: https://codereview.chromium.org/395093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283543 0039d316-1c4b-4281-b951-d872f2087c98

(This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later.)

R=davidben@chromium.org, eroman@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/345063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283542 0039d316-1c4b-4281-b951-d872f2087c98

video_decoder_shim.cc uses libyuv, and the build fails if we're not
building in component=shared_library mode and enable_webrtc=0:

In file included from ../../third_party/libyuv/include/libyuv.h:15:0,
                 from ../../content/renderer/pepper/video_decoder_shim.cc:25:
../../third_party/libyuv/include/libyuv/compare.h:14:32: fatal error: libyuv/basic_types.h: No such file or directory
 #include "libyuv/basic_types.h"
                                ^

R=dmichael@chromium.org, bbudge@chromium.org

Review URL: https://codereview.chromium.org/393813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283541 0039d316-1c4b-4281-b951-d872f2087c98

Doing some sorting and splitting of data to make large amounts
of changes easier to study.

BUG=

Review URL: https://codereview.chromium.org/375063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283540 0039d316-1c4b-4281-b951-d872f2087c98

The home-card can be in a minimized state. In this state, only a narrow line
is displayed at the bottom of the screen, and dragging it up shows the overview
mode. When a window is selected in the overview mode, the home-card is minimized
again.

BUG=381224
R=mukai@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/394043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283539 0039d316-1c4b-4281-b951-d872f2087c98

Before, the FakeProvidedFileSystem had some hardcoded responses. However, since
FileStreamWriter is coming soon, we will need to verify if the file on the
file system is changed correctly.

For that, FakeProvidedFileSystem has been refactored, so it is possible to add
and get fake files and verify their values.

TEST=unit_tests: *FileSystemProvider*
BUG=391362

Review URL: https://codereview.chromium.org/393233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283538 0039d316-1c4b-4281-b951-d872f2087c98

split off from https://codereview.chromium.org/388963002/

BUG=160586

Review URL: https://codereview.chromium.org/390183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283537 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/385553002/ uses BackoffEntry, but it requires a lot of changes, so it probably won't be merged to M37. I suggest to merge this small fix.

BUG=377725
TEST=manual

Review URL: https://codereview.chromium.org/383183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283536 0039d316-1c4b-4281-b951-d872f2087c98

Enables most of compiler warning on ASan build.

BUG=162783

Review URL: https://codereview.chromium.org/391743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283535 0039d316-1c4b-4281-b951-d872f2087c98

When only image is opened then on long press context menu appears.
From context menu on selection of "open image" page reloads which
does not make sense.Added condition to hide option "open image"
if page url and image url for which context menu appears is same.

BUG=270682

Review URL: https://codereview.chromium.org/396063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283534 0039d316-1c4b-4281-b951-d872f2087c98

Adding component/auto_login_parser/BUILD.gn.

TBR=jochen

Review URL: https://codereview.chromium.org/382943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329247

Review URL: https://codereview.chromium.org/393803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283530 0039d316-1c4b-4281-b951-d872f2087c98

Selecting the "Cached images and files" in the Clear Browsing Data
dialog will now remove all idle ephemeral apps.

BUG=392007
TEST=browser_tests

Review URL: https://codereview.chromium.org/383703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283529 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283528 0039d316-1c4b-4281-b951-d872f2087c98

Port QueryHistoryAndBookmarks and QuerySearchTerms methods to use
CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/369673009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393019
NOTRY=true

Review URL: https://codereview.chromium.org/394593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283526 0039d316-1c4b-4281-b951-d872f2087c98

X11 implementation of PlatformWindow does not correctly process XInput2
yet. So do not listen for mouse-events there.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/394323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283524 0039d316-1c4b-4281-b951-d872f2087c98

Apps&Extensions for supervised users: Add Extension::WAS_INSTALLED_BY_CUSTODIAN flag and proto entry.

Currently, supervised users can not use Apps/Extensions at all. In the future, their custodian will be able to remotely install Apps/Extensions for them. This CL introduces a new extension flag and corresponding proto entry that marks these extensions, so we can allow only those in the client.

Relevant design doc section: https://docs.google.com/a/google.com/document/d/1rqahhrErR_HiZ04v-Skb_kvXeyOfnTvBPFvKwAxuf10/edit#heading=h.ptivtbjwlda5

BUG=390520

Review URL: https://codereview.chromium.org/353493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283522 0039d316-1c4b-4281-b951-d872f2087c98

google
infobars
invalidation
navigation_intercaption
network_time
password_manager
plugins
search_provider_logos
sessions

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/397953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/395083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283519 0039d316-1c4b-4281-b951-d872f2087c98

This new AudioBlockFifo() is made for the input code to avoid copying audio data during Push() and Consume().

Contrast to the existing AudioFifo, which requires a AudioBus* as input param for its Push() and Consume() methods to copy the data from/to the FIFO, this new AudioBlockFifo keeps blocks of AudioBus, it accepts interleaved data as input for its Push() method, and its Consume() method return an AudioBus for consumption. So the copy operations in this AudioBlockFifo() is 1 versus 3 in AudioFifo().


NOTRY=true
BUG=393199
TEST=media_unittests --gtest_filter="*AudioBlockFifo*"

Review URL: https://codereview.chromium.org/389623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283518 0039d316-1c4b-4281-b951-d872f2087c98

See bug for new mocks and screenshots.

BUG=318977

Review URL: https://codereview.chromium.org/342833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283517 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/393953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283516 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
BUG=386892

Review URL: https://codereview.chromium.org/397493007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386892
R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/392923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283514 0039d316-1c4b-4281-b951-d872f2087c98

CanUseCompositorAPI() and CanUseVideoDecodeAPI() were defined only if WebRTC support was enabled, even though they do not depend on it.
    
Make the ENABLE_WEBRTC ifdef cover only CanUseMediaStreamAPI() instead.

BUG=386743
R=teravest@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/390763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283512 0039d316-1c4b-4281-b951-d872f2087c98

"instanceof" was used instead of "instanceOf".

BUG=394139

Review URL: https://codereview.chromium.org/391283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283511 0039d316-1c4b-4281-b951-d872f2087c98

This is in anticipation of adding more crypto-library specific files, so the file lists are not duplicated

BUG=374912
R=brettw@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/395643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283510 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283509 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/396163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283508 0039d316-1c4b-4281-b951-d872f2087c98

Remove extension unload notification from LazyBackgroundLazyBackgroundTaskQueue and use ExtensionRegistryObserver instead.

BUG=354046

Review URL: https://codereview.chromium.org/391563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283507 0039d316-1c4b-4281-b951-d872f2087c98

The existing implementation directly tries to open browser windows and
relies on profiles to obtain Drive related services.

The CL inserts an indirection to those places and make it easy to
test, i.e., to verify the correctness of opened URLs and to
insert test fake Drive instances.

BUG=161209

Review URL: https://codereview.chromium.org/391003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283506 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/321423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283505 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283503 0039d316-1c4b-4281-b951-d872f2087c98

This brings in:
0ce77e3  Add a newline at the end of fpdfeditpage.cpp.
27e35a8  Remove uninitialized const global g_GbFontNameMap.
b44bac5  Error handling for invalid component number in CPDF_ICCBasedCS::v_Load
f86d7d6  Fix uninitialized coords in _DrawCoonPatchMeshes
1c8d196  Fix uninitialized nresults in GetRGB
feff0db  Fix uninitialized RGB in DrawShading
8434565  Fix uninitialized Storage in _LUTeval16
9114e83  Add support to extract viewer preference
8daab31  Fix an out-of-boundary issue for wide string
456cde9  Fix uninitialized Storage
fab8896  Fix uninitialized okeybuf
41e06e7  Fix uninitialized triangle
d5a0e7a  Zero out temporary arrays before use in PDF encryption.
b66432c  Fix a null object bug

BUG=82385,386728,391470,387809,386730,387826,169120,381521,387843,387011,387835,387834,387975
NOTRY=true
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/393403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144683

Review URL: https://codereview.chromium.org/391023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283501 0039d316-1c4b-4281-b951-d872f2087c98