GitLab

Revert of Turn on pinch virtual-viewport by default on Windows (patchset #1 id:1 of https://codereview.chromium.org/516653002/)

Reason for revert:
Tentative revert to see if this is the cause of AppWindowInteractiveTest.TestInnerBounds failures on Win7 waterfall builders.

Original issue's description:
> Turn on pinch virtual-viewport by default on Windows
>
> BUG=148816
>
> Committed: https://chromium.googlesource.com/chromium/src/+/44fc05214f6c86da5c8f8d192f514ff55fb72932

TBR=cpu@chromium.org,luken@chromium.org,piman@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148816

Review URL: https://codereview.chromium.org/549203002

Cr-Commit-Position: refs/heads/master@{#293754}

Website Settings page.

Review URL: https://codereview.chromium.org/549083005

Cr-Commit-Position: refs/heads/master@{#293753}

>> Removed Ctrl+Shift+P shortcut for system dialog printing on Windows.
>>    BUG=374321
>>    Review URL: https://codereview.chromium.org/522493002
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/551773002

Cr-Commit-Position: refs/heads/master@{#293752}

A mistake I've made in the past! Not sure if it's possible to test this code
in release builds.

BUG=303491

Review URL: https://codereview.chromium.org/547283002

Cr-Commit-Position: refs/heads/master@{#293751}

Revert of Created an empty expectations file to ignore flaky tests (patchset #9 id:160001 of https://codereview.chromium.org/376653002/)

Reason for revert:
Ignorer-bot project has been delayed to determine whether it is necessary at all. This doesn't have to be in the repo.

Original issue's description:
> Created an empty expectations file to ignore flaky tests
>
> This is used by https://codereview.chromium.org/373223003/
>
> BUG=390600
> R=eseidel@chromium.org, stip@chromium.org, hinoka@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284062

TBR=ojan@chromium.org,eseidel@chromium.org,hinoka@chromium.org,sergeyberezin@chromium.org,stip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=390600

Review URL: https://codereview.chromium.org/549103003

Cr-Commit-Position: refs/heads/master@{#293750}

This code was used for Win8 non-aura builds. Now it's dead.

BUG=142330
NOTRY=true

Review URL: https://codereview.chromium.org/546403002

Cr-Commit-Position: refs/heads/master@{#293749}

ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string.

Previously, only the latter case was handled when trying to continue propagating keys.

BUG=407163
TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*).

Review URL: https://codereview.chromium.org/547783002

Cr-Commit-Position: refs/heads/master@{#293748}

for QUIC sessions.

Review URL: https://codereview.chromium.org/546133002

Cr-Commit-Position: refs/heads/master@{#293747}

BUG=411931
TBR=keishi, reed

Review URL: https://codereview.chromium.org/551913002

Cr-Commit-Position: refs/heads/master@{#293746}

BUG=None

Review URL: https://codereview.chromium.org/551763002

Cr-Commit-Position: refs/heads/master@{#293745}

1) When the status is ADDING (adding message is sent), the token is refreshed.
2) When the status is REMOVING (removing message is sent), the token is added
again.
3) updating multiple account mappings

BUG=374969
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/544363002

Cr-Commit-Position: refs/heads/master@{#293744}

Fixed missing and extra imports

BUG=411931
TBR=keishi

Review URL: https://codereview.chromium.org/556513002

Cr-Commit-Position: refs/heads/master@{#293743}

Revert of Disable WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint (patchset #1 id:1 of https://codereview.chromium.org/554713002/)

Reason for revert:
Compile error... I'll have to look into this.

Original issue's description:
> Disable WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint
>
> It broke on Android Tests (dbg)
>
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21342
>
> [FAIL] org.chromium.content.browser.WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint:
> java.util.concurrent.TimeoutException: waitForCallback timed out!
>   at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
>   at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
>   at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:197)
>   at org.chromium.content.browser.WebContentsObserverAndroidTest.testDidFirstVisuallyNonEmptyPaint(WebContentsObserverAndroidTest.java:70)
>   at java.lang.reflect.Method.invokeNative(Native Method)
>   at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
>   at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
>   at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
>   at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
>   at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
>   at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
>   at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
>
> BUG=411931
> TBR=keishi, reed
>
> Committed: https://chromium.googlesource.com/chromium/src/+/833089c8f5bec9a81323cbb314689f9569eb6ec8

TBR=keishi@chromium.org,reed@android.com
NOTREECHECKS=true
NOTRY=true
BUG=411931

Review URL: https://codereview.chromium.org/551043003

Cr-Commit-Position: refs/heads/master@{#293742}

This change is lays groundwork for making attachment upload operations
persistent.

Make GenericChangeProcessor responsible for writing attachments to the
AttachmentStore and calling UploadAttachments.  In a future CL, datatype
code will be responsible for writing attachments to the store.

Queue up attachments for upload inside of AttachmentService.  In a
future CL we'll add rate limiting, retry, and back-off logic.

Expose AttachmentService's AttachmentStore via GetStore method.

(This is a reland of issue 512413003.)

BUG=

Review URL: https://codereview.chromium.org/548533003

Cr-Commit-Position: refs/heads/master@{#293741}

BUG=410824

Review URL: https://codereview.chromium.org/545193003

Cr-Commit-Position: refs/heads/master@{#293740}

Move the Options, Permissions, Visit website, Launch, and
Reload links to be on the same line in the
chrome://extensions page, directly below the description (so
they are in the same place for all extensions in the list).

Also reword "Visit website" to be either "Details" or
"Developer website", depending on whether it will link to
the developer's website or the chrome web store.

Finally, tweak the css to give a bit more padding to the
description and make the version text grey.

----------------------------

NOTE: The reviewed version of this patch is at
https://codereview.chromium.org/540113002, but that one had the wrong
Base URL (whoops).

(TBRs are original reviewers)
TBR=dbeam@chromium.org
TBR=yoz@chromium.org

BUG=410895

Review URL: https://codereview.chromium.org/550443003

Cr-Commit-Position: refs/heads/master@{#293739}

It broke on Android Tests (dbg)

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21342

[FAIL] org.chromium.content.browser.WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint:
java.util.concurrent.TimeoutException: waitForCallback timed out!
  at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
  at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
  at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:197)
  at org.chromium.content.browser.WebContentsObserverAndroidTest.testDidFirstVisuallyNonEmptyPaint(WebContentsObserverAndroidTest.java:70)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
  at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
  at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
  at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)

BUG=411931
TBR=keishi, reed

Review URL: https://codereview.chromium.org/554713002

Cr-Commit-Position: refs/heads/master@{#293738}

https://codereview.chromium.org/505373002 introduced a regression by
implicitly changing an Update() call to an UpdatePageActions() call on
extensions being loaded/unloaded. This is mostly correct, but we lost the
check to make sure an extension didn't override the bookmark star. Correct this.
Also add a regression test.

BUG=410372
TBR=sky@chromium.org (minor TestBrowserWindow change)

Review URL: https://codereview.chromium.org/540483002

Cr-Commit-Position: refs/heads/master@{#293737}

BUG=385740

Review URL: https://codereview.chromium.org/540323002

Cr-Commit-Position: refs/heads/master@{#293736}

https://skia.googlesource.com/skia/+log/6dcccc476bddd4ccba69491f6a87eed68e581414..87c4138fae37ba6b7e4de7acc3fce19524d726ea

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/552653004

Cr-Commit-Position: refs/heads/master@{#293735}

BUG=398378

Review URL: https://codereview.chromium.org/548183002

Cr-Commit-Position: refs/heads/master@{#293734}

BUG=410848

Review URL: https://codereview.chromium.org/553923002

Cr-Commit-Position: refs/heads/master@{#293733}

Revert of Removing X11 native_event uses for key events. (patchset #7 id:180001 of https://codereview.chromium.org/479873002/)

Reason for revert:
Broke Android Tests (dbg)

C  427.575s Main  [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText:
C  427.575s Main  junit.framework.AssertionFailedError
C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694)
C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410)
C  427.575s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  427.575s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  427.575s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  427.575s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  427.575s Main  	at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  427.575s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  427.575s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Original issue's description:
> Removing uses of X11 native key events.
>
> BUG=380349
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
>
> Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9

TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380349

Review URL: https://codereview.chromium.org/548303003

Cr-Commit-Position: refs/heads/master@{#293732}

TBR=ulan@chromium.org

Summary of changes available at:
https://chromium.googlesource.com/external/v8/+log/1af4d9551ad4..42ed2fc449e8

BUG=

Review URL: https://codereview.chromium.org/554643002

Cr-Commit-Position: refs/heads/master@{#293731}

Revert of Adding Text Selection Action Bar Unit Test cases. (patchset #11 id:190001 of https://codereview.chromium.org/521583003/)

Reason for revert:
This is breaking on Android Tests (dbg)

Original issue's description:
> Adding Text Selection Action Bar Unit Test cases.
>
> Currently there is not enough unit test cases available to cover
> the functionality of Text Selection Action Bar. In this patch covering
> essentail unit test cases for the same.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/7da8be70e45d91995fb4476713d7920ce77cb90f

TBR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/549433004

Cr-Commit-Position: refs/heads/master@{#293730}

The default BrowserContextKeyedServiceFactory::GetBrowserContextToUse() returns NULL for guest mode profile, overriding it to redirect to original profile.

BUG=411763
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/550053003

Cr-Commit-Position: refs/heads/master@{#293729}

page.

BUG=372607

Review URL: https://codereview.chromium.org/547433002

Cr-Commit-Position: refs/heads/master@{#293728}

BUG=148816

Review URL: https://codereview.chromium.org/516653002

Cr-Commit-Position: refs/heads/master@{#293727}

Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/)

Reason for revert:
13% regression on page load times.

BUG=411520

Original issue's description:
> Forward input and compositing tasks to the Blink scheduler
>
> Instead of posting input and compositor tasks directly to the
> main thread message loop, forward them to the Blink scheduler
> so they can be prioritized over other tasks.
>
> BUG=391005
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845
>
> Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948

TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391005

Review URL: https://codereview.chromium.org/553483005

Cr-Commit-Position: refs/heads/master@{#293726}

I wrote two unittests which open  the device, wait for the data callback, then close the device, ran the tests in an infinite loop, after several hours, it hits NO_MIC_DATA on the input side. The problem is that sometimes the audio unit gets corrupted, and our input code does not correctly dispose the unit component, so the broken audio unit can be leaked and prevent the OS pumping audio callback to all auido units.

This patch fixes two problems:
1, AUAudioInputStream::Close() is not completely correct, we need to call AudioComponentInstanceDispose()
2, It seems that we should setup the input callback before setting the formats, which might not be correct (I am not really sure, but the tests show that I was able to restart the stream after changing it)

BUG=411869

Review URL: https://codereview.chromium.org/554523002

Cr-Commit-Position: refs/heads/master@{#293725}

Disable WebNotificationTrayTest.TouchFeedback and TouchFeedbackCancellation which are failing on ASAN machines.

TBR=skuhne@chromium.org
BUG=411881

Review URL: https://codereview.chromium.org/551833002

Cr-Commit-Position: refs/heads/master@{#293724}

This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.

BUG=404066, 411428

Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669

Review URL: https://codereview.chromium.org/480453002

Cr-Commit-Position: refs/heads/master@{#293723}

Revert of Revert of Forward input and compositing tasks to the Blink scheduler (patchset #1 id:1 of https://codereview.chromium.org/548253002/)

Reason for revert:
this didn't reduce flakiness

Original issue's description:
> Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/)
>
> Reason for revert:
> suspecting it's causing the high rate of flakes in Instrumentation test ContentShellTest
>
> BUG=411756
>
> Original issue's description:
> > Forward input and compositing tasks to the Blink scheduler
> >
> > Instead of posting input and compositor tasks directly to the
> > main thread message loop, forward them to the Blink scheduler
> > so they can be prioritized over other tasks.
> >
> > BUG=391005
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948
>
> TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=391005
>
> Committed: https://chromium.googlesource.com/chromium/src/+/66f85d5405417e6ddd11e1b9be677062a2e3ae4f

TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411756

Review URL: https://codereview.chromium.org/548333002

Cr-Commit-Position: refs/heads/master@{#293722}

Changing command dispatch from a "switch" dispatch to table
based dispatch makes DoCommand about 2 times faster on
Android, and also seems to be reducing times in other
command_buffer code due to code size reduction.

BUG=394570

Review URL: https://codereview.chromium.org/540053004

Cr-Commit-Position: refs/heads/master@{#293721}

Please see https://codereview.chromium.org/510323002 for reference.

NOTRY=true

Review URL: https://codereview.chromium.org/552553002

Cr-Commit-Position: refs/heads/master@{#293720}

Add content_editable_extractor_test to the gyp file and make it pass.

BUG=371692

Review URL: https://codereview.chromium.org/548523002

Cr-Commit-Position: refs/heads/master@{#293719}

Revert of Add test for ChromeVox keyboard commands. (patchset #8 id:140001 of https://codereview.chromium.org/490443002/)

Reason for revert:
Broke Linux ChromiumOS Tests (dbg)(3)

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1199

Original issue's description:
> Add test for ChromeVox keyboard commands.
>
> This is just a couple of quick sanity checks to prevent future regressions
> like the one in the linked bug. It tests both a Search+Shift shortcut and
> the corresponding Prefix Key shortcut.
>
> Adds support for sending the meta modifier key in
> aura/x11 tests.
>
> BUG=404470
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ad123c3ac76fadc625a9dff66960743d0df253ba

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/550183002

Cr-Commit-Position: refs/heads/master@{#293718}

Goal is to:

1) Reduce amount of log overhead for WebRTC clients;
2) Reduce risk for false-alarm for "no data" on initial short streams.

BUG=405449

Review URL: https://codereview.chromium.org/551763003

Cr-Commit-Position: refs/heads/master@{#293717}

BUG=410915
TEST=Start Chrome with --enable-new-avatar-menu. Sign in a profile. In
the avatar menu, the descenders in the "@gmail.com" string should not
be cut off.

Review URL: https://codereview.chromium.org/546053003

Cr-Commit-Position: refs/heads/master@{#293716}

BUG=407972

Review URL: https://codereview.chromium.org/544123003

Cr-Commit-Position: refs/heads/master@{#293715}