- 11 Jul, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cfd0a11a. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21164 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I12f52d4715c8df2f7207557920f98ce11fcc2c6f Reviewed-on: https://chromium-review.googlesource.com/1132844 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574116}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2f043d847dd..a6a7842fdbf5 git log a2f043d847dd..a6a7842fdbf5 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 jiawei.shao@intel.com ES31: Support atomic functions on D3D11 - Part I Created with: gclient setdep -r src/third_party/angle@a6a7842fdbf5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I76e2e62d0893c9473d1b720e740960409bdead1c Reviewed-on: https://chromium-review.googlesource.com/1132756Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574115}
-
Hitoshi Yoshida authored
In order to make their lifetime clear in Unified-GC, this CL makes ScriptState inherited from GC. This allows to have a cyclic reference between v8::Context, ScriptState, and V8PerContextData in Unified-GC world. Bug: 773605 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibbea4f8a15c8b5e2508b53aa4ddec38d82f6d8ad Reviewed-on: https://chromium-review.googlesource.com/928189Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#574114}
-
Ramin Halavati authored
Change-Id: I7b61ee7d2bbbd3b18e66958d6a0e863d5b199f2e TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1131953Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#574113}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10041796ae14..345d3323ed4a git log 10041796ae14..345d3323ed4a --date=short --no-merges --format='%ad %ae %s' 2018-07-11 dtu@chromium.org [pinpoint] Use --benchmark argument for performance_webview_test_suite. Created with: gclient setdep -r src/third_party/catapult@345d3323ed4a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I88509cd9044cf8e3654f0618e79b3d913d513fe8 Reviewed-on: https://chromium-review.googlesource.com/1132754Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574112}
-
Adam Rice authored
Constructing a Response from a non-stream will currently succeed even if creating the ReadableStream for the body failed. In this case response.body will be undefined. Add a test to verify that it is undefined, and touching it does not crash the renderer. Bug: 853189 Change-Id: I7fcf5ebc8b347c859b40b3d403d40bc048504211 Reviewed-on: https://chromium-review.googlesource.com/1132833 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574111}
-
Matt Falkenhagen authored
NavigationURLLoaderImpl holds raw pointers to objects owned by NavigationHandleImpl, namely AppCacheNavigationHandle. Therefore the handle should outlive the loader. If the handle is destroyed before the loader the following sequence can happen: 1. (UI) |navigation_handle_| is destroyed. This destroys |appcache_handle_| which posts a task to the IO thread to destroy |appcache_handle_->core_|. 2. (Background thread) Another thread (e.g., ServiceWorkerDatabase) posts a task to the IO thread that results in |request_controller_| being called. 3. (UI) |loader_| is destroyed. This posts a task to the IO thread to destroy |request_controller_|. 4. (IO) |appcache_handle_->core_| is destroyed. 5. (IO) The task from 2. runs, and accesses the raw pointer to appcache_handle_->core. No test added because I don't see a good way to test this. Bug: 857005 Change-Id: I7c44312a2072836f53475559ddfe9ca1fdc8e18a Reviewed-on: https://chromium-review.googlesource.com/1132715Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574110}
-
David Roger authored
Dice headers were not sent when cookies are blocked, which is the same behavior as Mirror. However, in the Mirror case, not sending the header was disabling the feature much earlier (i.e. we would not even show the signin page). For Dice, the signin page is shown anyway, and thus there is no point in having this extra check. Removing that check allows the Gaia page to better detect what is going wrong, and show a better error page to the user (telling to the user to re-enable their cookies, instead of a generic "Something went wrong" message). Bug: 860038 Change-Id: I63cca38737ac85df420f011d9d59b699ccb3f104 Reviewed-on: https://chromium-review.googlesource.com/1128870Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#574109}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8d674dd7cef..61cc9fabf255 git log e8d674dd7cef..61cc9fabf255 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@61cc9fabf255 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Iba07e552bc9511bc2bff4fe124fb17d001b211a6 Reviewed-on: https://chromium-review.googlesource.com/1132755Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574108}
-
Mohamed Amir Yosef authored
This CL addresses the remaining work to fix the attached bug which includes: 1. Detecting a cache_guid mismatches in ClientTagBasedModelTypeProcessor::ConnectIfReady(). 2. Ignore sync metadata in that case, and tell the bridge to delete it (treat as DisableSync/EnableSync). Change-Id: Ibf2f4c0b89872884f1c09a3a2e8fec1136014b93 Bug: 820049 Change-Id: Ibf2f4c0b89872884f1c09a3a2e8fec1136014b93 Reviewed-on: https://chromium-review.googlesource.com/1130527 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574107}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I37f962245e818a16b31ed9666b5c918233d355e9 Reviewed-on: https://chromium-review.googlesource.com/1132846Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574106}
-
Kinuko Yasuda authored
We are seeing a crash that happens while the frame's subresource_ factories are null and it's last commited URL is for about: schemes (e.g. about:srcdoc or about:blank). This situation doesn't really make sense (e.g. prefetches shouldn't come to the browser process for about:blank), so we suppose there's probably a race somewhere. This change does two things: - send URLLoaderFactory for prefetch on NavigationCommit (so no race) - remove PrefetchURLLoaderService related code Bug: 849929 Change-Id: If350afa26daaeb0c679091b74b2013ab7f121531 Reviewed-on: https://chromium-review.googlesource.com/1116411 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574105}
-
Rakina Zata Amni authored
Currently in some cases, ShadowRoot.elementsFromPoint may not return the document element even when Document.elementsFromPoint returns the document element such as when the document element height is shorter than the hit-tested element's position. This CL fixes it by removing a check in TreeScope::ElementsFromHitTestResult. See example live case detailed in this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=843215#c16 Bug: 843215 Change-Id: I5b774d1a091f3c3f72345c55bca188fad309ba58 Reviewed-on: https://chromium-review.googlesource.com/1131023 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574104}
-
Daniel Bratell authored
Both syslog and the base namespace have LOG_INFO symbols and in certain cases (which include, but is not limited to, jumbo builds) those will clash. This patch undefs the syslog LOG_INFO macro as is already done with LOG_WARNING previously. Change-Id: Iff59a2ef079d3bb38378af76932b21a128507353 Reviewed-on: https://chromium-review.googlesource.com/1027611 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#574103}
-
Aleks Totic authored
Static position needs to be adjusted based upon block container padding box, not upon inline container padding box. Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib6a5fbb27a56f7a724a52366988cfbd5063d2e36 Reviewed-on: https://chromium-review.googlesource.com/1132532Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574102}
-
Kunihiko Sakamoto authored
This completes the htxg -> sxg renaming. Bug: 856530 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idf5243b0ff08acc761313299415bcb7fa32b333d Reviewed-on: https://chromium-review.googlesource.com/1132835Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Sam McNally authored
Bug: 854153 Change-Id: I3a7bb8ff09a5fc366ef918dea8e821ed6606fe0e Reviewed-on: https://chromium-review.googlesource.com/1132261 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574100}
-
Yutaka Hirano authored
Some entries are missing, some are fixed, some are not specific to virtual/outofblink-cors. This CL removes fixed/missing ones and reorders entries which are not specific to virtual/outofblink-cors. Bug: 736308 Change-Id: Ic39ce52e5ccd730ccf476bc9be7804d04bcc3f19 Reviewed-on: https://chromium-review.googlesource.com/1130558 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#574099}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a0a490d. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21163 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc TBR=kereliuk No-Export: true Change-Id: Ic94e54953c4c6609ba8a3b5d26878adb23893748 Reviewed-on: https://chromium-review.googlesource.com/1132683 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Test: manually verified Bug: 858957 Change-Id: I31c2b69ca92680ea38ab38ba65f13169e0e11b45 Reviewed-on: https://chromium-review.googlesource.com/1128822Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574097}
-
Lily Houghton authored
Bug: 821027 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I597a7ee5d5cd423474232dc3d996055b0962dc60 Reviewed-on: https://chromium-review.googlesource.com/1104800 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#574096}
-
Tomasz Moniuszko authored
Change-Id: I5558e93ca31e5ab546457b0e07a73e5f1a60c614 Reviewed-on: https://chromium-review.googlesource.com/1125074Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#574095}
-
tanvir.rizvi authored
This patch changes 15381.html to utilize |selection_test()|. Follow up patch will rename it to |justify-center-do-not-modify-rootEditableElement.html| for better readability and information. Bug: 679977 Change-Id: I41a2816aa3dfb19d7068983d39a7bd726e4272eb Reviewed-on: https://chromium-review.googlesource.com/1128899Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#574094}
-
Tarun Bansal authored
Bug: 852484 Change-Id: I4b62bc03266d9e754e01cb7983d841635d9a347b Reviewed-on: https://chromium-review.googlesource.com/1132689Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574093}
-
Christopher Cameron authored
Avoid checking the full input |text| string, rather, only examine the part that sits inside |range| and its adjacent context. Note that we still need the full string (or at least we need to know the offset into it that we are using), because that will affect the output. Pre-compute the input hash, to avoid re-computing a string's hash at every comparison. Add comments regarding key hash computation and thread use, and mark members as const (requested in previous patch's review). Bug: 860612 Change-Id: I9dd73e0a2d0247a7139131edfb33b3d99138b103 Reviewed-on: https://chromium-review.googlesource.com/1130159 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574092}
-
Tarun Bansal authored
blink-dev approval thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/G_rkd0yo2AM/WaVhRALcAQAJ Bug: 826950 Change-Id: If511883b7428f30136642302862b51f14ffe4894 Reviewed-on: https://chromium-review.googlesource.com/1132612Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574091}
-
rbpotter authored
This is currently broken in Polymer2. Bug: 738611 Change-Id: I813b1b8aa6b4b4cfa31d1735f3b3b35f318e4c3a Reviewed-on: https://chromium-review.googlesource.com/1125501 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574090}
-
Wenzhao Zang authored
Addressed several corner cases including: 1) Handles overflow of long wallpaper descriptions. 2) Add spinner in the center of the current wallpaper thumbnail. 3) Adjust the color of the error message. Bug: 861915 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibd8b4090dec51a1caad76c1872929490e8f042ae Reviewed-on: https://chromium-review.googlesource.com/1125538Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#574089}
-
Emil A Eklund authored
Modify ShapingLineBreaker performance test to include the paragraph text shaping operation in the timing rather than just the time for each line. Change-Id: I3f23333e17251a9640c5337171c8883c964bb9c2 Reviewed-on: https://chromium-review.googlesource.com/1132822 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
When PRINT_UNSYMBOLIZED_STACK_TRACES is on, |object_fd| is created in |SymbolizeAndDemangle| but not used. The handle is not closed when returning the function. This CL fixes this file descriptor leak by using FileDescriptor. Change-Id: I216c00690946671edd802f91fd694573d5783ba0 Reviewed-on: https://chromium-review.googlesource.com/1120087Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574087}
-
Hiroki Nakagawa authored
FetchContext::CheckResponseNosniff() is called only from ResourceLoader. That should be placed in ResourceLoader for code health. Bug: 845285 Change-Id: I3174ec08c046d3f95eaf304d23bcb29105c0c67f Reviewed-on: https://chromium-review.googlesource.com/1131044Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Currently PreflightLoader doesn't do anything when the preflight request fails by network errors. This CL fixes that. Bug: 736308, 803766 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ica8f911e060b185980a653d7ddecb08f5c86c8ac Reviewed-on: https://chromium-review.googlesource.com/1126894 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Hayato Ito authored
A part of http://crbug.com/738794. TBR=tkent Bug: 738794 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3710ab07b66afc4766cdbe6a64974c1eb676e1a4 Reviewed-on: https://chromium-review.googlesource.com/1126691Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574084}
-
Hitoshi Yoshida authored
Before this CL, setting |null| as a member of dictionary had the same meaning with unsetting the member. It is consistent with the intention of "present" state, and we don't require a way to unset members. (We can create a dictionary from scratch and set necessary members, to achieve such a state.) After this CL, setting |null| makes the member present and be |null|. Bug: 855968 Change-Id: Ia1cbb5cede890cc00834205ca618543c043b9fbb Reviewed-on: https://chromium-review.googlesource.com/1128696Reviewed-by:
-
Alice Boxhall authored
This reverts commit 1afbb0e4. Reason for revert: Causing test failures on Android CFI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2026 https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941340307860291344%2F%2B%2Fsteps%2Fcontent_unittests_on_Android_device_Nexus_5X%2F0%2Flogs%2FDevToolsManagerTest.NoUnresponsiveDialogInInspectedContents%2F0 Original change's description: > Migrate //content unit tests off of QuitCurrent*Deprecated(). > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: If5cf7d3dcda8dc411c6c90de31885dca683354d8 > Reviewed-on: https://chromium-review.googlesource.com/1130656 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574006} TBR=wez@chromium.org,boliu@chromium.org Change-Id: Icb42050ab3fcbf283098bb36943a8c9dfbefccf8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1132636Reviewed-by:
-
Stefan Zager authored
The immediate motivation for this patch is to pave the way to move stuff out of platform/scroll and into core/. That aside, it probably makes more sense to put this kind of code in core/ rather than platform/. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0859fbfa6ddf82c607a36cbbd0bee77e49a3c0b0 Reviewed-on: https://chromium-review.googlesource.com/1131000Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#574081}
-
Ryan Sleevi authored
During shutdown, the P2PSocketDispatcherHost may still be holding on to resources referring back to the URLRequestContext used to create it, but after that URLRequestContext has already shut down. Gracefully clean up these resources when the MessageFilter signals that the channel is closing, so that the correct shutdown sequence order is observed. BUG=860837 Change-Id: Ie4c2ed24cebc619c40468ca9720d521dfcf1962e Reviewed-on: https://chromium-review.googlesource.com/1128404 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574080}
-
rbpotter authored
Focus the search box when the dialog is shown. Also add an interactive UI test to verify the behavior and fix the same issue in the advanced settings dialog. Bug: 860139 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I925ba10d10a477dfc526d860d5db108534f4254f Reviewed-on: https://chromium-review.googlesource.com/1130659Reviewed-by:
-
Min Qin authored
RenderFrameImpl::DownloadUrl() can be abused to trigger a large number of download to overwhelm the browser process. This CL rate limits the number of download to a maximum of 10 per second. Bug: 860045 Change-Id: I490ae3a99eb59aef709b9f1e6be5eb0f787354f4 Reviewed-on: https://chromium-review.googlesource.com/1132485 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#574078}
-
Tatsuhisa Yamaguchi authored
Close the system tray bubble when these actions are taken. - Switch to another user - Sign in another user - Lock screen Bug: 859041 Test: verified manually Change-Id: Id70d71e73a5c261212bbbb13d52f376275da8002 Reviewed-on: https://chromium-review.googlesource.com/1127914Reviewed-by:
-
