- 28 Nov, 2017 40 commits
-
-
Reilly Grant authored
This patch, mirroring the logic in WebUIDataSourceImpl::SetJsonPath, excludes the configured JSON path (used for localization strings) from the set of resources that are marked as gzipped. Bug: 787428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I158766444870b93fad44a1117e19f54e8f4b59e7 Reviewed-on: https://chromium-review.googlesource.com/792131 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519846}
-
Lei Zhang authored
Having pointers that are const will make it obvious if they are never nullptrs, or if they can be sometimes. Change-Id: I3b817b7cfebdc64372fb203d019eaf1c5ca49d87 Reviewed-on: https://chromium-review.googlesource.com/786824Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#519845}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/65711d3e974c..cde6fc4afe73 $ git log 65711d3e9..cde6fc4af --date=short --no-merges --format='%ad %ae %s' 2017-11-27 hanxi Startup tracing for WebAPKs Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id25a969d3d42a6a59cd33793ba1ad8c654b04799 Reviewed-on: https://chromium-review.googlesource.com/793891 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519844}
-
Andrey Kosyakov authored
Back-end can often produce layerTreeDidChange() at a rate that can't be handled by front-end, so throttle it. A better fix would be to change the protocol to only send these events when front-end is ready to process them, but let's have a trivial fix first. Change-Id: Id24233cf75697363ea1b7995346a735a2055b226 Reviewed-on: https://chromium-review.googlesource.com/786902Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519843}
-
Scott Violet authored
All other code paths properly set it. Without this we hit DCHECKs as the type isn't set. BUG=786544 TEST=covered by tests Change-Id: Ia3837afa9641c6fef83ed4441dbcb5ab1d5d9cd4 Reviewed-on: https://chromium-review.googlesource.com/794520Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519842}
-
Avi Drissman authored
BUG=696454 TBR=jam@chromium.org Change-Id: I68bae775dfa3a4a5c74b19659b81cfe976502365 Reviewed-on: https://chromium-review.googlesource.com/791517Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519841}
-
Sadrul Habib Chowdhury authored
Use --mus=viz if the mus window-server is the viz-host. If --mus is not set to viz, then mus is used, but chrome still is the viz host. For now, always set it to 'viz', so that mus still remains the viz host. Once some more fixes land, we can turn it off by default. BUG=786453 Change-Id: If8f6fca0178322311a0a14b718b08f9084bda35c Reviewed-on: https://chromium-review.googlesource.com/792276 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519840}
-
Pavel Yatsuk authored
The issue is that ProcessorEntityTracker hits DCHECK when loading entity data for commit if its specifics doesn't match the one passed to ProcessorEntityTracker::MakeLocalChange. This can happen if model type code assembles specifics differently after restart. I'm removing the DCHECK and adding unittest for this scenario. BUG=787741 R=pnoland@chromium.org Change-Id: I1abe5c9e3d89c9f312c8faa0cae889805e2dc4cb Reviewed-on: https://chromium-review.googlesource.com/792536Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#519839}
-
Troy Hildebrandt authored
Bug: 781340 Change-Id: Id9d18f4873ce0d47ed882ff9a6e00140f424b991 Reviewed-on: https://chromium-review.googlesource.com/782709 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#519838}
-
Vaclav Brozek authored
The test PasswordSyncableServiceAndroidAutofillTest.TwoWayServerAndLocalMerge derives a few parameters from a single integer variable in two places. It seems that in the second place it prepares another variable to derive from but then uses the same as in the first place. Looks like a copy-paste typo. In any case, switching to the prepared variable has strictly more coverage, so this CL changes to the prepared variable. Bug: 739101 Change-Id: I27bb5895e48c1d1f87f91cac8a9e26fa81390e1d Reviewed-on: https://chromium-review.googlesource.com/793610Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#519837}
-
Daniel Park authored
-Reorders order for doesUserQualify -Adds filtering methods -Adds tests for filtering methods -Adds logging for when the last time the random # gen. was rolled -Adds Chrome Home Force Survey check to doesUserQualify to allow for testing of other survey qualifications Filtering method: -Gets the max number from the finch config -Rolls a random number up from 0 (inclusive) to that number (exclusive) -If the random number = 0, process continues for user -Else stop Bug: 778384 Change-Id: Ie7063724614c98121e0e93c1a4b091557635015a Reviewed-on: https://chromium-review.googlesource.com/741867 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#519836}
-
Trent Apted authored
This regressed in r518459 which added a step to clear out a stale NSMenu tree once it could never be used again. But it turns out that -[NSMenuDelegate menuDidClose:] is a bad signal for this. AppKit isn't actually done with the menu at that point, and doesn't give the signal we need. To fix, keep the menu around as before, and improve test coverage. Bug: 788430 Change-Id: Idbc19cb56e6e52d699d94518b2164d0bd776ce9d Reviewed-on: https://chromium-review.googlesource.com/790090Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519835}
-
Robert Ma authored
With this change, non-WPT layout tests are completely independent of WPT files and hence won't be affected by imports. The change also makes the behaviour more consistent as we already have copies of testharness.js, testdriver.js and idlharness.js, with webidl2.js being the only left. An apache alias rule is changed accordingly. See crbug.com/685854 for maintaining these Chromium copies. Besides, WebIDLParser.js (which is an old version of webidl2.js) is removed from resources/ to avoid confusion. The only three files using it are modified to use webidl2.js instead. Bug: 787829, 685854 Change-Id: I2d9966646cc7db557d87ec403cd0c833ee262279 Reviewed-on: https://chromium-review.googlesource.com/785992 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#519834}
-
John Budorick authored
TBR=agrieve@chromium.org,yfriedman@chromium.org,mef@chromium.org,pasko@chromium.org Bug: 782848,789177 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I30cdc80f19ee01619e7ce808423c10ffc752644d Reviewed-on: https://chromium-review.googlesource.com/794338Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#519833}
-
Jay Civelli authored
Introducing a new XML parser service that parses XML into a base::DictionaryValue. It does so by JSONifying the XML content. Also factoring out TestServiceManagerListener to its own file, now that it is used in 2 places (safe_json_parser_browsertest.cc and safe_xml_parser_browsertest.cc). Bug: 784667 Change-Id: I1f41f44d49910da43837aac8bca52e24533460ef Reviewed-on: https://chromium-review.googlesource.com/767890Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#519832}
-
Herb Derby authored
BUG=472742 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iddaaf37132faf2698c09ae0851c741fb78d97656 Reviewed-on: https://chromium-review.googlesource.com/791010Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@chromium.org> Cr-Commit-Position: refs/heads/master@{#519831}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0f8e4dbd28d1..592c225b03ca $ git log 0f8e4dbd2..592c225b0 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 bsheedy Make Skia compatible with Android NDK r16 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I575587cd47062e30d6cfe9d39c1edfdb9e18ec38 Reviewed-on: https://chromium-review.googlesource.com/794431Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519830}
-
Dave Tapuska authored
When I landed MojoInputMessages by default yesterday in https://chromium-review.googlesource.com/789590 the dispatchKeyEvent-focus.js layout test became flaky. The cause was layout tests don't use a compositor thread and events could have been placed out of order because events hitting the WidgetInputHandlerImpl (setFocus would get queued in the input_event_queue_ whereas events received would get executed right away) There is no need for the input_event_queue_ to be passed when there is no compositor_task_queue_ as that causes an extra thread hop that isn't necessary. BUG=722928 Change-Id: I6d40ec67072e2ef98f2ebac04e6e8d54c7282ad0 Reviewed-on: https://chromium-review.googlesource.com/793972Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#519829}
-
Nate Chapin authored
Bug: Change-Id: I115d8ae2d9694fd98f145cb43181ed361c827427 Reviewed-on: https://chromium-review.googlesource.com/786443Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#519828}
-
Scott Little authored
TBR=allada@chromium.org Bug: 785179 Change-Id: I148b8511fa1c7d38fd9d9db8a5caa00d3616bcf1 Reviewed-on: https://chromium-review.googlesource.com/794513Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#519827}
-
Lei Zhang authored
If the not reachable code handling code gets removed, the rest of the function works just fine and correctly returns an empty string. Change-Id: Ia41522564ff242c097463ec804cf868a7b4f7784 Reviewed-on: https://chromium-review.googlesource.com/792298Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#519826}
-
Mohamad Ahmadi authored
Replaces usages of PersonalDataManager::GetURLRequestContextGetter() with ApplicationContext::GetSystemURLRequestContext() Bug: 781942 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e42baf9ce61d722410c1f49ee33a55c5e53485a Reviewed-on: https://chromium-review.googlesource.com/793850 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519825}
-
Bruce Dawson authored
The crashes seen in bug 734002 seem to only make sense if TerminateProcess when used to terminate the current process can return. This seems impossible. However, if this is happening (especially on Windows 7 where a disproportionate number of these crashes are happening) it would be nice to know for sure. Therefore, explicitly crashing will be informative, one way or another. Unfortunately the crash rate for this crash is extremely low on canary, probably due to a population bias away from Windows 7. So, it may be a while before we get any data. Bug: 734002 Change-Id: I8c483593de718770b15ff43b699a3e8f2e08bfdc Reviewed-on: https://chromium-review.googlesource.com/791826 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519824}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac0ab16a9d31..d638a44a623a $ git log ac0ab16a9..d638a44a6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I5058eba9b741f305249a84a1642445ed89d412a9 Reviewed-on: https://chromium-review.googlesource.com/794371Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519823}
-
Robert Ma authored
This reverts commit cd0c516c. Reason for revert: failing on bots (Git.__init__ throws when cwd does not yet exist.) Original change's description: > Refactor wpt-import to use common.checkout.git > > Some methods are not currently supported by common.checkout.git, and > Git.run is used in such cases for now. Later we would like to port some > of them (the reusable ones) to common.checkout.git. > > Bug: 676399 > Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19 > Reviewed-on: https://chromium-review.googlesource.com/793984 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519777} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: I692635b8a3ff57edb19ad7ee6401b0940dccce63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 676399 Reviewed-on: https://chromium-review.googlesource.com/794570Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#519822}
-
Benjamin Pastene authored
It jumped a bit: https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1511826720000&f=buildername%3ALollipop%20Phone%20Tester&f=name%3Anet_unittests&l=1000&n=true&s=created_ts%3Adesc&st=1510530720000 And delete ansr's unused testing spec. R=jbudorick@chromium.org Bug: Change-Id: I8177fc19b1495110c71a43c09a00c4477c8bdae2 Reviewed-on: https://chromium-review.googlesource.com/792004Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#519821}
-
Peter Beverloo authored
We can make the browser process authoritative by having the interface request be routed through RendererInterfaceBinders. A consequence of this is that we no longer will be able to establish a connection after the context is destroyed. That's fine, but leads to a minor change in behaviour: when calling Notification.permission from a detached context, it will now always return "denied". Other features tend to reject the promise in this situation, but we don't have one of those. Throwing when accessing the property will definitely have (bad) side effects. Bug: 595685 Change-Id: I51b988cedabd0689bb118a3d841a6864eb64a24a Reviewed-on: https://chromium-review.googlesource.com/791550 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#519820}
-
Katie Dektar authored
Elements who clip their children continue to label nodes outside their bounds as 'offscreen', whereas elements who do not clip will no longer label their children nodes 'offscreen'. This fixes a bug where absolutly positioned divs of size (0, 0) with overflow:visible were having all children marked as offscreen. Bug: 786008 Change-Id: I9b4b3e944670035000b6a20c3c4752453e29a2bd Reviewed-on: https://chromium-review.googlesource.com/777731 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#519819}
-
Takumi Fujimoto authored
Cast SDK uses some special strings (auto-join, cast-session) for presentation ID that may not correspond to that of existing routes. This CL handles those cases and sends the requests to the extension MRP. Bug: 786654 Change-Id: Ib32befe63936473edd71d16959e7a8caf8db81a9 Reviewed-on: https://chromium-review.googlesource.com/780584 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519818}
-
Marc Treib authored
This makes the button a bit darker so it meets the minimum contrast ratio Bug: 707004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8160d6ba4bead047064b6cc1b2de2c56ffea6c23 Reviewed-on: https://chromium-review.googlesource.com/793815Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#519817}
-
Alexei Svitkine authored
This change makes it so that UKM Sources that have no entries and that aren't NAVIGATION_ID-based will not be sent up. If a source is not sent this way, it will be kept around (up to a limit of 100 sources - which can be overridden by a param) so that it can be sent in the next log if there's an entry for it at that point. This allows us to use the UKM whitelist mechanism to disable metrics and have their associated sources not sent. (For metrics that don't use NAVIGATION_ID - as NAVIGATION_ID ones are safe.) BUG=788887 Change-Id: Ibfa468643e52b2adff0f416af6f4078ca91e7229 Reviewed-on: https://chromium-review.googlesource.com/789651 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#519816}
-
Danyao Wang authored
This way the events in navigation histogram are mutually exclusive. Also updated histograms.xml and enum.xml which I forgot to update earlier. Bug: 786551 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I19152cc808e41d6d7a019875145b895a0e48ba0e Reviewed-on: https://chromium-review.googlesource.com/786670 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#519815}
-
Dan Zhang authored
The old way of initialize QuicStreamSequencerBuffer::block_count_ may assign it to 2049 instead of 2048 (16MB / 8KB = 2k). This cl fix this bug and also make the condition check of a QUIC_BUG to check this value correctly. R=rch@chromium.org Merge internal change: 164489401, 174343515 Bug: Change-Id: Iaadc4084c470277d0f0882d75b4a61539c780aad Reviewed-on: https://chromium-review.googlesource.com/793977Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#519814}
-
David Tseng authored
- some Android apps require focusable nodes have either focus or makeVisible actions performed on them for some UI to show up (e.g. Assistant) - ChromeVox, as a result, needs to observe more containers. For focusable nodes, ChromeVox will not typically descend into their descendants unless the node's role is explicitly known to be a container. In Android, this is mostly nodes with role 'list'. their contents shown Navigate in other apps with many focusable containers e.g. Play Store. Verify navigation continues into descendants. Test: navigate in Assistant. Verify that invisible listItem nodes have Bug: 788650 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a6b512b3d133f6bae9e89dd11488229c0fe4660 Reviewed-on: https://chromium-review.googlesource.com/792098Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519813}
-
Will Chen authored
TBR=luoe@chromium.org Bug: 789225 Change-Id: I1453c23aa6ccd1c5db9b96423e8e5d9061bc412f Reviewed-on: https://chromium-review.googlesource.com/794393 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#519812}
-
Kurt Horimoto authored
This CL adds ChromeBroadcastObserverBridge, which allows C++ objects to register as observers for broadcasted UI state. Bug: 785663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5ee8ffdfd2173a8a57b16e0e2ad9d1634dcbd4ea Reviewed-on: https://chromium-review.googlesource.com/780810 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519811}
-
Aleksei Seren authored
Shutdown histograms were not properly written because of several issues: 1) There is an incorrect calculation of current open browsers which have not yet started to close. This leads to the fact that browser_shutdown::OnShutdownStarting() is not called in case of several browsers shutdown. 2) During the closure of the browser we are trying to find if there is any background Chrome applications with help of KeepAliveRegistry::IsKeepingAlive() function call, which is actually tracking running Browsers also (i.e. it can return true even if there is no background application). So it is needed to introduce new function to track background applications only. R=sky@chromium.org BUG=707147 BUG=707144 Change-Id: If4f7c080965c95e2c0b810817e94a09f3a52ba51 Reviewed-on: https://chromium-review.googlesource.com/760356 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519810}
-
Reid Kleckner authored
These bots are timing out near the end of the build. Our theory is that LTCG is slowing down the link steps. There are probably other official MSVC builders out there, but we are probably the only ones seeing these timeouts because we configure out bots to build *all* test targets, not just chromium_builder_tests or chrome. While I'm here, completely rewrite the configs used by the MSVC bots on the clang waterfall. This has the side effect of enabling DCHECKs on the 32-bit shared+release bot to make it consistent with the 64-bit bot. I don't think the inconsistency was intentional. R=dpranke@chromium.org, hans@chromium.org Change-Id: Ia54a297714f4217e9614616ac2c2dafd8fbdfc5e Reviewed-on: https://chromium-review.googlesource.com/794311 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#519809}
-
sebsg authored
Bug: 789059 Change-Id: I60aee9281d367fe8df545fef59ad920462d10a87 Reviewed-on: https://chromium-review.googlesource.com/794095Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519808}
-
Robert Sesek authored
ee84ce22bb89 fuchsia: Set kOS in MinidumpMiscInfoDebugBuildString 1020a6147d3d fuchsia: Use crashpad_info section matching Linux/Android for now 050d111bf986 fuchsia: Set METRICS_OS_NAME 4ee20f583191 Add Fuchsia clang and sdk to DEPS 0d05b0d59e19 fuchsia: Use RandBytes UUID generator af28b83eb7b6 In Annotation::SetSize, use AnnotationList::Register rather than Get Bug: 598854 Change-Id: Iccbc85ad93f03385bf0b4623f48046050f424062 Reviewed-on: https://chromium-review.googlesource.com/794036Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#519807}
-