1. 24 Nov, 2020 40 commits
    • dpapad's avatar
      WebUI: Auto-generate tracing_resources.grd with generate_grd(). · 57c03ad0
      dpapad authored
      This file was previously auto-generated with a custom one-off python
      script, which is no longer necessary now that generate_grd() exists.
      
      The previously generated file was also unnecessarily using
      |flattenhtml| and |allowexternalscript| Grit attributes which are
      removed as part of using the new tool.
      
      Besides the benefit of removing a one-off script, this also removes a
      TODO about crbug.com/1112471 about making the one-off script work with
      Python 3, which is now obsolete.
      
      Bug: 1132403,1152343,1112471
      Change-Id: I06928dcc2690b819eea1680fde23221ded94ed89
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557349
      Commit-Queue: dpapad <dpapad@chromium.org>
      Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830647}
      57c03ad0
    • chromium-autoroll's avatar
      Roll Chrome Win64 PGO Profile · 94a77e74
      chromium-autoroll authored
      Roll Chrome Win64 PGO profile from chrome-win64-master-1606196878-8e98c60eb2828a7469f5671822f6024fb48eb0e5.profdata to chrome-win64-master-1606218923-28e4a6cb560c6a9acc44daf784662f70e5c57403.profdata
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/pgo-win64-chromium
      Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chrome.try:win64-chrome
      Tbr: pgo-profile-sheriffs@google.com
      Change-Id: I1169bb59a50b6179bdbb6ee2f44ff87bcadc614c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558157Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#830646}
      94a77e74
    • chromium-autoroll's avatar
      Roll Dawn from 03badec5d73a to 90bac683b40f (1 revision) · ef914747
      chromium-autoroll authored
      https://dawn.googlesource.com/dawn.git/+log/03badec5d73a..90bac683b40f
      
      2020-11-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 6cd6f7462c49 to 12ed862c7ef2 (11 revisions)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/dawn-chromium-autoroll
      Please CC enga@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
      Bug: None
      Tbr: enga@google.com
      Change-Id: I8c9cb5dd1b4dfd7e6995baa74a596c45947d727a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558167Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#830645}
      ef914747
    • Sergey Ulanov's avatar
      [Fuchsia] Clear init_vector and subsample for clear streams · cc85bdd2
      Sergey Ulanov authored
      Fuchsia*StreamDecryptor were not clearing init_vector and subsample
      parameters for unencrypted buffers. Updated it to reset the
      corresponding fields in the EncryptedFormat table.
      
      Bug: crbug.com/1152210
      Change-Id: I6655b8eb221ffdc1d02d8cc80aae6bb44113dda3
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556817
      Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
      Commit-Queue: David Dorwin <ddorwin@chromium.org>
      Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830644}
      cc85bdd2
    • Chrome Metrics Logs's avatar
      Delay expiry of frequently used histograms. · 49704905
      Chrome Metrics Logs authored
      Updates the expires_after attribute for 88 histograms that show
      frequent access in the past 90 days.  These are the 95% most
      frequently used histograms over that time that do not already
      have a date later than or within 60 days of 2021-02-22.
      
      TBR=chromium-metrics-reviews@google.com
      
      Change-Id: I073439b4543852b0aba6c736e1ec2edc29510225
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556800Reviewed-by: default avatarChrome Metrics Logs <chrome-metrics-team+robot@google.com>
      Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
      Cr-Commit-Position: refs/heads/master@{#830643}
      49704905
    • Tina Wang's avatar
      [ios] Add feature flag for incognito mode feature · ff4ac858
      Tina Wang authored
      Add a feature flag to guard the changes for IncognitoModeAvailability
      policy related changes.
      
      Bug: 1148838
      Change-Id: Ibc563259651424c61e189b9ee74dc5c96135af91
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555257
      Commit-Queue: Tina Wang <tinazwang@chromium.org>
      Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
      Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830642}
      ff4ac858
    • Yi Gu's avatar
      Mark fast/canvas/canvas-composite-shadow.html flaky on win under oop-r · 37bc1635
      Yi Gu authored
      The test is flaky under oop-r:
      https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Foopr-canvas2d%2Ffast%2Fcanvas%2Fcanvas-composite-shadow.html
      
      TBR=kylechar@chromium.org
      Bug: 1152496
      
      Change-Id: I8fd1a32544880d899bcfd4c29e10e117de9c08a7
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556570Reviewed-by: default avatarYi Gu <yigu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830641}
      37bc1635
    • Rune Lillesveen's avatar
      Triage border radius clip tests. · fb97da75
      Rune Lillesveen authored
      Fixed a test/reference mismatch, but after that the failure in Blink is
      a subpixel rendering issues.
      
      Bug: 1151922, 997202
      Change-Id: Ibed68359944ace2ee75fd810a0ef3afc0364acc8
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556640
      Commit-Queue: Rune Lillesveen <futhark@chromium.org>
      Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830640}
      fb97da75
    • Chrome Metrics Logs's avatar
      Delay expiry of histograms causing alerts. · 0156fb38
      Chrome Metrics Logs authored
      Updates the expires_after attribute for 3 histograms that have
      been used to generate alerts in the past 90 days and do not already have
      a date later than or within 60 days of 2021-02-22.
      
      TBR=chromium-metrics-reviews@google.com
      
      Change-Id: I3bdbe8dd9c2ea644aab3c998fb2019059aeb80ee
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557785Reviewed-by: default avatarChrome Metrics Logs <chrome-metrics-team+robot@google.com>
      Reviewed-by: default avatarWeilun Shi <sweilun@chromium.org>
      Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
      Commit-Queue: Weilun Shi <sweilun@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830639}
      0156fb38
    • Sigurdur Asgeirsson's avatar
      PM: Deal with out of sequence shared worker destruction. · 70ecd56b
      Sigurdur Asgeirsson authored
      Bug: 1143281
      Change-Id: Iaaf47e7c73f8f92606fb1aa4efd2b614741dad19
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555502Reviewed-by: default avatarPatrick Monette <pmonette@chromium.org>
      Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830638}
      70ecd56b
    • Alexander Hendrich's avatar
      Add 'signinProfile' as pref location to policy_test_cases.json · 741b76fa
      Alexander Hendrich authored
      This CL is part of a larger refactoring/clean-up of
      policy_test_cases.json.
      
      This CL adds 'signinProfile' as possible pref location to
      policy_test_cases.json and then checks the sign-in profile's prefs
      accordingly (Chrome OS only).
      
      Bug: 1151251
      Change-Id: I52c3c8b86d0cef62cb4529b870216f4c4c023968
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551128
      Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
      Reviewed-by: default avatarPavol Marko <pmarko@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830637}
      741b76fa
    • Maksim Ivanov's avatar
      Fix moved-from-dereference crash in //chromeos/services/secure_channel/ · 89b2055e
      Maksim Ivanov authored
      Fix use-after-move (potential) bugs found by the
      "bugprone-use-after-move" clang-tidy check.
      
      Bug: 1122844
      Change-Id: I1abda42fcea0837c64c2c1aa1a82acaa5ff93aad
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556518Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
      Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830636}
      89b2055e
    • chromium-internal-autoroll's avatar
      Roll Help App from GMpv5BeMv... to bGWD0dCUQ... · 5dde8240
      chromium-internal-autoroll authored
      Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011240600_RC00.html
      
      https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/bGWD0dCUQSIgdz4mBoxEa-RzGSnD9QMw17rfdCA1yJMC
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
      Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
      Bug: None
      Tbr: help-app@grotations.appspotmail.com
      Change-Id: Ic2a33778390da6d9f4433dd1fb4755b47fafb3c5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557915Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#830635}
      5dde8240
    • Yunke Zhou's avatar
      Oobe: replace dialog element with cr-dialog in oobe-help-dialog · 478a4052
      Yunke Zhou authored
      Bug: 1061406
      Change-Id: Iae7d39ef0a17fcd9041c28b02d5ffe1131d1476d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556686
      Commit-Queue: Yunke Zhou <yunkez@google.com>
      Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
      Reviewed-by: default avatarDenis Kuznetsov [CET] <antrim@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830634}
      478a4052
    • Philip Pfaffe's avatar
      Fix and reenable the test after the DevTools change landed · 6fccf865
      Philip Pfaffe authored
      Fixed: chromium:1152362
      Change-Id: I2b4fd6a3e9c5c03b9c654e3b0543164ca3dd08f5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556939Reviewed-by: default avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830633}
      6fccf865
    • Javier Ernesto Flores Robles's avatar
      [iOS] Set FirstResponderSendAction as default · 2aa1a2f6
      Javier Ernesto Flores Robles authored
      Remove experiment flag, and set enabled behavior as default.
      
      Keep old behavior when asking the NTP and WebView to become first
      responder. This is done checking if the first responder is a view, and
      asking if not. Because in the previous logic for GetFirstResponder() the
      search was made in the view hierarchy, ignoring view controllers.
      
      The experiment enabled without the check added in this CL could explain
      issues like crbug.com/1150498.
      
      Bug: 816427, 1150498
      Change-Id: Ib9ac17b59da8635d00beff071aee4bd6afeedb78
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495976Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
      Commit-Queue: Javier Flores <javierrobles@chromium.org>
      Auto-Submit: Javier Flores <javierrobles@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830632}
      2aa1a2f6
    • Chris Lu's avatar
      [ios] Add histograms to location permissions experiment · 31bd38f0
      Chris Lu authored
      These histograms will be useful in validating that the client-side
      experiment is working.
      
      Bug: 1138603, 1149650
      Change-Id: I2e4f3d4fca2a750ad727d3c15fede3e0eb80db0e
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532859
      Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
      Reviewed-by: default avatarCaitlin Fischer <caitlinfischer@google.com>
      Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830631}
      31bd38f0
    • Stepan Khapugin's avatar
      [iOS] Fix shutdown crash with autocorrect. · 0ada9d84
      Stepan Khapugin authored
      Fixes a crash when autocorrect is not accepted yet by the user, and the
      app is being killed in background.
      
      Fixed: 1150965
      Change-Id: I8f8196d882db53b5211dfcdac53afee7bc784962
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555064
      Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
      Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
      Reviewed-by: default avatarRobbie Gibson <rkgibson@google.com>
      Cr-Commit-Position: refs/heads/master@{#830630}
      0ada9d84
    • dpapad's avatar
      WebUI: Exclude tracing_resources.grd/pak from Android builds via GN. · 45683e90
      dpapad authored
      Previously tracing_resources.grd was included in Android, as an empty
      file. Using GN to exclude the grd/pak files as well as
      content/browser/tracing/BUILD.gn as a whole seems more appropriate.
      
      Bug: None
      Change-Id: I36ea83a2477538d0def3fa914288c7a7c809231a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556394Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
      Commit-Queue: dpapad <dpapad@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830629}
      45683e90
    • Sigurdur Asgeirsson's avatar
      Fix null pointer access in HungPagesTableModel. · 9e404388
      Sigurdur Asgeirsson authored
      Looks like Reset is sometimes called without a preceding call to
      InitForWebContents.
      
      Bug: 1151304, 1145565
      Change-Id: Ia021767cf21b001d9ffef4ef6a945c93474a3892
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557221Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
      Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830628}
      9e404388
    • Liquan (Max) Gu's avatar
      [WebLayer] Hide PaymentMethodsSection behind PaymentUiService · 9a649041
      Liquan (Max) Gu authored
      Changes:
      * Hides the PaymentMethodsSection getter and setter in CPRService
        behind PaymentUiService and replace them with getPaymentApps. This
        is because "PaymentMethodsSection" is a UI term and "payment app" is
        an PaymentRequest API term.
      * Encapsulates the logic of "loading apps into app selector" behind
        PaymentUiService#loadPaymentApps().
      
      Bug: 1025619
      
      Change-Id: I310dffa9d926be853bda9d138c622d8d27b52706
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553310
      Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
      Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830627}
      9a649041
    • Sreerenj Balachandran's avatar
      vaapi/av1_decode: Fix film grain decode · 08dd69a0
      Sreerenj Balachandran authored
      For decoding the film-grain videos, we provide an additional
      vaSurface as input on top of the regular reconstruct surface.
      But when we invoke the vaBeginPicture API, the underlying driver
      always expects the reconstructed surface as the target,
      not the post-processed display surface.
      
      This patch ensures that the vaBeginPicture() always receives the
      reconstructed surface.
      
      Fixme: since the current av1_decoder implementation is not
      pre-allocating enough surfaces, film-grain decode will stall.
      
      Bug: b:172214398
      Test: video_decode_accelerator_tests
      Change-Id: I924b27b9d1f044b77786ab843fb37d99449eb706
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545237Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
      Reviewed-by: default avatarAndres Calderon Jaramillo <andrescj@chromium.org>
      Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
      Cr-Commit-Position: refs/heads/master@{#830626}
      08dd69a0
    • Matthias Körber's avatar
      [Autofill] Add finch guarded retrieval of overall predictions from cache · e638d7b5
      Matthias Körber authored
      Change-Id: If3d6d659df9265d1b16989fe6590dbdd61cc3b76
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537696
      Commit-Queue: Matthias Körber <koerber@google.com>
      Reviewed-by: default avatarChristoph Schwering <schwering@google.com>
      Cr-Commit-Position: refs/heads/master@{#830625}
      e638d7b5
    • Dave Tapuska's avatar
      Move link touch adjustment calculation and link highlight into base. · 99598799
      Dave Tapuska authored
      Move the calculation of the touch adjustment into the base widget.
      Protect link highlighting with a ForMainFrame as these rely on
      animations for the main frame.
      
      BUG=1097816
      
      Change-Id: If8e415c830fa0e89accc0f398809c0e7b9893664
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552228
      Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
      Reviewed-by: default avatardanakj <danakj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830624}
      99598799
    • Clemens Arbesser's avatar
      [Autofill Assistant] Allow injecting base64-encoded trigger scripts. · 09488245
      Clemens Arbesser authored
      Bug: b/174125596
      Change-Id: I0d31dbd880e542ea27d2558ccdbb2d0c59d839c1
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556523
      Commit-Queue: Clemens Arbesser <arbesser@google.com>
      Reviewed-by: default avatarMarian Fechete <marianfe@google.com>
      Reviewed-by: default avatarLukasz Suder <lsuder@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830623}
      09488245
    • chromium-autoroll's avatar
      Roll ANGLE from 084b862ba31b to 5fac02c8e485 (5 revisions) · bb1103a5
      chromium-autoroll authored
      https://chromium.googlesource.com/angle/angle.git/+log/084b862ba31b..5fac02c8e485
      
      2020-11-24 jmadill@chromium.org Revert "Vulkan: Fix incorrect exposure of sRGB extensions"
      2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 6ef69fbda85b to 0e8c2a5ca5f3 (6 revisions)
      2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6d612051c083 to 43bb60e1fa11 (6 revisions)
      2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0ec6b066bfbc to 31f74e1a4605 (1 revision)
      2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from b54d55122868 to 02a49daeeece (1 revision)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/angle-chromium-autoroll
      Please CC jmadill@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
      Bug: None
      Tbr: jmadill@google.com
      Change-Id: Ie0fc80dddc25c7c300e248f6376b4d4871751a00
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557912Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#830622}
      bb1103a5
    • Dave Tapuska's avatar
      Collapse Scroll[Begin|Update|End] into a common handler. · d62564d8
      Dave Tapuska authored
      Unify handling of gesture scroll events. Dismiss any outstanding
      page popup on these events.
      
      BUG=1097816
      
      Change-Id: I39fd4d4dd10ada132d9d440c1b9d72c81389f60a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551247
      Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
      Reviewed-by: default avatardanakj <danakj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830621}
      d62564d8
    • Yi Gu's avatar
      Mark virtual/android/fullscreen/video-scrolled-iframe.html as flaky · 0feb5f8c
      Yi Gu authored
      The test has been flaky recently:
      https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=not_site_per_process_blink_web_tests%20(with%20patch)&tests=virtual/android/fullscreen/video-scrolled-iframe.html
      
      TBR=msw@chromium.org
      NOTRY=True
      
      Bug: 1149771
      
      Change-Id: If879675625a80dabd88faaa17162f541db20d90e
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558169Reviewed-by: default avatarYi Gu <yigu@chromium.org>
      Commit-Queue: Yi Gu <yigu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830620}
      0feb5f8c
    • Justin DeWitt's avatar
      Revert "[ToolbarMVC] Move loadUrl logic to LocationBarMediator" · 4e3395cd
      Justin DeWitt authored
      This reverts commit 068a70b1.
      
      Reason for revert: Breaks internal compile:
      
      
      [1015/1490] ACTION //clank/javatests:clank_test_java__errorprone(//build/toolchain/android:android_clang_arm)
      FAILED: obj/clank/javatests/clank_test_java__errorprone.errorprone.stamp
      /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../build/android/gyp/compile_java.py --depfile=gen/clank/javatests/clank_test_java__errorprone.d --generated-dir=gen/clank/javatests/clank_test_java/generated_java --jar-path=obj/clank/javatests/clank_test_java__errorprone.errorprone.stamp --java-srcjars=\[\"gen/clank/javatests/clank_test_java.generated.srcjar\"\] --header-jar obj/clank/javatests/clank_test_java.turbine.jar --classpath=@FileArg\(gen/clank/javatests/clank_test_java.build_config:deps_info:javac_full_interface_classpath\) --java-version=1.8 --java-srcjars=@FileArg\(gen/clank/javatests/clank_test_java.build_config:deps_info:owned_resource_srcjars\) --bootclasspath=@FileArg\(gen/clank/javatests/clank_test_java.build_config:android:sdk_interface_jars\) --chromium-code=1 --warnings-as-errors --jar-info-exclude-globs=\[\"\*/R.class\",\ \"\*/R\\\$\*.class\",\ \"\*/Manifest.class\",\ \"\*/Manifest\\\$\*.class\",\ \"\*/GEN_JNI.class\"\] --processorpath=@FileArg\(gen/tools/android/errorprone_plugin/errorprone_plugin.build_config:deps_info:host_classpath\) --enable-errorprone @gen/clank/javatests/clank_test_java.sources
      Traceback (most recent call last):
      File "../../build/android/gyp/compile_java.py", line 756, in <module>
      sys.exit(main(sys.argv[1:]))
      File "../../build/android/gyp/compile_java.py", line 752, in main
      output_paths=output_paths)
      File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 64, in CallAndWriteDepfileIfStale
      track_subpaths_allowlist=track_subpaths_allowlist)
      File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/md5_check.py", line 155, in CallAndRecordIfStale
      function(*args)
      File "../../build/android/gyp/compile_java.py", line 747, in <lambda>
      lambda: _OnStaleMd5(options, javac_cmd, javac_args, java_files),
      File "../../build/android/gyp/compile_java.py", line 424, in _OnStaleMd5
      save_outputs=not options.enable_errorprone)
      File "../../build/android/gyp/compile_java.py", line 521, in _RunCompiler
      fail_on_output=options.warnings_as_errors)
      File "/b/s/w/ir/cache/builder/src/build/android/gyp/util/build_utils.py", line 272, in CheckOutput
      raise CalledProcessError(cwd, args, stdout + stderr)
      util.build_utils.CalledProcessError: Command failed: ( cd /b/s/w/ir/cache/builder/src/out/Debug; ../../third_party/jdk/current/bin/javac -g -encoding UTF-8 -sourcepath : -XDcompilePolicy=simple '-Xplugin:ErrorProne -XepAllErrorsAsWarnings -Xep:CollectionUndefinedEquality:OFF -Xep:ModifyCollectionInEnhancedForLoop:OFF -Xep:InvalidParam:OFF -Xep:InvalidLink:OFF -Xep:InvalidInlineTag:OFF -Xep:EmptyBlockTag:OFF -Xep:PublicConstructorForAbstractClass:OFF -Xep:InvalidBlockTag:OFF -Xep:StaticAssignmentInConstructor:OFF -Xep:MutablePublicArray:OFF -Xep:UnescapedEntity:OFF -Xep:NonCanonicalType:OFF -Xep:ProtectedMembersInFinalClass:OFF -Xep:AlmostJavadoc:OFF -Xep:DoubleBraceInitialization:OFF -Xep:CatchAndPrintStackTrace:OFF -Xep:SynchronizeOnNonFinalField:OFF -Xep:TypeParameterUnusedInFormals:OFF -Xep:CatchFail:OFF -Xep:JUnitAmbiguousTestClass:OFF -Xep:UnnecessaryParentheses:OFF -Xep:DefaultCharset:OFF -Xep:JdkObsolete:OFF -Xep:FunctionalInterfaceClash:OFF -Xep:FutureReturnValueIgnored:OFF -Xep:OperatorPrecedence:OFF -Xep:ThreadJoinLoop:OFF -Xep:StringSplitter:OFF -Xep:ClassNewInstance:OFF -Xep:ClassCanBeStatic:OFF -Xep:FloatCast:OFF -Xep:ThreadLocalUsage:OFF -Xep:Finally:OFF -Xep:FragmentNotInstantiable:OFF -Xep:HidingField:OFF -Xep:IntLongMath:OFF -Xep:BadComparable:OFF -Xep:EqualsHashCode:OFF -Xep:TypeParameterShadowing:OFF -Xep:ImmutableEnumChecker:OFF -Xep:InputStreamSlowMultibyteRead:OFF -Xep:BoxedPrimitiveConstructor:OFF -Xep:OverrideThrowableToString:OFF -Xep:CollectionToArraySafeParameter:OFF -Xep:ObjectToString:OFF -Xep:UnusedMethod:OFF -Xep:UnusedVariable:OFF -Xep:UnsafeReflectiveConstructionCast:OFF -Xep:MixedMutabilityReturnType:OFF -Xep:EqualsGetClass:OFF -Xep:UndefinedEquals:OFF -Xep:ExtendingJUnitAssert:OFF -Xep:SystemExitOutsideMain:OFF -Xep:TypeParameterNaming:OFF -Xep:UnusedException:OFF -Xep:UngroupedOverloads:OFF -Xep:FunctionalInterfaceClash:OFF -Xep:InconsistentOverloads:OFF -Xep:SameNameButDifferent:OFF -Xep:UnnecessaryLambda:OFF -Xep:UnnecessaryAnonymousClass:OFF -Xep:LiteProtoToString:OFF -Xep:MissingSummary:OFF -Xep:ReturnFromVoid:OFF -Xep:EmptyCatch:OFF -Xep:BadImport:OFF -Xep:UseCorrectAssertInTests:OFF -Xep:InlineFormatString:OFF -Xep:DefaultPackage:OFF -Xep:RefersToDaggerCodegen:OFF -Xep:RemoveUnusedImports:OFF -Xep:BinderIdentityRestoredDangerously:WARN -Xep:EmptyIf:WARN -Xep:EqualsBrokenForNull:WARN -Xep:InvalidThrows:WARN -Xep:LongLiteralLowerCaseSuffix:WARN -Xep:MultiVariableDeclaration:WARN -Xep:ParameterNotNullable:WARN -Xep:RedundantOverride:WARN -Xep:StaticQualifiedUsingExpression:WARN -Xep:StringEquality:WARN -Xep:TimeUnitMismatch:WARN -Xep:UnnecessaryStaticImport:WARN -Xep:UseBinds:WARN -Xep:WildcardImport:WARN' -XDshould-stop.ifNoError=FLOW -source 1.8 -target 1.8 -proc:none -bootclasspath obj/third_party/android_sdk/android.ijar.jar:../../third_party/jdk/extras/java_8/jre/lib/rt.jar -processorpath lib.java/tools/android/errorprone_plugin/errorprone_plugin.jar:lib.java/third_party/android_deps/com_google_auto_service_auto_service_annotations.jar:lib.java/third_party/android_deps/com_google_code_findbugs_jsr305.jar:lib.java/third_party/android_deps/com_google_errorprone_error_prone_annotations.jar:lib.java/third_party/android_deps/com_google_guava_failureaccess.jar:lib.java/third_party/android_deps/com_google_guava_listenablefuture.jar:lib.java/third_party/android_deps/com_google_j2objc_j2objc_annotations.jar:lib.java/third_party/android_deps/org_checkerframework_checker_qual.jar:lib.java/third_party/android_deps/org_codehaus_mojo_animal_sniffer_annotations.jar:lib.java/third_party/android_deps/com_google_guava_guava.jar:lib.java/third_party/android_deps/com_google_errorprone_error_prone_annotation.jar:lib.java/third_party/android_deps/com_github_ben_manes_caffeine_caffeine.jar:lib.java/third_party/android_deps/com_github_kevinstern_software_and_algorithms.jar:lib.java/third_party/android_deps/com_google_auto_value_auto_value_annotations.jar:lib.java/third_party/android_deps/com_google_errorprone_javac.jar:lib.java/third_party/android_deps/com_googlecode_java_diff_utils_diffutils.jar:lib.java/third_party/android_deps/org_checkerframework_dataflow_shaded.jar:lib.java/third_party/android_deps/com_google_errorprone_error_prone_check_api.jar:lib.java/third_party/android_deps/com_google_auto_auto_common.jar:lib.java/third_party/android_deps/com_google_code_findbugs_jFormatString.jar:lib.java/third_party/android_deps/com_google_errorprone_error_prone_type_annotations.jar:lib.java/third_party/android_deps/com_google_protobuf_protobuf_java.jar:lib.java/third_party/android_deps/org_pcollections_pcollections.jar:lib.java/third_party/android_deps/org_threeten_threeten_extra.jar:lib.java/third_party/android_deps/com_google_errorprone_error_prone_core.jar -d obj/clank/javatests/clank_test_java__errorprone.errorprone.stamp.staging/classes -classpath ../../clank/third_party/chimera/chimerastubs.jar:../../third_party/android_sdk/public/platforms/android-30/optional/android.test.base.jar:../../third_party/android_sdk/public/platforms/android-30/optional/android.test.mock.jar:../../third_party/android_sdk/public/platforms/android-30/optional/android.test.runner.jar:../../third_party/android_sdk/public/platforms/android-30/optional/org.apache.http.legacy.jar:obj/base/base_java.turbine.jar:obj/base/base_java_test_support.turbine.jar:obj/base/jni_java.turbine.jar:obj/cc/mojom/mojom_java.turbine.jar:obj/chrome/android/base_module_java.turbine.jar:obj/chrome/android/browser_java_test_support.turbine.jar:obj/chrome/android/chrome_java.turbine.jar:obj/chrome/android/chrome_test_util_java.turbine.jar:obj/chrome/android/features/dev_ui/public/java.turbine.jar:obj/chrome/android/features/keyboard_accessory/factory/public_java.turbine.jar:obj/chrome/android/features/keyboard_accessory/public/public_java.turbine.jar:obj/chrome/android/modules/cablev2_authenticator/public/java.turbine.jar:obj/chrome/android/modules/dev_ui/provider/java.turbine.jar:obj/chrome/android/modules/extra_icu/provider/java.turbine.jar:obj/chrome/android/modules/extra_icu/public/java.turbine.jar:obj/chrome/android/modules/image_editor/provider/java.turbine.jar:obj/chrome/android/modules/stack_unwinder/provider/java.turbine.jar:obj/chrome/android/modules/stack_unwinder/public/java.turbine.jar:obj/chrome/android/modules/test_dummy/provider/java.turbine.jar:obj/chrome/android/modules/test_dummy/public/java.turbine.jar:obj/chrome/android/partner_location_descriptor_proto_java.turbine.jar:obj/chrome/android/update_proto_java.turbine.jar:obj/chrome/android/usage_stats_proto_java.turbine.jar:obj/chrome/android/webapk/libs/client/client_java.turbine.jar:obj/chrome/android/webapk/libs/common/common_java.turbine.jar:obj/chrome/android/webapk/libs/common/splash_java.turbine.jar:obj/chrome/android/webapk/libs/runtime_library/webapk_service_aidl_java.turbine.jar:obj/chrome/browser/android/crypto/java.turbine.jar:obj/chrome/browser/android/externalauth/java.turbine.jar:obj/chrome/browser/android/lifecycle/java.turbine.jar:obj/chrome/browser/banners/android/java.turbine.jar:obj/chrome/browser/browser_controls/android/java.turbine.jar:obj/chrome/browser/contextmenu/java.turbine.jar:obj/chrome/browser/device/java.turbine.jar:obj/chrome/browser/download/android/factory_java.turbine.jar:obj/chrome/browser/download/android/java.turbine.jar:obj/chrome/browser/endpoint_fetcher/java.turbine.jar:obj/chrome/browser/engagement/android/java.turbine.jar:obj/chrome/browser/enterprise/util/java.turbine.jar:obj/chrome/browser/feedback/android/java.turbine.jar:obj/chrome/browser/flags/java.turbine.jar:obj/chrome/browser/fullscreen/android/java.turbine.jar:obj/chrome/browser/image_descriptions/java.turbine.jar:obj/chrome/browser/image_editor/public/java.turbine.jar:obj/chrome/browser/image_fetcher/java.turbine.jar:obj/chrome/browser/incognito/interstitial/android/java.turbine.jar:obj/chrome/browser/metrics_settings/android/java.turbine.jar:obj/chrome/browser/notifications/chime/android/java.turbine.jar:obj/chrome/browser/offline_pages/android/java.turbine.jar:obj/chrome/browser/omaha/android/java.turbine.jar:obj/chrome/browser/optimization_guide/android/java.turbine.jar:obj/chrome/browser/paint_preview/android/java.turbine.jar:obj/chrome/browser/password_check/android/internal/public_factory_java.turbine.jar:obj/chrome/browser/password_check/android/internal/public_ui_factory_java.turbine.jar:obj/chrome/browser/password_check/android/password_check_java_enums.turbine.jar:obj/chrome/browser/password_check/android/public_java.turbine.jar:obj/chrome/browser/password_check/android/public_ui_java.turbine.jar:obj/chrome/browser/password_manager/android/java.turbine.jar:obj/chrome/browser/performance_hints/android/java.turbine.jar:obj/chrome/browser/policy/android/java.turbine.jar:obj/chrome/browser/preferences/java.turbine.jar:obj/chrome/browser/privacy/java.turbine.jar:obj/chrome/browser/profiles/android/java.turbine.jar:obj/chrome/browser/safe_browsing/android/java.turbine.jar:obj/chrome/browser/safety_check/android/java.turbine.jar:obj/chrome/browser/settings/java.turbine.jar:obj/chrome/browser/settings/test_support_java.turbine.jar:obj/chrome/browser/share/java.turbine.jar:obj/chrome/browser/signin/android/java.turbine.jar:obj/chrome/browser/signin/services/android/java.turbine.jar:obj/chrome/browser/tab/critical_persisted_tab_data_proto_java.turbine.jar:obj/chrome/browser/tab/java.turbine.jar:obj/chrome/browser/tabmodel/factory_java.turbine.jar:obj/chrome/browser/tabmodel/java.turbine.jar:obj/chrome/browser/tabpersistence/java.turbine.jar:obj/chrome/browser/test_dummy/internal/base_module_java.turbine.jar:obj/chrome/browser/test_dummy/java.turbine.jar:obj/chrome/browser/thumbnail/generator/java.turbine.jar:obj/chrome/browser/thumbnail/generator/proto_java.turbine.jar:obj/chrome/browser/ui/android/appmenu/factory_java.turbine.jar:obj/chrome/browser/ui/android/appmenu/internal/java.turbine.jar:obj/chrome/browser/ui/android/appmenu/java.turbine.jar:obj/chrome/browser/ui/android/appmenu/test/test_support_java.turbine.jar:obj/chrome/browser/ui/android/default_browser_promo/java.turbine.jar:obj/chrome/browser/ui/android/favicon/java.turbine.jar:obj/chrome/browser/ui/android/layouts/java.turbine.jar:obj/chrome/browser/ui/android/layouts/third_party/float_property/java.turbine.jar:obj/chrome/browser/ui/android/native_page/java.turbine.jar:obj/chrome/browser/ui/messages/android/java.turbine.jar:obj/chrome/browser/uid/android/java.turbine.jar:obj/chrome/browser/user_education/java.turbine.jar:obj/chrome/browser/util/java.turbine.jar:obj/chrome/browser/version/java.turbine.jar:obj/chrome/browser/video_tutorials/factory_java.turbine.jar:obj/chrome/browser/video_tutorials/java.turbine.jar:obj/chrome/browser/webauthn/android/java.turbine.jar:obj/chrome/browser/xsurface/java.turbine.jar:obj/chrome/test/android/chrome_java_test_support.turbine.jar:obj/clank/browser/chime/java.turbine.jar:obj/clank/components/safe_browsing/safe_browsing_java.turbine.jar:obj/clank/features/chime/public/java.turbine.jar:obj/clank/features/image_editor/provider/java.turbine.jar:obj/clank/features/image_editor/public/java.turbine.jar:obj/clank/java/base_module_java.turbine.jar:obj/clank/java/clank_java.turbine.jar:obj/clank/java/partnercustomization_proto_java.turbine.jar:obj/clank/java/usage_stats_java.turbine.jar:obj/clank/java/usage_stats_proto_java.turbine.jar:obj/clank/third_party/android_deps/google_android_datatransport_transport_api_java.ijar.jar:obj/clank/third_party/android_deps/google_android_datatransport_transport_backend_cct_java.ijar.jar:obj/clank/third_party/android_deps/google_android_datatransport_transport_runtime_java.ijar.jar:obj/clank/third_party/android_deps/google_firebase_firebase_appindexing_java.ijar.jar:obj/clank/third_party/android_deps/google_firebase_firebase_common_java.ijar.jar:obj/clank/third_party/android_deps/google_firebase_firebase_components_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_auth_api_phone_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_auth_base_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_auth_folsom_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_base_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_basement_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_cast_framework_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_cast_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_clearcut_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_feedback_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_fido_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_gcm_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_gmscompliance_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_googlehelp_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_identity_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_iid_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_instantapps_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_location_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_maps_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_ocr_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_people_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_phenotype_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_safetynet_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_stats_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_tasks_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_vision_common_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_vision_java.ijar.jar:obj/clank/third_party/android_deps/google_play_services_wallet_java.ijar.jar:obj/clank/third_party/android_edu/android_edu_java.turbine.jar:obj/clank/third_party/android_finsky/android_finsky_java.turbine.jar:obj/clank/third_party/android_vending/android_vending_java.turbine.jar:obj/clank/third_party/context_proto/context_proto_java.turbine.jar:obj/clank/third_party/google3/all_common.ijar.jar:obj/clank/third_party/google3/gsf.ijar.jar:obj/clank/third_party/google3/guava.ijar.jar:obj/clank/third_party/google3/material.ijar.jar:obj/clank/third_party/google3/material_and_gms_common.ijar.jar:obj/clank/third_party/google3/material_feature_highlight.ijar.jar:obj/clank/third_party/google3/material_font.ijar.jar:obj/clank/third_party/google3/phenotype_flags.ijar.jar:obj/clank/third_party/google3/proguard_annotations.ijar.jar:obj/clank/third_party/google3/protobuf.ijar.jar:obj/clank/third_party/google3/protobuf_generated_registry.ijar.jar:obj/clank/third_party/hats/hats_library_java.ijar.jar:obj/clank/third_party/hats/hats_survey_data_proto_java.turbine.jar:obj/clank/third_party/highcommand/highcommand.ijar.jar:obj/clank/third_party/lens/lens_sdk_google3_java.ijar.jar:obj/components/autofill/android/autofill_java.turbine.jar:obj/components/autofill_assistant/browser/proto_java.turbine.jar:obj/components/background_task_scheduler/background_task_scheduler_task_ids_java.turbine.jar:obj/components/background_task_scheduler/factory_java.turbine.jar:obj/components/background_task_scheduler/internal/internal_java.turbine.jar:obj/components/background_task_scheduler/internal/native_task_java.turbine.jar:obj/components/background_task_scheduler/internal/proto_java.turbine.jar:obj/components/background_task_scheduler/public_java.turbine.jar:obj/components/bookmarks/common/android/bookmarks_java.turbine.jar:obj/components/browser_ui/android/bottomsheet/factory_java.turbine.jar:obj/components/browser_ui/android/bottomsheet/java.turbine.jar:obj/components/browser_ui/android/bottomsheet/manager_java.turbine.jar:obj/components/browser_ui/banners/android/java.turbine.jar:obj/components/browser_ui/client_certificate/android/java.turbine.jar:obj/components/browser_ui/contacts_picker/android/java.turbine.jar:obj/components/browser_ui/display_cutout/android/java.turbine.jar:obj/components/browser_ui/http_auth/android/java.turbine.jar:obj/components/browser_ui/media/android/java.turbine.jar:obj/components/browser_ui/modaldialog/android/java.turbine.jar:obj/components/browser_ui/notifications/android/java.turbine.jar:obj/components/browser_ui/notifications/android/test_support_java.turbine.jar:obj/components/browser_ui/photo_picker/android/java.turbine.jar:obj/components/browser_ui/settings/android/java.turbine.jar:obj/components/browser_ui/share/android/java.turbine.jar:obj/components/browser_ui/site_settings/android/java.turbine.jar:obj/components/browser_ui/sms/android/java.turbine.jar:obj/components/browser_ui/styles/android/java.turbine.jar:obj/components/browser_ui/util/android/java.turbine.jar:obj/components/browser_ui/webshare/android/java.turbine.jar:obj/components/browser_ui/widget/android/java.turbine.jar:obj/components/browser_ui/widget/android/test_support_java.turbine.jar:obj/components/content_capture/android/java.turbine.jar:obj/components/content_settings/android/content_settings_enums_java.turbine.jar:obj/components/content_settings/android/java.turbine.jar:obj/components/content_settings/core/common/mojo_bindings_java.turbine.jar:obj/components/contextual_search/content/common/mojom/mojom_java.turbine.jar:obj/components/crash/android/java.turbine.jar:obj/components/dom_distiller/content/browser/android/dom_distiller_content_java.turbine.jar:obj/components/dom_distiller/core/android/dom_distiller_core_java.turbine.jar:obj/components/dom_distiller/core/mojom/mojom_java.turbine.jar:obj/components/download/internal/background_service/internal_java.turbine.jar:obj/components/download/internal/common/internal_java.turbine.jar:obj/components/download/network/network_java.turbine.jar:obj/components/download/public/common/public_java.turbine.jar:obj/components/download/public/task/public_java.turbine.jar:obj/components/embedder_support/android/application_java.turbine.jar:obj/components/embedder_support/android/browser_context_java.turbine.jar:obj/components/embedder_support/android/content_view_java.turbine.jar:obj/components/embedder_support/android/context_menu_java.turbine.jar:obj/components/embedder_support/android/util_java.turbine.jar:obj/components/embedder_support/android/web_contents_delegate_java.turbine.jar:obj/components/external_intents/android/java.turbine.jar:obj/components/favicon/android/java.turbine.jar:obj/components/feature_engagement/internal/internal_java.turbine.jar:obj/components/feature_engagement/public/public_java.turbine.jar:obj/components/feed/core/proto/proto_java.turbine.jar:obj/components/feed/core/proto/proto_java_v2.turbine.jar:obj/components/find_in_page/android/java.turbine.jar:obj/components/gcm_driver/android/gcm_driver_java.turbine.jar:obj/components/gcm_driver/instance_id/android/instance_id_driver_java.turbine.jar:obj/components/infobars/android/infobar_android_enums_java.turbine.jar:obj/components/infobars/android/java.turbine.jar:obj/components/infobars/core/infobar_enums_java.turbine.jar:obj/components/javascript_dialogs/android/java.turbine.jar:obj/components/language/android/language_bridge_java.turbine.jar:obj/components/location/android/location_java.turbine.jar:obj/components/location/android/settings_java.turbine.jar:obj/components/media_router/browser/android/cast_options_provider_java.turbine.jar:obj/components/media_router/browser/android/java.turbine.jar:obj/components/messages/android/factory_java.turbine.jar:obj/components/messages/android/java.turbine.jar:obj/components/messages/android/manager_java.turbine.jar:obj/components/minidump_uploader/minidump_uploader_java.turbine.jar:obj/components/module_installer/android/module_installer_java.turbine.jar:obj/components/module_installer/android/module_interface_java.turbine.jar:obj/components/navigation_interception/android/navigation_interception_java.turbine.jar:obj/components/offline_items_collection/core/core_java.turbine.jar:obj/components/omnibox/browser/browser_java.turbine.jar:obj/components/optimization_guide/proto/optimization_guide_proto_java.turbine.jar:obj/components/page_info/android/java.turbine.jar:obj/components/page_info/android/page_info_action_enum_java.turbine.jar:obj/components/paint_preview/browser/android/java.turbine.jar:obj/components/paint_preview/player/android/java.turbine.jar:obj/components/password_manager/core/browser/password_manager_java_enums.turbine.jar:obj/components/payments/content/android/all_java.turbine.jar:obj/components/payments/content/android/service_java.turbine.jar:obj/components/payments/mojom/mojom_java.turbine.jar:obj/components/permissions/android/java.turbine.jar:obj/components/policy/android/policy_java.turbine.jar:obj/components/policy/android/policy_java_test_support.turbine.jar:obj/components/prefs/android/java.turbine.jar:obj/components/query_tiles/public_java.turbine.jar:obj/components/query_tiles/query_tile_java.turbine.jar:obj/components/safe_browsing/android/safe_browsing_java.turbine.jar:obj/components/schema_org/common/mojom_java.turbine.jar:obj/components/search_engines/android/java.turbine.jar:obj/components/security_interstitials/content/android/java.turbine.jar:obj/components/security_state/content/android/java.turbine.jar:obj/components/security_state/core/security_state_enums_java.turbine.jar:obj/components/services/filesystem/public/mojom/mojom_java.turbine.jar:obj/components/signin/core/browser/android/java.turbine.jar:obj/components/signin/core/browser/android/signin_java_test_support.turbine.jar:obj/components/signin/core/browser/signin_enums_java.turbine.jar:obj/components/signin/public/android/java.turbine.jar:obj/components/spellcheck/browser/android/java.turbine.jar:obj/components/strictmode/android/java.turbine.jar:obj/components/subresource_filter/android/java.turbine.jar:obj/components/sync/android/sync_java.turbine.jar:obj/components/sync/protocol/protocol_java.turbine.jar:obj/components/thin_webview/factory_java.turbine.jar:obj/components/thin_webview/internal/internal_java.turbine.jar:obj/components/thin_webview/java.turbine.jar:obj/components/translate/content/android/java.turbine.jar:obj/components/translate/content/android/translate_android_enums_java.turbine.jar:obj/components/translate/core/common/translate_infobar_event_enum_java.turbine.jar:obj/components/url_formatter/android/url_formatter_java.turbine.jar:obj/components/user_prefs/android/java.turbine.jar:obj/components/variations/android/variations_java.turbine.jar:obj/components/version_info/android/version_constants_java.turbine.jar:obj/components/viz/common/common_java.turbine.jar:obj/components/viz/service/service_java.turbine.jar:obj/components/webapk/android/libs/client/java.turbine.jar:obj/components/webapk/android/libs/common/java.turbine.jar:obj/components/webrtc/android/java.turbine.jar:obj/components/webxr/android/ar_java_base.turbine.jar:obj/components/webxr/android/ar_java_interfaces.turbine.jar:obj/components/webxr/android/webxr_android_enums_java.turbine.jar:obj/content/public/android/content_java.turbine.jar:obj/content/public/common/trust_tokens_mojo_bindings_java.turbine.jar:obj/content/public/test/android/android_test_message_pump_support_java.turbine.jar:obj/content/public/test/android/content_java_test_support.turbine.jar:obj/device/bluetooth/java.turbine.jar:obj/device/gamepad/java.turbine.jar:obj/gpu/ipc/common/gpu_preferences_interface_java.turbine.jar:obj/gpu/ipc/common/interfaces_java.turbine.jar:obj/gpu/ipc/common/vulkan_interface_java.turbine.jar:obj/media/base/android/display_java.turbine.jar:obj/media/base/android/media_java.turbine.jar:obj/media/capture/content/android/screen_capture_java.turbine.jar:obj/media/capture/mojom/video_capture_java.turbine.jar:obj/media/capture/video/android/capture_java.turbine.jar:obj/media/learning/mojo/public/mojom/mojom_java.turbine.jar:obj/media/midi/midi_java.turbine.jar:obj/media/mojo/mojom/mojom_java.turbine.jar:obj/mojo/public/java/base_java.turbine.jar:obj/mojo/public/java/bindings_java.turbine.jar:obj/mojo/public/java/system/system_impl_java.turbine.jar:obj/mojo/public/java/system_java.turbine.jar:obj/mojo/public/mojom/base/base_java.turbine.jar:obj/net/android/embedded_test_server_aidl_java.turbine.jar:obj/net/android/net_java.turbine.jar:obj/net/android/net_java_test_support.turbine.jar:obj/net/android/net_thread_stats_uid_java.turbine.jar:obj/printing/printing_java.turbine.jar:obj/services/data_decoder/public/cpp/android/safe_json_java.turbine.jar:obj/services/data_decoder/public/mojom/mojom_resource_snapshot_for_web_bundle_java.turbine.jar:obj/services/device/battery/android/battery_monitor_java.turbine.jar:obj/services/device/generic_sensor/java.turbine.jar:obj/services/device/geolocation/geolocation_java.turbine.jar:obj/services/device/java.turbine.jar:obj/services/device/nfc/android/java.turbine.jar:obj/services/device/public/java/device_feature_list_java.turbine.jar:obj/services/device/public/java/geolocation_java.turbine.jar:obj/services/device/public/java/nfc_java.turbine.jar:obj/services/device/public/mojom/generic_sensor_java.turbine.jar:obj/services/device/public/mojom/mojom_java.turbine.jar:obj/services/device/public/mojom/usb_java.turbine.jar:obj/services/device/screen_orientation/java.turbine.jar:obj/services/device/time_zone_monitor/java.turbine.jar:obj/services/device/usb/java.turbine.jar:obj/services/device/vibration/android/vibration_manager_java.turbine.jar:obj/services/device/wake_lock/power_save_blocker/java.turbine.jar:obj/services/media_session/public/cpp/android/media_session_java.turbine.jar:obj/services/media_session/public/mojom/mojom_java.turbine.jar:obj/services/network/public/mojom/cookies_mojom_java.turbine.jar:obj/services/network/public/mojom/mojom_ip_address_java.turbine.jar:obj/services/network/public/mojom/mojom_java.turbine.jar:obj/services/network/public/mojom/mojom_network_isolation_key_java.turbine.jar:obj/services/network/public/mojom/mojom_schemeful_site_java.turbine.jar:obj/services/network/public/mojom/url_loader_base_java.turbine.jar:obj/services/network/public/mojom/websocket_mojom_java.turbine.jar:obj/services/proxy_resolver/public/mojom/mojom_java.turbine.jar:obj/services/service_manager/public/java/service_manager_java.turbine.jar:obj/services/service_manager/public/mojom/constants_java.turbine.jar:obj/services/service_manager/public/mojom/mojom_java.turbine.jar:obj/services/shape_detection/public/mojom/mojom_java.turbine.jar:obj/services/shape_detection/shape_detection_java.turbine.jar:obj/services/viz/public/mojom/mojom_java.turbine.jar:obj/skia/public/mojom/mojom_java.turbine.jar:obj/testing/android/reporter/reporter_java.turbine.jar:obj/third_party/accessibility_test_framework/accessibility-test-framework.ijar.jar:obj/third_party/android_data_chart/android_data_chart_java.turbine.jar:obj/third_party/android_deps/android_arch_core_common.ijar.jar:obj/third_party/android_deps/android_arch_core_runtime_java.ijar.jar:obj/third_party/android_deps/android_arch_lifecycle_common.ijar.jar:obj/third_party/android_deps/android_arch_lifecycle_livedata_core_java.ijar.jar:obj/third_party/android_deps/android_arch_lifecycle_livedata_java.ijar.jar:obj/third_party/android_deps/android_arch_lifecycle_runtime_java.ijar.jar:obj/third_party/android_deps/android_arch_lifecycle_viewmodel_java.ijar.jar:obj/third_party/android_deps/androidx_activity_activity_java.ijar.jar:obj/third_party/android_deps/androidx_annotation_annotation.ijar.jar:obj/third_party/android_deps/androidx_annotation_annotation_experimental_java.ijar.jar:obj/third_party/android_deps/androidx_appcompat_appcompat_java.ijar.jar:obj/third_party/android_deps/androidx_appcompat_appcompat_resources_java.ijar.jar:obj/third_party/android_deps/androidx_arch_core_core_common.ijar.jar:obj/third_party/android_deps/androidx_arch_core_core_runtime_java.ijar.jar:obj/third_party/android_deps/androidx_asynclayoutinflater_asynclayoutinflater_java.ijar.jar:obj/third_party/android_deps/androidx_cardview_cardview_java.ijar.jar:obj/third_party/android_deps/androidx_collection_collection.ijar.jar:obj/third_party/android_deps/androidx_concurrent_concurrent_futures.ijar.jar:obj/third_party/android_deps/androidx_coordinatorlayout_coordinatorlayout_java.ijar.jar:obj/third_party/android_deps/androidx_core_core_java.ijar.jar:obj/third_party/android_deps/androidx_cursoradapter_cursoradapter_java.ijar.jar:obj/third_party/android_deps/androidx_customview_customview_java.ijar.jar:obj/third_party/android_deps/androidx_documentfile_documentfile_java.ijar.jar:obj/third_party/android_deps/androidx_drawerlayout_drawerlayout_java.ijar.jar:obj/third_party/android_deps/androidx_fragment_fragment_java.ijar.jar:obj/third_party/android_deps/androidx_gridlayout_gridlayout_java.ijar.jar:obj/third_party/android_deps/androidx_interpolator_interpolator_java.ijar.jar:obj/third_party/android_deps/androidx_legacy_legacy_support_core_ui_java.ijar.jar:obj/third_party/android_deps/androidx_legacy_legacy_support_core_utils_java.ijar.jar:obj/third_party/android_deps/androidx_legacy_legacy_support_v4_java.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_common.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_common_java8.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_livedata_core_java.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_livedata_java.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_runtime_java.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_viewmodel_java.ijar.jar:obj/third_party/android_deps/androidx_lifecycle_lifecycle_viewmodel_savedstate_java.ijar.jar:obj/third_party/android_deps/androidx_loader_loader_java.ijar.jar:obj/third_party/android_deps/androidx_localbroadcastmanager_localbroadcastmanager_java.ijar.jar:obj/third_party/android_deps/androidx_media_media_java.ijar.jar:obj/third_party/android_deps/androidx_mediarouter_mediarouter_java.ijar.jar:obj/third_party/android_deps/androidx_multidex_multidex_java.ijar.jar:obj/third_party/android_deps/androidx_palette_palette_java.ijar.jar:obj/third_party/android_deps/androidx_preference_preference_java.ijar.jar:obj/third_party/android_deps/androidx_print_print_java.ijar.jar:obj/third_party/android_deps/androidx_recyclerview_recyclerview_java.ijar.jar:obj/third_party/android_deps/androidx_savedstate_savedstate_java.ijar.jar:obj/third_party/android_deps/androidx_slidingpanelayout_slidingpanelayout_java.ijar.jar:obj/third_party/android_deps/androidx_swiperefreshlayout_swiperefreshlayout_java.ijar.jar:obj/third_party/android_deps/androidx_test_monitor_java.ijar.jar:obj/third_party/android_deps/androidx_test_runner_java.ijar.jar:obj/third_party/android_deps/androidx_test_uiautomator_uiautomator_java.ijar.jar:obj/third_party/android_deps/androidx_transition_transition_java.ijar.jar:obj/third_party/android_deps/androidx_vectordrawable_vectordrawable_animated_java.ijar.jar:obj/third_party/android_deps/androidx_vectordrawable_vectordrawable_java.ijar.jar:obj/third_party/android_deps/androidx_versionedparcelable_versionedparcelable_java.ijar.jar:obj/third_party/android_deps/androidx_viewpager2_viewpager2_java.ijar.jar:obj/third_party/android_deps/androidx_viewpager_viewpager_java.ijar.jar:obj/third_party/android_deps/chromium_play_services_availability_java.turbine.jar:obj/third_party/android_deps/com_android_support_asynclayoutinflater_java.ijar.jar:obj/third_party/android_deps/com_android_support_collections.ijar.jar:obj/third_party/android_deps/com_android_support_coordinatorlayout_java.ijar.jar:obj/third_party/android_deps/com_android_support_cursoradapter_java.ijar.jar:obj/third_party/android_deps/com_android_support_customview_java.ijar.jar:obj/third_party/android_deps/com_android_support_documentfile_java.ijar.jar:obj/third_party/android_deps/com_android_support_drawerlayout_java.ijar.jar:obj/third_party/android_deps/com_android_support_interpolator_java.ijar.jar:obj/third_party/android_deps/com_android_support_loader_java.ijar.jar:obj/third_party/android_deps/com_android_support_localbroadcastmanager_java.ijar.jar:obj/third_party/android_deps/com_android_support_print_java.ijar.jar:obj/third_party/android_deps/com_android_support_slidingpanelayout_java.ijar.jar:obj/third_party/android_deps/com_android_support_support_annotations.ijar.jar:obj/third_party/android_deps/com_android_support_support_compat_java.ijar.jar:obj/third_party/android_deps/com_android_support_support_core_ui_java.ijar.jar:obj/third_party/android_deps/com_android_support_support_core_utils_java.ijar.jar:obj/third_party/android_deps/com_android_support_swiperefreshlayout_java.ijar.jar:obj/third_party/android_deps/com_android_support_versionedparcelable_java.ijar.jar:obj/third_party/android_deps/com_android_support_viewpager_java.ijar.jar:obj/third_party/android_deps/com_google_code_findbugs_jsr305.ijar.jar:obj/third_party/android_deps/com_google_dagger_dagger.ijar.jar:obj/third_party/android_deps/com_google_errorprone_error_prone_annotations.ijar.jar:obj/third_party/android_deps/com_google_guava_guava_android.ijar.jar:obj/third_party/android_deps/com_google_guava_listenablefuture.ijar.jar:obj/third_party/android_deps/com_google_j2objc_j2objc_annotations.ijar.jar:obj/third_party/android_deps/javax_inject_javax_inject.ijar.jar:obj/third_party/android_deps/local_modifications/androidx_fragment_fragment/androidx_fragment_fragment_java.ijar.jar:obj/third_party/android_deps/local_modifications/androidx_preference_preference/androidx_preference_preference_java.ijar.jar:obj/third_party/android_deps/net_sf_kxml_kxml2.ijar.jar:obj/third_party/android_deps/org_checkerframework_checker_compat_qual.ijar.jar:obj/third_party/android_deps/org_codehaus_mojo_animal_sniffer_annotations.ijar.jar:obj/third_party/android_deps/utils/java.turbine.jar:obj/third_party/android_media/android_media_java.turbine.jar:obj/third_party/android_provider/android_provider_java.turbine.jar:obj/third_party/android_sdk/android_support_chromium_java.turbine.jar:obj/third_party/android_sdk/androidx_browser/androidx_browser_java.turbine.jar:obj/third_party/android_sdk/gcm.ijar.jar:obj/third_party/android_support_test_runner/exposed-instrumentation-api-publish-no-dep.ijar.jar:obj/third_party/android_support_test_runner/rules_java.ijar.jar:obj/third_party/android_support_test_runner/runner-release-no-dep.ijar.jar:obj/third_party/android_swipe_refresh/android_swipe_refresh_java.turbine.jar:obj/third_party/blink/public/blink_headers_java.turbine.jar:obj/third_party/blink/public/mojom/android_mojo_bindings_java.turbine.jar:obj/third_party/blink/public/mojom/authenticator_test_mojo_bindings_java.turbine.jar:obj/third_party/blink/public/mojom/color_scheme_mojo_bindings_java.turbine.jar:obj/third_party/blink/public/mojom/dom_storage/dom_storage_java.turbine.jar:obj/third_party/blink/public/mojom/frame/frame_java.turbine.jar:obj/third_party/blink/public/mojom/gpu/gpu_java.turbine.jar:obj/third_party/blink/public/mojom/mojom_core_java.turbine.jar:obj/third_party/blink/public/mojom/mojom_mhtml_load_result_java.turbine.jar:obj/third_party/blink/public/mojom/mojom_platform_java.turbine.jar:obj/third_party/blink/public/mojom/script_type_mojo_bindings_java.turbine.jar:obj/third_party/blink/public/mojom/service_worker/storage_java.turbine.jar:obj/third_party/blink/public/mojom/tokens/tokens_java.turbine.jar:obj/third_party/blink/public/mojom/usb/usb_java.turbine.jar:obj/third_party/blink/public/mojom/web_feature_mojo_bindings_java.turbine.jar:obj/third_party/espresso/espresso-contrib-release-no-dep.ijar.jar:obj/third_party/espresso/espresso-core-release-no-dep.ijar.jar:obj/third_party/espresso/espresso-idling-resource-release-no-dep.ijar.jar:obj/third_party/espresso/espresso-intents-release-no-dep.ijar.jar:obj/third_party/espresso/espresso-web-release-no-dep.ijar.jar:obj/third_party/gif_player/gif_player_java.turbine.jar:obj/third_party/google_android_play_core/com_google_android_play_core_java.ijar.jar:obj/third_party/hamcrest/hamcrest-core.ijar.jar:obj/third_party/hamcrest/hamcrest-library.ijar.jar:obj/third_party/junit/junit.turbine.jar:obj/third_party/metrics_proto/metrics_proto_java.turbine.jar:obj/third_party/ub-uiautomator/ub-uiautomator.ijar.jar:obj/ui/android/ui_java_test_support.turbine.jar:obj/ui/android/ui_no_recycler_view_java.turbine.jar:obj/ui/android/ui_recycler_view_java.turbine.jar:obj/ui/android/ui_utils_java.turbine.jar:obj/ui/base/cursor/mojom/cursor_type_java.turbine.jar:obj/ui/base/cursor/mojom/mojom_java.turbine.jar:obj/ui/base/dragdrop/mojom/mojom_java.turbine.jar:obj/ui/base/ime/mojom/mojom_java.turbine.jar:obj/ui/base/mojom/mojom_java.turbine.jar:obj/ui/display/mojom/mojom_java.turbine.jar:obj/ui/events/mojom/mojom_java.turbine.jar:obj/ui/gfx/geometry/mojom/mojom_java.turbine.jar:obj/ui/gfx/mojom/mojom_java.turbine.jar:obj/ui/gfx/mojom/native_handle_types_java.turbine.jar:obj/ui/gfx/range/mojom/mojom_java.turbine.jar:obj/ui/gl/mojom/mojom_java.turbine.jar:obj/ui/latency/mojom/mojom_java.turbine.jar:obj/url/gurl_android_test_helper_java.turbine.jar:obj/url/gurl_java.turbine.jar:obj/url/mojom/url_mojom_gurl_java.turbine.jar:obj/url/mojom/url_mojom_origin_java.turbine.jar:obj/url/origin_java.turbine.jar @obj/clank/javatests/clank_test_java__errorprone.errorprone.stamp.staging/files_list.txt )
      ../../clank/javatests/src/com/google/android/apps/chrome/googleintegration/GwsIntegrationTest.java:320: error: cannot find symbol
      locationBar.performSearchQuery(query, null);
      ^
      symbol:   method performSearchQuery(String,<null>)
      location: variable locationBar of type LocationBarLayout
      1 error
      
      
      Original change's description:
      > [ToolbarMVC] Move loadUrl logic to LocationBarMediator
      >
      > Bug: 1147581
      > Change-Id: Ic19a6f597138d6d9a769ac1fb186a317d8e3f3fe
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551466
      > Commit-Queue: Brandon Wylie <wylieb@chromium.org>
      > Reviewed-by: Ted Choc <tedchoc@chromium.org>
      > Reviewed-by: Filip Gorski <fgorski@chromium.org>
      > Reviewed-by: Patrick Noland <pnoland@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#830389}
      
      TBR=fgorski@chromium.org,tedchoc@chromium.org,wylieb@chromium.org,pnoland@chromium.org,bttk@chromium.org
      
      Change-Id: I350d1c2c7b8b349e786192f42a109b9ed50d9121
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 1147581
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558570Reviewed-by: default avatarJustin DeWitt <dewittj@chromium.org>
      Commit-Queue: Justin DeWitt <dewittj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830619}
      4e3395cd
    • Christoph Schwering's avatar
      [Autofill] Cleaned up autofill validation functions. · fb743598
      Christoph Schwering authored
      This cosmetic CL rewrites the validation functions
      for autofill data in a declarative way.
      
      Bug: 1007974
      Change-Id: I99f8171caf67b3ebc711afe2cc231f73eb310684
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440873Reviewed-by: default avatarMatthias Körber <koerber@google.com>
      Commit-Queue: Christoph Schwering <schwering@google.com>
      Cr-Commit-Position: refs/heads/master@{#830618}
      fb743598
    • Dave Tapuska's avatar
      Break up HandleGestureEvent into base. · a061eada
      Dave Tapuska authored
      Move scaling and some checks into base.
      Move kGestureDoubleTap handling into base.
      Add temporary method to call for the other types of gestures.
      Remove event_cancelled from DidHandleGestureEvent.
      
      BUG=1097816
      
      Change-Id: I26bfe8a9a53b080c3ccf5dd3a005ad45bc4739ad
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551242
      Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
      Reviewed-by: default avatardanakj <danakj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830617}
      a061eada
    • Sylvain Defresne's avatar
      [ios] Always use symbolic links to system Xcode in build_root_dir · a06a6eb7
      Sylvain Defresne authored
      Goma RBE only supports paths that are relative to the source dir
      while build not using Goma or using old Goma backend supports both
      so always use symbolic link to system Xcode on iOS.
      
      This fix the compilation for people using Goma as Goma RBE is now
      the default backend and without this change, the build would fall
      back to local compilation, drastically slowing the build.
      
      Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe
      gn variables as they are now always expected to be `true`. Keep
      the variable ios_use_goma_rbe to avoid breaking the bots that do
      override the value but ignore it (bot set it to true anyway).
      
      Bug: none
      Change-Id: I2a3c098304594fb20491ab92100e9a4101a048db
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555117
      Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
      Reviewed-by: default avatarNico Weber <thakis@chromium.org>
      Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830616}
      a06a6eb7
    • chromium-autoroll's avatar
      Roll Skia from 68ac3b9ec3ca to dbc19ea84ef4 (4 revisions) · 679696cf
      chromium-autoroll authored
      https://skia.googlesource.com/skia.git/+log/68ac3b9ec3ca..dbc19ea84ef4
      
      2020-11-24 mtklein@google.com implement a whole slew of arm64 ops
      2020-11-24 johnstiles@google.com Add 'isBoolean' method to SkSL::Type.
      2020-11-24 johnstiles@google.com Reland "Simplify _blend_set_color_saturation, removing an instruction."
      2020-11-24 reed@google.com fix test to use new api
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/skia-autoroll
      Please CC adlai@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Cq-Do-Not-Cancel-Tryjobs: true
      Bug: None
      Tbr: adlai@google.com
      Change-Id: I131b4e45573ced7f88673edea53a067db8412089
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557845Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#830615}
      679696cf
    • Egor Pasko's avatar
      sheriff: disable launchNTP_withMultipleFeedCardsRendered · 4f3f9df8
      Egor Pasko authored
      It fails reproducibly on the only bot it runs.
      
      Tbr: harringtond@chromium.org
      Bug: 1152438
      Change-Id: Id4666402f16540fe4689f195dc2311ae3e50a2ff
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558398Reviewed-by: default avatarEgor Pasko <pasko@chromium.org>
      Commit-Queue: Egor Pasko <pasko@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830614}
      4f3f9df8
    • Jeremy Leconte's avatar
      Roll all upstream iOS tests to run on 12a7209. · 070dbf03
      Jeremy Leconte authored
      The xcode_build_version is already 12a7209 but I'm not sure where it is used.
      The xcode installed is 12a8189n.
      https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20ios-device/7690
      
      Bug: 1128632, webrtc:12134
      Change-Id: I4403d87f4056524f31b6e19a21e17851aa07eb5c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556944
      Commit-Queue: Jeremy Leconte <jleconte@google.com>
      Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
      Reviewed-by: default avatarMirko Bonadei <mbonadei@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830613}
      070dbf03
    • Victor Vasiliev's avatar
      Pass OnDatagramProcessed() calls into the network service. · 10e45b5e
      Victor Vasiliev authored
      Bug: 1150350
      Change-Id: I735ab6e7379e4a307e0770faaa77e9303e437485
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556449
      Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
      Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830612}
      10e45b5e
    • Torne (Richard Coles)'s avatar
      webview: mark correct header UMA as obsolete. · a22314e7
      Torne (Richard Coles) authored
      Previous CL marked Android.WebView.ExtraHeaders.Valid as obsolete, which
      is incorrect; the UMA which was removed was ExtraHeadersRedirect.
      
      Bug: 1038002
      Change-Id: I4508958e02a3da78edd89077efd9418f415fa7c7
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553860
      Auto-Submit: Richard Coles <torne@chromium.org>
      Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
      Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830611}
      a22314e7
    • Maksim Ivanov's avatar
      Fix use-after-move in //c/b/chromeos/net/network_diagnostics/ · 0e68e5fc
      Maksim Ivanov authored
      Fix use-after-move (potential) bugs found by the
      "bugprone-use-after-move" clang-tidy check.
      
      Bug: 1122844
      Change-Id: Ife278a458c9151724a8426541063ae7d3261a49b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555042
      Commit-Queue: Kartik Hegde <khegde@chromium.org>
      Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
      Reviewed-by: default avatarKartik Hegde <khegde@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830610}
      0e68e5fc
    • Tomasz Wiszkowski's avatar
      Use the TextSecondaryThick for group headers · ae4f2afe
      Tomasz Wiszkowski authored
      This change improves clarity of the suggestion headers by updating
      the text style used to render the group title.
      
      Bug: 1123740
      Change-Id: I77c9b89adbc8f4cd5477deef022db3912d9d1ae0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556215
      Commit-Queue: Tomasz Wiszkowski <ender@google.com>
      Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830609}
      ae4f2afe
    • Maksim Ivanov's avatar
      Fix double-callback-call crash in //chromeos/login/auth/ · f8fb2ff1
      Maksim Ivanov authored
      Fix bug found by the "bugprone-use-after-move" clang-tidy check.
      
      Bug: 1122844
      Change-Id: Icfdf8af891b11942d24bda43fb1e203333d3bd9f
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556679
      Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
      Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
      Reviewed-by: default avatarAchuith Bhandarkar <achuith@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#830608}
      f8fb2ff1