GitLab

Allows navigation requests to be canceled before they are committed when they become stale.

BUG=397998

Review URL: https://codereview.chromium.org/475783002

Cr-Commit-Position: refs/heads/master@{#293484}

BUG=410824

Review URL: https://codereview.chromium.org/537993002

Cr-Commit-Position: refs/heads/master@{#293483}

BUG=408431

Review URL: https://codereview.chromium.org/537123002

Cr-Commit-Position: refs/heads/master@{#293482}

Autocomplete: Fix a typo that flipped the extension keyword provider check for enabling in incognito mode.

This is deliberately kept small for easy merging.

BUG=409705

Review URL: https://codereview.chromium.org/537283002

Cr-Commit-Position: refs/heads/master@{#293481}

BUG=402800

Review URL: https://codereview.chromium.org/519643002

Cr-Commit-Position: refs/heads/master@{#293480}

Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui, and webkit.

TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/529273002

Cr-Commit-Position: refs/heads/master@{#293479}

BUG=399186

Review URL: https://codereview.chromium.org/491263002

Cr-Commit-Position: refs/heads/master@{#293478}

BUG=409490
TEST=manually

Review URL: https://codereview.chromium.org/528263002

Cr-Commit-Position: refs/heads/master@{#293477}

This patch conveys more information about frame timings to Blink.
Specifically it adds the current deadline by which work should be
finished as well as the expected interval between frames. The
Blink scheduler will use this information to schedule lower priority
work.

We also notify Blink when a committed frame actually got composited,
which means the current frame is done and lower priority work can be
started immediately (i.e., before the scheduled deadline).

BUG=391005

Review URL: https://codereview.chromium.org/521613002

Cr-Commit-Position: refs/heads/master@{#293476}

The embedder was initialized in the constructor of CoreImpl. This is not
correct, because when it will be used in Chromium, the embedder is
initialized by the native code.

This remove the initialization from CoreImpl. Instead, for tests,
initialize it when loading the native library.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/544603002

Cr-Commit-Position: refs/heads/master@{#293475}

 * Don't count demoted dirty tracker as pending.
 * Notify observer of service state update when the initialization is completed.

BUG=410675

Review URL: https://codereview.chromium.org/537883002

Cr-Commit-Position: refs/heads/master@{#293474}

properly  with invalid server's originator_cache_guid and
originator_client_item_id.
It checks UpdateBookmarkPositioning works fine.

BUG=
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/533113002

Cr-Commit-Position: refs/heads/master@{#293473}

The progress bar of sync status in Desktop Notification is not updated
due to issue 400636.

BUG=408931
TEST=manually
1. Copy local file to Drive
2. Start sync
3. Close Files.app
4. Observe the Notification

Review URL: https://codereview.chromium.org/543973003

Cr-Commit-Position: refs/heads/master@{#293472}

Condition variables should be signaled inside the critical section.
cf) http://www.chromium.org/developers/lock-and-condition-variable#inside

BUG=None
TEST=Ran trybots.

Review URL: https://codereview.chromium.org/533823003

Cr-Commit-Position: refs/heads/master@{#293471}

Remove noamsml@ from all OWNERS files.

NOTRY=true

Review URL: https://codereview.chromium.org/541943002

Cr-Commit-Position: refs/heads/master@{#293470}

BUG=

Review URL: https://codereview.chromium.org/537843002

Cr-Commit-Position: refs/heads/master@{#293469}

We have a plan in progress to upgrade the 'important' field to a combination
of two fields 'primary' and 'improvement_direction'. This will be a two-sided
patch that will require reworking the dashboard's handling of chart JSON. Since
the dashboard has been modified to accept chart JSON with 'important' values,
we want to update Telemetry to continue serializing values with this field for
now.

R=nednguyen

Review URL: https://codereview.chromium.org/541253002

Cr-Commit-Position: refs/heads/master@{#293468}

BUG=none

Review URL: https://codereview.chromium.org/538263003

Cr-Commit-Position: refs/heads/master@{#293467}

BUG=none
TEST=none
R=asvitkine@chromium.org, jwd@chromium.org

Review URL: https://codereview.chromium.org/541933002

Cr-Commit-Position: refs/heads/master@{#293466}

The DLL must match the executable, and the kernel driver must match the OS. Confusing, I know!

BUG=336558
TEST=python tools/telemetry/run_tests msr  # On a machine with 32-bit Python and 64-bit Windows, in a shell with Administrator privileges.
R=tonyg

Review URL: https://codereview.chromium.org/539303002

Cr-Commit-Position: refs/heads/master@{#293465}

This reverts HidService to being a singleton instance for now.

BUG=401234
TBR=rpaquay

Review URL: https://codereview.chromium.org/523743005

Cr-Commit-Position: refs/heads/master@{#293464}

BUG=397741

Review URL: https://codereview.chromium.org/540183002

Cr-Commit-Position: refs/heads/master@{#293463}

This makes it easier for automated tools such as nacl_deps_bump.py to
update the field.  It also makes it easier to search the history for
changes to the field.

The field was removed by fd5ba194,
which switched DEPS from SVN revisions to Git revisions.

BUG=263848
TEST=trybots

Committing with
NOTRY=true
due to race with updates to adjacent webkit_revision.

Review URL: https://codereview.chromium.org/546453003

Cr-Commit-Position: refs/heads/master@{#293462}

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/538863003

Cr-Commit-Position: refs/heads/master@{#293461}

Before this cl, VideoTrackAdapter.FramesReceived was logged for all types of MediaStreamVideoSources including remote video sources and pepper api sources.
The indent of this UMA stat is to track if a video capture device output video frames or not.

BUG= 409624

Review URL: https://codereview.chromium.org/529733002

Cr-Commit-Position: refs/heads/master@{#293460}

The implicit conversion operator is being removed, because of the
surprises it can cause. For example, one might write:
  scoped_refptr<Foo> CreateFoo();
to ensure that callers hold the result in a scoped_refptr. But the
implicit conversion to T* means that a caller can accidentally hold
the result in a Foo* and the compiler won't catch it.

Since there are a large number of dependencies on this implicit
conversion, the cleanup is being conducted by a combination of
automated tooling and manual cleanup. It is also being staged on a
platform by platform basis. All known dependencies on the implicit
conversion on Linux (but not ChromeOS) have been removed, so this
patch disables the conversion operator on Linux builds to prevent
new dependencies on the implicit conversion.

Finally, to help facilitate this transition, temporary operator
overloads for comparison have been added. These will eventually be
removed.

BUG=110610
R=jyasskin@chromium.org, rsleevi@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/510323002

Cr-Commit-Position: refs/heads/master@{#293459}

Fix a couple more dependencies on implicit conversions that have been
checked in since this morning.

BUG=110610
R=vtl@google.com
TBR=rsleevi, vtl, yzshen

Review URL: https://codereview.chromium.org/541243003

Cr-Commit-Position: refs/heads/master@{#293458}

It isn't necessary to mess around with sharing CGLContextObjs anymore,
they were necessary only to share data between the frame subscriber
and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its
own CGLContextObj, and draw using immediate mode (using shaders
resulted in an increase in startup time).

BUG=314190
TBR=pfeldman@chromium.org
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/541663002

Cr-Commit-Position: refs/heads/master@{#293457}

This is an intermediate step, the real fix is to get rid of
ResourceLoaderBridge.

BUG=338338
TEST=None, no functional changes
R=avi@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/519333002

Cr-Commit-Position: refs/heads/master@{#293456}

*.crdownload
*.crx
*.dmg
*.exe
*.html
*.jar
*.ps
*.torrent
*.txt
*.zip

BUG=397181
TEST=manually
1.Go to chrome://histogram.
2.Open the each file.
3.Confirtm the count is increased.

Review URL: https://codereview.chromium.org/539853002

Cr-Commit-Position: refs/heads/master@{#293455}

Similar to bug 398384, but perform the same bounds check we introduced to
chrome_pdf::CopyImage() in the chrome_pdf::AlphaBlend() function.

Also change the return value from bool to void, since AlphaBlend() always
returns true, and no-one was checking the return value anyways.

BUG=384891

Review URL: https://codereview.chromium.org/544863002

Cr-Commit-Position: refs/heads/master@{#293454}

BUG=110610
TBR=caitkp, michaeln, rockot, sievers, sky, willchan

Review URL: https://codereview.chromium.org/543893002

Cr-Commit-Position: refs/heads/master@{#293453}

This required ripping out the old concept of app navigation,
since it is no longer compatible with how apps get connected
to.

BUG=

Review URL: https://codereview.chromium.org/514063003

Cr-Commit-Position: refs/heads/master@{#293452}

BUG=408189

Review URL: https://codereview.chromium.org/529223003

Cr-Commit-Position: refs/heads/master@{#293451}

Cleaning up weak_ptr_factorydestruction order in "src/ash" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/497733002

Cr-Commit-Position: refs/heads/master@{#293450}

It's pretty common that GUID strings express hex digits in lowercase.
This CL modifies base::IsValidGUID() to also accept GUID strings in
lowercase, so that the function can be used to validate GUIDs not
generated by base::GenerateGUID().

BUG=None
TEST=base_unittests

Review URL: https://codereview.chromium.org/546603002

Cr-Commit-Position: refs/heads/master@{#293449}

Revert of Check to ensure PowerObservers are added and removed on the same thread (patchset #7 id:120001 of https://codereview.chromium.org/502003003/)

Reason for revert:
Causing failures on Mac try jobs:
ExtensionServiceTest.ExternalExtensionAutoAcknowledgement (run #1):
[ RUN      ] ExtensionServiceTest.ExternalExtensionAutoAcknowledgement
[8427:1799:0904/211500:4724222818698:FATAL:power_monitor.cc(38)] Check failed: obs->power_monitor_thread_checker_.

Original issue's description:
> Check to ensure PowerObservers are added and removed on the same thread
>
> This behavior is required by ObserverListThreadSafe and may leads to crashes if not followed
>
> BUG=404767
>
> Committed: https://chromium.googlesource.com/chromium/src/+/518c46fbba70c91169bfc0c64b542f06e56b3915

TBR=thakis@chromium.org,brettw@chromium.org,scottmg@chromium.org,bajones@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404767

Review URL: https://codereview.chromium.org/544913003

Cr-Commit-Position: refs/heads/master@{#293448}

It reduces disk I/O cost on counting dirty trackers.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabase*"

Review URL: https://codereview.chromium.org/536343002

Cr-Commit-Position: refs/heads/master@{#293447}

This reduces the amount of logging for most tests, which is filling up
the disk on the tryserver master, while leaving logging for bugs under
investigation.

BUG=393331,405577,407976,408358
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/541283002

Cr-Commit-Position: refs/heads/master@{#293446}

Simple cleanup to remove unneeded parts of BrowserActionsContainer
and friends. No behavioral changes, and nothing fancy.

Review URL: https://codereview.chromium.org/542493002

Cr-Commit-Position: refs/heads/master@{#293445}