- 19 Sep, 2018 40 commits
-
-
Sam McNally authored
In order to make the test pass: - Change chrome.fileManagerPrivate.setEntryTag() to succeed but take no other action with DriveFS enabled; it won't be supported with DriveFS. - Enable a mock SyncFileSystemService so the use of the syncFileSystem API can succeed locally. - Add support for mounting a USB drive containing a DCIM directory with an image. This test only exercises basic functionality: - There is no previous photo backup history in the syncFileSystem. - Images in the external drive are not duplicated in Drive. Bug: 883628 Change-Id: Ic5244de54bdd6f3fee0c82a356e7e530b85dba64 Reviewed-on: https://chromium-review.googlesource.com/1230193Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592313}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I05c9d8527695a94de3fa65467150184ab3daa344 Reviewed-on: https://chromium-review.googlesource.com/1232585Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#592312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7930e1e7a4f..568e0b054ae4 Created with: gclient setdep -r src-internal@568e0b054ae4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I37e1eeb1cc535f862eccdb7238838eec987eec2a Reviewed-on: https://chromium-review.googlesource.com/1232623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592311}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57988b451c5c..274a6922da39 git log 57988b451c5c..274a6922da39 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 dgarrett@google.com chromeos_config: Make external PreCQ builds internal. Created with: gclient setdep -r src/third_party/chromite@274a6922da39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2c14d26a49e45c88455e92dc4494bb833b45f36b Reviewed-on: https://chromium-review.googlesource.com/1232622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592310}
-
Anand K. Mistry authored
Additionally, update a few call sites that were missed on previous CLs. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 TBR=avi@chromium.org Change-Id: Ic3d5fb246a0610d63d377de7c038f7e2359f1bdc Reviewed-on: https://chromium-review.googlesource.com/1229721Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592309}
-
Alexey Baskakov authored
Extensions shouldn't leak into chrome/browser/ui/ code. Use TabHelper::GetAppId instead of Extension* Since we are going to use std::string for AppId, this change will allow us to use an abstract apps::App and move off the Extensions System in the future. Drive By: Erase unused TabHelper::web_app_info(). Bug: 774918 Change-Id: I3596bb80729c53f53215325abd371dda8a06a50a Reviewed-on: https://chromium-review.googlesource.com/1229719 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#592308}
-
Wenzhao Zang authored
The goal is to show screensaver immediately after demo session logs in. In order to avoid the visual delay during the screensaver installation, we need to: 1. Bypass install_limiter: it's reasonable to make an exception for the screensaver app during demo mode. The choices for the size limit (1MB) and the delay (5000 ms) are somewhat arbitrary in the first place. We'd still like to keep the install limiter in all other cases unless there's a real need to bypass it, ie: 1) All other apps during demo mode, 2) The screensaver app in non-demo mode (only possible if people randomly find it from the web store.) 3) All other apps in non-demo mode (the majority cases). 2. Initiate installation earlier: if we wait until session state becomes active, then its installation will happen later than the policy forced ones. Instead, we can observe the profile creation and start installation right after profile is created. Highlights app should be installed at the same time, but do not change it for now because: 1) Before we disable browser launch for demo sessions, we want Highlights app to appear between the screensaver and the browser window. This is hard to achieve if installing Highlights app at the same time with screensaver (which happens before browser launch). 2) Installing another large app may affect installing the screensaver. Bug: 870851 Change-Id: Ia8f7bb4f02d69e73a4c79839531ee1c190414d3d Reviewed-on: https://chromium-review.googlesource.com/1212448 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592307}
-
Xing Liu authored
We persist download response headers and url chain when OnDownloadCreated is called. This CL does the following: 1. If the persist failed during ACTIVE state, delete the driver and the file to let the download service to retry. 2. Change DownloadDriver::Remove to be able to remove file for completed download. 3. Add did_receive_response in entry proto, since some protocol or a socket error may cause the response headers to be empty. We should validate the entry state with this flag instead of response headers. TBR=carlosk@chromium.org Bug: 883359, 881314 Change-Id: I560cc478b5d1f12c33b56b94ee97cbb1d2b76c3d Reviewed-on: https://chromium-review.googlesource.com/1227290 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592306}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15b586a4932a..79c651330b94 git log 15b586a4932a..79c651330b94 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 nodir@google.com [gclient] Remove is_blink_mode Created with: gclient setdep -r src/third_party/depot_tools@79c651330b94 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:694348 TBR=agable@chromium.org Change-Id: If83b476bde46ba443ae6ee96de16064226875c06 Reviewed-on: https://chromium-review.googlesource.com/1232620Reviewed-by:
-
Jordy Greenblatt authored
Under the hood: -Pulled styling imports into multidevice_setup_shared_css Visible -Unified default text specs -Placed button bar at the bottom of the page -Implemented some (not all) padding between elements in start setup page Bug: 878646, 878644, 878643 Change-Id: I53d97060d139bcadd9594866f9342040fa386e80 Reviewed-on: https://chromium-review.googlesource.com/1232473Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#592304}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 95797d79. With Chromium commits locally applied on WPT: 87da8d40 "[Background Fetch] Miscellaneous cleanups." 29028a2d "[css-tables] Force layout when colgroups are removed or added" 66a74d2f "Revert "[css-tables] Force layout when colgroups are removed or added"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24804 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic9fb2fc7372c537e304824eb1894d02378b930c5 Reviewed-on: https://chromium-review.googlesource.com/1232680 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#592303}
-
Xiaocheng Hu authored
crrev.com/c/1175758 bridged text fragments to dom snapshot inspector, which was however removed in crrev.com/c/1173717 due to a behavior change. This patch bridges them again. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If3d224617defd12d7d2fbc6fcda8a70fff2ede16 Reviewed-on: https://chromium-review.googlesource.com/1231927Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592302}
-
Pavel Feldman authored
It is essential that the inspector task queue that is used to interrupt v8 execution can not be stopped via the virtual time fence. All other Blink queues are stoppable, so we can't (don't want to) encode this behavior into the queue traits, hence the separate plumbing. Change-Id: I01c78783837f468c1ce0b12fd4f0abd3efe6e473 Reviewed-on: https://chromium-review.googlesource.com/1232913 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592301}
-
Ken MacKay authored
Revert back to the old behaviour where we silently swallow errors about encryption. Otherwise cast_shell_browsertests crash/hang. I'm not sure why the tests using encrypted audio passed before (or pass with this change) but I'll look into it later. Change-Id: Ie0c869f85244ac35f80a980952bdbe03a5204a58 Reviewed-on: https://chromium-review.googlesource.com/1232880Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#592300}
-
Lan Wei authored
In order to improve the performance and eliminate the issues that the fake mouse move events cause to the testing and web developers, we should not send fake mouse move events After the layout is changed. This is implemented behind a flag. We will try to update the hover effect after the layout is changed in a following patch. Bug: 877132 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I02b124b86998e2bf2d4ccc1e00ce122b7e67e7f7 Reviewed-on: https://chromium-review.googlesource.com/1212349 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592299}
-
Trent Apted authored
Bug: 879958, 882750 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia5992149ad55370a912ed02271dbaa1a93332ff1 Reviewed-on: https://chromium-review.googlesource.com/1226483Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#592298}
-
Alexey Kozyatinskiy authored
Starting next Node 10.x and Node 11 release, Node will report fileURL instead of platform path for all parsed scripts. R=dgozman@chromium.org Bug: none Change-Id: Ic9ca40a2369a0b4529be7822a7e55a08a7378200 Reviewed-on: https://chromium-review.googlesource.com/1229073Reviewed-by:
-
Sam McNally authored
Currently, the dim-offline class is added to any files either with availableOffline set to false or undefined. It should only be applied to files with availableOffline set to false. Explicitly check for equality to false rather than relying on truthiness. Bug: 885302 Change-Id: If948f161d64dc34280a12f275cd6f07e98356030 Reviewed-on: https://chromium-review.googlesource.com/1232795 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
BUG=None Change-Id: I9eea1f8b1c750f73db012310115557a06d205db3 Reviewed-on: https://chromium-review.googlesource.com/1233013Reviewed-by:
-
Luciano Pacheco authored
Add a new flag "wait-for-debugger-webui" which makes WebUI tests stop for waiting to a debugger. This flag only works if "remote-debugging-port" flag is also set. The WebUI test will wait until user issues "go()" command from the JS console to proceed with tests. This waiting scheme works by having a global variable |waitUser|, which is either false or undefined by default, so it doesn't wait by default. When the flags are provided, the BrowserTest C++ class sets the JS global variable |waitUser| to true before starting the tests. In JS when |waitUser| is true, the function retries by re-scheduling itself for 1 second in the future. IMPORTANT: There is no timeout for this retry, only the default timeout of the tests infrastructure applies here. --gtest_filter='FileManagerJsTest.MetadataCacheSet' and --gtest_filter='*CrExtensionsItemsTest.Warnings*' Bug: 880688 Test: Checked manually that the following tests wait for debugger Change-Id: Ia198d2c5ed8c6d464f0ab8fb1c7201da9a7c5169 Reviewed-on: https://chromium-review.googlesource.com/1205919 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
On Chrome OS, notification control buttons (close & settings) should change its visibility depending on its focus. It's handled in MessageCenterView by iterating through MesageViews of MessageListView, but it's awkward and can be handled in MessageView. It eliminates duplicated logic of MessageCenterView and UnifiedMessageCenterView. Also it restores focus support in popups. TEST=manual(non-ARC and ARC notifications) BUG=none Change-Id: Iec9612d219f4dce5e16d713952ad4d5003a760a3 Reviewed-on: https://chromium-review.googlesource.com/1220853Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#592293}
-
khmel@chromium.org authored
TEST=Locally BUG=836844 Change-Id: Ibe02b2da0a5ad57440d294058aabd97c3933fee0 Reviewed-on: https://chromium-review.googlesource.com/1232684 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592292}
-
Kevin Marshall authored
This patch allows the user to input text in Frames using Fuchsia IME's on-screen keyboard. All input event conversion logic is moved to a helper library "InputEventDispatcher", which takes events from the hardware keyboard and on-screen keyboard event handlers. Add platform-specific IME hide/show hooks to RenderWidgetHostViewAura. Bug: 876934 Change-Id: I51068e59bd08e9bc0d711bf33c2bbb6f4b0e24ef Reviewed-on: https://chromium-review.googlesource.com/1213876 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#592291}
-
Dale Curtis authored
Particularly where ChunkDemuxer might be holding the lock for a large append on the render thread, we can end up stalling out audio rendering unnecessarily. I consider reworking these methods to not hold the lock for calls to AttemptRead, but we do need the lock when accessing the queue or setting |pending_read_|, so AutoUnlock appears to be the best effort here. BUG=879970 TEST=none R=chcunningham Change-Id: Id8fc62fa8129519d373d2a1d2c0bed2b029c590b Reviewed-on: https://chromium-review.googlesource.com/1232474Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/07b5283a4ea1..15b586a4932a git log 07b5283a4ea1..15b586a4932a --date=short --no-merges --format='%ad %ae %s' 2018-09-18 nodir@google.com Remove PATCH_PROJECT 2018-09-18 nodir@google.com [gclient] Remove calculate_patch_root Created with: gclient setdep -r src/third_party/depot_tools@15b586a4932a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:694348,chromium:694348 TBR=agable@chromium.org Change-Id: I731dbabefa43fbb0c6c9665a06f9ff532730f2f2 Reviewed-on: https://chromium-review.googlesource.com/1232618Reviewed-by:
-
Koji Ishii authored
external/wpt/css/cssom/getComputedStyle-insets-absolute.html Legacy passes 180 while NG passes 192. external/wpt/css/cssom/getComputedStyle-insets-fixed.html Legasy passes 168 while NG passes 180. Based on build 9840. https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/9840/layout-test-results/results.html TBR=atotic@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I54b8405ac3fc2a03af399a5e842b3560ce80f8ed Reviewed-on: https://chromium-review.googlesource.com/1233073 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Jimmy Gong authored
- Adds an error message for when an invalid SMB mount url is provided. BUG=chromium:882594 Change-Id: I9952a11cdaf4baa727076737636a1346c0048bc2 Reviewed-on: https://chromium-review.googlesource.com/1217852 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592287}
-
Xu Xing authored
Current case only cover dependency. The added cases verify task with different priority and category runs in predefined order. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I185d4fab123c5318df4e60f99506fa20dc622ab7 Reviewed-on: https://chromium-review.googlesource.com/1196234Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#592286}
-
Tatiana Buldina authored
Bug: chromedriver:1936 Change-Id: I9e385f3249226d886c49023126582a96e4687d82 Reviewed-on: https://chromium-review.googlesource.com/1231913Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#592285}
-
Daniel Cheng authored
Rather than plumb this through several layers so that //content can set the corresponding bit, just set it directly from Blink. Bug: 841358 Change-Id: Id3fd32f75f07b5c8361220ee44402ce403e624c4 Reviewed-on: https://chromium-review.googlesource.com/1225931 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592284}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c858b7a312a..e7930e1e7a4f Created with: gclient setdep -r src-internal@e7930e1e7a4f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6448a994fdd806048a8bd2df940805824da69df5 Reviewed-on: https://chromium-review.googlesource.com/1232614Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 9805 9807 9808 9813 9815 9820 9827 9838 9840 1 lines were removed and 0 lines were deflaked by consecutive results since 9803. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia8a1175878e300f18b439a41ee583b8142595688 Reviewed-on: https://chromium-review.googlesource.com/1229654 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Gina Ko authored
Bug: internal b/115289705 Change-Id: I849a3c28522d2d9bf15b7bfacd21cffe7530eb0a Reviewed-on: https://chromium-review.googlesource.com/1232353Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yi-Chun Gina Ko <yichunko@google.com> Cr-Commit-Position: refs/heads/master@{#592281}
-
David Black authored
Bug: b:115904144 Change-Id: I42c65867baa9b64a3587e040839dfb716b7a6ad0 Reviewed-on: https://chromium-review.googlesource.com/1231823 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592280}
-
Tim Zheng authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/b03af0353854..48093e2673c6 $ git log b03af0353..48093e267 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 timzheng Add a display density parameter. 2018-09-07 iby Add package info for Crostini apps Created with: roll-dep src/third_party/cros_system_api Bug: chromium:839242 Change-Id: I518308ae7ca60ae0cf7110aef7cc2692e8e148fb Reviewed-on: https://chromium-review.googlesource.com/1232208 Commit-Queue: Tim Zheng <timzheng@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#592279}
-
mrefaat authored
WKHTTPSystemCookieStore object can be deleted while there are some pending callbacks, these callbacks needs to check if the object is alive or not and based on that either early return or continue running. We only need to keep a valid pointer to the WKHTTPCookieStore, the problem that happens when the WKHTTPSystemCookieStore object is deleted is the pointer it self become invalid, so the solution is to copy the weak pointer of WKHTTPCookieStore inside the WKHTTPSystemCookieStore methods, so it remains valid inside the blocks. Bug: 883909 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie499c368859ec4b604ea1cd97c971b7597bc5b57 Reviewed-on: https://chromium-review.googlesource.com/1225750Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592278}
-
Xiaohui Chen authored
This helps with debugging view related issues. Bug: None Test: locally compile Change-Id: I2a335e8eee149ee5c5d5e4549a8119290b34193b Reviewed-on: https://chromium-review.googlesource.com/1227115Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592277}
-
Christian Fremerey authored
This is to prevent ending up with uninitialized fields whenever new fields are added to mojom.PhotoState. This fixes errors on webrtc Linux Tester bot. TBR=mcasas@chromium.org Bug: 823316 Change-Id: I6de6bdd49d4f2161868c98b4a31b07fdf18ee7ab Reviewed-on: https://chromium-review.googlesource.com/1232393Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592276}
-
Eugene But authored
This test verifies that no WebStateObserver callbacks are called during restoration. Removed superfluous DCHECK from GetNavigationItemImplAtIndex(). Bug: 877671, 812253 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic4db92fec8204fd8fe92da9a19ea6f16cc3a32a3 Reviewed-on: https://chromium-review.googlesource.com/1189124 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592275}
-
Robert Ogden authored
This uses a post delayed task on every preview navigation to monitor if the navigation has hung for any reason. This is done using the WebContentsHelper, adding a WebContentsObserver to it. If after some configurable delay, the original previews navigation is still ongoing, and all navigations since are to the previews server, stop all loading and load the original page. Bug: 885252 Change-Id: If4e1678cfb6d175714d6da08a7cf5af2b477fd6e Reviewed-on: https://chromium-review.googlesource.com/1231693 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592274}
-
