- 25 Mar, 2020 40 commits
-
-
Jan Wilken Dörrie authored
Similarly to https://crrev.com/c/2107984 this change migrates all tests in password_check_test.js to async / wait, rather than returning promises. This change does not modify functionality. Bug: 1047726 Change-Id: Ic2de2a713a0af6ad9f6ec9450b4a0ec2849ca402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120492 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753397}
-
Jan Wilken Dörrie authored
This change adds a histogram and logic that records the referrer when the user navigates to the Password Check page. The set of referrers include Web UI like the Safety Check or the Password Settings, or native UI like the Phish Guard or Password Breach dialog. Bug: 1047726 Change-Id: I0b81ef062a55414b622ae5f773309f4cc4592f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116216 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Lei Zhang authored
The histogram is useful for observing the impact of Chromium exporting tagged PDFs by default when saving as PDF in Print Preview. Bug: 1053245 Change-Id: Ic2b848efce17bf39ac08dea198bb4e4026dff67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119763Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753395}
-
Peng Huang authored
VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace VulkanImplementation::CreateVkImageAndImportAHB(), and will replace VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. Bug: None Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753394}
-
Dan Harrington authored
- Just loads from network. - To make testing easier, you can now inject the internal (translated) response. Bug: 1044139 Change-Id: I52b231ebda49c944626f090b66af612e7979d436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116922Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#753393}
-
Nektarios Paisios authored
When an AXNode in an AXTreeUpdate changed its role to, or from, a role of ax::mojom::role::kIgnored, we were not updating the unignored members in AXNode, such as unignored_index_in_parent_ and unignored_child_count_. Also took the opportunity to fix TestAXNodeWrapper to work with the unignored tree. Currently, it only walked up to the unignored parent, but traversed all children, including the ignored ones. This was both inconsistent and wrong. Wrong because AXPlatformNode works only with unignored nodes. RelNotes: N/A R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I944ad1a34a25815f9ba038c0f92c5000db8de522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120272 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753392}
-
Jeff Yoon authored
ios-simulator-cronet under chromium.fyi has already been migrated. Missed migrating the trybot with it. Bug: 1055164,912681 Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753391}
-
Koji Ishii authored
* crbug.com/652964: `hyphens: auto` not supported on Win/Linux. * crbug.com/1022415: Last word fails to hyphenate. * Skip: The hyphen character renders slightly differently only on Mac10.10. TBR=ikilpatrick@chromium.org Bug: 652964, 1022415, 1064523 Change-Id: I031ce56c0b2807d94bb14c876438354e7be6db59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121112Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753390}
-
Asanka Herath authored
These metrics builders prepare identifiability metrics that are reported via UKM. Bug: 973801 Change-Id: I4358eda3737f95f95772a874367ca2ac1fb5d651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092061 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#753389}
-
Mehran Mahmoudi authored
This adds a missing step to the Java instructions on vscode.md. Change-Id: Ica35ba46b8046595efad668734eb1eb9db84968a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121315Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753388}
-
Erik Jensen authored
The Linux host disables autorepeat at the start of the connection, but it can get re-enabled if, e.g., the users desktop environment reapplies its settings. This can lead to network jitter causing undesired key repeats until the user reconnects. This change checks the current autorepeat state on keydown, and re-disables it if necessary. Bug: 1064728 Change-Id: I5db9cd28215492d11546a5a3f5df08acc2d55dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121047Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753387}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/988ce0490a11..5c4c61eeb38f git log 988ce0490a11..5c4c61eeb38f --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bsalomon@google.com Reland x4 "Drawing YUVA images does not flatten for bicubic." 2020-03-25 csmartdalton@google.com ccpr: Polyfill buffer mapping when not supported 2020-03-25 mtklein@google.com update to clang 10 Created with: gclient setdep -r src/third_party/skia@5c4c61eeb38f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I6e2a4b09b30600824dc561ab9276f12a79c4d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753386}
-
Daniel Hosseinian authored
The function returns a struct, DocumentMetadata, which contains fields with document metadata, including the entries from the /Info dictionary of a PDF. Implement the function in PDFiumEngine. Add a test and check in a test PDF. Remove PDFEngine::GetMetadata() as it only had one caller and its functionality would be redundant with the new GetDocumentMetadata(). Simultaneously, privatize the old GetDocumentMetadata(), which only fetched unparsed field entries one by one and rename to GetMetadataByField(). Bug: 93619 Change-Id: I36ce50fa2bf2e4a5eba94efa54cfd3e3bbf72f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096103 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753385}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/5730877113892864 Bug: 1062476 Change-Id: Iaf04998c660c4626e75610328d1e9dac2562de26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110219Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753384}
-
Xi Han authored
This is a follow up CL for https://crrev.com/c/1999001. Bug: 1041865 Change-Id: I35142ce77bbab8987336f509cc7d9cbdd34103d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118621Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753383}
-
Jon Mann authored
Previously there were three services running at the same time, including unnecessary instances for the default and signin profiles. Bug: 966270 Change-Id: I6e1a4338c6d9c6619febb5305671ce2da14769ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110214Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#753382}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8cef397d7dec..77090261dabc git log 8cef397d7dec..77090261dabc --date=short --first-parent --format='%ad %ae %s' 2020-03-25 capn@google.com Identify image views based on their state 2020-03-25 capn@google.com Provide packed VkFormat to uint8_t mapping 2020-03-25 capn@google.com Uniquely identify sampler state 2020-03-25 capn@google.com Split vk::Sampler state off into a structure 2020-03-25 capn@google.com Fix handling Memset<> assignment and comparison 2020-03-25 bclayton@google.com Add script for updating llvm 10 2020-03-25 amaiorano@google.com regres: add daily run against SwiftShader/Subzero Created with: gclient setdep -r src/third_party/swiftshader@77090261dabc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib0d231221c19750a1c8f314bc3aad1fd13ef930c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120909Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a1f482cf07e..54f9ec739967 git log 4a1f482cf07e..54f9ec739967 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 sadrul@chromium.org telemetry: Check for errors when cleaning up minidumps. Created with: gclient setdep -r src/third_party/catapult@54f9ec739967 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1063087 Tbr: skyostil@google.com Change-Id: I2516887804f922f3943173a39891b647e4b30d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120907Reviewed-by:
-
John Budorick authored
Bug: 793982 Change-Id: I35c4843cd0daa4987c4384e093147e08e719a30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121077Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753379}
-
Jan Wilken Dörrie authored
This change introduces a histogram to record user actions performed on the password check page and adds appropriate logic and tests. Fixed: 1062575 Change-Id: I8d16d043b5160b0a7894a20d7a32fc1fe8324988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107984Reviewed-by:
-
Ben Joyce authored
Part of the support library -> androidx migration. Bug: 1052460 Change-Id: I7a899d751fcb5f3ad016ef572a9188b7b96a0a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120095 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753377}
-
Sahel Sharify authored
This reverts commit 09d2eea3. Reason for revert: Compile error on Clank build: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8884826887745781792/+/steps/compile/0/stdout Original change's description: > Reland "[Payments][Android] Move PayerData.java into components/payments/.." > > This is a reland of 352154b4 > > Original change's description: > > [Payments][Android] Move PayerData.java into components/payments/.. > > > > This cl moves PayerData.java class into components/payments so that > > the WebPaymentIntentHelper.java class can use it without depending on > > chrome/browser. It also introduces a new Address class and its > > converter utility class so that PayerData.java does not depend on > > mojom.PaymentAddress. > > > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > > Bug: 1026667 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752597} > > TBR=kenrb@chromium.org,rouslan@chromium.org > > Bug: 1026667 > Change-Id: I2d7eb6016a51060ae10d6d9aed73eba841aea68c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120963 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753322} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: I831159b23bdc117a41024997cfb4d4651e04e77a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119381Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753376}
-
Reilly Grant authored
The new backend is tickling a Windows OS bug that causes the browser process to crash. It can be re-enabled in the future for Windows versions containing the fix. Bug: 1063124 Change-Id: I2f054cf6bfe548bdbf7031640172068b2e3e0e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121046 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#753375}
-
Xiaohan Wang authored
Normally ScopedHString::Create() should only fail on out-of-memory errors, which is already handled. For other errors, currently we use DLOG which will silently pass nullptr or empty string to downstream code, which may cause other errors which will be hard to track. This CL use NOTREACHED() for those errors so we'll get crashes in some builds if it happens. Change-Id: Ia7d556d1f981e106fe791c704727f7dd95477c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119654 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26abd91781d5..056caa9eda32 Created with: gclient setdep -r src-internal@056caa9eda32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058522 Tbr: jbudorick@google.com Change-Id: Idfcaa6d1a7ac54fdb47e3b4f122a1881f3729b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120908Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753373}
-
Moe Ahmadi authored
Cleans up existing variations and adds new ones to enable proactive ZPS in NTP Omnibox/Realbox to chrome://flags/#omnibox-on-focus-suggestions Bug: 1046547 Change-Id: Id2bc53aa997c7f4e4181e89ab16f8e9dc84dab9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121080Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753372}
-
Francois Doray authored
All MessagePumps now use DoSomeWork. In a future, CL: - DoSomeWork will be renamed to DoWork - Complexity of ThreadControllerWithMessagePump and SequenceManager can be reduced. For example, WorkDeduplicator can be simplified. These changes will be done separately to minimize the size of this CL. Bug: 885371 Change-Id: I3c557e19bf8da6dc21c655202d3572a71a23c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070716 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753371}
-
Donn Denman authored
Updates the ResolvedSearchTerm java class to use a builder pattern. This class has long been immutable, but that's made it hard to work with due to all the private members. Now with a builder we can specify what we want. Change-Id: I79477f5d768871dba21881025ea328fc629d7a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119878 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#753370}
-
Andrey Kosyakov authored
This ensures that the devtools_page URL has correct scheme and host, both when loading the manifest and when pushing data to DevTools front-end. Bug: 1059577 Change-Id: I69a7ccdccfae31781ead371a85d23df36f108665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118894 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753369}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia81fac584909e836752a1b6f7f3624c2697b1cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121072Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#753368}
-
Roman Sorokin authored
The WebviewLoginTest.BackButton became flaky after CL:2002869. It tries to go back before loadingFrameContents_ set to false. Don't think we should restrict going back by this flag. We check isWhitelistErrorShown_ and authCompleted_ anyway. Fixed: 1043661 Change-Id: Ia114136d688dceed1f8f4ca40d412eb874286394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120357Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753367}
-
alanlxl authored
Previously we post the whole UpdateSmartDimMlAgent to a new thread and post some of the following work back to UI thread manually. This CL uses PostTaskAndReplyWithResult to post only I/O (reading files from components) to a new thread and switch back to UI thread automatically. This way we can lock all functions of download_worker.cc to UI thread as well as simplify the code. Bug: 1049886 Test: Pass the unit tests and tested on the DUT Change-Id: Iaf70a3d37d49c33a6332293711b25697eefa8df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116168Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#753366}
-
Dana Fried authored
FlexRule by default doesn't know the orientation of the layout it's in, so the existing pre-baked rules you get from calling: FlexSpecification(MinimumFlexSizeRule, MaximumFlexSizeRule, bool) apply the same logic on both axes. This is typically not the desired behavior, however. For example, if you have a FlexLayout with cross axis alignment = center and the default flex rule uses kPreferredSnapToZero, then if a child view is slightly too large on the cross axis, instead of being clipped at the top and bottom, it drops out entirely. This resulted in several kinds of yucky bugs (see below for examples). What we really want is the ability to easily provide a flex rule that applies only on the main axis; possibly with a different cross-axis rule that would default to using the view's preferred size. This CL adds a constructor of the form: FlexSpecification( orientation, main_axis_min_size, main_axis_max_size = preferred, use_height_for_width = false, cross_axis_min_size = preferred) The order of arguments is chosen so that those with defaults least likely to be overridden are last. This new constructor would be used in 95% of the cases where we currently call the three-argument FlexSpecification constructor mentioned above, and can still replace the other constructor in the other 5% of cases at the cost of a little verbosity. The old constructor is not removed but a note is placed on it suggesting the new constructor be used in most cases. Bug: 1061869, 1063275, 1063455 Change-Id: Id8a85f9d80bfe393344ce25f3ed885f18b48d29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113690Reviewed-by:Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753365}
-
Ryan Sleevi authored
Currently, ShouldRequireCTForTesting is implemented as a tristate, with values of false, true, and nullptr. true and nullptr work as expected, while false causes CT to be required in some cases where it is otherwise not required (such as official builds, for locally trusted certs). This simplifies the implementation by making it bi-state, and renames the method and enums to better reflect that true is forcing CT on absolutely, while false is... not forcing CT on absolutely. Bug: 1064391 Change-Id: I1f85a70d32e5c9a0772d877f8217009e6ccddf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118577Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753364}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/46fdad4eca63..b172d257d938 git log 46fdad4eca63..b172d257d938 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 miu@chromium.org Cast Streaming apps: Limit FFMPEG decode threads to 8. Created with: gclient setdep -r src/third_party/openscreen/src@b172d257d938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I542f255382185a19fe230c666ec5f89468f1c282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120905Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae5e8fb6311c..449349092a72 git log ae5e8fb6311c..449349092a72 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 brgoddar@microsoft.com Network: Fix blue focus ring on Network Log Area when Learn More Clicked 2020-03-25 aerotwist@chromium.org Skips flaky multple-worker test 2020-03-25 bmeurer@chromium.org Disable popover eager evaluation on Wasm frames. Created with: gclient setdep -r src/third_party/devtools-frontend/src@449349092a72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056138,chromium:1063875,chromium:1064581 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia75a2ea68cfa24c9208d6f65d114105d148c46d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120906Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I5b95f74395d05e0c26a53c7d9419ec0cb1938ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121039 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753361}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1aff54a5..754d46b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbb6152a21d4d6fdfd55ce6572b607de7d53c781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753360}
-
Omer Katz authored
This reverts commit 2f69de56. Reason for revert: quick resolution to issue 1059655 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: Ia3e3f4ef5dd20c4826b3a8a96adc33c3401e5eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120477Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Increases the sharding values for chrome_public_test_vr_apk-ddready-ddview and chrome_public_test_vr_apk-ddready-cardboard. The tests are currently taking about 54 and 21 minutes to run, respectively, so the sharding values are increased to get the per-shard runtime down to the 10-15 minute range. Change-Id: I34fd76dc643e06d166559496016ae530000e9f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
