- 12 Feb, 2018 4 commits
-
-
Alan Cutter authored
frames() is no longer being shipped in M60 [0], as a result we cannot refer to it as a replacement for step-middle. [0] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/j7l8_DjMsVE/0HKZgZXNAQAJ Bug: 646265 Change-Id: I8f828fabd7c6c8ccc5e72d393ef260de31fcb23c Reviewed-on: https://chromium-review.googlesource.com/557481 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Suzy Howlett <suzyh@chromium.org> Cr-Commit-Position: refs/heads/master@{#536017}
-
Jinsuk Kim authored
WebContentsUserData-backed objects requires its WebContents instance from CVC be non-null, which causes numerous null checking statments. This CL examines callsites to the methods that contains accesses to those objects, adds null-checking statements if missing, and removes it if redundant. Some observations the changes are based on: - private native method doesn't need null check; WebContents is certainly valid at that point. - CVC.destroy() itself or calls from it (before it nulls out WebContents) doesn't need null check since WebContent is valid up to that point. Added null check: ... since clusterfuzz results warn that these need it: - setTouchScrollInProgress - destroyPastePopup ... by moving it over from the 2 callsites: - updateTextSelectionUI (onAttachedToWindow, onDetachedFromWindow) Removed null check as callsites already have null checking/assert, or assure WebContents is not null: - hidePopupsAndClearSelection (WebContentObserver.resetPopupsAndInput, onFocusChanged, showSelectPopup) - hidePopupsAndPreserveSelection (destroy, onHide, updateTextSelectionUI, onFocusChanged, onRotationChanged) - hidePopups (above 2) - onAttachedToWindow, onDetachedFromWindow: moved to updateTextSelectionUI - onRotationChanged: consolidated null checks Inlined one-liner restoreSelectionPopupsIfNecessary into callsites to eliminate the concern on null check on it (much clearer when inlined). Bug: 810179 Change-Id: I55aab2b1f7917a9af4522a1bcf8d3e7d9b172f2a Reviewed-on: https://chromium-review.googlesource.com/907770 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#536016}
-
Patti authored
Update the "clear all text" button's icon and show it while editing in touch mode. Screenshots - https://drive.google.com/file/d/1EFdKPFsvo70ZD0FfK0mfKLS-avijyCtN/view?usp=sharing Bug: 801583 Change-Id: I9b5dca22654d8f24c467e3f9c21d278a7c63005e Reviewed-on: https://chromium-review.googlesource.com/910828 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#536015}
-
Alan Cutter authored
Bookmark apps don't get special Chrome app permissions and it doesn't make sense to display the permissions allocated to them when it will always be none. This CL changes the "App info" context menu entry to go to "Site settings" for the bookmark app's URL. This is inline with our UX mocks for PWAs. Bug: 800205 Change-Id: I8e0135836c44bd7c88a22ea87b7bf1526dba14eb Reviewed-on: https://chromium-review.googlesource.com/910329 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536014}
-
- 11 Feb, 2018 23 commits
-
-
Giovanni Ortuño Urquidi authored
When a website calls window.open() with a URL for which there is a PWA installed, we cancel the navigation in the newly opened tab and start a new navigation in a new app window. This patch plumbs the opener that would have existed in the new tab to the new app window, so that the new app window can access it. This only takes care of the child window. The parent window is not yet able to access the newly opened app window. Bug: 804881 Change-Id: Ie08c3425b13b4940435e6cf3614a015d61ed10a3 Reviewed-on: https://chromium-review.googlesource.com/906042Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#536013}
-
Noel Gordon authored
Patch files are no longer needed per the patch/README guidelines. Bug: 697280 Change-Id: I975a99ac0de50eb7c61a037c458853dc6406ff69 Reviewed-on: https://chromium-review.googlesource.com/912908Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#536012}
-
wutao authored
Mipmap generation is not guaranteed to be GPU accelerated on all devices that Chrome OS ships on, and without acceleration it is too slow to use trilinear filtering. In addition, some device drivers may not support correct mipmap generation. We can use this flag as a workaround until driver bugs have been fixed. This cl creates an ash switch so that we can turn off trilinear filtering. Bug: 799501, b/72298538 Test: Can create the flag and turn off the trilinear filtering. Change-Id: Ia711fce0bc037a391f4bb610e73af32301de7a89 Reviewed-on: https://chromium-review.googlesource.com/908251 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536011}
-
Eric Willigers authored
The CSS translate property no longer resolves percentages in getComputedStyle results. CSS WG Resolution: RESOLVED: % values of translate are serialized as percent for computed values. Add note making the behavior explicit. https://github.com/w3c/csswg-drafts/issues/2124 BUG=811027 Change-Id: I6f9b60c285d1eccc2e13ff0e806794df5cce5151 Reviewed-on: https://chromium-review.googlesource.com/912052 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#536010}
-
Mike Klein authored
Change-Id: I2693be780057c1ba715fce3ae3c398c536f147ea Reviewed-on: https://chromium-review.googlesource.com/911734Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#536009}
-
David 'Digit' Turner authored
This CL adds a small unit-test for the ZIP parsing code. To achieve this, the FileDescriptor class is also slightly improved: - It now always wraps a single integer value, instead of using void* when unit-testing. - The Read() method now returns an ssize_t value. - The SeekTo() method now returns an off_t value. - The ReadFull() method was added. - The Map() method now returns nullptr on failure, instead of MAP_FAILED, and the mock implementation was fixed. - More importantly, the GetFileSize() method was added to avoid calling stat() or fstat() directly in the zip parser, making it unit-testable!! + A new script is added to generate manually a set of data tables corresponding to various test zip archives embedded directly into the unit-test source code (see generate_zip_test_tables.sh) BUG=NONE R=pasko@chromium.org,agrieve@chromium.org,rmcilroy@chromium.org Change-Id: I095aa21ba26d924f7b95cf826d606875bd7d4591 Reviewed-on: https://chromium-review.googlesource.com/911408Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#536008}
-
Rohit Rao authored
BUG=811075 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4c6ab0393b1051807d3e9886fd08556e6fdb67a3 Reviewed-on: https://chromium-review.googlesource.com/911736Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536007}
-
https://skia.googlesource.com/skia.git/+log/c5cecdcaf8ab..78c110e2f0fa $ git log c5cecdcaf..78c110e2f --date=short --no-merges --format='%ad %ae %s' 2018-02-09 caryclark resolve bookmaker refs fixes Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: If19828715f27fedc1bdd488fd65fe4218db29bb7 Reviewed-on: https://chromium-review.googlesource.com/913148 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536006}
-
Kush Sinha authored
Enable Mirror account reconciliation on Chrome OS if the preference |kAccountConsistencyMirrorRequired| is set. This is a Chrome OS specific preference and was being used to stop sign in from secondary Google accounts and sign out from the primary account. Enabling Mirror here will have the effect of users' cookies getting re-minted if they clear their cookies from the Settings page. Bug: 805519 Test: out/ChromeOS/unit_tests --gtest_filter="*AccountConsistencyModeManagerTest*" Change-Id: Ie8fe9c4be9868d1301f6063dc84764a1c9dea028 Reviewed-on: https://chromium-review.googlesource.com/906430 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#536005}
-
https://skia.googlesource.com/skia.git/+log/954295bc700d..c5cecdcaf8ab $ git log 954295bc7..c5cecdcaf --date=short --no-merges --format='%ad %ae %s' 2018-02-09 brianosman Remove image functions from GrGLInterface, part one Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ie300196e258f5c344d6d8aa921a23d77e33751a7 Reviewed-on: https://chromium-review.googlesource.com/911978 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifdb2041f20f777b06180bc981786d1c6777eb778 Reviewed-on: https://chromium-review.googlesource.com/911999 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#536003}
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I301857ed92c18e80943ac4b6abab062c839b332f Reviewed-on: https://chromium-review.googlesource.com/911998 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
yiyix authored
In this patch, I added some metrics to measure effectiveness of draw occlusion so that we can get more meaningful data from finch trials. Metrics added includes measuring the number of quads that are removed or resized, total area of drawing that are skipped, and total number draw quads that need to go through complex transforms. Bug:672929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I354c95a3ac5525ab81694ad67f4f1b183c86f0cb Reviewed-on: https://chromium-review.googlesource.com/898342 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#536001}
-
https://skia.googlesource.com/skia.git/+log/193d3a051400..954295bc700d $ git log 193d3a051..954295bc7 --date=short --no-merges --format='%ad %ae %s' 2018-02-11 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ie262a2ca81f4047c12fbbf7168a7e3089c35234e Reviewed-on: https://chromium-review.googlesource.com/912779Reviewed-by:
-
Sylvain Defresne authored
Use browsing_data::RecordDeletionForPeriod() to record the action instead of re-implementing it and use the function browsing_data::CalculateEndDeleteTime to correctly compute the end of the time period (fix the "older than 30 days" time period). Remove unnecessary code to clean up delete_end_ as the corresponding issue is long fixed. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1cf0287daad9f4228a1d2c146e0f8f2028e16cd Reviewed-on: https://chromium-review.googlesource.com/911885Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#535999}
-
Ken Rockot authored
and struct_traits => mojom_traits TBR=dcheng@chromium.org TBR=asvitkine@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: Ic201838785b6613659bea1dab6a3f59b070e5e9a Reviewed-on: https://chromium-review.googlesource.com/912733 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Bence Béky authored
HttpBasicState::Initialize() always succeeds, so remove callback argument and change return type to void. Why convert CompletionCallback to CompletionOnceCallback if one can safely remove it instead? :) Bug: 807724 Change-Id: I16244d0600a278139ba2e112373f95933245a1b2 Reviewed-on: https://chromium-review.googlesource.com/908635Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#535997}
-
Bence Béky authored
Bug: 807724 Change-Id: Ieb4afbaf6986261bbd795051b18a8eb148aa0ad1 Reviewed-on: https://chromium-review.googlesource.com/908868Reviewed-by:
-
Ken Rockot authored
and struct_traits => mojom_traits TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia252dcac3d6e0c00ab143871e66b7eec13a66e81 Reviewed-on: https://chromium-review.googlesource.com/912778 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ken Rockot authored
and struct_traits => mojom_traits TBR=dcheng@chromium.org TBR=sky@chromium.org Bug: 806965 Change-Id: I8f8aca7d28c654378792d02d9ad272d226763cb2 Reviewed-on: https://chromium-review.googlesource.com/912517Reviewed-by:
-
Bence Béky authored
Change logging in StaticSocketDataHelper::VerifyWriteData() such that if writted data does not match mock write, then print actual written data in full length, not only truncated to the length of the mock write data. Remove unused StaticSocketDataProvider:CompleteRead(). The rest of this CL belongs to https://crbug.com/810752: Inline ConstructSpdyGoAway() as ConstructSpdyGoAway(0). Remove unused struct SpdyHeaderInfo. Remove obsolete "The caller takes ownership of the frame." comment from spdy_test_util_common.h, leftover from when methods used to return raw pointers. This is a follow-up to https://crrev.com/2156643002/diff/1/net/spdy/spdy_test_util_common.h. Also remove useless "Returns a SpdySerializedFrame." comments from the line above the definition showing return type SpdySerializedFrame. Bug: 600438, 810752 Change-Id: I1f3471f4e4a9b71603257cf82986d0efe0288c7f Reviewed-on: https://chromium-review.googlesource.com/912013Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#535993}
-
Kenneth Russell authored
Start by copying nearly all of the bots' descriptions into new names. TBR=dpranke@chromium.org, machenbach@chromium.org, jmadill@chromium.org, ynovikov@chromium.org Bug: 792780 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0e9f564e9dc87124578f5b699b64011ff9b952da Reviewed-on: https://chromium-review.googlesource.com/912767 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#535992}
-
Noel Gordon authored
Similar to crrev.com/534964, since crc32 can be freely called per the "zlib.h" docs, add comment about zlib crc32 usage conventions viz., calling crc32(0, NULL, 0) before use and how we use that as signal to cache CPU features. Tbr: cavalcantii@chromium.org Bug: 796178 Change-Id: I3c80149ea9c09baeb5a376d54ffeb4e36b12b5ec Reviewed-on: https://chromium-review.googlesource.com/912790Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#535991}
-
- 10 Feb, 2018 13 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b1891a0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12320 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I919462ad2ead0c81343da55034b9993c4fe5694c Reviewed-on: https://chromium-review.googlesource.com/912114 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#535990}
-
Xiaocheng Hu authored
Change-Id: I6be5e1344f831b4b63d522084eace80799398115 Reviewed-on: https://chromium-review.googlesource.com/912462Reviewed-by:
-
Kim Paulhamus authored
Bug: 664630 Change-Id: Ie7fb418978c6d7194f071ead353084cc59ffb677 Reviewed-on: https://chromium-review.googlesource.com/912204Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#535988}
-
Steven Holte authored
These will be required for implementing UKMs SourceUrlRecorder for iOS. Bug: 792662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I110d51ddf79dd1e08e4759721387d21cf280c439 Reviewed-on: https://chromium-review.googlesource.com/887954 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#535987}
-
https://skia.googlesource.com/skia.git/+log/32750e6fb73f..193d3a051400 $ git log 32750e6fb..193d3a051 --date=short --no-merges --format='%ad %ae %s' 2018-02-08 reed use SkShaper instead of SkTextBox Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I74cbbaced485d6a8118bcd0575185f45a8197e02 Reviewed-on: https://chromium-review.googlesource.com/912134Reviewed-by:
-
Ken Rockot authored
And any struct_traits => mojom_traits Brought to you by grep and sed TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3782b0e0fbfe438678a9aeeaefd2922fbd19d0eb Reviewed-on: https://chromium-review.googlesource.com/912511Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0f64f2c2ac39f27fe175f9e71bb627de91fd7b13 Reviewed-on: https://chromium-review.googlesource.com/912775 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=sky@chromium.org Bug: 806965 Change-Id: Ia1eb1567f60ea4e5e9ac3a3ec98052c575767501 Reviewed-on: https://chromium-review.googlesource.com/912773Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: I15f64c901705cc2573e2c36b78af4cb6158f0104 Reviewed-on: https://chromium-review.googlesource.com/912772 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: I6fe6abafbdf5d51b633489440d72ab6073af59aa Reviewed-on: https://chromium-review.googlesource.com/912771 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ken Rockot authored
TBR=dcheng@chromium.org TBR=jam@chromium.org Bug: 806965 Change-Id: Ie3ae003a0e2aeca38b6ead9aa82e5399e7b0ac86 Reviewed-on: https://chromium-review.googlesource.com/912770 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ken Rockot authored
TBR=jam@chromium.org TBR=dcheng@chromium.org Bug: 806965 Change-Id: I5ada864d9ce5ab638d23ba5177140b1bb0415b9c Reviewed-on: https://chromium-review.googlesource.com/912769 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Eugene But authored
Rename TestPreClassificationCheckInPageNavigation to TestPreClassificationCheckSameDocumentNavigation. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. Bug: 695189 Change-Id: Ib0e1229d1730d6ac01038aed112a47d9eea78015 Reviewed-on: https://chromium-review.googlesource.com/912451Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#535978}
-
