- 27 Sep, 2018 40 commits
-
-
Sylvain Defresne authored
The documentation says that the parameter must not be empty, so add a DCHECK instead of a check. This is safe as the underlying method in KSF DCHECK too. Bug: 809610 Change-Id: Ib7c8b15d1bbc3f82ee3403f530a0167020cfee53 Reviewed-on: https://chromium-review.googlesource.com/1248629Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594721}
-
Marc Treib authored
Bug: none Change-Id: I9a1bd69329e187e39d82edb20c913d947fd9b588 Reviewed-on: https://chromium-review.googlesource.com/1249069Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594720}
-
Marina Ciocea authored
Disabled tests: NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler TBR=shimazu@chromium.org Bug: 889855 Change-Id: I7215b4e074da8932725a2d6540cccf29eea823a3 Reviewed-on: https://chromium-review.googlesource.com/1249083Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594719}
-
Leonard Grey authored
No behavior change intended, just pushing some code into the function from the callsite. This will allow Mac to use the same interface, but with mouse events targeting widgets instead of aura::Windows. Bug: 769352 Change-Id: Ibfec8c567b6e28b1d9b77bf6a7c388e1b69e3395 Reviewed-on: https://chromium-review.googlesource.com/1237115 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594718}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Id9ffa19550de44af7e4f89bc8f3d4439e572398f Reviewed-on: https://chromium-review.googlesource.com/1248784 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594717}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic82c971941b125a31c1fa0a6377b1e451fa045fb Reviewed-on: https://chromium-review.googlesource.com/1249384 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594716}
-
Marc Treib authored
It was used to back a policy which was removed in https://crrev.com/c/1224033, and supervised user creation itself has been gone for way longer. Bug: 828890 Change-Id: I3a764e88f72599799263d1dc141d88e5e8b85a91 Reviewed-on: https://chromium-review.googlesource.com/1245708Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594715}
-
Marc Treib authored
This fixes one (small) issue where the next_token_request_time didn't get cleared if the retry timer called us while there was already a request ongoing. It also adds a bunch of DCHECKs to hopefully catch any other cases I might have missed. Inspired by some recent bug reports that showed a "Next Token Request" time in the past on about:sync-internals. Bug: 889859 Change-Id: I8cd189c0e4acccc4af0d38a3ce9da6ccbd3cac7a Reviewed-on: https://chromium-review.googlesource.com/1249067Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594714}
-
Mario Sanchez Prada authored
This hasn't yet been migrated from OAuth2AccessTokenConsumer::TokenResponse and it will be useful at least to determine whether we are under advanced protection from AdvancedProtectionStatusManager once a token is fetched. Additional test coverage will be added in a follow-up patch. TBR=thestig@chromium.org Bug: 889764 Change-Id: Id9a8bcc7b2e3a5238b7a1c98f7787a8e905b6add Reviewed-on: https://chromium-review.googlesource.com/1248625 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#594713}
-
Rayan Kanso authored
Set a per-origin limit (5) for how many active background fetch registrations an origin can have. This is to avoid a potential abuse vector until a more concrete permission model is in place. With this, an origin can't keep registering fetches and permanently have a notification shown, also blocking other origins from starting a background fetch. Bug: 889401 Change-Id: I9aeac7121c46ffdd3910b3b891051e9c4951bc6e Reviewed-on: https://chromium-review.googlesource.com/1245369 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594712}
-
timidger authored
This allows the Chrome Cleanup Tool to request Chrome to delete extensions it finds. This was put in the mojom interface because it's the simplest way to add to the CCT interface to Chrome. This has no real dependency on the chrome prompt workflow. Also changes the chrome cleaner to only build on platforms that support extensions as it was breaking on android (which we don't support). R=joenotcharles@chromium.org, joenotcharles@google.com, kinuko@chromium.org, reillyg@chromium.org Bug: 889568 Change-Id: Idbbebda824e3d7764940773964f50045639617bd Reviewed-on: https://chromium-review.googlesource.com/1207219 Commit-Queue: Preston Carpenter <timidger@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594711}
-
Jonathan Metzman authored
Bug: 884560 Change-Id: I7e6ac6869b2e2e068214cc5944d73a22549e5a70 Reviewed-on: https://chromium-review.googlesource.com/1247189Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594710}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3e48afc936d..227d4e10276c git log b3e48afc936d..227d4e10276c --date=short --no-merges --format='%ad %ae %s' 2018-09-27 scroggo@google.com encodedProfile can be null, so check for that Created with: gclient setdep -r src/third_party/skia@227d4e10276c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/116608007 TBR=bsalomon@chromium.org Change-Id: I9d547ab395024639cf48edd467d61ce8e596e531 Reviewed-on: https://chromium-review.googlesource.com/1249310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594709}
-
Mark Cogan authored
Move infobar_close into downloads/, which is the only place where it's used, and rename it. Bug: 884722 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I539058203790b7ba7b0e28e94e989ce32e0e95fd Reviewed-on: https://chromium-review.googlesource.com/1248704 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594708}
-
Mikel Astiz authored
This changes the behavior of TabNodePool::AssociateWithFreeTabNode() to always return the smallest available ID, resulting in a more compact distribution of sync IDs too, hence a lower number of sync entities. This will allow, in future patches, the deletion of arbitrary tab entities, without incurring an increase of the number of session sync entities. Bug: 882489 Change-Id: I11ac5167f6971dbd8239b530a87a49eb51f20261 Reviewed-on: https://chromium-review.googlesource.com/1242883Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95c25ea38fcf..5d8c6f4f9d8f Created with: gclient setdep -r src-internal@5d8c6f4f9d8f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d2c80e7adc203c8824fe6bb654fcf238b27a25f Reviewed-on: https://chromium-review.googlesource.com/1249308Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594706}
-
Thomas Tangl authored
The signin-allowed policy is now tied to the new pref signin.allowed_on_next_startup. This means that changes only take effect on the next startup. Note: This change only affects Desktop. Additional change: - Move the signin-allowed toggle to the top of the privacy page. Screenshot: https://drive.google.com/file/d/1FD0gQRmwlnIFeiAMpU7U_3x4ErUu91Tb/view?usp=sharing TBR=scottchen@chromium.org Bug: 888776 Change-Id: I4f7281a3b7eee8e799c48cf829dde12c7e9cbcc8 Reviewed-on: https://chromium-review.googlesource.com/1249021Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#594705}
-
Oskar Sundbom authored
When an input stream is being processed in the audio service, its InputController monitors an output stream (actually, its OutputController) to get the audio it needs to perform echo cancellation. When the output stream is replaced, the input controller should stop monitoring the old output stream and start monitoring the new one. If the creation and destruction of these streams are interleaved, this would break, as the input controller would start monitoring the new stream, then stop monitoring any stream as the old output stream was destroyed. This CL ensures the input controller only stops monitoring if the destroyed stream is the one it's currently monitoring. Bug: 883651 Change-Id: I5731840d8af11ecd76ecd1a25126034c5ff496ac Reviewed-on: https://chromium-review.googlesource.com/1245711 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594704}
-
Eric Stevenson authored
Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1232018. Change-Id: I79982c7e0879af5d2a68d60bbd165164762c6a30 Reviewed-on: https://chromium-review.googlesource.com/1246831Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594703}
-
Mikel Astiz authored
There is no need to cast SyncableService instances to interface SyncChangeProcessor, neither do these services need to implement any functions in there, since they are not exercised. One exception is SyncChangeProcessor::UpdateDataTypeContext(), which is called from SharedChangeProcessor, but there is no SyncableService that implements any functionality in such function. In order to keep the patch less intrusive, GetAllSyncData() is kept around, now moved to SyncableService, since all implementations provide such functionality. However, we don't seem to call that function from anywhere, so a TODO has been added to simplify that in future patches. TBR=groby@chromium.org Bug: 870624 Change-Id: I54b33cdd1ecc5584a806d3ff0fc0f3f6708467ca Reviewed-on: https://chromium-review.googlesource.com/1243809Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594702}
-
Stephane Zermatten authored
Change-Id: Id13a8add39f1d8591d837db322f33dcc5b4335d7 Reviewed-on: https://chromium-review.googlesource.com/1248623Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#594701}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3c7694137a0e..e9a7e90625fe git log 3c7694137a0e..e9a7e90625fe --date=short --no-merges --format='%ad %ae %s' 2018-09-27 devicentepena@webrtc.org AEC3: ERLE: Allowing increases of the ERLE estimate for low render signals. 2018-09-27 jonaso@webrtc.org Add GetSources to VideoRtpReceiver Created with: gclient setdep -r src/third_party/webrtc@e9a7e90625fe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I571658577df50b70210d63ab17a637368e4e857f Reviewed-on: https://chromium-review.googlesource.com/1249306Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594700}
-
Vadym Doroshenko authored
Password Manager sends crowdsourcing votes for sign-in forms with labeling of fields with Autofill votes. The idea to use autofill votes in such situation is deprecated now. And moreover on the CL https://chromium-review.googlesource.com/c/chromium/src/+/1219710 it's allowed to send normal Password Manager votes for sign-in forms. So in order to avoid double vote sending and decrease code complexity it's now time to remove sign-in vote sending. Bug: 889472, 875768 Change-Id: Ibad10f13b69776a433f6c0a2e2017f234b85a6ec Reviewed-on: https://chromium-review.googlesource.com/1248626 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594699}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b926e364a51b..4e651334d46b git log b926e364a51b..4e651334d46b --date=short --no-merges --format='%ad %ae %s' 2018-09-27 perezju@chromium.org [pinpoint_cli] Iterate over test results in job Created with: gclient setdep -r src/third_party/catapult@4e651334d46b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I05f4b537358d90b1a8adca71822b87bef7e91dc5 Reviewed-on: https://chromium-review.googlesource.com/1249305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594698}
-
Marina Ciocea authored
This reverts commit e6f5eba3. Reason for revert: looks related to the Win10 Test flakiness reported by findit. Original change's description: > Download Shelf : Connect OfflineItem to the shelf > > This CL connects offline item with the download shelf. Some of > the OfflineItemModel methods are still not implemented. > > Bug: 881499 > Change-Id: I2f0cd71815a08bcddfca753378543749389d78db > Reviewed-on: https://chromium-review.googlesource.com/1239875 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594471} TBR=qinmin@chromium.org,carlosk@chromium.org,shaktisahu@chromium.org Change-Id: I98129d5eaca139d27ab7bb15f3ca194efb1331c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499, 889790 Reviewed-on: https://chromium-review.googlesource.com/1249068Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594697}
-
Jeremy Roman authored
There is existing documentation about the details, but as yet no overall "what is this thing" summary. Change-Id: I057d1c67a8f7d5fe1cbbeb65505a3be0419bfafc Reviewed-on: https://chromium-review.googlesource.com/1246951 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#594696}
-
Gemene Narcis authored
This CL move the class that reports metrics about HTTP to HTTPS migration in separate files. The class is renamed in HttpCredentialCleaner since it will be extended in the next CLs to remove obsolete HTTP credentials as well. Bug: 871140 Change-Id: I52784893278a54876d68922cb2478a61974c049a Reviewed-on: https://chromium-review.googlesource.com/1249122 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594695}
-
Jan Krcal authored
This CL refactors a few helpers for AutofillWalletMetadataSyncBridge with the new AutofillMetadata struct in mind. Bug: 853688 Change-Id: Idec8e641f116ad57454527a9c4b7f42a408507d7 Reviewed-on: https://chromium-review.googlesource.com/1245724 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594694}
-
Marina Ciocea authored
Disable flaky test AudioServiceOutputDeviceTest.VerifyDataFlow on chromium.memory/Linux Chromium OS ASan LSan. TBR=olka@chromium.org Bug: 889845 Change-Id: Ia567217a45085fbc190985504fd29d42b162a16d Reviewed-on: https://chromium-review.googlesource.com/1249264Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594693}
-
Michael Lippautz authored
Tracing bails out when encountering that flags already have been set explicitly. Also make the test bail out in this case. Bug: 889396 Change-Id: Ic438a15f136e964f0c9bd1a123a8ae230ffab850 Reviewed-on: https://chromium-review.googlesource.com/1245367 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594692}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec3aded0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25387 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ib74c62a3a259a200401bd7a09abeaad443dfdf7b Reviewed-on: https://chromium-review.googlesource.com/1249301 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594691}
-
Philip Jägenstedt authored
With tweaks from this comment: https://github.com/web-platform-tests/wpt/pull/12858#issuecomment-419775438 Bug: 879798 Change-Id: I3806dffd01dcc7a1f7dd21a7fe68ce3c099df181 Reviewed-on: https://chromium-review.googlesource.com/1224010Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#594690}
-
Adam Langley authored
This change tweaks the templates for handling dictionaries. It does not alter the generated code, but makes subsequent changes smaller and therefore clearer. Change-Id: I9bf6620fc2ca2415abaaf917130ea55b539e4c3f Reviewed-on: https://chromium-review.googlesource.com/1241454Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#594689}
-
Sylvain Defresne authored
The method is never invoked, so remove it. Bug: none Change-Id: Ib96cd1a7c34e4dce7ccf8ed9b1937ccb59ec987c Reviewed-on: https://chromium-review.googlesource.com/1243483 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#594688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9fae1c2..4034a5cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I585d662022f0482c02d51189c8972d52d0cfd130 Reviewed-on: https://chromium-review.googlesource.com/1249302Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594687}
-
Vadym Doroshenko authored
Manual fallback with NPFM is implemented similar to PFM, namely: 1.The user is typing 2.FormData is extracted and sent to the browser. 3.PasswordManager::ShowManualFallbackForSaving is called a.NPFM is cloned b.Received FormData is considered to be submitted form c.Cloned NPFM is moved to UI Along the way, GetSignonRealm was extracted to the util file. Bug: 831123 Change-Id: Ibbb30ccd1a1e8084e378480cd2ceccca4eaa93d4 Reviewed-on: https://chromium-review.googlesource.com/1238896 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594686}
-
Oskar Sundbom authored
When using APM in Audio Service, the output device for a microphone with native echo cancellation support may be set before the stream has started. For the Windows AEC implementation, this would start the dummy output stream, which is used to ensure a continuous reverse stream, too early. Bug: 882420 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1121cc4b35a0457f006326dfc0340379f9a0e091 Reviewed-on: https://chromium-review.googlesource.com/1243088 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#594685}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/02fed02c00e5..3c7694137a0e git log 02fed02c00e5..3c7694137a0e --date=short --no-merges --format='%ad %ae %s' 2018-09-27 brandtr@webrtc.org iOS: Add maxFramerate to RtpEncodingParameters. Created with: gclient setdep -r src/third_party/webrtc@3c7694137a0e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I75b156c72bf81ea67153fa2981f8935c15c1f2c6 Reviewed-on: https://chromium-review.googlesource.com/1249221Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594684}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba7382c58459..b926e364a51b git log ba7382c58459..b926e364a51b --date=short --no-merges --format='%ad %ae %s' 2018-09-27 cbruni@chromium.org [telemetry] Enforce consistent language settings 2018-09-27 anthonyalridge@google.com Increase default font size of svg text. Created with: gclient setdep -r src/third_party/catapult@b926e364a51b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878390,chromium:866423 TBR=sullivan@chromium.org Change-Id: Idbb445763bb76c6935e511c28911d656aa040b94 Reviewed-on: https://chromium-review.googlesource.com/1249242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594683}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/115e8a2625f5..122919bddd98 git log 115e8a2625f5..122919bddd98 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Update docs on building ANGLE inside Chromium. Created with: gclient setdep -r src/third_party/angle@122919bddd98 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I7fd8fe7ad4191b724746411923831c6bdd374e23 Reviewed-on: https://chromium-review.googlesource.com/1249241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594682}
-