- 13 Oct, 2019 4 commits
-
-
Xianzhu Wang authored
Now we record foreign layers directly in LinkHighlightImpl::Paint() without GraphicsLayers, just like what we have been doing for CompositeAfterPaint. Bug: 1012594 Change-Id: I448b4b109dae4778a9f4650639633d083e4a5e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849252 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705422}
-
Jinfeng Ma authored
Renaming the variables and functions related to the original kOverlayScrollbars paint phase. This is 3/3 of a series of patches: 1. https://crrev.com/c/1816486 2. https://crrev.com/c/1817874 3. This patch. Bug: 1006173 Change-Id: Ie34b71936d03ade4673fdcb8510de735276937ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831917Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705421}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ica60821676b7c7884c0f6c3cec9eb72ef390a684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705420}
-
Kevin Marshall authored
Addresses wez's post-landing comments made to CL#1848411: * All paths from URLs are assumed to begin with slash. Conditional handling of relative paths is removed. * Add a comment explaining Fuchsia's lack of support for absolute paths. Bug: 1011180 Change-Id: Idb4cbe0cfac2a7547f44488ee9133b8ca0ea8207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854801 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705419}
-
- 12 Oct, 2019 36 commits
-
-
Jinfeng Ma authored
Clean up PaintLayerScrollableArea::UpdateScrollCornerStyle and ScrollableAreaPainter::PaintResizer with the new added function: PaintLayerScrollableArea::HasNonOverlayOverflowControls. This is 2/3 of a series of patches: 1. https://crrev.com/c/1816486 2. This patch. 3. https://crrev.com/c/1831917 Bug: 1006173 Change-Id: Ic6bb659cb7d7e646955e08a4f5035313f71dee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817874Reviewed-by:
-
Xianzhu Wang authored
This reverts the line to before crrev.com/c/1826994 (see crrev.com/c/1826994/3/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc#b2680). Still not sure how the visual rect of composited overlay scrollbar affects texture memory. The visual rect doesn't affect paint or raster invalidation. Bug: 1011996 Change-Id: I20f2c9bddd2e6a0aff254f598ba0f16b3d6d5738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847942 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/88d7869db091..5abb9b7c5d0c git log 88d7869db091..5abb9b7c5d0c --date=short --no-merges --format='%ad %ae %s' 2019-10-12 nodir@chromium.org Revert "Reland "depot_tools: Add httplib2 to .vpython"" Created with: gclient setdep -r src/third_party/depot_tools@5abb9b7c5d0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: Idc93fd0b88cc8e8928be3fd6f159c0f4a28c7257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857664Reviewed-by:
-
Xianzhu Wang authored
Most of the new baselines are following up https://chromium-review.googlesource.com/c/chromium/src/+/1856359 (Disable mock theme) TBR=wangxianzhu@chromium.org Change-Id: Id9c07511f90d689a774fecdf39d56b99901366ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857665Reviewed-by:
-
Daniel Cheng authored
Currently, state synchronization between the browser and the renderer process is complicated and buggy for cross-process navigations. The renderer process is responsible for processing the commit IPC and then reporting success back up to the browser process, which then updates its state. However, it's unclear if this can lead to races. Instead, if it is possible to assume that one CommitNavigation() IPC from the browser always maps to one committed navigation in the renderer, the code can be simplified to remove multiphase navigation commits. This means the browser would be able to mark a provisional local frame as committed as soon as it sends a commit IPC to the renderer for that frame. Bug: 999255 Change-Id: I7d58293e6c2ec6ca0d09b614ae5a41340f4afd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775663 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe95b86e. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6296b99a81334c4347fbf8d7f2711899c3e9e4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857245Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705413}
-
Weiliang Chen authored
For Android Classic overlay path, connect the shared image video to receive overlay promotion hints through SkiaOutputSurface. This includes adding a new type of scoped read lock on display resource provider for shared image, and making sure overlay resources are waited and kept alive. This approach uese the SharedImage API for video, and doesn't change logic to generate overlay candidates. TBR=kylechar Bug: 979795 Change-Id: Ia370be37c6bbbcfaa4cba26f179e79ac9124ac77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811961 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#705412}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I06b0b9ca51a016d2e258639129c6cfa4b46a4ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857709Reviewed-by:
-
Fergal Daly authored
Change-Id: I5f4e72e22247b16424230fcf6bbdcb7b3c147db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852351 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705410}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/130fdbcc23ed..a2f89c000483 git log 130fdbcc23ed..a2f89c000483 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 jiajie.hu@intel.com Add sampler array index validation for ESSL 3.00 onwards Created with: gclient setdep -r src/third_party/angle@a2f89c000483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:985032 Change-Id: If974b1060689f6e0303d669d558a808aa179aad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856855Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15aa86bf55aa..e74f8be31fac Created with: gclient setdep -r src-internal@e74f8be31fac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I47f4073a5988247e8ca6a37aae3070e9d0d33739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705408}
-
Miyoung Shin authored
This CL converts SocketObserver{Ptr, Request} in chrome, components, content, extensions, jingle, google_apis and services to the new Mojo type, and uses pending_remote<T> in network_context.mojom, proxy_resolving_socket.mojom and tcp_socket.mojom. Bug: 955171 Change-Id: I3bac36caf28dd5008f32deb6157dec202e8e2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851888 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#705407}
-
Miyoung Shin authored
This CL converts SSLConfigClient{Ptr, Request} in chrome and services to the new Mojo type, and uses pending_receiver<SSLConfigClient> in network_context.mojom. Bug: 955171 Change-Id: Ied34cb3bba3d04d927aa601996296af157c692b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852525 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Adam Langley <agl@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of 7cf54149 Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 12 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I034377bb4772d565567ced5dd15f58a6440ee1ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849741 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704527} Bug: 1001360 Change-Id: I7daf25b863f41aa22d9db551e0ae9dc1bd10e128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852344 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8352ab39aafc..15aa86bf55aa Created with: gclient setdep -r src-internal@15aa86bf55aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2bd2ab9d7a3097dc170f6bb953dcda548ea16318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857793Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36ab07aa..1877e9da Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I85e56d4a5b71622e1b13e38de84d0d03424496e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857381Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705403}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_presentation_receiver_flags.h file was moved to third_party/blink/public/common/presentation. Since the file is no longer in the public/web/ directory we are also renaming it to presentation_receiver_flags.h. The static keyword was also removed as constexpr is static. Bug: 1008303 Change-Id: I78c6641ac7c41fc7275b121ad5f7e68a9476f080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856079Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
The two callsites that call ResolveActiveEnd() also perform an 'end' instance time lookup and handle an 'unresolved' value, so merge these two bits into ResolveActiveEnd(). Bug: 998526 Change-Id: I0e1dff5a465c47e16e23b74b42bcec68ba83b7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855987 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#705401}
-
Miyoung Shin authored
This CL converts XRTestHookPtr and mojo:Binding<XRTestHook> in chrome to the new Mojo type, and use pending_remote<XRTestHook> in browser_test_interfaces.mojom. Bug: 955171 Change-Id: I0b89731dcd91ab1150f7b9f574c4b5eaa42471a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847594 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#705400}
-
Fredrik Söderquist authored
Use this when discarding or otherwise initializing an interval to an unresolved state - which hopefully slightly more readable than what is currently used. Drop some friend declarations from SMILTime that are no longer needed, while we're in the vicinity. Bug: 998526 Change-Id: I08531a906c0e093f2786c4c1a925ebd823f99ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856163 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Miyoung Shin authored
This CL converts mojo::AssociatedBinding<XRRuntimeEventListener> that is left only in BrowserXRRuntime class to the new Mojo type. Bug: 955171 Change-Id: I114458055b27ffd306e357bad1d01cdd1e303238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849736 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Fredrik Söderquist authored
If a mutation of the 'end' attribute ended up introducing an offset value that was before or at the begin time for the current interval, we'll no longer have a valid interval (unresolved active duration). In this case do what ResolveInterval() does and discard the current interval. Bug: 1013365 Change-Id: I871c2c235f179dabb31c2347c47f83c53d44b1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855963Reviewed-by:
-
François Doray authored
With this CL, content::LockObserver is notified when the number of IndexedDB connections (active or pending) in a frame switches between zero and non-zero. The information is plumbed to the Performance Manager which uses it to avoid freezing pages with IndexedDB connections. This is because freezing a page with active IndexedDB connections can prevent other pages from performing IndexedDB operations. In the future, we would like to get more granular information about when it is really problematic to freeze a frame because of its current usage of IndexedDB, but this is a good first step to allow shipping page freezing without breaking usage of IndexedDB. More details at https://docs.google.com/document/d/1CUE1pfS5pGhJt6X0EKwv2sQYP5PcdzyGZKKtdBYzEOw/edit?usp=sharing Bug: 980533 Change-Id: Ifbb0d0ea66ab4b6f522ffa4824af7a2fea16ccaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848794 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#705396}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactoryPtr from //services to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: I9adc787b0010321165d1b8cb47af462101ca73c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855150Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1948af385c1b..130fdbcc23ed git log 1948af385c1b..130fdbcc23ed --date=short --no-merges --format='%ad %ae %s' 2019-10-12 jmadill@chromium.org Roll chromium_revision 43eb5958..93253402 (704334:704874) Created with: gclient setdep -r src/third_party/angle@130fdbcc23ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ifc7552242bc4e561440e245af8427629b896cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857469Reviewed-by:
-
Fredrik Söderquist authored
When seeking forward we don't need to reset all the timed elements, but can just move from the latest update time to the new presentation time directly. Bug: 998526 Change-Id: I1866b59b4e02f9de1a26c6a5844c4d8893dd68b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856161Reviewed-by:
-
Miyoung Shin authored
This CL converts TCPBoundSocket{Ptr, Request} in chrome, content and services to the new Mojo type, and uses pending_receiver<TCPBoundSocket> in network_context.mojom. Bug: 955171 Change-Id: I7299992edda7ef98db66dfc75105487dd2e92d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849747Reviewed-by: -
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6106a9b8462f023d40c7eb42b5082d54ccafcec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857574Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21bb102317d6..17844a0135bf git log 21bb102317d6..17844a0135bf --date=short --no-merges --format='%ad %ae %s' 2019-10-12 vapier@chromium.org cros lint: upgrade to pylint-1.7 Created with: gclient setdep -r src/third_party/chromite@17844a0135bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4a6fe616a9f98f55b1d6251e6f2e20e4cb72e045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857662Reviewed-by:
-
Ken Rockot authored
This changes BrowserTestBase::SetUp to disallow FeatureList overrides for the remaining duration of the test. Catches incorrect usage of ScopedFeatureList which can cause data races. Bug: 846380 Change-Id: Ie76d59e191edc3ac05c96131e83e5aa0b73dfda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842111 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b6287e93..36ab07aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie25c8bf1fcba97a7003c8b55d7f9744861235f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857380Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/483426c9f91a..21bb102317d6 git log 483426c9f91a..21bb102317d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 vapier@chromium.org paygen_payload_lib: use binary mode in more places Created with: gclient setdep -r src/third_party/chromite@21bb102317d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia425bd459981c70789dac058ee5d64366b569bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857660Reviewed-by:
-
Xianzhu Wang authored
This is a reduced version of crrev.com/c/1835272. This CL keeps fast/scrolling/scrollbars still using mock themes, which will be addressed as part of crbug.com/953847. The mock theme was for 1. platforms that have multiple native themes / toolkits because we don't support multiple baselines for them 2. to reduce platform dependent baselines 3. to test some features (e.g. hover effect of scrollbar track) that are not available on some native themes However, the mock theme prevented us from testing the real native theme and may hide some bugs, and is a maintenance burden. Each of the above reasons can be counter justified: 1. If a platform does have multiple native themes / toolkits, we can force the test environment to test only one of them, or extent the testing infrastructure to support multiple native themes / toolkits. 2. We have good rebaseline tools to support platform dependent baselines. Also we prefer ref/testharness tests to pixel tests. 3. We only need to support a feature that is used by a native theme, thus it will be tested with that native theme. If a feature is not used by any native theme, then we don't need to test and support it. For discussions see: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADBxrieDnCJOwDide2ZbyGvQRKRJzia9Pxbc-fnXJNAShL5q%2Bw%40mail.gmail.com?utm_medium=email&utm_source=footer About TBR: The reviewers already LGTM'ed crrev.com/c/1835272. TBR=tkent@chromium.org,mkwst@chromium.org Bug: 1013637, 953847 Change-Id: Ifea3c76ed01efd694ad64eb21bc329e8e1c7c1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856359Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f90eb5d3..b6287e93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9092716bc56d167a6638bccf4cafd0c0144a4c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857244Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8be669fd96e4..8bbf9e2c6e40 git log 8be669fd96e4..8bbf9e2c6e40 --date=short --no-merges --format='%ad %ae %s' 2019-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 002d8b5c..c1f96a7b (705236:705365) Created with: gclient setdep -r src/third_party/webrtc@8bbf9e2c6e40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia8acd18a1f60abc302fab3c89bbecbd4f3e39965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857492Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cbae8a8b9f6..88d7869db091 git log 2cbae8a8b9f6..88d7869db091 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ehmaldonado@chromium.org Reland "depot_tools: Add httplib2 to .vpython" Created with: gclient setdep -r src/third_party/depot_tools@88d7869db091 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I78ad64b527de6f93252dc272e4dd708ca83abd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857192Reviewed-by:
-
