- 19 Oct, 2017 40 commits
-
-
Gauthier Ambard authored
When the NTP will appear, the layout needs to be invalidated. It ensures that the insets for the Most Visited section are correct when the device is rotated while another screen (e.g. settings) is presented in front of the NTP. Bug: 771149 Change-Id: If8c926fbb0e5cca860b31c4ccc7b672fe49b9e80 Reviewed-on: https://chromium-review.googlesource.com/726082Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#510069}
-
Henrik Kjellander authored
TBR=dpranke@chromium.org Bug: webrtc:8363 Change-Id: I4dd6d686e901fa0b050cc0e0d15e1c89a357891b Reviewed-on: https://chromium-review.googlesource.com/706790Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#510068}
-
Blake O'Hare authored
I removed the test parameter a while back but didn't see this comment. Bug: Change-Id: Ib916240cf10ca0f8b589e8aa9d1b32a4a4a03889 Reviewed-on: https://chromium-review.googlesource.com/727820Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#510067}
-
Mikel Astiz authored
This reverts commit 0b789948. Reason for revert: breaks Linux ChromiumOS Tests. Bug: 776308 Original change's description: > Reland: Fire focus if needed in automation api > > TBR=dtseng@chromium.org > Bug: 773866 > > Original change > > Reviewed-on: https://chromium-review.googlesource.com/723606 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#509911} > Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f > Reviewed-on: https://chromium-review.googlesource.com/727122 > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510006} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: I9025ec011491530ec70cf0c1a0e33bdfec32c512 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773866 Reviewed-on: https://chromium-review.googlesource.com/728160Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#510066}
-
Thomas Tangl authored
The button to close all windows, which appears in the profile chooser menu, should be shown even when there is only one window open. This addresses the comment crbug.com/130656#c49. More fixes are coming. The MacOS version can be found here: crrev.com/c/725426. Bug: 130656 Change-Id: I90b9c93c9a8452472b1d8dfc89fcf7084987a3a6 Reviewed-on: https://chromium-review.googlesource.com/720360 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#510065}
-
Hajime Hoshi authored
This CL changes WebFrameSchedulerImpl::*TaskRunner() to create WebTaskRunnerImpl objects anytime so that the relationship between WebTaskRunnerImpl and TaskQueue will be n:1. This is a preparation to make WebFrameSchedulerImpl's task runner getters accept task type and store it inside WebTaskRunnerImpl. This is part of the big CL that includes all the necessary changes: https://chromium-review.googlesource.com/c/chromium/src/+/704459 This is a part of adding-task-type work (https://docs.google.com/document/d/1Py2ZdjpaCMdpVtKfdHMITAn5gst_owjQiqlbPm3mCxc/edit?ts=59d49142#) Bug: 762453 Change-Id: Iae1263717990ea959a2ed62ba86c63ef593be600 Reviewed-on: https://chromium-review.googlesource.com/727420Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#510064}
-
Lei Zhang authored
For progress paint timeout values instead of ints. Change-Id: Ibf1391b3c9871e69ef03859063310f8b5f03b38a Reviewed-on: https://chromium-review.googlesource.com/727722 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#510063}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/8a958528b2ca..117c48291cbf $ git log 8a958528b..117c48291 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0429718a89130518353842a462bee9bf89cc9974 Reviewed-on: https://chromium-review.googlesource.com/727544Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510062}
-
Fredrik Söderquist authored
This moves scale-handling out into the (now former) consumers of the ImageResourceContent::ImageSize method. Bug: 773272 Change-Id: I08760b181a48f8a5dcc5ceff68a19c67eba3601a Reviewed-on: https://chromium-review.googlesource.com/726087 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#510061}
-
Bernhard Bauer authored
* Remove self-destroying objects in favor of simply binding callbacks * Make SiteDataDeleteHelper not refouncted anymore * Don't hold on to JNIEnv Bug: 766752 Change-Id: Ib85bc88b7118100a4af730c88c86dca489d5d3ed Reviewed-on: https://chromium-review.googlesource.com/725732Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510060}
-
Christian Dullweber authored
This test creates site data entries via javascript and tests that they are counted and deleted correctly. Bug: 769425 Change-Id: I81178ade64a5d76fd19ee7e79c6a55c4c5ae32cc Reviewed-on: https://chromium-review.googlesource.com/725385 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#510059}
-
Takashi Toyoshima authored
Since the feature is already launched and we do not need to monitor performance impact any more, let's remove intervention related metrics. Bug: 578029 Change-Id: I11f682d3bfcfe5f2bd5ec8d27c355635568489d5 Reviewed-on: https://chromium-review.googlesource.com/722820Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#510058}
-
Takeshi Yoshino authored
It seems they were used to make sure users are aware of that the contents in the String argument must be "output of KURL::GetString() called on a valid KURL object, or indiscernible from such" as noted in the comment. However, these methods are actually performing validation and there's no fast path assuming the input is valid. Considering the value of the annotation and additional character typing in coding, I'd like to propose removal of it. The constructor invocation in WorkletModuleResponsesMapTest.cpp that is taking String() (i.e. null String) is replaced with KURL() invocation. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I40f433e6c1472fba559af9b87ea12cff06d21045 Reviewed-on: https://chromium-review.googlesource.com/718236 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#510057}
-
Egor Pasko authored
This reverts commit 38636aa2. Reason for revert: downstream failure: unable to find chromium-debug.keystore (internal bug: http://crbug.com/776328) Original change's description: > Android: Remove last remnants of ANT > > It had a good run. > > Bug: 375324 > Change-Id: I1db1d501f58d3d3ac8731bc36e8ca550da24adf9 > Reviewed-on: https://chromium-review.googlesource.com/722521 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509785} TBR=thakis@chromium.org,agrieve@chromium.org Change-Id: I7323c95dcdd47145166d6bbd61345cc17db2e7d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 375324 Reviewed-on: https://chromium-review.googlesource.com/727902Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510056}
-
Lalit Maganti authored
Currently the RequestGlobalDump has an ambiguous dual semantic: return results or add to the trace. For historical reasons both semantics have been collapsed in the same function, but this is now getting too hairy, making the codebase hard to reason about, and caused some bugs. Splitting the functions names as they clearly achieve two different functions with different outcomes, specifically: When adding the dump to the trace, clients don't care about the returned object (which also happens to be empty). Likewise when returning the dump (e.g. for SUMMARY_ONLY) the clients don't care about the dump_guid. Bug: 775039 Change-Id: Ia0861bcd20775802813a35f5a138fa022521f416 Reviewed-on: https://chromium-review.googlesource.com/721540 Commit-Queue: Lalit Maganti <lalitm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510055}
-
Ivan Kotenkov authored
Steps to replicate: 1. Build clang-tidy and clang-apply-replacements as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md 2. Build blink in out/gn. 3. Generate the compilation database: tools/clang/scripts/generate_compdb.py -p out/gn > compile_commands.json 4. Run clang-tidy and apply replacements: cd out/gn && PATH_TO_RUN_CLANG_TIDY/run-clang-tidy.py -p ../../ -clang-tidy-binary PATH_TO_CLANG_TIDY_BINARY -clang-apply-replacements-binary PATH_TO_CLANG_APPLY_REPLACEMENTS_BINARY -checks=-*,hicpp-use-nullptr -fix -j 8 third_party/WebKit BUG=403854 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571 Reviewed-on: https://chromium-review.googlesource.com/720361 Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#510054}
-
Mohamed Amir Yosef authored
When a pushed suggestion is received, ignore it if it exists in one of the following - Currently shown articles. - Dismissed articles (was already implemented before this CL). - Archived articles (i.e. possibly shown on previously opened NTPs). Bug: 774122 Change-Id: I46076e432b1ecd12c47e550a5faea7c0c36d6432 Reviewed-on: https://chromium-review.googlesource.com/713495 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510053}
-
Mihai Sardarescu authored
Gaia started sending the auth code in the same response as the Gaia cookies. The auth code is now send in the following responses: * For the regular sign-in case, the auth code and the cookies are sent in an XHR response. * For sign-up and when JS is disabled, the auth code and the cookies are sent in main frame response. This CL ensures that the DICE header is parsed on all Gaia responses (so far XHR were ignored). This allows Chrome to correctly extract the auth code from XHR responses, adapting the DICE sign-in flow to the new Gaia behavior. Note: This flow is also used for DICE fixing auth errors that is already rolling out in M62. Bug: 775856 Change-Id: I9d19e44f0d5c8d81e5af399649507f6b23af46d3 Reviewed-on: https://chromium-review.googlesource.com/725382Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#510052}
-
Mikel Astiz authored
This reverts commit db2ec9ce. Reason for revert: I reverted the wrong patch, sorry for the mess. It should have been the reland patch, https://chromium-review.googlesource.com/727122 Original change's description: > Revert "Fire focus if needed in automation api" > > This reverts commit 9af30c03. > > Reason for revert: breaks Linux ChromiumOS Tests. > > Bug: 776308 > > Original change's description: > > Fire focus if needed in automation api > > > > Bug: 773866 > > > > Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59 > > Reviewed-on: https://chromium-review.googlesource.com/723606 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#509911} > > TBR=dmazzoni@chromium.org,dtseng@chromium.org > > Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 773866 > Reviewed-on: https://chromium-review.googlesource.com/727982 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510044} TBR=dmazzoni@chromium.org,dtseng@chromium.org,mastiz@chromium.org Change-Id: Iaa74032a25ec60545cf7be951b0dd0c7cf731afb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776308, 773866 Reviewed-on: https://chromium-review.googlesource.com/727901Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#510051}
-
Ramin Halavati authored
Network Traffic Annotation Auditor switches current directory to source before calling 'tools/clang/scripts/run_tool.py' as the script expects to be run from there. Bug: 656607 Bug: 690323 Change-Id: I5eeb872281b6966a341d159260c6037cba73aa99 Reviewed-on: https://chromium-review.googlesource.com/727881Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#510050}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/037f9b80bbd8..c3d1208d5c69 $ git log 037f9b80b..c3d1208d5 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 machenbach Revert "bot_update recipe: Upload source manifest" Created with: roll-dep src/third_party/depot_tools Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: Idfba621d88ef838f1a38ed63a6e8205df3517d00 Reviewed-on: https://chromium-review.googlesource.com/727531Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510049}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2f56bff..17c3128d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iacf8b82efa88231884a4b6736e6fccf90c297f1c Reviewed-on: https://chromium-review.googlesource.com/727941Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510048}
-
henrika authored
Goal is to match recent changes in third_party/webrtc/modules/audio_device/include/audio_device.h where two unused APIs have been removed. This CL ensures that these methods are removed in Chrome as well so I can then delete the signatures totally in third party (WebRTC). Similar changes have been done in https://chromium-review.googlesource.com/c/chromium/src/+/657399 TBR=sergeyu Bug: webrtc:7306 Change-Id: Ie63ca4db09911601b1cc606c9b5bd47b59add612 Reviewed-on: https://chromium-review.googlesource.com/725737 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510047}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7ce549f32ec2..6fb802e2b2e3 $ git log 7ce549f32..6fb802e2b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I0e7dbf4b15f80c107def6082618345dfebfa5eee Reviewed-on: https://chromium-review.googlesource.com/727534Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510046}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a25d87f24cc6..b9501ea73c6c $ git log a25d87f24..b9501ea73 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 benjhayden Add isReferenceBuild diagnostic. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia0496871f7ef7bace5393da7f113abf46adcbcaf Reviewed-on: https://chromium-review.googlesource.com/726754 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510045}
-
Mikel Astiz authored
This reverts commit 9af30c03. Reason for revert: breaks Linux ChromiumOS Tests. Bug: 776308 Original change's description: > Fire focus if needed in automation api > > Bug: 773866 > > Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59 > Reviewed-on: https://chromium-review.googlesource.com/723606 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509911} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773866 Reviewed-on: https://chromium-review.googlesource.com/727982Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#510044}
-
Jochen Eisinger authored
R=dcheng@chromium.org Bug: 772386 Change-Id: Ic352ad8d20838eab6e759f3a53f1d56d7bfb76b7 Reviewed-on: https://chromium-review.googlesource.com/720374Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510043}
-
Daniel Bratell authored
There were three different DependentIOBuffer classes, three similar kBufferSize constants, two similar InitializeResourceBufferConstants functions and two identical GetNumericArg functions. Besides being potentially confusing, it causes clashes in jumbo build experiments (chromium unity build system in development). This patch moves around GetNumericArg (to merge the two copies) and InitializeResourceBufferConstants (to make them not clash). It renames the DependentIOBuffer classes which are deceptively similar as well as the kBufferSize contstants and some other variables that were not actually constants. Bug: 746953 Change-Id: Id7cfa4baac0aa67a7b086896701aeab931e23a96 Reviewed-on: https://chromium-review.googlesource.com/723302Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#510042}
-
Patrik Höglund authored
This reverts commit 885d259d. Reason for revert: Need to test new sound card config on win bots. Original change's description: > Disables WebRtcAudioQualityBrowserTest on Windows > > TBR=phoglund > > Bug: webrtc:677256 > Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d > Reviewed-on: https://chromium-review.googlesource.com/677458 > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > Commit-Queue: Henrik Andreasson <henrika@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503516} TBR=phoglund@chromium.org,henrika@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 677256,737090 Change-Id: Ie41beeec00b3e3fbc7702ba6c7fd8a754c567e18 Reviewed-on: https://chromium-review.googlesource.com/727919Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#510041}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/95c5e3392f3a..7ce549f32ec2 $ git log 95c5e3392..7ce549f32 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 082e70060..6dee4d8c1 (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ie475ccf71d28e6456355d00730515800592662b1 Reviewed-on: https://chromium-review.googlesource.com/727701Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510040}
-
Marc Treib authored
Bug: 631937 Change-Id: I1b0396f0dc757d9f445909ce244a6f72e1983b49 Reviewed-on: https://chromium-review.googlesource.com/700443Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#510039}
-
Takuto Ikuta authored
This CL enables swarming for all builders using GOMA_TESTS in chromium_fyi.py https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py Bug: 776264 Change-Id: I4c31bc7f47788186629d661b34bb16e82e4cfe0b Reviewed-on: https://chromium-review.googlesource.com/727679Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#510038}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43e99bf7..f2f56bff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iab2f48e478c57bf6775b9bc91a6ed893e2f59bbe Reviewed-on: https://chromium-review.googlesource.com/727625Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510037}
-
Tatiana Gornak authored
BUG=739343, 775825 Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0 Reviewed-on: https://chromium-review.googlesource.com/725342Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#510036}
-
Daniel Cheng authored
Historically, the Oilpan macros for Trace() methods were defined using macros, since there were two different types of Visitors. The macros can conditionally include virtual as well: however, this makes it harder to enable the chrome clang plugin checks around usage of virtual, override, and final. While it's possible to adjust the plugin heuristics to account for these macros, the macro definitions are simple enough that they are no longer needed. Replacement was automated using perl regex to expand the macros. Manual fixes were required for: Source/core/dom/NthIndexCache.h Source/core/html/canvas/CanvasRenderingContext.h Source/modules/canvas2d/CanvasRenderingContext2D.h Source/modules/media_controls/elements/MediaControlDivElement.h Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h Source/modules/vr/VRDisplayCapabilities.h Source/modules/vr/VREyeParameters.h Source/modules/vr/VRFrameData.h Source/modules/vr/VRStageParameters.h Bug: 775741 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5901e047eb0f08050a00b8faab7ea731e7447db2 Reviewed-on: https://chromium-review.googlesource.com/726978 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#510035}
-
Marc Treib authored
Bug: 583291 Change-Id: I62f45a36db59b118a5f7a571252c4a4a705355b8 Reviewed-on: https://chromium-review.googlesource.com/725723Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#510034}
-
Benoit Lize authored
These tests should have been re-enabled in 96a257b8, but weren't. Do it for realz. Bug: 570423 Change-Id: I3e2aa6e230af3412b854c2d2cb1a2dba03ced338 Reviewed-on: https://chromium-review.googlesource.com/725816Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510033}
-
Morten Stenshorne authored
I'm leaving Opera Software today. TBR=eae@chromium.org NOTRY=true Change-Id: Id9e11f73d3a3cbc0f2a772f93945cff21e742933 Reviewed-on: https://chromium-review.googlesource.com/727981Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#510032}
-
Nathan Bruer authored
When using network persistence and save a file that is not safe to save with the desired name on the filesystem, devtools will now encode parts that are deemed 'unsafe' to save on filesystem. Example: 'con' and 'nul' are not allowed on windows. '?' also not allowed on windows. R=lushnikov,pfeldman BUG=760316 Change-Id: I29bd227fc3f7f5f10a6b80ed45d21b6a7a6d34a2 Reviewed-on: https://chromium-review.googlesource.com/727195 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#510031}
-
Eric Seckler authored
In e.g. some headless environments, we care about deterministic rendering results. As the new content rendering timeout can affect page rendering, we'd like a way to disable it. This patch adds a command line switch to that effect. Change-Id: Ib0c09aa57df82665ffb4f1290c8ad5d2761aa7bf Bug: 776292 Reviewed-on: https://chromium-review.googlesource.com/725324 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510030}
-