GitLab

The exponent was being checked against numeric_limits<...>::max_exponent
which is the power-of-two limit. Use max_exponent10 instead. Also make
sure to apply any exponent sign prior to the range check so that
min_exponent10 can be used as the lower bound. This means computing the
base number before checking for/parsing the exponent part. This could
be slower in some cases, but reasonably only when an error is
encountered. Also, scientific notation should be fairly scarce to begin
with.

Also move declarations of local variables closer to their first use (and
in the inner-most scope possible.) Unravel the handling of/accumulation
into 'frac' when computing the decimal part.

BUG=675174

Review-Url: https://codereview.chromium.org/2588023002
Cr-Commit-Position: refs/heads/master@{#439522}

see https://skia-review.googlesource.com/c/6206/

BUG=
NOTRY=True

Review-Url: https://codereview.chromium.org/2583023003
Cr-Commit-Position: refs/heads/master@{#439521}

This fixes a couple of bugs:

1. Makes sure the ChromeNetworkDelegate can't call in to a destroyed DomainReliabilityMonitor by moving ownership of the Monitor from ProfileImplIOData to ChromeNetworkDelegate.

2. Makes sure the uploader doesn't leave URL requests around once they're all supposed to be gone by adding a separate "shutdown" step that deletes existing requests and prohibits new ones.

BUG=644858

Review-Url: https://codereview.chromium.org/2336043007
Cr-Commit-Position: refs/heads/master@{#439520}

Review-Url: https://codereview.chromium.org/2587063002
Cr-Commit-Position: refs/heads/master@{#439519}

Review-Url: https://codereview.chromium.org/2564123002
Cr-Commit-Position: refs/heads/master@{#439518}

https://skia.googlesource.com/skia.git/+log/efa9d34ccbde..d1c550e71fa7

$ git log efa9d34cc..d1c550e71 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 fmalita Consolidate TILEX_LOW_BITS/TILEY_LOW_BITS -> EXTRACT_LOW_BITS
2016-12-19 robertphillips "Fix" some ImageFilter fuzzer issues

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2587093002
Cr-Commit-Position: refs/heads/master@{#439517}

This CL adds a module which is intended to produce simple HTML
diffs to view with layout test results.

BUG=672651

Review-Url: https://codereview.chromium.org/2580143002
Cr-Commit-Position: refs/heads/master@{#439516}

Remove //components/proximity_auth/remote_device.h. It was supposed to have been removed in https://codereview.chromium.org/2560713002.

BUG=672263

TBR=tengs@chromium.org

Review-Url: https://codereview.chromium.org/2586983003
Cr-Commit-Position: refs/heads/master@{#439515}

We can't really make the calls use an event in the current situation.
Adding TODO's to explain how it should be done and rename methods for
future usage

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2587083002
Cr-Commit-Position: refs/heads/master@{#439514}

BUG=654071

Review-Url: https://codereview.chromium.org/2580023002
Cr-Commit-Position: refs/heads/master@{#439513}

TBR=kbr@chromium.org
BUG=655335
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2586283002
Cr-Commit-Position: refs/heads/master@{#439512}

Original CL: http://crrev.com/2562643004

Fixes BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline.

TBR=mariakhomenko@chromium.org
BUG=601053,674293

Review-Url: https://codereview.chromium.org/2580523002
Cr-Commit-Position: refs/heads/master@{#439511}

Clear the StyleEngine of css connected fonts on detach().

This used to be saved by an active stylesheet update, it seems. With
the new active stylesheet update this is done more selectively and it
might have been done when document going inactive before. Clearing the
font cache on detach fixes the leak issues in css3/fonts.

TEST=css3/fonts/
BUG=674934

Review-Url: https://codereview.chromium.org/2582413002
Cr-Commit-Position: refs/heads/master@{#439510}

Update list of required files and compile flags.

BUG=None

Review-Url: https://codereview.chromium.org/2588003002
Cr-Commit-Position: refs/heads/master@{#439509}

Plumb custom bounds through DstRangeRelationToSrcRange to remove
duplicate comparisons. Refactor RangeConstraint from an enum to a class
containing bools, which can be independently evaluated at compile-time.

NOTRY=true

Review-Url: https://codereview.chromium.org/2585043002
Cr-Commit-Position: refs/heads/master@{#439508}

Last week, a CL landed that contained a gtest with an empty test name,
e.g.

  TEST(FooTest, )

This broke our gtest-list-tests parsing logic because it saw this:

  FooTest.

    testBar

and incorrectly handled the line containing only spaces. This patch
fixes the handling of that case.

Review-Url: https://codereview.chromium.org/2582263003
Cr-Commit-Position: refs/heads/master@{#439507}

Revert of Enable connection to Mojo services from Blink (patchset #19 id:360001 of https://codereview.chromium.org/2460723003/ )

Reason for revert:
Caused some build failures, looks like missing dependencies?

https://build.chromium.org/p/chromium.gpu/builders/GPU%20Win%20Builder/builds/56562/steps/compile/logs/stdio

FAILED: obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj.rsp /c ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp /Foobj/third_party/WebKit/Source/platform/heap/heap/ThreadState.obj /Fd"obj/third_party/WebKit/Source/platform/heap/heap_cc.pdb"
e:\b\c\b\win\src\third_party\webkit\public\platform\platform.h(59): fatal error C1083: Cannot open include file: 'services/service_manager/public/interfaces/connector.mojom-blink.h': No such file or directory

Original issue's description:
> Enable connection to Mojo services from Blink
>
> This CL enables connections to Mojo services from Blink; more specifically,
> from //third_party/WebKit/Source/modules, where dependencies on Chromium
> code are in general undesired (including on Mojo services' client
> libraries). To enable connecting to services without using the
> Service Manager's client library, this CL does the following:
>
> (1) Adds a method to Platform that exposes the connection to the
> ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
> (2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
> supports connecting to Mojo services by name from Blink.
> (3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
> of connecting to an interface that is hosted in a service other than
> //content/browser from Blink.
>
> ServiceConnector being "bare-bones" includes the facts that:
> - Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
> thread-hostile. This should be easy to relax using similar mechanisms as
> InterfaceProviderImpl.
> - There is currently no API for obtaining an InterfaceProvider for a given
> service (or a thread-safe wrapper, per the above comment). Again, this should
> be easy to add.
>
> This CL also moves the definition of the device service name to mojom instead
> of C++ in order to facilitate using this constant from Blink.
>
> BUG=612341
> TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
>      and then click "recheck" to ensure that the renderer picks up the new
>      time zone. Don't reload the page, which is likely to give you a new
>      renderer process, use the "recheck" link on the page.
>
> Committed: https://crrev.com/8e3745ac05d7918a91ff9efb02280a7c1443de5c
> Cr-Commit-Position: refs/heads/master@{#439498}

TBR=jochen@chromium.org,dcheng@chromium.org,esprehn@chromium.org,haraken@chromium.org,noel@chromium.org,rockot@chromium.org,blundell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612341

Review-Url: https://codereview.chromium.org/2589493006
Cr-Commit-Position: refs/heads/master@{#439506}

With this CL, tasks posted to the base/task_scheduler/post_task.h API
no longer run asynchronously on a dedicated thread. Instead, they are
posted to a MessageLoop on the thread where the ScopedTaskScheduler
lives and run synchronously when RunLoop::Run/RunUntilIdle() is
invoked. This CL also allows usage of the
base/task_scheduler/post_task.h API within the scope of a
TestBrowserThreadBundle.

Benefits of running TaskScheduler tasks synchronously:
- Tests are more deterministic.
- It is easier to wait for a chain of tasks involving TaskScheduler.
  E.g.:
   base::PostTaskAndReplyWithTraits(
       FROM_HERE, TaskTraits(), Bind(&A), Bind(&B));
   base::RunLoop().RunUntilIdle();
       // Without this CL, this returns immediately because there
       // are no pending tasks on the main thread initially. With
       // this CL, this returns when A and B have run.

Note that this CL prevents a TestBrowserThreadBundle or a MessageLoop
from being initialized in the scope of a ScopedTaskScheduler. It
fixes tests that previously did this.

BUG=553459

Review-Url: https://codereview.chromium.org/2557083002
Cr-Commit-Position: refs/heads/master@{#439505}

Deleted a comment in MessageService::OpenChannelImpl that
questioned the use of |guest_process_id| and
|guest_render_frame_routing_id|. These ID appear to be used by some
component extensions (bug 424762) so they cannot be removed.

Review-Url: https://codereview.chromium.org/2529213002
Cr-Commit-Position: refs/heads/master@{#439504}

This is temporarily using ::reset() to guarantee backward compatibility
and reduce chances of breakage for now.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2589873002
Cr-Commit-Position: refs/heads/master@{#439503}

Fixed typo in color_space.typemap

Added color_space.typemap to typemaps.gni

BUG=670364

Review-Url: https://codereview.chromium.org/2585213004
Cr-Commit-Position: refs/heads/master@{#439502}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

R=mef@chromium.org

Review-Url: https://codereview.chromium.org/2587573002
Cr-Commit-Position: refs/heads/master@{#439501}

https://skia.googlesource.com/skia.git/+log/879bdc9b40e6..efa9d34ccbde

$ git log 879bdc9b4..efa9d34cc --date=short --no-merges --format='%ad %ae %s'
2016-12-16 bungeman Explicit ownership of data in SkBlockMemoryStream.
2016-12-19 scroggo Allow running gn_to_bp.py from another script
2016-12-16 scroggo GIF: Avoid copying/storing data when possible
2016-12-19 msarett Move existing writeICC() code into SkICC

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2588803002
Cr-Commit-Position: refs/heads/master@{#439500}

As a precursor step for removing event listener properties
prior to moving a node iterator, this CL attempts to simplify
the code in

EventHandlerRegistry::didMoveBetweenFrameHosts()

by having it re-use the
existing code in EventHandlerRegistry::didMoveIntoFrameHost(). While
this doesn't allow simply skimming the old properties off of the old
frameHost, presumably this is still equivalent and efficient enough
given that such moves presumably happen infrequently compared to things
like drawing frames, etc.

BUG=

Review-Url: https://codereview.chromium.org/2578873004
Cr-Commit-Position: refs/heads/master@{#439499}

This CL enables connections to Mojo services from Blink; more specifically,
from //third_party/WebKit/Source/modules, where dependencies on Chromium
code are in general undesired (including on Mojo services' client
libraries). To enable connecting to services without using the
Service Manager's client library, this CL does the following:

(1) Adds a method to Platform that exposes the connection to the
ServiceManager as a service_manager::mojom::blink::ConnectorPtr.
(2) Builds a bare-bones ServiceConnector around this ConnectorPtr that
supports connecting to Mojo services by name from Blink.
(3) Ports TimeZoneMonitor to be hosted in the Device Service as an example
of connecting to an interface that is hosted in a service other than
//content/browser from Blink.

ServiceConnector being "bare-bones" includes the facts that:
- Unlike blink::InterfaceProvider, blink::ServiceConnector is currently
thread-hostile. This should be easy to relax using similar mechanisms as
InterfaceProviderImpl.
- There is currently no API for obtaining an InterfaceProvider for a given
service (or a thread-safe wrapper, per the above comment). Again, this should
be easy to add.

This CL also moves the definition of the device service name to mojom instead
of C++ in order to facilitate using this constant from Blink.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Review-Url: https://codereview.chromium.org/2460723003
Cr-Commit-Position: refs/heads/master@{#439498}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f394e56d2888..2c95066149e8

$ git log f394e56d2..2c9506614 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 jbudorick [py_utils] Add empty and optional context managers.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2587053002
Cr-Commit-Position: refs/heads/master@{#439497}

Adds api to Coordinator. Does not yet add Java bridge api support.
Also, cleans up some terminology wrt immediate*callback when not
necessarily immediate mode only.

BUG=672584

Review-Url: https://codereview.chromium.org/2570433007
Cr-Commit-Position: refs/heads/master@{#439496}

When Kiosk app is just installed from Play, "OnAppRegistered()" is called, but
ArcKioskAppService didn't know about Kiosk app id.
Now it retrieves app id if not know yet.

BUG=674776

Review-Url: https://codereview.chromium.org/2584813002
Cr-Commit-Position: refs/heads/master@{#439495}

Before this we only had tests for filling predictor database. This CL
adds test that prefills database and then activates prefetching on the
same web page. Then it checks that cache actually has been populated by
prefetched resources.

BUG=650253

Review-Url: https://codereview.chromium.org/2553083002
Cr-Commit-Position: refs/heads/master@{#439494}

Revert of Upstream Chrome on iOS source code [11/11]. (patchset #1 id:1 of https://codereview.chromium.org/2589843002/ )

Reason for revert:
Fail compilation on the waterfall.

Original issue's description:
> Upstream Chrome on iOS source code [11/11].
>
> Upstream all BUILD.gn changes to enable compilation of the code
> that has been upstreamed by the previous ten CLs and changes to
> browser_state_keyed_service_factories.mm to use the new factory.
>
> Update the default provider factory to use chromium provider (it
> will be merged with ChromeBrowserProvider eventually).
>
> BUG=653086
> R=pinkerton@chromium.org, rohitrao@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277eaf132dce4831

TBR=rohitrao@chromium.org,pinkerton@chromium.org,agrieve@chromium.org,markusheintz@chromium.org,blundell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653086

Review-Url: https://codereview.chromium.org/2589883002
Cr-Commit-Position: refs/heads/master@{#439493}

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2589843002 .
Cr-Commit-Position: refs/heads/master@{#439492}

https://skia.googlesource.com/skia.git/+log/746cc0b92290..879bdc9b40e6

$ git log 746cc0b92..879bdc9b4 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 egdaniel Temorarily remove Vulkan NexusPlayer bots till we can fix them
2016-12-19 borenet Roll Recipe DEPS

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2583203002
Cr-Commit-Position: refs/heads/master@{#439491}

Using update-w3c-deps in Chromium 82befc59.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7834

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2588723002
Cr-Commit-Position: refs/heads/master@{#439490}

Unties Node construction with the initialisation of their parent and
children. This allows controlling when the notifications about child
modifications are propagated, and simplifies the initialisation order.

The InnerNode#setParent() call is now what enables the notifications
and is done as the last step of the NewTabPageAdapter constructor.

ChildNode and InnerNode share almost all of the logic related to
managing the tree and their implementations make use of that without
specific modifications.

This also fixes some bugs related to resetting the section list.

BUG=616090,674023

Review-Url: https://codereview.chromium.org/2573173002
Cr-Commit-Position: refs/heads/master@{#439489}

Previously, MediaSessionImpl uses the metadata and controls to determine
whether a page uses the MediaSession API. However there comes an issues
that we need to update the routed MediaSession every time when a service
is created/destroyed or its metadata/controls changed, which is a lot of
maintainance work.

This CL simplifies the MediaSessionService routing strategy. It only
checks whether a service is created for a given frame. The rationale is
that a MediaSessionService is created when and only when anything passes
through mojo, which is enough for indicating whether a frame uses
MediaSession API.

BUG=670319

Review-Url: https://codereview.chromium.org/2585243002
Cr-Commit-Position: refs/heads/master@{#439488}

Revert of [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (patchset #6 id:140001 of https://codereview.chromium.org/2551223003/ )

Reason for revert:
Seems like a likely cause for failures on:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Faccelerometer.html&testType=webkit_tests

Original issue's description:
> [Sensors] Align sensor reading updates and 'onchange' notification with rAF.
>
> For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.
>
> Before this change a timers were used and this could unnecessarily drain CPU and battery.
>
> BUG=668052
> BUG=606766
>
> Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
> Cr-Commit-Position: refs/heads/master@{#439467}

TBR=reillyg@chromium.org,alexander.shalamov@intel.com,haraken@chromium.org,foolip@chromium.org,mikhail.pozdnyakov@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668052

Review-Url: https://codereview.chromium.org/2590513002
Cr-Commit-Position: refs/heads/master@{#439487}

PaymentRequest.canMakePayment() should return true if user has a payment
app with an instrument or a credit card with valid name and number.

BUG=674926

Review-Url: https://codereview.chromium.org/2558993003
Cr-Commit-Position: refs/heads/master@{#439486}

R.java and R.txt files for an AAR were generated by extracting all
resources from the AAR and its dependencies and running aapt on these
resources. This approach turned out to be problematic for AARs of
GMS (Play Services).

GMS is shipped as a bunch of AARs with dependencies between them.
However the way it deals with resources is rather unusual. GMS code
references all resources via com.google.android.gms.R class that
corresponds to the "basement" AAR. This AAR has R.txt with entries for
all resources of the GMS but contains only a small subset of the
resources. All other resources are provided by other AARs: they have
different packages and no R.txt files though.

The consumer of the GMS must generate com.google.android.gms.R class
with entries for all resources provided by used GMS AARs. Entries for
resources that belong to the unused AARs may be ommited. This is what
Gradle plugin for Android does.

However AAR support in Chromium discarded R.txt from "basement" then
generated very small com.google.android.gms.R without essential entries
and this caused crashes in runtime.

This CL changes processing of the AARs resources. If R.txt is present in
AAR then aapt-generated R.txt is discared. The one from AAR is used to
generate R.java for java dependencies of the AAR target and to generate
final R.java file during APK build which is compiled and included into
the final APK.

During obfuscation Proguard checks that all entries that are referenced
in code were in fact generated. This check cannot be done during resource
processing because "basement"'s R.txt lists resources that aren't
included in Chromium and this is because code that uses these resources
isn't included either.

BUG=670368
R=agrieve@chromium.org,dgn@chromium.org

Review-Url: https://codereview.chromium.org/2570313002
Cr-Commit-Position: refs/heads/master@{#439485}

Partition Alloc, which has been recently moved to base/, has tests
that rely on the ability to successfully make large (512 MB)
allocations. Turns out this is not possible on small devices like
ChromeCast, that seem to either have little overcommit margins or
a heavily fragmented address space.

This CL skips those tests on devices that have < 2 GiB of physical
memory. For the same reason, it lowers down the chunk size of the
RepeatedReturnNullDirect test. The rationale of the test is to check
that repeated failures are handled consistently when performing
directly mapped allocations. The chunk size is irrelevant as long as
it is big enough to hit the directly-mmap codepaths (current
threshold = 1 MB).

BUG=675255

Review-Url: https://codereview.chromium.org/2589813002
Cr-Commit-Position: refs/heads/master@{#439484}

The media controls are (at least sometimes) painted twice. The second
time after figuring out how many buttons fit into the available width.
At least one of the fullscreen tests were flaky because the first paint
was dumped instead of the second one. Adding a layoutAndPaintAsyncThen
in the full-screen-test.js framework seems to fix the issue.

Although the issue was filed after landing changes for issue 567021,
the flakiness is also seen locally without those changes running the
test with --repeat-each=30 in debug.

R=fs@opera.com
TEST=virtual/android/fullscreen/full-screen-stacking-context.html
BUG=675055

Review-Url: https://codereview.chromium.org/2586243002
Cr-Commit-Position: refs/heads/master@{#439483}