Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 Apr, 2013 2 commits
    • scottmg@chromium.org's avatar
      Revert 194184 "push MouseMove through WebContents and back to de..." · 57fb61f9
      scottmg@chromium.org authored 
      Broke mouse dodge on Mac, and perhaps isn't correct for Win Aura anyhow.

BUG=233299

> push MouseMove through WebContents and back to delegate to fix status bubble avoid
> 
> This fixes the status bubble not "dodging" the mouse on Aura.
> 
> On non-Aura, the path to get to StatusBubbleViews::MouseMoved is:
> - RenderWidgetHostViewWin::OnMouseEvent
> - SendMessage to the parent window
> - WebContentsViewWin::OnMouseMove
> - Browser::ContentsMouseEvent
> - StatusBubbleViews::MouseMoved
> 
> On Aura, the path is:
> - HWNDMessageHandler
> - DesktkopRootWindowHostWin::HandleMouseEvent
> - RootWindow::OnHostMoustEvent
> - EventDispatcher, etc.
> - content::RenderWidgetHostViewAura::OnMouseEvent
> - RenderViewHostImpl::ForwardMouseEvent
> - WebContentsImpl::HandleMouseMove  // ***
> - Browser::ContentsMoveEvent
> - StatusBubbleViews::MouseMoved.
> 
> This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***.
> 
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/14234020

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195027 0039d316-1c4b-4281-b951-d872f2087c98
      57fb61f9
    • thakis@chromium.org's avatar
      Fix a warning in 64bit c++11 mode. · 418c4abf
      thakis@chromium.org authored 
      The (harmless) warning was:

../../webkit/plugins/ppapi/message_channel.cc:286:69: error: comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (std::numeric_limits<size_t>::max() / sizeof(NPIdentifier) <=
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

It's always false in 64bit mode, but it's arguably useful in 32bit mode.

BUG=233330

Review URL: https://codereview.chromium.org/14246019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195026 0039d316-1c4b-4281-b951-d872f2087c98
      418c4abf
  3. 18 Apr, 2013 38 commits