GitLab

BUG=406439
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/802823002

Cr-Commit-Position: refs/heads/master@{#308234}

The code currently excludes paste-and-go operations.  It should probably
also exclude paste+enter operations; these are effectively equivalent.

TODO before submitting: test interactively

BUG=
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/795343002

Cr-Commit-Position: refs/heads/master@{#308233}

We previously were not properly expanding the free list when
dup2 results in growing the descriptor range.

Added of test of this.

BUG=None
TEST=Dup2Allocate
R=binji@chromium.org

Review URL: https://codereview.chromium.org/795213003

Cr-Commit-Position: refs/heads/master@{#308232}

Fullscreen exit bubble is actually used to control both mouse lock and fullscreen. Addition of keyboard lock would make it the third behavior requiring some clean-up. This is part 1 of the refactor and contains just renames.

Also the difference from the original CL is that I have reverted rename of fullscreen_controller in lieu of doing it when I actually move the functionality and using exclusive_access_* instead of lock_exit.

BUG=166928

Review URL: https://codereview.chromium.org/789403002

Cr-Commit-Position: refs/heads/master@{#308231}

BUG=441955

Review URL: https://codereview.chromium.org/805553002

Cr-Commit-Position: refs/heads/master@{#308230}

APIPermission::kUnlimitedStorage is used in the storage implementation in
//extensions so the permission should live there.

This allows app_shell to load apps with unlimitedStorage in the manifest.

BUG=none
TEST=existing browser_tests

Review URL: https://codereview.chromium.org/805563002

Cr-Commit-Position: refs/heads/master@{#308229}

Original review: https://codereview.chromium.org/801493002/

BUG=429746
TESTS=display_unittests with ASAN
TBR=derat@chromium.org

Review URL: https://codereview.chromium.org/800143002

Cr-Commit-Position: refs/heads/master@{#308228}

They've been supplanted by ffmpeg_regression_tests. They also crash
when you run them.

TBR=glider

Review URL: https://codereview.chromium.org/801993002

Cr-Commit-Position: refs/heads/master@{#308227}

Stop using HTTP/2 in case TLS 1.2 is not supported, connection has been
downgraded to below TLS 1.2, or AES-GCM cipher required by HTTP/2 draft
specification is not supported.

BUG=436835

Review URL: https://codereview.chromium.org/757033004

Cr-Commit-Position: refs/heads/master@{#308226}

BUG=285151
R=guohui@chromium.org

Review URL: https://codereview.chromium.org/797303002

Cr-Commit-Position: refs/heads/master@{#308225}

BUG=428919

Review URL: https://codereview.chromium.org/804443002

Cr-Commit-Position: refs/heads/master@{#308224}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/095dcae..1fdbfa4

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/788073005

Cr-Commit-Position: refs/heads/master@{#308223}

This is temporary instrumentation to try and narrow down the area
and mode where Chrome is (likely) hanging on logoff/restart.

TBR=mpearson@chromium.org,erikwright@chromium.org

BUG=412384

Review URL: https://codereview.chromium.org/796963002

Cr-Commit-Position: refs/heads/master@{#308222}

When tasks are posted to a message loop, we may need to schedule the
message loop to wake up if it was sleeping so it processes the message.
The incoming task queue checks whether the incoming queue was already
empty as a way to avoid scheduling unnecessarily, but we can be more
precise. Once a message loop is scheduled, we know that it will sooner
or later wake up and enter its run loop. In its run loop it will
repeatedly drain the work queue and attempt to reload from the incoming
queue until there is no work immediately available to do. This means that
before waiting for more work the loop will always reload from an empty
incoming queue. Thus, once we schedule a loop we do not need to schedule
the same loop again until after an empty reload occurs.

This adds a bool to IncomingTaskQueue protected by the incoming task
queue lock that keeps track of if the loop has been scheduled since the
last empty reload.

Local testing on Linux desktop and a ChromeShell Android build shows
that this avoids roughly 40% of the ScheduleWork calls when browsing
around to random websites.

This also has the very nice consequence that when running a task and
posting another task to the same thread we *never* need to invoke
ScheduleWork which avoids the cost of the ScheduleWork call and avoids
a spurious wakeup when going to sleep.

BUG=412137

Review URL: https://codereview.chromium.org/614723003

Cr-Commit-Position: refs/heads/master@{#308221}

and -> &

BUG=441480

Review URL: https://codereview.chromium.org/799123002

Cr-Commit-Position: refs/heads/master@{#308220}

Fixes a null pointer dereference in RenderFrameProxyHost::RenderFrameProxyHost,
when a RenderFrameProxyHost is created as a side effect of destroying the
FrameTreeNode and RenderFrameHostManager. The crash occurs because of the
operation below:

  if (!frame_tree_node_->IsMainFrame() &&
      frame_tree_node_->parent()
              ->render_manager()
              ->current_frame_host()
              ->GetSiteInstance() == site_instance) {

When a FrameTreeNode is being detached from the tree, it is not the main
frame (because it is not equal to the root), but it also does not have a
parent (because, for reasons explained in FrameTreeNode::RemoveChild, it
is trimmed from the tree before destruction). So the parent() call above
returns NULL, resulting in great misfortune.

Add a test that failed without the fix.

BUG=441357

Review URL: https://codereview.chromium.org/799593004

Cr-Commit-Position: refs/heads/master@{#308219}

While in a nested loop, Chrome is not blocked, keeps updating the client area and is responding to user actions.
Subtracting the time in nested loops from the task in which it happens, so that we don't diagnose this task as a source of jank.

BUG=401560, 440919

Review URL: https://codereview.chromium.org/788883004

Cr-Commit-Position: refs/heads/master@{#308218}

The file descriptors aren't needed anymore once the file is mapped, and we want to avoid running out.

BUG=364272,362048,434890,425766,412136,376441,436677

Review URL: https://codereview.chromium.org/799133003

Cr-Commit-Position: refs/heads/master@{#308217}

Doing so forces the library to load and triggers our FMA3-disabling
code.

BUG=440892

Review URL: https://codereview.chromium.org/797313003

Cr-Commit-Position: refs/heads/master@{#308216}

BUG=

Review URL: https://codereview.chromium.org/802803002

Cr-Commit-Position: refs/heads/master@{#308215}

This is a possible fix for crashes observed in this function. The member
variable browser_context_ is possibly invalid because the object may
be freed by function->Run(). To avoid this we move the call to
ProcessManager::Get() to before where function->Run() is called.

BUG=441679

Review URL: https://codereview.chromium.org/798103002

Cr-Commit-Position: refs/heads/master@{#308214}

BUG=439572

Review URL: https://codereview.chromium.org/785763002

Cr-Commit-Position: refs/heads/master@{#308213}

R=thestig@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/801983002

Cr-Commit-Position: refs/heads/master@{#308212}

Some cleanup:

* Replaced iterator with range based for loop.
* Renamed a few parameters/local variables to improve clarity:
  * ChromiumEnv::RestoreIfNecessary "result" param -> "dir_entries".
  * "dir_filepath" -> "dir_path"
  * ChromiumEnv::GetChildren "dir_string" -> "dir"
* Accepted some "git cl format" improvements.

Review URL: https://codereview.chromium.org/790913003

Cr-Commit-Position: refs/heads/master@{#308211}

This change fixes the USB device handle tests on OS X by claiming the
necessary interfaces before using them and using the right endpoint
numbers. It also enables the HID connection tests on OS X by creating
a MessageLoopForUI on the main thread (to mimic the usual configuration
in the Chrome browser process) and a separate thread running a
MessageLoopForIO.

Review URL: https://codereview.chromium.org/804643002

Cr-Commit-Position: refs/heads/master@{#308210}

In favor of less things to have in chrome/browser/chromeos.

BUG=437719
TEST=everything builds as before

Review URL: https://codereview.chromium.org/799683003

Cr-Commit-Position: refs/heads/master@{#308209}

BUG=426292

Review URL: https://codereview.chromium.org/803693002

Cr-Commit-Position: refs/heads/master@{#308208}

BUG=420316

Review URL: https://codereview.chromium.org/792193003

Cr-Commit-Position: refs/heads/master@{#308207}

BUG=417532

Review URL: https://codereview.chromium.org/785353003

Cr-Commit-Position: refs/heads/master@{#308206}

BUG=417532
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/793463002

Cr-Commit-Position: refs/heads/master@{#308205}

This adds a use_xkbcommon variable that allows usage of libxkbcommon in
the build. Turn this on for linux ozone builds (except embedded builds).

BUG=430194
TEST=build

Review URL: https://codereview.chromium.org/751623003

Cr-Commit-Position: refs/heads/master@{#308204}

BUG=417532

Review URL: https://codereview.chromium.org/785363002

Cr-Commit-Position: refs/heads/master@{#308203}

$ git log dbff01c15..b10edf25e --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-12-11 maruel Remove FileSystem; it's not used anymore even by tests.
2014-12-11 maruel Overhaul tests to stop using FileSystem in isolateserver.py.
2014-12-10 maruel Fix regression in 012067b422; exception bc 2 report_on_exception_exit() calls
2014-12-10 maruel Add coherent automatic https:// prefix to server flags.
2014-12-10 maruel Remove last remnant of support for --indir.
2014-12-09 maruel Get rid of tests/run_isolated/ and create a in-process isolate server mock.
2014-12-08 maruel Remove --isolated from run_isolated.py.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/794903006

Cr-Commit-Position: refs/heads/master@{#308202}

BUG=441757
TBR=jeremyim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/804573004

Cr-Commit-Position: refs/heads/master@{#308201}

BUG=441481

Review URL: https://codereview.chromium.org/801533002

Cr-Commit-Position: refs/heads/master@{#308200}

Allows the extension to display an infobar to collect explicit user consent
before registering a key.

BUG=426358

Review URL: https://codereview.chromium.org/766303003

Cr-Commit-Position: refs/heads/master@{#308199}

BUG=

Review URL: https://codereview.chromium.org/797753003

Cr-Commit-Position: refs/heads/master@{#308198}

Dependent on https://codereview.chromium.org/787393003/

BUG=

Review URL: https://codereview.chromium.org/796503004

Cr-Commit-Position: refs/heads/master@{#308197}

R=benjhayden@chromium.org
BUG=440741

Review URL: https://codereview.chromium.org/795353002

Cr-Commit-Position: refs/heads/master@{#308196}

Revert of Update DisplayConfigurator to use the asynchronous tasks (patchset #4 id:60001 of https://codereview.chromium.org/801493002/)

Reason for revert:
seems to be causing problems in display_unittests on the following bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/5095

Original issue's description:
> Update DisplayConfigurator to use the asynchronous tasks
>
> Now DisplayConfigurator can take advantage of asynchronous configuration APIs.
> Note: For X11, NativeDisplayDelegate is still implemented via synchronous calls
> so all configurations will be synchronous on X11.
>
> Notable changes:
>  1) EnterState(), UpdateCachedDisplays() and FindMirrorMode() have been moved
> into the DisplayLayoutManager implementation.
>  2) NativeDisplayDelegate's initialization has been moved before grabbing the
> server. Shouldn't cause any issues since the server doesn't need to be grabbed
> when initializing NDD.
>
> BUG=429746
> TEST=display_unittests and manually on Link with X11
>
> Committed: https://crrev.com/7547705543d6b711a166e513a43a4e43f93fd254
> Cr-Commit-Position: refs/heads/master@{#308175}

TBR=derat@chromium.org,dnicoara@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=429746

Review URL: https://codereview.chromium.org/797383002

Cr-Commit-Position: refs/heads/master@{#308195}