GitLab

https://skia.googlesource.com/skia.git/+log/7b7ab595d908..b45d5124816e


git log 7b7ab595d908..b45d5124816e --date=short --no-merges --format='%ad %ae %s'
2018-12-06 halcanary@google.com bin/sysopen: script moved to bin
2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8f1b7a66a5e3..d300548fcc28 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@b45d5124816e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I3d2ffa675f1a4bc1a9509ab85ecb6c7b974dc5f9
Reviewed-on: https://chromium-review.googlesource.com/c/1365423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614363}

 - remove list_thumbnail_loader_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - add @types to the unittest vars
 - inline the canvas dataURL image creation step in Setup()
 - fix all Closure compiler errors

No change in test behavior, no new tests.

Bug: 912557
Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377
Reviewed-on: https://chromium-review.googlesource.com/c/1364999
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614362}

This test requires MP4 support in content_shell; that's not enabled by
default and breaks WPT imports.

TBR=chcunningham@chromium.org, wolenetz@chromium.org

No-Try: true
Change-Id: I3f176312cec46c8ef03dad5d40106c721b0f9723
Reviewed-on: https://chromium-review.googlesource.com/c/1365613Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#614361}

This CL makes PerformanceEventTiming IDL consistent with the spec, after
https://github.com/WICG/event-timing/pull/16. Note that EventCount is
not yet implemented.

Bug: 823744
Change-Id: I01779ed82cba0cfea0542ab74cc95b4e7adc8aac
Reviewed-on: https://chromium-review.googlesource.com/c/1363961Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614360}

Bug: 851596
Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547
Reviewed-on: https://chromium-review.googlesource.com/c/1364976
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614359}

This fixes the GCC build after commit b6ef3ba2 ("Pass GpuPreferences to
in-process GPU in Mash"):

    In file included from ../../content/utility/utility_service_factory.h:12,
                     from ../../content/utility/utility_service_factory.cc:5:
    ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’:
    ../../base/memory/scoped_refptr.h:208:14:   required from ‘scoped_refptr<T>::~scoped_refptr() [with T = gl::GLSurface]’
    ../../gpu/ipc/service/gpu_init.h:70:48:   required from here
    ../../base/memory/scoped_refptr.h:284:8: error: invalid use of incomplete type ‘class gl::GLSurface’
       ptr->Release();
       ~~~~~^~~~~~~
    In file included from ../../services/viz/service.h:8,
                     from ../../content/utility/utility_service_factory.cc:35:
    ../../gpu/ipc/service/gpu_init.h:22:7: note: forward declaration of ‘class gl::GLSurface’
     class GLSurface;
           ^~~~~~~~~

gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC
seems to require a full declaration for things to work.

Bug: 819294
Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd
Reviewed-on: https://chromium-review.googlesource.com/c/1365249Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#614358}

Otherwise dangling pointers are leave - this can affect other
tests. For example, if some test uses content::TestBrowserThreadBundle
and runs after AndroidWebViewStateSerializerTest, this test will fail.

Change-Id: Ic39f5e10a68a232ca2b3d58dcd21dc61bab29e43
Reviewed-on: https://chromium-review.googlesource.com/c/1354445
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614357}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/03afee3b9081..2e4563d94f9d


git log 03afee3b9081..2e4563d94f9d --date=short --no-merges --format='%ad %ae %s'
2018-12-06 stevenperron@google.com Document in the context what happens with id overflow. (#2159)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2e4563d94f9d

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3d9b965d9a72ca7f3180c5a14e4ed28a7ce905db
Reviewed-on: https://chromium-review.googlesource.com/c/1365422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614356}

https://android.googlesource.com/platform/external/perfetto.git/+log/659c1b009ec3..f6a1cb2d8968


git log 659c1b009ec3..f6a1cb2d8968 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 lalitm@google.com Merge "trace_processor: speed up args table even more"


Created with:
  gclient setdep -r src/third_party/perfetto@f6a1cb2d8968

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iefd01cf34bed9c2c688570386aa10a75fdaa45f4
Reviewed-on: https://chromium-review.googlesource.com/c/1365421Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614355}

BUG=498579

Change-Id: I0ef207bbcf210de686902b2248f4e0c96453b707
Reviewed-on: https://chromium-review.googlesource.com/c/1365236
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614354}

In current implementation of find_in_page.js, when user navigates to a
match result out of the screen, the orange highlight will be added to it
with a 250ms delay. In previous version, the callback invoked after
250ms will always add orange highlight to the current selected match
result, and the CL(http://crrev/c/1347363) accidently changed the logic
and created a bug. If user clicks "goNext" fast enough, selected match
result may get highlighted permanently.

However, after deeper investigation, the delayed highlight seems to be
buggy from the begining. Navigating backward to a match result that is
inside the screen will also meets the condition and trigger the delay,
but the 250ms is just too short to be noticed.
Besides, why we need the delay is also mysterious, and here is my guess:
In ancient time the find_in_page.js do two things, first scroll to the
match result and then do the highlight, and somehow UIWebView requires
us to add a delay(see the comments in old version code). Then the
scrolling work moved from Js into OC, so there are two lines about
scrolling that are commented out.

Since UX has also confirmed that delay on highlight is not necessary, it
should be removed now.

Bug: 911611
Change-Id: If0fef219b33954e243e527f3b50dbe836f753ede
Reviewed-on: https://chromium-review.googlesource.com/c/1365610Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614353}

Bug: 908479
Change-Id: I6b6d50319143a5b4135c446d7723d6a70fc3fecc
Reviewed-on: https://chromium-review.googlesource.com/c/1364610Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614352}

This test currently relies upon the exact ordering of RenderFrame,
InjectFrame and CheckForFrameChanges, which is a mix of delayed and
immediate tasks. The scheduler doesn't guarantee the exact ordering
of these which causes this test to flake.  We add some extra
RunLoop().RunUntilIdle() calls to ensure CheckForFrameChanges has
a chance to run.

TBR=miu@chromium.org

Bug: 863341, 891670
Change-Id: I526d6b77f6ce46f04d84584f5daba096ef1a98e5
Reviewed-on: https://chromium-review.googlesource.com/c/1365248Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614351}

BUG=None

Change-Id: Ie6bcdd0b88fd32f8416871f58381cd88f2b6e234
Reviewed-on: https://chromium-review.googlesource.com/c/1364650
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614350}

This is to simplify DEPS and enforce to use the same revision for each luci-go
client.

Change-Id: Ibb642840e09fe83f8736dbf86ab73f00154b0843
Reviewed-on: https://chromium-review.googlesource.com/c/1364998Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614349}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d138913917ce..71928dd258ca


git log d138913917ce..71928dd258ca --date=short --no-merges --format='%ad %ae %s'
2018-12-06 dhanyaganesh@chromium.org lib/cidb.py: Delete functions used in bad_cl_detector


Created with:
  gclient setdep -r src/third_party/chromite@71928dd258ca

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ice83d4eef69c02fcd84486fabe2d28c58eed7cd7
Reviewed-on: https://chromium-review.googlesource.com/c/1365419Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614348}

Bug: 911415
Change-Id: Ifab02f8eccba1f2501400150d9aa563e88f44ac8
Reviewed-on: https://chromium-review.googlesource.com/c/1365105
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614347}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8807e6de3a17..44685896babc


Created with:
  gclient setdep -r src-internal@44685896babc

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If1245f560fc46b4b68ad7243540bdeaaf2b309ad
Reviewed-on: https://chromium-review.googlesource.com/c/1365420Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614346}

BUG=762641
TBR=stevenjb@chromium.org

Change-Id: I2d05b9f382d1b86bf0aebf1b8418417f062d759e
Reviewed-on: https://chromium-review.googlesource.com/c/1365550
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614345}

Besides checking hosts and paths against intent extras, this CL
specifically checks for HTTPS scheme on module-managed URLs.
CustomTabActivityTest is also updated to use HTTPS test server
for all tests that are dynamic module related.

This is guarded by the CCTModuleCustomHeader Finch feature.

Bug: 882404
Change-Id: I24d3e5b16762818ba330ad8f9c0f030eaf9d82e9
Reviewed-on: https://chromium-review.googlesource.com/c/1361065
Commit-Queue: John Lin <chuanl@google.com>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614344}

https://webrtc.googlesource.com/src.git/+log/fafae11bfc4c..628f37a6fe24


git log fafae11bfc4c..628f37a6fe24 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 hta@webrtc.org Delete a cricket::DtlsTransport when PC is closed


Created with:
  gclient setdep -r src/third_party/webrtc@628f37a6fe24

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:907849
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie1e59d6a33a293fd29401a6f788a14412896c3cb
Reviewed-on: https://chromium-review.googlesource.com/c/1365418Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614343}

Add the option to get a MockClock that is in sync with the underlying
MockTickClock that ScopedTaskEnvironment uses. Some test need access to
a base::Clock and ScopedTaskEnvironment currently just provides a
MockTickClock.

Need for this araised while refactoring
components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler_unittest.cc
to use ScopedTaskEnvironment instead of MessageLoop.

Bug: 891670
Change-Id: I0716dbe2b46e268dfe57bed7c667d275f62519af
Reviewed-on: https://chromium-review.googlesource.com/c/1356553
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614342}

Previously, spatial navigation could not navigate inside a focused
container. This change makes spatnav first search (or scroll) a
focused scroll container, before searching outside of it:

(1) Search for focusable elements inside any focused container.
(2) If step (1) couldn't find a candidate, try to scroll the container.
(3) If step (2) couldn't scroll, search for focusable elements outside
    the container.

This follows the design document: https://bit.ly/snav2.

Bug: 821297
Change-Id: I81ab360dac5ee865e34c0f840378c9a637a8fe89
Reviewed-on: https://chromium-review.googlesource.com/c/960185
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#614341}

1. Switch to <atomic>, which is the future of atomics in Blink.

2. Since this logic is subtle, it is factored out into a separate class
   with a verbose comment, explaining why its semantics are correct.

3. Since the load didn't previously synchronize with the store, and the
   only requirement a thread has is that it sees its own writes (and the
   data doesn't become corrupt), std::memory_order_relaxed is used for
   all accesses.

Bug: 736037
Change-Id: I017da1ebfba3e95e5d0393014dc57fb4958bd6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1364151Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614340}

Use FetchCountext::CountUsage instead.

Bug: 123004
Change-Id: I0809339a59bb6b3e29bf364923502af5c83a5f07
Reviewed-on: https://chromium-review.googlesource.com/c/1364997Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614339}

This CL adds the new representation for tab data next to the existing
one. This ensures that the old UI still works and the new UI is
completely guarded by #autofill-keyboard-accessory-view.

The actual drawing of the elements follows in crrev.com/c/1356547.

Bug: 853772, 911084
Change-Id: Ia38706aefb687fbe704b62307fa7d793a9b45c36
Reviewed-on: https://chromium-review.googlesource.com/c/1350875
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614338}

Supposed to improve goma cache hit rate. I found gdb debugging still
works with it enabled.

Bug: 439949
Change-Id: Ia78ae57e5eb84fa8fb8bbb3c6bb15ea7814932bd
Reviewed-on: https://chromium-review.googlesource.com/c/1364692
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614337}

https://skia.googlesource.com/skia.git/+log/7c4a9b7c7e0e..7b7ab595d908


git log 7c4a9b7c7e0e..7b7ab595d908 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 reed@google.com SkRunFont is gone, there is only SkFont


Created with:
  gclient setdep -r src/third_party/skia@7b7ab595d908

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: Id40b7d9fe6a9513d6352c50b6624fa0e436fa3b5
Reviewed-on: https://chromium-review.googlesource.com/c/1365417Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614336}

This test relies on the ordering of delayed and non-delayed tasks
which is a mistake. Changeing it to quit after all tasks have
run makes it reliable.

TBR=asvitkine@chromium.org

Bug: 863341, 891670
Change-Id: Id8dcbda9359a3adcf9688973457edf146d1d070f
Reviewed-on: https://chromium-review.googlesource.com/c/1365447
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614335}

- Override validationMessage() and ValidationSubMessage() to return
  correct strings

- ValidationMessaeClientImpl doesn't reject display:inline anchor
  elements.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: Ie743d6018bb38f30db0b8624a6313519dd5737f4
Reviewed-on: https://chromium-review.googlesource.com/c/1365108
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614334}

https://android.googlesource.com/platform/external/perfetto.git/+log/c30ed73dd52a..659c1b009ec3


git log c30ed73dd52a..659c1b009ec3 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 fmayer@google.com Merge "Bump libunwindstack version."


Created with:
  gclient setdep -r src/third_party/perfetto@659c1b009ec3

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I630fd97193f894a0e0cbe60330730e616ab39f65
Reviewed-on: https://chromium-review.googlesource.com/c/1365415Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614333}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb2f2ad6ffdf..8807e6de3a17


Created with:
  gclient setdep -r src-internal@8807e6de3a17

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia5bde08c98963dcef9b75753e08be31595dac2af
Reviewed-on: https://chromium-review.googlesource.com/c/1365416Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614332}

Several test suites relied on the common resources .pak being unsuccessfully
loaded in order to function correctly. On Android, .pak files can leak between
successive runs of different test suites, which would cause flaky test failures.
This CL makes it so that failing to load the common resources .pak file will hit
a DCHECK. This CL fixes several instances where test suites were incorrectly
trying to load [and failing to load] the common resources .pak file.

Change-Id: I5294f921e42524b699c7019b7a56c0a30106c89c
Bug: 906587
Reviewed-on: https://chromium-review.googlesource.com/c/1363447Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614331}

The MessageLoop version of IsIdleForTesting does not take Now() into
account, but the SequenceManager version was.  This is a mistake
because its flaky when there are delayed tasks that are just about
to run.

TBR=fdoray@chromium.org

Bug: 910645, 863341, 891670
Change-Id: Ieaf5e534df0f553046b76fa844f61e4a268082f9
Reviewed-on: https://chromium-review.googlesource.com/c/1365233Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614330}

Previously the TaskQueueSelector would allow up to 3 delayed tasks to
run for every immediate task if both where ready to run.  This patch
changes it to a 1:1 ratio like the MessageLoop.  NB neither the
SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
of immediate tasks.

In addition I've removed the PrioritizingSelector inner class which makes
the code a bit more readable.  In addition based on review comments I
changed the style of functions to return a pointer to the WorkQueue or
null rather than a bool. This in general improves readability.

Bug: 863341, 891670
Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
Reviewed-on: https://chromium-review.googlesource.com/c/1361103
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614329}

TBR=

Bug: skia:2664
Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f
Reviewed-on: https://chromium-review.googlesource.com/c/1363212
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614328}

This CL migrates (most of) account_reconcilor_unittest.cc code
away from SigninManager and PO2TS.
Production code was migrated and unit tests were minimally updated
to keep running in [1].

Remarks:
- The CL can completely remove SigninManager direct API calls.
- The CL could not completely remove direct PO2TS API calls, due to two
missing API: set_all_credentials_loaded_for_testing and LoadCredentials.
- Given how the test uses gaia_id to manipulate reconciles and how
IdentityTestEnvironment hides setting the gaia_id from the tests,
there were some adaptations needed so that the functionalities could
continue fully tested. For instance, the following methods were added/
used:

* GaiaIdForAccountKey: Added.
* identity::GetTestGaiaIdForEmail: Referenced.

[1] https://chromium-review.googlesource.com/c/1330223

BUG=910581

Change-Id: I58db6044caa22b6072cb6d22dd7c97c668c46cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1357059Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#614327}

https://webrtc.googlesource.com/src.git/+log/518add35a8f3..fafae11bfc4c


git log 518add35a8f3..fafae11bfc4c --date=short --no-merges --format='%ad %ae %s'
2018-12-06 terelius@webrtc.org Allow parsing RTC event logs without a transaction ID.


Created with:
  gclient setdep -r src/third_party/webrtc@fafae11bfc4c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2becf74e5f60f900df64e46c4e9a20b4e5603999
Reviewed-on: https://chromium-review.googlesource.com/c/1365414Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614326}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddbf9b06e56d..eb2f2ad6ffdf


Created with:
  gclient setdep -r src-internal@eb2f2ad6ffdf

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I641322947d4d0b62fb0cf79fc9ae43742fb6b51e
Reviewed-on: https://chromium-review.googlesource.com/c/1365413Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614325}

Remove part of the description of BrowsingDataCounter's |pref_| that's no longer true and irrelevant.

Bug: none
Change-Id: Ibfb47522b33b5ca92f9e29191c79b7070d425e38
Reviewed-on: https://chromium-review.googlesource.com/c/1358459Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614324}