GitLab

BUG=125390
TEST=Chrome on Android UI tests, not ready to be upstreamed yet.


Review URL: https://chromiumcodereview.appspot.com/10695124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128378
TEST=GDataOperationsTest.GetDataOperationParseJson passes.

Review URL: https://chromiumcodereview.appspot.com/10749015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146104 0039d316-1c4b-4281-b951-d872f2087c98

BUG= https://code.google.com/p/chromium/issues/detail?id=136793
TEST= none

Review URL: https://chromiumcodereview.appspot.com/10695077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146103 0039d316-1c4b-4281-b951-d872f2087c98

When fetching origins from the quota database, include the ones where the modification time exactly matches the beginning.

This includes origins with modification time 0 in the result when fetching origins "since the beginning of time".

BUG=134825
TEST=content_unittests:QuotaDatabaseTest.OriginLastModifiedSince; manual: Database storage is deleted from the Clear Browsing Data dialog.

Review URL: https://chromiumcodereview.appspot.com/10700035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146102 0039d316-1c4b-4281-b951-d872f2087c98

Progress shows uploaded and downloaded bytes, but not copyed (so it 'in sync' with the sync indicator; current API restrics from more percise status update).
So for pinned or previusly copied gdata files progress still jumps in big chuncks.

BUG=134600
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10697098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146101 0039d316-1c4b-4281-b951-d872f2087c98

The current implementation of NetworkChangeNotifier on Android
assumes that the embedder has the Android ACCESS_NETWORK_STATE
platform permission, and will crash if it does not.

This change refactors the implementation such that the embedder
pushes state changes into the NetworkChangeNotfier, and makes
the NetworkChangeNotifier a singleton.


Review URL: https://chromiumcodereview.appspot.com/10693068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146100 0039d316-1c4b-4281-b951-d872f2087c98

Module and methods changes:
1. run_tests_helper -> constants
2. FromOkAndFailed -> FromRun
3. Remove duplicated apk check

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10692153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133939
TEST=Manual with simulated connectivity failures.


Review URL: https://chromiumcodereview.appspot.com/10695058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146098 0039d316-1c4b-4281-b951-d872f2087c98

If $PWD contains a symlink, build/android/envsetup.sh ends up setting
CHROME_SRC to the same symlinked path. This breaks some utilities (e.g.,
grit) that work with absolute paths and expect them to be prefixed by
CHROME_SRC.

The fix is to set CHROME_SRC to the canonical absolute path of the
current directory.

BUG=
TEST=cd $SYMLINKED_PATH; unset CHROME_SRC; . build/android/envsetup.sh; android_gyp


Review URL: https://chromiumcodereview.appspot.com/10700141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132980
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10736026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146096 0039d316-1c4b-4281-b951-d872f2087c98

AndroidCommand only needs two args while emulator.py pass three

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10700157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146095 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146065

Review URL: https://chromiumcodereview.appspot.com/10698114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136387,98431
TEST=see bug for manual test


Review URL: https://chromiumcodereview.appspot.com/10763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244
TEST=N/A, only moving code, no change in functionality


Review URL: https://chromiumcodereview.appspot.com/10696145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146092 0039d316-1c4b-4281-b951-d872f2087c98

Finder on Mac OS has a habit of putting .DS_Store files into directories, which would (silently) prevent us from deleting them.

Also, don't treat trying to delete a directory that doesn't exist on disk anymore as an error.
Add URL to quota managed origin deletion callback.


BUG=134825
TEST=Clear Browsing Data does that.


Review URL: https://chromiumcodereview.appspot.com/10701094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146089 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146088 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10690132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146086 0039d316-1c4b-4281-b951-d872f2087c98

No UI changes were shipped (apart from the startup option string change).

BUG=133904
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10689116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146084 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146083 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jbates@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10704152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146082 0039d316-1c4b-4281-b951-d872f2087c98

This is a band-aid fix that runs ui_unittests when runing chrome_tests.sh with a '-t gfx' option. Also, it renames an exclude file to use it when running ui_unittests.

BUG=none
TEST=make valgrind and heapchecker bots green.
Review URL: https://chromiumcodereview.appspot.com/10698146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101244
TEST=N/A, only moving code, no change in functionality


Review URL: https://chromiumcodereview.appspot.com/10696144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146079 0039d316-1c4b-4281-b951-d872f2087c98

Revert 146038 as it might have broken chromeos browser_tests - Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.

BUG=121479

Review URL: https://chromiumcodereview.appspot.com/10704073

TBR=koz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10736024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146078 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10695140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146077 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10701135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146076 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10700154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146074 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146073 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10702139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146072 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10696166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146071 0039d316-1c4b-4281-b951-d872f2087c98

This change prevents using the spellcheck service when Chrome is launched with a --disable-asynchronous-spellchecking flag because the spellcheck service depends on asynchronous spellchecking.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10753023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compiles, works, passes tests
R=csilv@chromium.org,thestig@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146069 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10689154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10693137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146067 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146066 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146065 0039d316-1c4b-4281-b951-d872f2087c98

Instead of DCHECKing (and then later crashing) if the state machine thinks it should be uploading old logs, but there aren't any, just advance the state and return.

This should prevent crashing in edge cases where something else has gone wrong and the state is out of sync.

Also change StageNextLogForUpload to CHECK instead of DCHECK that there is a next log before doing a swap(), since swap()ing in garbage pointers leads to hard-to-understand crashes later.

BUG=135285
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10692059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146064 0039d316-1c4b-4281-b951-d872f2087c98

[NTP4] Fix pane switcher images while we figure out the difference between <structure type="chrome_html">s and <include type="BINDATA">s.  This is partial revert of r145332.

R=tbreisacher@chromium.org
BUG=136389
TEST=Pane switchers have arrows again.


Review URL: https://chromiumcodereview.appspot.com/10689155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146063 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10763011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146062 0039d316-1c4b-4281-b951-d872f2087c98