- 28 Nov, 2018 40 commits
-
-
Alexei Svitkine authored
The crash would happen if you install Chrome of a specific language and run it for the first time on a Windows OS of a different language. It was caused by code setting the language pref in-between the two places where it was queried - such that the first time it was queried resulted in a different value than the second. This triggered the CHECK that was introduced by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1349770 Which correctly identified the problem. This CL fixes the issue by moving the importing of the first-run locale setting to earlier. Bug: 908791, 908114 Change-Id: Ie2e0178f298f78d38e0bc7f0b58c2205bb617561 Reviewed-on: https://chromium-review.googlesource.com/c/1352482Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611480}
-
Takumi Fujimoto authored
Update the tests to use the test UI API, which is implemented using the Views Cast dialog, replacing the use of the WebUI dialog. Some changes are made to the test UI API to better suit the needs of the tests. This re-enables many tests that were previously disabled for being flaky. Local file casting tests (5 test cases) are disabled in this CL, and will be implemented in a later CL: DISABLED_OpenLocalMediaFileInCurrentTab DISABLED_OpenLocalMediaFileInNewTab DISABLED_OpenLocalMediaFileFailsAndShowsIssue DISABLED_OpenLocalMediaFileFullscreen DISABLED_OpenLocalMediaFileCastFailNoFullscreen The following tests are still flaky, so they are marked MANUAL and will be run only on the private waterfall until they are fixed: MediaRouterIntegrationBrowserTest.MANUAL_Fail_NoProvider MediaRouterIntegrationBrowserTest.MANUAL_Dialog_Basic MediaRouterIntegrationBrowserTest.MANUAL_Dialog_RouteCreationTimedOut MediaRouterIntegrationOneUABrowserTest.MANUAL_SendAndOnMessage MediaRouterIntegrationOneUABrowserTest.MANUAL_ReceiverCloseConnection Bug: 900248 Change-Id: Ie328fd1c4b606a7f8291d8d22b7d83a89f1ee666 Reviewed-on: https://chromium-review.googlesource.com/c/1338226 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611479}
-
Jeremy Roman authored
Bug: 884059 Change-Id: I8f17beea35b0dd3ed356aeb04b25ae5d869a1c71 Reviewed-on: https://chromium-review.googlesource.com/c/1334190Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611478}
-
Moe Ahmadi authored
Adds GetOriginalMimeType() to web::DownloadTask in order to retrieve the MIME type download request originally attempted to fetch as the effective MIME type can change. Bug: 908696 Change-Id: I2bc1cd0fbc3ff038d0c5b50c819901a30e639d8e Reviewed-on: https://chromium-review.googlesource.com/c/1351338 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#611477}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f2b94cb9a6b..752d220a5f31 git log 4f2b94cb9a6b..752d220a5f31 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 jmadill@chromium.org Use flat enum for PrimitiveMode. 2018-11-27 geofflang@chromium.org Supress RobustResourceInitTestES3.MaskedStencilClearBuffer on Linux OpenGL 2018-11-27 jmadill@chromium.org Reformat all cpp and h files. Created with: gclient setdep -r src/third_party/angle@752d220a5f31 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I1f5422540001e82ca4b6d275b59648428e958c87 Reviewed-on: https://chromium-review.googlesource.com/c/1352551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611476}
-
Peter Boström authored
Adds a drop-in motion to the current fade-in effect. This (fade in and motion) is currently linear but expected to be updated in a later change after consulting UX. Bug: chromium:903806 Change-Id: Iebc44c281ad18be2c02a1e84903cc6d0ff64b84f Reviewed-on: https://chromium-review.googlesource.com/c/1352689Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611475}
-
Kenichi Ishibashi authored
Before this CL, all histograms under ServiceWorker.LoadTiming category were recorded by UMA_HISTOGRAM_TIMES macro. The macro can record up to 10 seconds but we've realized that 10 seconds limit isn't enough for some milestones. Use UMA_HISTOGRAM_MEDIUM_TIMES for these histograms so that they can be recorded up to 3 minutes. Bug: 877972 Change-Id: Icca1ddd583c87c4dd9a6ebd924b81edd2648b2f0 Reviewed-on: https://chromium-review.googlesource.com/c/1350433 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#611474}
-
Chris Blume authored
Right now, the draw functor factory is named in such a way that it only creates OpenGL functors. We want to also be able to create Vulkan functors. This CL renames the factory to be API-agnostic and renames the function which creates the functor to be API-specific. Change-Id: Ib304a376710a59ddde7afa72b9583a0e2243ddc9 Reviewed-on: https://chromium-review.googlesource.com/c/1352036Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#611473}
-
Vlad Tsyrklevich authored
Add the GWP-ASan crash handler hook to the list of user stream data sources in the Windows crashpad process. The GWP-ASan crash handler inspects crashes, and if they are related to a GWP-ASan allocation, adds additional debugging data to the minidump. CQ-DEPEND=CL:1330283 Bug: 896019 Change-Id: I0b38c60cd46c029200240560fdb714fbd2087f70 Reviewed-on: https://chromium-review.googlesource.com/c/1338324 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#611472}
-
Tarun Bansal authored
Change-Id: I534829c0717dc7c85d008459be9b1ffff3deb577 Reviewed-on: https://chromium-review.googlesource.com/c/1338951 Commit-Queue: Ben Greenstein <bengr@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611471}
-
Sergey Ulanov authored
Added OzonePlatform::IsNativePixmapConfigSupported() which is now used to verify that the current ozone platform supports particular image format. It replaces PlatformProperties::supported_buffer_format and ClientNativePixmapFactory::IsConfigurationSupported() Change-Id: I619f8130c09038e44bc558bdf59b816979e228a5 Reviewed-on: https://chromium-review.googlesource.com/c/1347036 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#611470}
-
Abhishek Arya authored
R=mmoroz@chromium.org,rch@chromium.org,enne@chromium.org,ajwong@chromium.org,jschin@chromium.org TBR=tkent@chromium.org Bug: 907103 Change-Id: Ib93a393e35650233f3c77e32080af048f9b301fb Reviewed-on: https://chromium-review.googlesource.com/c/1351483 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#611469}
-
James Darpinian authored
Implementing a WebGL spec change: https://github.com/KhronosGroup/WebGL/pull/2658 Fixes WebGL 2 conformance test: conformance2/transform_feedback/same-buffer-two-binding-points.html We want to forbid this for all GL contexts, not just WebGL ones, because it is also forbidden by DirectX, so ANGLE can't efficiently implement it. Bug: 866089 Change-Id: Ibf57adf513eca05b46b93d2139ba038d488c9cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1346994Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#611468}
-
Antonio Gomes authored
BUG=907487 Change-Id: Ib1343dc9dc93a1b5ca9ecf72658e29de7bd97116 Reviewed-on: https://chromium-review.googlesource.com/c/1348673Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#611467}
-
Anne Lim authored
Created CreditCardSaveStrikeDatabase implementation of StrikeDatabase, which is to be used to count strikes for credit card saves. Bug: 884817 Change-Id: I96b2b98894d06f97f6ea3bb24f3566cea273133f Reviewed-on: https://chromium-review.googlesource.com/c/1349169 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#611466}
-
bsheedy authored
Regular roll to the most recent release versions of Daydream and VrCore. TBR=bajones@chromium.org Change-Id: I913293ce4ba653d9d57b5062fe94b628f70ac5ef Reviewed-on: https://chromium-review.googlesource.com/c/1352486Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611465}
-
Wez authored
Mark dcheck-is-fatal as a special never-expiring flag, since it is used with special DCHECK-enabled builds to explicitly opt-in (or out) of crashing when a check fails. Bug: 901515 Change-Id: I153082352eaaa048db9d4070f802b4ce1ab8c38a Reviewed-on: https://chromium-review.googlesource.com/c/1351732Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611464}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af1cdca8c140..7f2a2ae33b38 Created with: gclient setdep -r src-internal@7f2a2ae33b38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8cf1cf853015a2305ae3d7cd55ed92d918a381aa Reviewed-on: https://chromium-review.googlesource.com/c/1352066Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611463}
-
David Black authored
This CL adds an |id| paramter to the existing Assistant Reminders deep link to allow opening a specific reminder. Omitting an |id| falls back to top-level Assistant Settings. Bug: b:120085149 Change-Id: If2e4a5c532ce585102bb3e448f1d585c02c9cf62 Reviewed-on: https://chromium-review.googlesource.com/c/1352477Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#611462}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/adb9e705092b..d429f5426b5b git log adb9e705092b..d429f5426b5b --date=short --no-merges --format='%ad %ae %s' 2018-11-27 thestig@chromium.org Get rid of "exceptions" in CBC_C40Encoder::EncodeChar(). 2018-11-27 tsepez@chromium.org Remove some wide string literals in favor of single-bytes 2018-11-27 tsepez@chromium.org Remove BC_UtilCodingConvert.{cpp,h} Created with: gclient setdep -r src/third_party/pdfium@d429f5426b5b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I80591803c4180c10e40b0405cadde9857ea271aa Reviewed-on: https://chromium-review.googlesource.com/c/1352550Reviewed-by:
-
dpapad authored
Last consumer of this dependency was the Files app, which no longer uses it. Bug: 847729 Change-Id: Ibba5a18b722bc44ef74689834660a7197cc923d3 Reviewed-on: https://chromium-review.googlesource.com/c/1352430Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steve McKay <smckay@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611460}
-
Weidong Guo authored
Changes: Use composition text instead of Textfield::SetText() for autocomplete text to avoid cancelling candidate popup window. Bug: 897206 Test: SearchBoxViewAutocompleteTest.SearchBoxAutocompletesNotHandledForIME Change-Id: I876aa4fd4c755b98437a28ed463a19b0e067be15 Reviewed-on: https://chromium-review.googlesource.com/c/1340831 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611459}
-
Chris Blume authored
Right now, AwContents has a member |functor_|. This is never read. It is only written in the function it is being consumed in. This CL simplifies AwContents by removing the |functor_| member and consuming the parameter in SetAwGLFunctor(). Change-Id: Ib40ee7d7e198b656e2f8b9011996b6d0550596bf Reviewed-on: https://chromium-review.googlesource.com/c/1352414Reviewed-by:
-
Jazz Xu authored
Bug: 907666 Change-Id: Icbee5df7ce3b253407843dbbfd569117d3b866de Reviewed-on: https://chromium-review.googlesource.com/c/1351601 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611457}
-
Hao Zhang authored
Add user actions for autofill settings adding cards. Bug: 904459 Change-Id: Ib1d0c1c9fe50e6f95eb09072b1e71231126b28c8 Reviewed-on: https://chromium-review.googlesource.com/c/1351901Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Pedro Amaral authored
Bug: 903864 Change-Id: I7110ee2b0e6eab650d9388c828738ad349e20cc2 Reviewed-on: https://chromium-review.googlesource.com/c/1340791 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#611455}
-
Kent Tamura authored
On Android and Fuchsia, all of web tests are accessed via http, and 'LayoutTests' was prepended to their URLs even after the Great Blink mv. It should be updated to 'web_tests' because some tests find test root directory by searching for 'web_tests', and test_runner changes its behavior by checking path names in a URL [1]. [1] https://cs.chromium.org/chromium/src/content/shell/test_runner/test_interfaces.cc?type=cs&sq=package:chromium&g=0&l=35 TBR=qyesrsley@chromium.org No-Try: true Bug: 909012 Change-Id: Ia4a45238d55248d2fc6c06b56c3878aa0a38d8a3 Reviewed-on: https://chromium-review.googlesource.com/c/1352118Reviewed-by:
-
ziyangch authored
-the internal part is eureka-internal/221797 BUG=internal b/120030063 Test=Check the logging when switching from opt-in to opt-out. Change-Id: Ib42484624007cf28c1a98ffc62851ea7f7656194 Reviewed-on: https://chromium-review.googlesource.com/c/1351283 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611453}
-
Ian Clelland authored
This adds a compile-time assertion macro to test whether a given feature is part of an origin trial, and uses it to assert that WebVR and WebXR are under origin trial when constructing the feature policy default feature list. Change-Id: I71a24d73ef0837165aefcdc0a12ed6212cee5553 Reviewed-on: https://chromium-review.googlesource.com/c/1136989 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611452}
-
Miguel Casas authored
This CL defines a new CanvasResourceProviderDirectGpuMemoryBuffer, which uses the CanvasResource's GpuMeMoryBuffer's texture for Skia's SkSurface::MakeFromBackendTextureAsRenderTarget. This is used for both 2D and WebGL lowlatency: - For 2D, we'll just use Skia to draw directly onto the front buffer, thus skipping copies, but possibly introducing more tearing. - 3D has a DrawingBuffer where it resolves all GL commands, in this case we blit onto the CRP's SkSurface; using the new "Direct" mode thus skips a copy. Bug: 902585 Change-Id: I6a8d88dd75812addd47abf21a3d74e6e5d2e42f4 Reviewed-on: https://chromium-review.googlesource.com/c/1321773 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611451}
-
Thomas Guilbert authored
The new RemotePlayback pipeline will be turned on by default in M72, using a finch experiment. This change disables tests that will fail if they get the finch configuration that turns on the new RemotePlayback pipeline on. Bug: 790766 Change-Id: Id7809111f9e3883ef68a6853750d04e377b38992 Reviewed-on: https://chromium-review.googlesource.com/c/1352613Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#611450}
-
yiyix authored
Change-Id: Idbe1d20fd14dfbbcf8810dee3c5a393f460b7f29 Reviewed-on: https://chromium-review.googlesource.com/c/1336509 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#611449}
-
Kurt Horimoto authored
This is required in order to do a finch-driven staged rollout of the smooth scrolling feature. Bug: 908990 Change-Id: Ic2bcd64a787b5f543bdbd0d56310fb3967dce5c8 Reviewed-on: https://chromium-review.googlesource.com/c/1352524 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611448}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6b3d18164b4a..59cfd3543875 git log 6b3d18164b4a..59cfd3543875 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 yvesg@webrtc.org Address vptr race condition while PeerConnection is destructed. 2018-11-27 kron@webrtc.org Change HdrMetadataExtension to ColorSpaceExtension 2018-11-27 nisse@webrtc.org Move RtcpStatistics from common_types.h to a new header file Created with: gclient setdep -r src/third_party/webrtc@59cfd3543875 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae8475100a6a4a4a30dc7443c2ca214f49602f1b Reviewed-on: https://chromium-review.googlesource.com/c/1352245Reviewed-by:
-
manuk authored
Previously, the additional properties column was rendered as stringified JSON [1]. Using colon-delimited key value strings [2] improves readability and saves >75% vertical space. [1] [ { "key": "last visit", "value": "48 hours ago" }, { "key": "typed count", "value": "36" }, { "key": "visit count", "value": "36" } ] [2] last visit: 48 hours ago typed count: 36 visit count: 36 Bug: 891303 Change-Id: I4630347e2806cc8deb434f80c20b1587cf06c989 Reviewed-on: https://chromium-review.googlesource.com/c/1340946 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#611446}
-
Ned Nguyen authored
Change-Id: I167996ca595f9ca8726fbab2728cc97ee2193b2f Reviewed-on: https://chromium-review.googlesource.com/c/1351943Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611445}
-
Nico Weber authored
base is now a static_library in nacl_nonsfi mode, like it already was everywhere else. Also fix a warning instead of suppressing it in nacl sfi builds. Bug: 570839 Change-Id: I5414e8a00c74a27edcffe7aa68c096d3486571bd Reviewed-on: https://chromium-review.googlesource.com/c/1352335 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611444}
-
Tom Anderson authored
BUG=908677 R=sky Change-Id: I5d4a5a43fdf6d503cbd69619472e130a7abcc374 Reviewed-on: https://chromium-review.googlesource.com/c/1351690Reviewed-by:
-
Toni Barzic authored
Also, ClearSigninProfile now closes any browser window opened in the profile. Ideally, no browsers would be open in the sign-in profile, but we've had cases where that had happened. BUG=906837,901768 Change-Id: Ia231d2ce3420c5c743bcd17f839ad00f4a851874 Reviewed-on: https://chromium-review.googlesource.com/c/1347105Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Greg Kerr authored
Bug: 902597 Change-Id: I3e422c88d774705a1c67682d0fdb1b18e3568170 Reviewed-on: https://chromium-review.googlesource.com/c/1327426 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611441}
-
