Commits · 5819ba399f61905f5938539942bbc1818671c242 · eriksson monteiro / tangled

31 Jul, 2019 40 commits

[Switch Access] Use new settings page · 5819ba39

Anastasia Helfinstein authored Jul 31, 2019

This is step 3 in the migration of Switch Access options into an
official settings page. While the first two steps created the settings
page and added plumbing for the updated event type, this change modifies
where the Switch Access extension finds the preference values, and what
page opens for Switch Access settings.

Bug: 958081
Change-Id: Id88c6ba1f54444af5cd817222c521121187310cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670272
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682891}

5819ba39

DevTools: fix collapsing empty sections in performance panel · de3005a2

Yang Guo authored Jul 31, 2019

R=alph@chromium.org

Bug: chromium:985454
Change-Id: I1a9b7953b1d7bdd9e9de715c3a999cd8997240db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719006
Commit-Queue: Alexei Filippov <alph@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682890}

de3005a2

Fix performance regression introduced by CL 1715764 · 5bf0642f

Kevin Ellis authored Jul 31, 2019

This patch fixes the calculation of when the compositor state needs
synchronization.  Ordering is important in the calculation of play
state, and some idle and pause states were being misclassified as
pending.

Bug: 988471, 988607
Change-Id: Ie73c57a3101f07bc44d5c353328d7e17d4fb1a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728074Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682889}

5bf0642f

Add draw_utils::AdjustBottomGapForRightSidePage(). · 8915f96d

Jeremy Chinsen authored Jul 31, 2019

Currently in PDFiumEngine::FillPageSides() the logic for handling the
bottom gaps of pages on the right side is in the FillPageSides().

This CL moves that logic to
draw_utils::AdjustBottomGapForRightSidePage(), making it testable.

Bug: 51472
Change-Id: I5c5d0929c46745ee315f3b7ce77dc4cb0b44e5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726757Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Cr-Commit-Position: refs/heads/master@{#682888}

8915f96d

Revert "Convert content::CommitNavigationParams to mojom." · 45db3a5d

Owen Min authored Jul 31, 2019

This reverts commit f9763b52.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55348

Original change's description:
> Convert content::CommitNavigationParams to mojom.
> 
> Bug: 984550
> Change-Id: Ic966c764e7fb52a9fb8d2ea44d9777bd8c1e4011
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725096
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682795}

TBR=avi@chromium.org,nasko@chromium.org,scottmg@chromium.org,lfg@chromium.org

Change-Id: Ibc3e06f427783c760970b5deb8f2bf6a6581b610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729577Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682887}

45db3a5d

content/browser/appcache: Always specify thread affinity when posting tasks · a74ffe90

Sami Kyostila authored Jul 31, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pwnall@chromium.org

Bug: 968047
Change-Id: If31471ee0f29bdeed0639192d1bdba1e75197c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729590
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682886}

a74ffe90

Improve logging of player state in media content_browsertests · 310dd7b3

John Rummell authored Jul 31, 2019

Adds more logging to log the player state with each event, and adds
readyState and networkState to the values output.

Bug: 986021
Test: Modified tests pass
Change-Id: Ib733fea0d75d39bd3e1b763ac39168fe9e47157c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728334Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682885}

310dd7b3

Remove |AtomicString::DeprecatedLower()| · ca1e4075

Koji Ishii authored Jul 31, 2019

This patch removes now unused |AtomicString::DeprecatedLower()|.
The 6 calls to it were converted to |LowerASCII()| recently.

|String::DeprecatedLower()| still has 37 usages, and that the
underlying function is still needed.

Bug: 627682
Change-Id: I081be03de495712a2b252e30e95ff5f79c5d1e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724153
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682884}

ca1e4075

Import wpt@3411d0ebcfa3356c876f76bed0b26f56fb5b824f · e5b8fefe

Chromium WPT Sync authored Jul 31, 2019

Using wpt-import in Chromium 8fd585ed.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
guidou@chromium.org, armax@chromium.org:
  external/wpt/mediacapture-streams
jochen@chromium.org, estark@chromium.org:
  external/wpt/referrer-policy
msisov@igalia.com:
  external/wpt/webvtt

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I55605da90660cc9e7b0a0ed1d93f8c621c41bb6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729570Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682883}

e5b8fefe

Disable... · 5aaba0e3

Owen Min authored Jul 31, 2019

Disable virtual/omt-worker-fetch/external/wpt/resource-timing/resource_timing_buffer_full_eventually.html

The test is timeout on Win and Linux.

Bug: 989665
Change-Id: I6a805c5c47293cf767c924594f92e5a7e1d7a6a8
Tbr: skym@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729398Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682882}

5aaba0e3

Re-enable masking of backdrop-filtered region on skia_renderer · 72633808

Mason Freed authored Jul 31, 2019

The CL in [1] disabled the use of the mask_resource_id when that
mask was for backdrop-filter use. However, in skia_renderer, the
mask is applied correctly for both backdrop and regular masks.

[1] https://chromium.googlesource.com/chromium/src/+/310cae44aff889a75fc85ce5ec89d9341eccc665

Bug: 981207
Change-Id: Iabb65b145968800d4c17bc3b0e5a01996046c144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724278
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682881}

72633808

Revert "Previews: Check for data saver state at navigation start" · 08a7289d

Owen Min authored Jul 31, 2019

This reverts commit e6af1df2.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/27665?blamelist=1#blamelist-tab

Original change's description:
> Previews: Check for data saver state at navigation start
> 
> This CL makes the data saver checks more resilient.
> 
> Moving the checks to the very beginning at the navigation start also
> prevents recording of some of the Previews histograms for
> non-DRP users.
> 
> Change-Id: I26c96d654180a2202eef5f0899c89c37bf4c6da5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716121
> Reviewed-by: Doug Arnett <dougarnett@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682836}

TBR=tbansal@chromium.org,dougarnett@chromium.org

Change-Id: I53b53e652139c9dde2be2b382266ee1778dd3657
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729576Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682880}

08a7289d

storage: Always specify thread affinity when posting tasks · d5265e99

Sami Kyostila authored Jul 31, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pwnall@chromium.org

Bug: 968047
Change-Id: Iff33707395af8d9edff34551ba90787c2bf8cdfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729079
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682879}

d5265e99

Remove JavaScriptDialogTabHelper's use of DidStartNavigationToPendingEntry. · ccd9f529

Avi Drissman authored Jul 31, 2019

BUG=817024

Change-Id: I60d8e6b269c0c8f565e689508789713f73703e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729470Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682878}

ccd9f529

[Fuchsia] Fix update-sdk.py not to re-download the same SDK. · 0fb1097e

Wez authored Jul 31, 2019

The script was looking in the wrong place for the legacy SDK files.

Bug: 977018, 989335
Change-Id: Ibd7d3f8e35633af579c27f282e47487a8fc20f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726959
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682877}

0fb1097e

Roll src-internal 5588ed40788d..fee597729b1d (2 commits) · 0a3f1d27

chromium-internal-autoroll authored Jul 31, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5588ed40788d..fee597729b1d

Created with:
gclient setdep -r src-internal@fee597729b1d

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ia4d7a81322d60444d4aa7c144eb7c07c047b6723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729557Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682876}

0a3f1d27

[DeviceSync v2] Fix CryptAuthDevice equality operator · f0f5c3f0

Josh Nohle authored Jul 31, 2019

Bug: 951969
Change-Id: I102d0cfe3de99276eb157f7b0c00f1b48a74b072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728544
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682875}

f0f5c3f0

Update V8 to version 7.8.43. · f050d8fb

v8-ci-autoroll-builder authored Jul 31, 2019

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f99c5871..748b4c7b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I83467dffe1f180cd5240fee91b5b4d154cca4976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729472Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682874}

f050d8fb

Record UMAs on navigation commit timeout · b026e586

Clark DuVall authored Jul 31, 2019

This should help debug the Clank renderer hangs with network service.

Bug: 934317
Change-Id: I78f69d5fafd05e4b8984601bc652b1d086d0ca49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726911
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682873}

b026e586

Reland "Move Java classes needed by all Java Cronet implementations to utils." · 00c9185e

Ben Kirchman authored Jul 31, 2019

This is a reland of 5a08e77e

Revert of this CL was due to a build failure. Fix the build failure by
adding the dependency for the new utils target to the Java Cronet
implementation's package target.

Original change's description:
> Move Java classes needed by all Java Cronet implementations to utils.
>
> To minimize code duplication, code that can be shared between the
> JavaUrlRequest and the FakeUrlRequest should be moved to a new shared
> file: JavaUrlRequestUtils.
>
> Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325
>
> Bug: 669707
> Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Commit-Queue: Benjamin Kirchman <kirchman@google.com>
> Cr-Commit-Position: refs/heads/master@{#681835}

Bug: 669707
Change-Id: Ifd4f6118e1bc3f41a151f942199e69451d5ac5c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724502Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Benjamin Kirchman <kirchman@google.com>
Cr-Commit-Position: refs/heads/master@{#682872}

00c9185e

[Fuchsia] Fix CleansUpContextJobs test to use its own job. · 33901df9

Wez authored Jul 31, 2019

The test is supposed to create a new sub-job of its parent job, so that
it can watch for the job becoming empty. Instead it was just duplicating
the handle to its existing job, causing the test to flake if any other
test batch process happened to be running in that job at the time.

Bug: 989085
Change-Id: I17a287dcb6e5b0a7351294f6297ed355eb3e15ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728440
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682871}

33901df9

gpu: reduce locks in transfer buffer · f0bdd22d

Adrienne Walker authored Jul 31, 2019

Currently, gpu::CommandBufferHelper::GetLastState locks a mutex to check
the latest token state for every outstanding block in the transfer
buffer.  Instead, take the lock once, and reuse the cached value when
looping over all the blocks.

On vmiura's "300 invalidation" repaint test in callgrind on Linux, the
number of cycles spent per library changed like this, filtered to
RasterBufferImpl::Playback and CommandBufferService::Flush:

             |  gpur  |  oopr  | % diff
-------------+--------+--------+-------
total cycles | 256.2m | 235.3m |  8.1%
libbase.so   |  19.9m |  13.1m | 34.3%
libgpu.so    |  16.1m |   8.7m | 45.9%
libpthread   |   5.7m |   1.5m | 72.8%

The callstack this avoids is:
gpu::FencedAllocator::GetLargestFreeSize ->
gpu::FencedAllocator::FreeUnused ->
gpu::CommandBufferHelper::HasTokenPassed ->
gpu::ComamndBufferProxyImpl::GetLastState ->
base::internal::LockImpl::Lock ->
pthread_mutex_lock

Change-Id: Ic7d7a93ff6b6833ce978318d3ad406afeca76c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725030Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682870}

f0bdd22d

Disable NetworkQualityEstimatorTest.TestTCPSocketRTT on ChromeOS · dc87c31d

Owen Min authored Jul 31, 2019

The test is flaky.

Bug: 986904
Change-Id: I670a6b99b5ec6448b4cc8cbf7f1569112d2d8bcb
Tbr: tbansal@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729396Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682869}

dc87c31d

Bump expiration of Previews.Offline.FalsePositivePrevention.* · 10a6b8cf

Robert Ogden authored Jul 31, 2019

Bug: 988679
Change-Id: Ifaee6742dc098c1c2fb90aceb8a4ef97766e52bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728433
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682868}

10a6b8cf

ui: removes unused mojoms/types · 25678548

Scott Violet authored Jul 31, 2019

These were added for mash, now that mash is no more they can be removed.

BUG=none
TEST=none

Change-Id: I56c1d89a168f03b31e5cf5bd8b7ab7b886dc1479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729060Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682867}

25678548

[ios] Remove ios-uirefresh-simulator bot. · c325894e

Justin Cohen authored Jul 31, 2019

Change-Id: I2a5bf8228c91fea4740e3716781e5e0a91189784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729575Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682866}

c325894e

Roll src/third_party/webrtc d0b67c2a70b3..53571c75c695 (1 commits) · 07530062

chromium-autoroll authored Jul 31, 2019

https://webrtc.googlesource.com/src.git/+log/d0b67c2a70b3..53571c75c695

git log d0b67c2a70b3..53571c75c695 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 srte@webrtc.org Adds config based creation of frame generator capturer.

Created with:
gclient setdep -r src/third_party/webrtc@53571c75c695

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I6c5318c8963c41c6137d3eac22ec50a824745719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729704Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682865}

07530062

Flag causes outlines to be drawn around tabs in low contrast dark themes · 07b03c65

Dana Fried authored Jul 31, 2019

Currently we draw tab outlines around the active tab when contrast ratio
between tab and background for the active tab is less than 1.3 to 1.
This works reasonably well for light themes but not for dark themes.

UX have requested the ability to try rendering a stroke around the
active tab in dark, low-contrast themes.

This CL adds a flag which, when enabled, causes an additional check to
be performed: if there is less than a 20% absolute luminance difference
between the tab and background, the stroke is also drawn.

Because this is a prototype for UX/internal evaluation purposes only it
may be removed.

Bug: 968459
Change-Id: I67668ba53ed528b5fdfd9b7c58547338daded011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725221Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682864}

07b03c65

Added a test to check that OWNERS files can be expanded. · 4b06ca70

Caitlin Fischer authored Jul 31, 2019

Bug: 924136
Change-Id: I5c360800f32e65855d6107f190d66f78abf622d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724409
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682863}

4b06ca70

[VideoCapture] Remove unused Media.VideoCaptureApi.Mac histogram. · a7a28c53

Armando Miraglia authored Jul 31, 2019

I have received various emails from chirp indicating that this histogram
does not have data. After searching for it in Code Search, it looks to me
as this histogram is never used hence I am removing it.

BUG=None

Change-Id: I9cf654d4e4f4ccfdc18936338a962c9e3ecb76e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722843
Auto-Submit: Armando Miraglia <armax@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682862}

a7a28c53

Match support for PAC on Android Web View between network service and non-Network Service. · 97290c99

Eric Roman authored Jul 31, 2019

Android WebView uses the system's PAC support (via localhost proxy) rather than Chromium's PAC implementation.

Bug: 989222
Change-Id: Ia0dcc436890fe5d92fb5124c1bc278d61979f8e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726763Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682861}

97290c99

chrome/browser/safe_browsing/download_protection: Always specify thread affinity when posting tasks · b6ccdf65

Sami Kyostila authored Jul 31, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=nparker@chromium.org

Bug: 968047
Change-Id: I11dd0befca765ffa4b25c8df66bd7557621b2b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729223
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682860}

b6ccdf65

Make TextFragmentAnchor case insensitive · 73bd0c83

Nick Burris authored Jul 31, 2019

Revert TextFragmentAnchor matching behavior back to case insensitive.
Case sensitive reduced ambiguity, but also reduced match rate on CSS
transformed text and &nbsp (see bug 982031). Ambiguity can, in most
cases, be reduced by providing more context terms, so case insensitive
is probably best.

Bug: 982031, 982035
Change-Id: I633c674affb16b571294e5d81b6ae3b24ec9a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729550Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682859}

73bd0c83

Modules: Add initial native Chrome code docs · 8fea5a10

Christopher Grant authored Jul 31, 2019

Change-Id: Ifd1be95869fa4b3c8bea29fff2e07671abe82e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725189
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682858}

8fea5a10

Revert "[Sheriff] Disable CacheStorageManagerTest.TestErrorInitializingCache." · c220d681

Wez authored Jul 31, 2019

This reverts commit bd32f816.

Reason for revert: Reverted the CLs that appear to have introduced the flakiness.

Original change's description:
> [Sheriff] Disable CacheStorageManagerTest.TestErrorInitializingCache.
> 
> Disable CacheStorageManagerTest.TestErrorInitializingCache in Fuchsia
> (flaky).
> 
> TBR=wanderview@chromium.org
> 
> Bug: 989313
> Change-Id: I18802fc677a99b9a83fc99a356f7c02ff568d11b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729150
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682694}

TBR=vitaliii@chromium.org,wanderview@chromium.org

Change-Id: I56f467459e882d5586a3aa57c1ae8bc94ae1ead8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 989313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729833Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682857}

c220d681

Minor cleanup to MaterialRefreshLayoutProvider · 7983de41

James Cook authored Jul 31, 2019

Sort headers and include what you use.

Bug: none
Change-Id: I5173a232342a6288d6d1a67ca0705e1e963e15ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728542
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682856}

7983de41

Roll src/third_party/perfetto e2248cbc238c..2c1dec165ba6 (4 commits) · d738b83e

chromium-autoroll authored Jul 31, 2019

https://android.googlesource.com/platform/external/perfetto.git/+log/e2248cbc238c..2c1dec165ba6

git log e2248cbc238c..2c1dec165ba6 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 treehugger-gerrit@google.com Merge "shmem: Avoid synchronous commits if in kDrop mode"
2019-07-31 ilkos@google.com Merge "Add trace duration and rename the metadata proto"
2019-07-31 treehugger-gerrit@google.com Merge "Add ability to generate UUIDs"
2019-07-31 treehugger-gerrit@google.com Merge "Log if max. number of data sources exhausted in client API."

Created with:
gclient setdep -r src/third_party/perfetto@2c1dec165ba6

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I221f6655b9df14124f91a0a43110bb78bc814541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729555Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#682855}

d738b83e

SettingsSplit: Remove unnecessary deps of os-settings on pageVisibility · 16d4186c

Jordy Greenblatt authored Jul 31, 2019

This is a CL to minimize os-settings's dependency on pageVisibility.
This includes removing some references to non-existent paths as in [1]
and replacing any pageVisibility path that only depends on guest mode
in OS Settings with an explicit check on whether the machine is in
guest mode from loadTimeData.

This doesn't completely eliminate the pageVisibility fork [2] bug
because the people-page still provides a pageVisibility subpath to sync-
settings, but it removes the vast majority of the dependencies on the
browser settings' pageVisibility. The people-page issue will be handled
in a later CL to avoid bloating.

LOGGED IN SCREENSHOTS:

Screenshots for OS Settings logged into a GAIA account with this change
deployed.

Page 1 http://screen/Tcbdf04X2Q4
Page 2 http://screen/9t80k4pRAGj
Page 3 http://screen/dRCw3iZcQUU

Compare to the top level 'settings-section's in UX mock [1] (modulo
reordering and renaming).

GUEST MODE SCREENSHOTS:

As per specs sent out by jessejames@, in guest mode, the visible
sections[2] are Network, Bluetooth, Device, Search engine, Date and
time, Privacy and security, Languages and input, Files, Printing, and
Accessibility. Compare this with screenshots of guest mode with this
change deployed:

Page 1 http://screen/AriC9twWUi3
Page 2 http://screen/qnrUthAru3G

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1716338
[2] http://crbug.com/974906

[1] https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQLWgsMW9gCl/files/MCEJu8Y2hyDScYKiC7u07no3e21TaxzYd_w
[2] There is a possibility that 'People' may be shown in guest mode
    depending on the outcome of a UX design discussion on the correct
    place for Kerberos settings, but this CL is working under the
    assumption that it is not shown. This can easily be changed after.

Bug: 987349, 974906
Change-Id: I7f384437f9008742926eb7cf9d4d623bd8415591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724828Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682854}

16d4186c

overview: Limit displayed windows to six for new layout. · 1cc0aa84

Danton Vu authored Jul 31, 2019

The new positioning logic is hidden behind a flag.

R=sammiequon@chromium.org

Test: added test
Bug: 978112

Change-Id: If9a565f3587e588041245be3f2dd8a2baa28c643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685517
Commit-Queue: Danton Vu <dantonvu@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682853}

1cc0aa84

mojo: Always specify thread affinity when posting tasks · 713cbf92

Sami Kyostila authored Jul 31, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 968047
Change-Id: I61bc20b765ad68c07e33d14e7ef3e28ee2282c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729153
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#682852}

713cbf92