- 12 Jan, 2017 40 commits
-
-
jamescook authored
BUG=none TEST=none Review-Url: https://codereview.chromium.org/2628923003 Cr-Commit-Position: refs/heads/master@{#443322}
-
ryanchung authored
- sheretov@ and vadimgo@ no longer works on cast. - add dougsteed@ BUG= Review-Url: https://codereview.chromium.org/2626053003 Cr-Commit-Position: refs/heads/master@{#443321}
-
jrummell authored
Currently PluginPrivateDataByOriginChecker only deletes all the data for the specified origin if it finds at least one file that matches the time range specified. However, if the origin has no files, it should be cleaned up as well. Adds a test that deletes the file for a particular origin before clearing all PluginPrivate storage to verify it works. BUG=678314 TEST=new content_unittest passes Review-Url: https://codereview.chromium.org/2622403002 Cr-Commit-Position: refs/heads/master@{#443320}
-
mahmadi authored
BUG=602666 Review-Url: https://codereview.chromium.org/2588913002 Cr-Commit-Position: refs/heads/master@{#443319}
-
rnephew authored
BUG=679375 Review-Url: https://codereview.chromium.org/2622003005 Cr-Commit-Position: refs/heads/master@{#443318}
-
ericrk authored
I got the data I wanted from this UMA, and it appears to be causing performance regressions. Removing. R=isherman@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2628833003 Cr-Commit-Position: refs/heads/master@{#443317}
-
tommycli authored
BUG=680544 TBR= Review-Url: https://codereview.chromium.org/2625273004 Cr-Commit-Position: refs/heads/master@{#443316}
-
alph authored
Review-Url: https://codereview.chromium.org/2629503002 Cr-Commit-Position: refs/heads/master@{#443315}
-
xlai authored
The images generated on gpu reference archive are correctly showing blurry edge on enlarged canvas. TBR=zmo@chromium.org BUG=676666 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2625393002 Cr-Commit-Position: refs/heads/master@{#443314}
-
ryansturm authored
This CL adds a count of requests using DRP and information about compression. This will allow us to reconsider UMA (e.g., logging UMA for Mixed content pages (HTTPS pages using DRP from HTTP sub-resources), logging UMA for <50% of network requests using DRP, >50% of network requests using DRP, etc.). This will also allow UMA for size of page in terms of network bytes and in terms of original content length (precompressed bytes from the origin). This will allow a DRP per-page data savings histogram as well. BUG=679893 Review-Url: https://codereview.chromium.org/2619243003 Cr-Commit-Position: refs/heads/master@{#443313}
-
dbeam authored
R=mahmadi@chromium.org BUG=679993 Review-Url: https://codereview.chromium.org/2629083002 Cr-Commit-Position: refs/heads/master@{#443312}
-
michaeldo authored
When the BrowserState is destroyed, the preload controller must be notified to ensure it will be released. This prevents the preload controller from receiving PrefChanged notifications after the browser state has been destroyed. BUG=677126 Review-Url: https://codereview.chromium.org/2629073003 Cr-Commit-Position: refs/heads/master@{#443311}
-
baxley authored
These tests are affected by crashes in the context menu tests. With these tests disabled. They could also be affected by alerts, but We now skip tests with alerts on EG tests. BUG=675400 Review-Url: https://codereview.chromium.org/2624263004 Cr-Commit-Position: refs/heads/master@{#443310}
-
michaelpg authored
Precursor to some possible refactoring to extract the file_handlers API from //chrome to //extensions. BUG=679870 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2621193002 Cr-Commit-Position: refs/heads/master@{#443309}
-
derat authored
Change it from "Initializing..." to "Loading apps..." per suggestion from UX. BUG=633596,633243 Review-Url: https://codereview.chromium.org/2625293003 Cr-Commit-Position: refs/heads/master@{#443308}
-
pauljensen authored
Executor passed into JavaUrlRequest is backed by a thread-pool so it can concurrently run tasks which can lead to crashes in underlying HttpURLConnection. Prevent this by serializing taskes passed to underlying Executor. BUG=664872 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2613393002 Cr-Commit-Position: refs/heads/master@{#443307}
-
nyquist authored
This CL removes all the BlimpBrowserTest tests, and related files. It also removes the test suite from the build bots, and a ThreadRestrictions friend-class from //base. BUG=677556 Review-Url: https://codereview.chromium.org/2620213004 Cr-Commit-Position: refs/heads/master@{#443306}
-
agrieve authored
Required for crash server to de-obfuscate java stack traces. BUG=620323 Review-Url: https://codereview.chromium.org/2556523002 Cr-Commit-Position: refs/heads/master@{#443305}
-
yusukes authored
Since TaskManagerImpl is destructed after ~ArcServiceManager is called, we need to check the return value from the getter. BUG=680301 TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC, press Ctrl+Shift+QQ to sign out, confirm the browser does not crash Review-Url: https://codereview.chromium.org/2625823005 Cr-Commit-Position: refs/heads/master@{#443304}
-
megjablon authored
In order to support Client-side Lo-Fi and other Previews optimizations which can be enabled in parallel, change the Lo-Fi bool to a Previews bitmask. TBR=mek@chromium.org BUG=657997 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2484633004 Cr-Commit-Position: refs/heads/master@{#443303}
-
wjmaclean authored
Prior to enabling PointerEvents, OOPIFs with TouchEvent handlers worked. But with PointerEvents turned on, they fail. This happens because the InputRouterImpl sending the touch events to the OOPIF never gets notified of the current TouchAction, in turn because ChromeClientImpl sends the TouchAction notification via RenderView and not the RenderWidget serving the OOPIF. Prior to PointerEvents this was not an issue, as the touch events would continue to flow regardlesss. But with PointerEvents, touch events are blocked after a TouchScrollStart is issued. This CL plumbs a LocalFrame* parameter into ChromeClient::setTouchAction so the notification can be sent via the correct channel. BUG=680158 Review-Url: https://codereview.chromium.org/2626133002 Cr-Commit-Position: refs/heads/master@{#443302}
-
megjablon authored
Suppress lint warnings for translations of the data_reduction_promo_summary string in values-pt-rBR/android_chrome_strings.xml and values-cs/android_chrome_strings.xml BUG=680246 Review-Url: https://codereview.chromium.org/2624183003 Cr-Commit-Position: refs/heads/master@{#443301}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7f52163a4f80..ed0540fbc6ef $ git log 7f52163a4..ed0540fbc --date=short --no-merges --format='%ad %ae %s' 2017-01-12 simonhatch Dashboard - Append a link to the doc on memory regressions for memory benchmarks. 2017-01-12 simonhatch Dashboard - Fix bisect output when no values are produced. BUG=680226 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2633503002 Cr-Commit-Position: refs/heads/master@{#443300}
-
sigbjornf authored
Revert r440390's debug instrumentation of ExtendableMessageEvent. R= BUG=655926 Review-Url: https://codereview.chromium.org/2623273004 Cr-Commit-Position: refs/heads/master@{#443299}
-
scottchen authored
BUG=649427 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2628773004 Cr-Commit-Position: refs/heads/master@{#443298}
-
alexmos authored
This variant of the test runs on Site Isolation Win in addition to the regular test, hence it also needs to be disabled. BUG=672570 NOTRY=true TBR=lukasza@chromium.org Review-Url: https://codereview.chromium.org/2633513002 Cr-Commit-Position: refs/heads/master@{#443297}
-
petermayo authored
Neighbours can clip to the same infinity. Using two of the same vertex in a polygon can cause the computed normal to be (0,0,0), which causes badness and failures. BUG=626095 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2551263002 Cr-Commit-Position: refs/heads/master@{#443296}
-
davidben authored
https://boringssl.googlesource.com/boringssl/+log/a81967b47c5eba78aedccd2bc3cb3fb95fe80bd0..8b8d22c961413c1ae465719d8252bea50587ed3f BUG=none Review-Url: https://codereview.chromium.org/2626273002 Cr-Commit-Position: refs/heads/master@{#443295}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/d32303e7276b..693fdbd6b81a $ git log d32303e72..693fdbd6b --date=short --no-merges --format='%ad %ae %s' 2017-01-12 reed refFoo variant for getters that naturally have a sk_sp 2017-01-12 mtklein skia_android_serial = "auto" 2017-01-12 brianosman Cleanup GrPixelConfig helper functions 2017-01-12 jvanverth Fix perf regression with SDF paths BUG=677889 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Review-Url: https://codereview.chromium.org/2627953004 Cr-Commit-Position: refs/heads/master@{#443294}
-
hanxi authored
The crash happens in a incognito page when a A2HS banner shows for a WebApp. It is caused since WebApkInstallServiceFactory didn't implemtent GetBrowserContextToUse() which returns a nullptr as default. In this CL, the same pointer of the original browser context is returned for the incognito page, so calling of WebApkInstallerService::Get() can return an null-empty instance of WebApkInstallerService. Crash Stacktrace: Thread 0 CRASHED [SIGSEGV @ 0x0000000c ] MAGIC SIGNATURE THREAD Stack Quality20%Show frame trust levels 0xd1af55a0 (libmonochrome.so -__tree:878 ) WebApkInstallService::IsInstallInProgress(GURL const&) 0xd1aefe43 (libmonochrome.so -shortcut_helper.cc:273 ) ShortcutHelper::IsWebApkInstalled(content::BrowserContext*, GURL const&, GURL const&) 0xd1a24ea3 (libmonochrome.so -app_banner_manager.cc:244 ) banners::AppBannerManager::PerformInstallableCheck() 0xd1abafd7 (libmonochrome.so -app_banner_manager_android.cc:180 ) banners::AppBannerManagerAndroid::PerformInstallableCheck() 0xd1a25c91 (libmonochrome.so -app_banner_manager.cc:239 ) banners::AppBannerManager::OnDidGetManifest(InstallableData const&) 0xd1a548d5 (libmonochrome.so -callback.h:85 ) InstallableManager::RunCallback(std::__ndk1::pair<InstallableParams, base::Callback<void (InstallableData const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> > const&, InstallableStatusCode) 0xd1a54a4d (libmonochrome.so -installable_manager.cc:246 ) InstallableManager::WorkOnTask() 0xd1a54d55 (libmonochrome.so -installable_manager.cc:288 ) InstallableManager::OnDidGetManifest(GURL const&, content::Manifest const&) BUG=679826 Review-Url: https://codereview.chromium.org/2620403002 Cr-Commit-Position: refs/heads/master@{#443293}
-
justincohen authored
This should have been removed when the 'top' omnibox was hidden on the NTP. Since there is only one omnibox visible on iPhone, we don't need the fakebox flag. BUG=666081 Review-Url: https://codereview.chromium.org/2601943002 Cr-Commit-Position: refs/heads/master@{#443292}
-
marq authored
BUG= Review-Url: https://codereview.chromium.org/2592983003 Cr-Commit-Position: refs/heads/master@{#443291}
-
siggi authored
Revert of Part two of fallback crash handler for Crashpad handler process. (patchset #11 id:220001 of https://codereview.chromium.org/2611393002/ ) Reason for revert: Breaks components_unittests on Win10. Original issue's description: > Part two of fallback crash handler for Crashpad handler process. > > This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it. > After this, the dump is dropped into the Crashpad database for eventual upload. > > BUG=678959 > > Review-Url: https://codereview.chromium.org/2611393002 > Cr-Commit-Position: refs/heads/master@{#443249} > Committed: https://chromium.googlesource.com/chromium/src/+/92651104e939dbe94378a607e7acd381ca394fd3 TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678959 Review-Url: https://codereview.chromium.org/2628863005 Cr-Commit-Position: refs/heads/master@{#443290}
-
bradnelson authored
BUG=v8:4203 R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2625823006 Cr-Commit-Position: refs/heads/master@{#443289}
-
rkjnsn authored
BUG=629305 Review-Url: https://codereview.chromium.org/2620373003 Cr-Commit-Position: refs/heads/master@{#443288}
-
olivierrobin authored
If a user has a distilled entry in the Reading List and is on a poor network, the distilled entry will be loaded and the user cannot access the online page. To avoid blocking the user from the up to date page, reloading a page from the offline page will not start the offline triggering timer. Reloading again from the pending loading will load back the online version. BUG=680481 Review-Url: https://codereview.chromium.org/2616093002 Cr-Commit-Position: refs/heads/master@{#443287}
-
michaelpg authored
This is the most Chrome-dependent part of //apps, and is only used for the app list in Chrome, so why not move it to chrome/browser/ui/app_list? This enables us to make the rest of the //apps code independent of Chrome so it can be used for app_shell. Alternatively, we could make custom_launcher_page_contents.cc not depend on Chrome (it's mostly for extensions::ChromeExtensionWebContentsObserver), but that's probably better off being lumped into a larger task to move app_list out of chrome if that should become a goal. BUG=679971 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2628883002 Cr-Commit-Position: refs/heads/master@{#443286}
-
awdf authored
- Push notifications are no longer grouped with all other Chrome notifications - However, this patch makes them standalone, rather than grouped by origin, as we aren't yet setting a summary notification. BUG=674015,674335 Review-Url: https://codereview.chromium.org/2628723003 Cr-Commit-Position: refs/heads/master@{#443285}
-
mstensho authored
Use early returns and variables to avoid unwanted line breaks in statements. Review-Url: https://codereview.chromium.org/2631513002 Cr-Commit-Position: refs/heads/master@{#443284}
-
fdoray authored
From observer_list_threadsafe.h: // If the observer to be removed is in the list, RemoveObserver MUST // be called from the same thread which called AddObserver. This rule is currently not respected by DomainReliabilityMonitor, which prevents the addition of a DCHECK. With this CL, the rule is respected and |last_network_change_time_| is read/written from the same thread (no data race). BUG= Review-Url: https://codereview.chromium.org/2627523003 Cr-Commit-Position: refs/heads/master@{#443283}
-