Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Dec, 2017 34 commits
  3. 12 Dec, 2017 6 commits
    • Raymes Khoury's avatar
      Add features::kGrantNotificationsToDSE to about:flags · 582b4313
      Raymes Khoury authored 
      This adds features::kGrantNotificationsToDSE to about flags for easy
toggling for testing purposes.

Bug: 780344
Change-Id: Iffbfe175fbafea5aef368255a226a7780cc3ab44
Reviewed-on: https://chromium-review.googlesource.com/821991
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523611}
      582b4313
    • catapult-deps-roller@chromium.org's avatar
      Roll src/third_party/catapult/ d076c5980..30c927c2b (1 commit) · 427d109e
      catapult-deps-roller@chromium.org authored 
      https://chromium.googlesource.com/catapult.git/+log/d076c5980367..30c927c2b8f3

$ git log d076c5980..30c927c2b --date=short --no-merges --format='%ad %ae %s'
2017-12-12 simonhatch Dashboard - Fix find_anomalies and graph_revisions called with None

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I67368146f9866f3093f726ad3db37e87f53eaa74
Reviewed-on: https://chromium-review.googlesource.com/822216
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523610}
      427d109e
    • Lukasz Anforowicz's avatar
      Revert "Improve granularity of window namespaces in Blink." · e4c10ef6
      Lukasz Anforowicz authored 
      This reverts commit 1c950906.

Reason for revert: Broke Hangouts Chrome App - see https://crbug.com/794079

Original change's description:
> Improve granularity of window namespaces in Blink.
>
> This CL ensures that blink::FrameTree::Find(const AtomicString& name)
> only looks for a match in the current set of related browsing contexts
> (represented in the browser by content::BrowsingInstance).  This CL
> means that window.open's behavior won't change just because a renderer
> process happens to host multiple unrelated browsing contexts (possible
> for example after reusing a renderer process because of hitting the
> process limit).
>
> This CL consists of 3 parts:
>
> - New browser tests.
>   - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>     for verifying browsing instance boundaries when the
>     renderer processes get reused.
>   - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>     for verifying that extensions can still lookup unrelated frames
>     from the same extension.
>
> - Having blink::Page maintain a set of related pages.
>   - Page::next_related_page_ and Page::prev_related_page_ form a
>     circular, double-linked list of related pages.
>   - Page::CreateOrdinary takes a new |opener| parameter and treats the
>     new page and the |opener| as related and puts them on the same list.
>   - |opener| is propagated from content::RenderViewImpl, through
>     blink::WebViewImpl into blink::Page.
>
> - Falling back to blink embedder when blink::FrameTree::Find finds no frame
>   with the given name.
>   - The fallback is needed to preserve the old behavior for extensions.
>   - The fallback goes through blink::LocalFrameClient,
>     blink::WebFrameClient / content::RenderFrameImpl,
>     content::ContentRendererClient / ::ChromeContentRendererClient,
>     ::ChromeExtensionsRendererClient and finally is implemented
>     by extensions::ExtensionFrameHelper.
>   - Currently the fallback iterates through all same-origin frames in
>     the given process, but requires that the |relative_to_frame| is an
>     extension frame.  In the future we might want to restrict piercing
>     of browsing instances to specific scenarios where it is needed
>     (e.g. restrict it to background pages / contents only?).
>
> I've tested this CL via:
> (all tests below pass before and after the CL, except for
> ProcessReuseVsBrowsingInstance which is fixed by this CL)
>
> - New tests:
>     - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>       (web -> web shouldn't violate browsing instance)
>     - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>       (extension/about:blank -> extension can violate browsing instance)
>
> - Existing tests:
>     - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener
>       (chrome.windows.create stays in the same browsing instance depending
>        on the setSelfAsOpener parameter)
>     - AppBackgroundPageApiTest.Basic
>       (hosted app -> background page can violate browsing instance;
>        tests handling of mapping of web urls [full url, not just origin]
>        to extensions)
>
> - Manual testing:
>   - Hangouts Chrome *extension* continues to work (sufficient to
>     validate that sign-in works).  Tested with version 2017.1019.418.1.
>
> Bug: 718489
> Test: See above.
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Tbr: tommycli@chromium.org
> Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a
> Reviewed-on: https://chromium-review.googlesource.com/764487
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521917}

TBR=dcheng@chromium.org,creis@chromium.org,thestig@chromium.org,wolenetz@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org,rbpotter@chromium.org


Bug: 718489, 794079
Change-Id: I7ee06ae1b8341044377d5e0ae975888c99d8f700
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/822756Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarMatthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: default avatarŁukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523609}
      e4c10ef6
    • Carlos Knippschild's avatar
      Prefetching download task takes limitless mode into account. · 2665ec85
      Carlos Knippschild authored 
      This change takes into account the "limitless prefetching" feature flag
to choose to ignore the daily download quota and increase the concurrent
downloads limit when it is enabled.

Bug: 793109
Change-Id: I6a3aea110976bcd1c2afac1dbfa86f06e0327b25
Reviewed-on: https://chromium-review.googlesource.com/817705
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523608}
      2665ec85
    • Nate Chapin's avatar
      CSSPreloadResourceClient should register with Resource via ResourceFetcher · d816df28
      Nate Chapin authored 
      Bug: 793028
Change-Id: Ice4ec0acdd179f2a7e2b17a497ee3bdf6e91fff4
Reviewed-on: https://chromium-review.googlesource.com/822916Reviewed-by: default avatarHiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523607}
      d816df28
    • Raymes Khoury's avatar
      Update the UI to reflect the notifications permission for the DSE · 6deaae48
      Raymes Khoury authored 
      This updates 2 UI surfaces to reflect notifications permissions set for
the DSE. Specifically:
1) In android Site Details, when toggle the DSE permission for
notififications, it will show the options "Allow/Block for the current
search engine". 2 cases are handled here: one when that setting links
directly into Notification Channels on Android O+ and the other in the
case where the permission is handled directly in Chrome.

2) In Settings>Search Engines, underneath the currently selected search
engine, it will display a link indicating whether
notifications/geolocation are allowed. The link will take the user to
the Site Details for the search engine. Several changes have been made
to the behavior here:
-The link used to indicate if location was disabled. Now, if
notifications are location are disabled, nothing will be shown in the
text for those permissions.
-The link used to take users directly to Android Location Settings when
the text indicated that system location was disabled. But now due to the
link handling combined permissions, it always takes the user directly to
Site Details for the search engine, where the user can follow a link
into Android Location Settings.

Bug: 780344
Change-Id: I41e0dd1028ad289141d1632875d30373b528f17c
Reviewed-on: https://chromium-review.googlesource.com/799534
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523606}
      6deaae48