- 08 Oct, 2018 40 commits
-
-
John Budorick authored
Bug: 790265 Change-Id: I86aa0233e66af6ee8a98775356124e827317b5de Reviewed-on: https://chromium-review.googlesource.com/c/1263881Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#597577}
-
Yao Xiao authored
It allows us to observe mainframe download in PageLoadMetricsObserver. Bug: 881345 Change-Id: Icc5a3fb9dd645b9bdc291b64030789312614b74d Reviewed-on: https://chromium-review.googlesource.com/c/1260566Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#597576}
-
Eugene But authored
Wait until Download button is shown up before tapping it. The timeout for the button should be the same as page load timeout, because the button is shown when the server responds. Bug: 892883 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9cc3b687a9ff8029f411e8eee02689719f1ac0ca Reviewed-on: https://chromium-review.googlesource.com/c/1267347Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63ee73a37124..3c5695530095 Created with: gclient setdep -r src-internal@3c5695530095 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4a11da9cfcc8b9e1710ca9c29052b90ccb2fb1c3 Reviewed-on: https://chromium-review.googlesource.com/c/1268556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597574}
-
Yuri Wiitala authored
The current theory (see bug) is that somehow the member set between audio::LoopbackStream and media::LoopbackGroupCoordinator became out-of- sync. This change tests that theory by modifying the destructor to ensure the exact set of SnooperNode instances that could be in-use by LoopbackStream::FlowNetwork are cleanly "disconnected" before shutdown (with further object destruction) proceeds. Bug: 888478, 867886 Change-Id: I7b34fe168a80302c43a4333b9a181342f7b79912 Reviewed-on: https://chromium-review.googlesource.com/c/1266875 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597573}
-
Maks Orlovich authored
Both calls can't be invoked on the same step with the state machine as the callback, as two asynchronous (net::ERR_IO_PENDING) returns mean that the callback would be invoked twice, and it's not meant for that (what with one invocation queuing self-deletion...) Also improve testing somewhat to actually make sure the wasm stuff is deleted as well. Longer-term, this should probably be elsewhere, this method isn't generally used with NetworkService (see: crbug.com/892652) Bug: 892583 Change-Id: I61be72c19f4ec713a2c27e5c4be963f603f3df20 Reviewed-on: https://chromium-review.googlesource.com/c/1264917Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597572}
-
Philip Rogers authored
This patch updates PropertyTreeManager::EnsureCompositorTransformNode to set the should_be_snapped bit on cc::TransformNode. This matches the behavior of cc's PropertyTreeBuilder (done in AddTransformNodeIfNeeded). Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47e0f59dc3d1b3e2bd1bb92cc9086a18308a3342 Reviewed-on: https://chromium-review.googlesource.com/c/1267077 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597571}
-
Yuri Wiitala authored
Modifies the legacy media::AudioOutputController to start/stop diverting without using the shared "OnDeviceChange()" code path. This blatant code duplication (sans UMAs) should allow us to evaluate whether certain metrics are okay (or have regressed) with the upcoming transition to the new Audio Service. See bug for details. Bug: 866455 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I56aaeeff8412d132a27a2a9fd6dae476160b4d20 Reviewed-on: https://chromium-review.googlesource.com/c/1266715 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d42baee1..9f7f390a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I89bae23507a1710e55b8661348d3f96d8a6edba5 Reviewed-on: https://chromium-review.googlesource.com/c/1268515Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597569}
-
Marc Treib authored
There's a C++ version and a Java equivalent of GoogleServiceAuthError. The Java version was missing a few entries that were added over the last years; this CL adds them and so brings the two back in sync. Longer-term, it'd be better to automatically generate the Java version from the C++ one using GENERATED_JAVA_ENUM_PACKAGE, but that's left for a future CL. Bug: 866329 Change-Id: Iaed8a9d10c4824bca3f2f828828f5934c0c2845e Reviewed-on: https://chromium-review.googlesource.com/c/1268335Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597568}
-
Mario Sanchez Prada authored
This new API will provide access to the account ID of the latest cached information for the user's primary account, which is conceptually not the same than getting an AccountInfo with GetPrimaryAccountInfo() and then accessing the account_id member, since that won't return any ID when the account has been removed from the AccountTrackerService. Bug: 887264 Change-Id: Id87e58fbe86e2a048067d4ede8d9621e2d430cff Reviewed-on: https://chromium-review.googlesource.com/c/1264162 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597567}
-
Joshua Pawlicki authored
Previous sheriff attempted disable but forgot the MAYBE_. TBR=ortuno@chromium.org Bug: 892004 Change-Id: I98ebef818d3e270f277f9f61be0090af9a0a195a Reviewed-on: https://chromium-review.googlesource.com/c/1268516Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597566}
-
Vasilii Sukhanov authored
The CL changes the layout of the "Save username?" bubble. It is used for federated credentials. The "Save password/username?" bubble has always a footer for the signed-in users. The footer is now shown in the account chooser for the signed-in users. Bug: 890336 Change-Id: I7133cb15c6377e82e971e793886f8520b5bfd4eb Reviewed-on: https://chromium-review.googlesource.com/c/1265259Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae06125bdbdf..63ee73a37124 Created with: gclient setdep -r src-internal@63ee73a37124 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icd4e5499cf71d5c657953e9e39adf68f62b105e8 Reviewed-on: https://chromium-review.googlesource.com/c/1268455Reviewed-by:
-
Mihai Sardarescu authored
There was always a risk that account information was left on the device if the tokens of the account was not loaded. This was not an issue in the application as the token service is the the source of truth for the list of accounts present in the browser. However, there is a small risk that we leave PII information on disk (e.g. email, ful name etc). This CL stop tracking the accounts for which tokens are no longer persent in the token DB. Bug: 891665 Change-Id: I3a9f17bc32efaccb00688108b731bc9337a83f68 Reviewed-on: https://chromium-review.googlesource.com/c/1257914Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#597563}
-
David Tseng authored
Currently, ChromeVox recovers to ancestors when nodes are deleted from the accessibility tree. This often times does not do exactly what we want. For example, when a page quickly removes and re-inserts a the same or similar node, ChromeVox loses its place. This also can lead to ChromeVox getting "stuck" in a navigational loop. Tree path based recovery is already used within editable text, so has good coverage. TreePathRecoveryStrategy (the class) is also a subclass of AncestorRecoveryStrategy, so it falls back to ancestry-based recovery when the tree path is invalid. An alternate approach was tried in: https://chromium-review.googlesource.com/c/chromium/src/+/1234856 Test: the new Google.com accessibility menu now does not loop when navigating with ChromeVox. Bug: 869914,885244 Change-Id: I129e2b31250c2f3169feb662b042e6900f61e424 Reviewed-on: https://chromium-review.googlesource.com/c/1262435Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597562}
-
Vaclav Brozek authored
When Chrome parses FormData of password forms into PasswordForm structures, it omits, under certain conditions, password fields marked as readonly. To understand the potential impact of removing this special handling, this CL adds a UKM metric to report when this occurs. This will provide both the frequency and some sample sites to understand the usage of readonly password fields. Privacy review of this metric: The whole UKM event "PasswordForm" has been reviewed in crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding new metrics for this event is OK under certain conditions (see the linked doc). The new twin metrics for the readonly attribute satisfy such conditions, in the opinion of the CL author, and hence are covered by that review. The new metrics have been added to the requested spreadsheet listing all passwords-related metrics. Choice of metrics: The core of the metrics is the ReadonlyPasswordFields enum, which describes different situations which can happen wrt. readonly fields during parsing. Those are in the UKM combined with the bit indicating whether the parsing overall was successful, because this is also relevant to the issue. Further, the metrics can be collected at two stages: when a form is parsed to be filled, and when it is parsed to be saved. Here there was a choice to either record this as an additional bit in one metric, or create two "twin" metrics. The advantage of the former is the ability to study how these two events correlate. The advantage of the latter is easier reading of the particular metrics and a lower range of values per metric. Because the correlation is unlikely to be of significant use, the latter approach was chosen. Bug: 883633 Change-Id: Ib63e52908ae3a257546646c1b255a6cd8fd48b6b Reviewed-on: https://chromium-review.googlesource.com/c/1261984Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597561}
-
Owen Min authored
When the GetConnectionType returns asynchronously, verification request is never sent because the default network type is CONNECTION_NONE and there is no network change notification later either. Resolves the issue by handling the callback from the API. Also 1) Separate network check from others so that we don't fetch network type again when we know it. 2) Rewrite the unittest to use more fake services instead of stun value. It increase the code coverage. Including SigninManager, ProfileOAuth2TokenService and TestNetworkConnectionTracker. Bug: 891817 Change-Id: Iebdc5bbc30e699b347d6a343bb6f4c979fbe1596 Reviewed-on: https://chromium-review.googlesource.com/c/1259542Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597560}
-
Zakhar Voit authored
Updated AllowedUILocales to limit not only the ui locales but also the available preferred languages. Renamed AllowedUILocales to AllowedLanguages to better indicate that. Bug: 579660 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1256570 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597559}
-
Colin Blundell authored
Will be needed by multiple clients for converting away from ProfileOAuth2TokenService. Bug: 882861 Change-Id: Ie648a701a02d34e786703604cb8d1f7f080202bc Reviewed-on: https://chromium-review.googlesource.com/c/1267499Reviewed-by:
-
Henrik Grunell authored
This reverts commit 96b1bcfd. Reason for revert: Broke audio on Win 7 and Win 8. The audio debug recording tests failed here https://ci.chromium.org/buildbot/chromium.webrtc/Win7%20Tester/ and they only broke on Win 7 and 8. When testing ToT build on a Win 7 machine is no audio output. Tested AppRTC, Youtube and onlinemictest.com/sound-test. Canary on the same machine works. This CL is the only in the range that's suspicious. Andrew, let me know if you believe this is incorrect. Original change's description: > Windows 10 low-latency audio API > > Implement the IAudioClient3 interface to allow lower output latency > for use in Web Audio via the latencyHint. Update AudioParameters > adding HardwareCapabilities with min_ and max_frames_per_buffer > representing the min and max buffer sizes supported by the audio > hardware so that requested buffer sizes can be appropriately clamped > in AudioLatency::GetExactBufferSize(). > > Bug: 316908 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ibafe6d917ec4d57a16092f040b57b4ff27ed54b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1165236 > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> > Cr-Commit-Position: refs/heads/master@{#597497} TBR=dalecurtis@chromium.org,robliao@chromium.org,kerrnel@chromium.org,olka@chromium.org,wfh@chromium.org,maxmorin@chromium.org,ossu@chromium.org,andrew.macpherson@soundtrap.com Change-Id: I7c76029c435b7434463734baa9a2b21469399c8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 316908 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1268280Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597557}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e00abc98e59..6a8327fc823d git log 2e00abc98e59..6a8327fc823d --date=short --no-merges --format='%ad %ae %s' 2018-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ccb83d4a..0cdd2e3e (597330:597498) 2018-10-08 srte@webrtc.org Reland "Reland "Using units in SendSideBandwidthEstimation."" 2018-10-08 perkj@webrtc.org Changed FakeVp8Encoder to write dimensions in payload. 2018-10-08 srte@webrtc.org Revert "Reland "Using units in SendSideBandwidthEstimation."" 2018-10-08 srte@webrtc.org Reland "Using units in SendSideBandwidthEstimation." 2018-10-08 oprypin@webrtc.org Revert "Using units in SendSideBandwidthEstimation." Created with: gclient setdep -r src/third_party/webrtc@6a8327fc823d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I23b504ce3d525570f708cdb268bd414d9d385fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1267686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597556}
-
Mark Pearson authored
I'm sad it took me so long to prepare this changelist. When I created it, there was a test failure, which I couldn't immediately identify the cause of. And it didn't seem that imperative to finish quickly, so it got postponed again and again. Finally I looked into it. The test failure was due to am inappropriate test, not any problem with the feature. This means I could've launched this months ago if I'd been more attentive. :-( The test scored_history_match_unittest failed because, with the flag enabled, the #hash_component part of a URL now was being parsed as two words ("hash" and "component"). The tests in this file that look at how the word "com" score (for testing for domain name matches) started scoring higher than expected because this new (unexpected) match. I revised the URL to be #hash_fragment to remove this errant (unexpected) match and leave the test continuing to test what it used to. Bug: 783500,364301 Change-Id: Id6c83457605ab30a630f7a4281573d000c4d2afd Reviewed-on: https://chromium-review.googlesource.com/c/1266724Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#597555}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d765b07f86f..6f591c9706e6 git log 6d765b07f86f..6f591c9706e6 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 oetuaho@nvidia.com Clean up TCompiler members and style Created with: gclient setdep -r src/third_party/angle@6f591c9706e6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I682cd3b9fb1ef07f7748bbe16cabb5f7cc09e937 Reviewed-on: https://chromium-review.googlesource.com/c/1267687Reviewed-by:
-
Colin Blundell authored
This CL extends FakeO2TSDelegate to support taking in transient errors and dropping them; before, it would just update the auth error, which violates the contract of O2TS::GetAuthError() and results in a DCHECK failing inside that class. This better reflects production behavior (e.g., of MutablePO2TSDelegate) and allows an upcoming CL to test proper behavior in the event of a transient error occurring. Bug: 882861 Change-Id: Icbf2020b1b7fd9a0992e0b17fd74fc9b3f0eaf42 Reviewed-on: https://chromium-review.googlesource.com/c/1268017Reviewed-by:
-
Mikel Astiz authored
The recently introduced feature toggle has been experimented with via Finch, suggesting that the new settings cause an important improvement in RAM usage (with early data, ~5 MB for the 50th percentile). In addition, all sync status metrics report no regression, so let's enable the change by default (but keep the kill switch around). Bug: 887068 Change-Id: Ic3d8d1dff09900f0e3f25f75db4bce71572224cb Reviewed-on: https://chromium-review.googlesource.com/c/1268117Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597552}
-
Rune Lillesveen authored
Include specificity for compound inside ::slotted(). Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gYrR2nR6quI Bug: 888042 Change-Id: Ibe421ce7423ba797cafd354696ff5cf693c52697 Reviewed-on: https://chromium-review.googlesource.com/c/1251421Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#597551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a279e61ff38..ae06125bdbdf Created with: gclient setdep -r src-internal@ae06125bdbdf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I406b1a857814409c336f97f999606fc3dbdc22e7 Reviewed-on: https://chromium-review.googlesource.com/c/1267957Reviewed-by:
-
Rune Lillesveen authored
Otherwise `:host div` is equally specific to `div`, which seems undesirable and doesn't match any spec. This is only done for Shadow DOM v1 since there are backward compat issues with Polymer and WebUI. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gYrR2nR6quI Bug: 857415 Change-Id: Ieaaf9b835ae7136806ced8f6e72fb30f9adf02af Reviewed-on: https://chromium-review.googlesource.com/c/1250963 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL applies small fixes th the tests that make them less flaky: * use a small keyboard height but reduce the threshold to make it display-independent * ensure the tab overview is present for tests that need it * dismiss keyboards with a library function instead of the more flaky back press Bug: 857460 Change-Id: Id460847bdc2df7f8bbc0d1a04c96f151e3dff0ae Reviewed-on: https://chromium-review.googlesource.com/c/1225767 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#597548}
-
Roman Sorokin authored
Also capitalized MACHINE_NAME placeholder for NativePrinters BUG=chromium:875876 Change-Id: I0270db0e970665db155248d75db54da353bd8720 Reviewed-on: https://chromium-review.googlesource.com/c/1245792Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597547}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9fcb424b..d42baee1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id402e8ea8c8fcd65f8234899137c3559f88f1499 Reviewed-on: https://chromium-review.googlesource.com/c/1267825Reviewed-by:
-
Greg Daniel authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I67e0f6017e84d964af316cef1f912dd58d050ce4 Reviewed-on: https://chromium-review.googlesource.com/c/1264922Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597545}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /content/browser. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=boliu@chromium.org, mkwst@chromium.org Bug: 890902 Change-Id: I06146497aa7a8cba7516eb17497ca33454141b2a Reviewed-on: https://chromium-review.googlesource.com/c/1257909Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597544}
-
Manuel Rego Casasnovas authored
The method LayoutBoxModelObject::RelativePositionOffset() was not considering the case of grid items, where the containing block is the grid area. The patch modifies the method so the new code uses OverrideContainingBlockContentLogicalWidth|Height when required. Two new tests are added, the first one does not use percentages and is already passing. The second one has the very same output but using percentages which was not working before this patch. BUG=835607 TEST=external/wpt/css/css-grid/grid-items/grid-items-relative-offsets-001.html TEST=external/wpt/css/css-grid/grid-items/grid-items-relative-offsets-002.html Change-Id: Icb76f4a521566ad36f87924835b21ae450f2cb24 Reviewed-on: https://chromium-review.googlesource.com/c/1238726Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#597543}
-
Noel Gordon authored
The FilesApp QuickView PDF browser test crashes the MSAN bot. Disable the test in MSAN. Tbr: slangley, lucmult No-Presubmit: true Bug: 768070,891150 Change-Id: I262418dd3b79df11824810c42749cd1b6d78edee Reviewed-on: https://chromium-review.googlesource.com/c/1267597Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597542}
-
Morten Stenshorne authored
NG needs to produce a rectangle with the block-axis offset relatively to block-start of the container, just like legacy does. Using purely physical coordinates is wrong. This fixes issues with scroll anchoring, and possibly other things too. One test had to be rebaselined, due to a rounding change. LayoutText::DebugRect() calls LinesBoundingBox(), which now flips the block-axis coordinate for vertical-rl. This affects rounding of the size of the rectangle. Bug: 889449 Change-Id: I7053ed7fe05ce443f53a128660d60f27fea7f8b3 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1264596 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597541}
-
Douglas Creager authored
This will allow us to add a new implementation that uses data_decoder to safely parse the untrusted JSON headers in a utility process. This patch just adds the new delegate interface and a default implementation that provides the existing behavior of parsing in-process. Bug: 892148, 811485 Change-Id: Ida8027ce44163c7f35535a3327343b7bf94ea854 Reviewed-on: https://chromium-review.googlesource.com/c/1262595 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#597540}
-
Marc Treib authored
This is done for two reasons: 1) It'll allow us to move a Wallet-specific special case from the general datatype-agnostic code into the Wallet-specific controller (once that exists). 2) It's actually less misleading: Directory data types actually ignore this value, i.e. passing CLEAR_METADATA didn't actually clear data for them. Bug: 889941 Change-Id: I4e660e41b17142480eb8b03569077686cedaab6c Reviewed-on: https://chromium-review.googlesource.com/c/1264695Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL hides the location bar for System PWAs. It also plumbs better bookmark app manifest validation into ExtensionBrowserTest. Bug: 836128 Change-Id: Ife1ec3962edd57a0f5ea7c44ff359894a9d0d7cf Reviewed-on: https://chromium-review.googlesource.com/c/1256467 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597538}
-
