GitLab

https://chromium-review.googlesource.com/c/chromium/src/+/1984717
fixed an issue with the iron-list sometimes setting an infinite
displayed item count by setting the height of iron-list using JS so
that it was always set to something nonzero before the list items were
updated. Unfortunately, this causes the list to never increase in
size if the dialog is resized larger after it has been opened, leaving
an odd empty space between the destinations list and the buttons.

Fix by adding a listener for the resize event that updates the height
of the list.

Change-Id: I7e010293831e5e1459cf1f0f6ba429dd52825b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006110
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732688}

The underlying EXO surface should only be resized when the main
RenderFrameHost changes. Embedded RHF (eg: iframes) should not cause the
EXO surface to resize.

Bug: b/147835637
Test: On device
Change-Id: I24cab3f2cb99d0b2a3693adc815d445522c1cec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006420Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732687}

Prior to this commit, valueMissing() incorrectly returned true for
text-mode inputs that were readonly or disabled. With this CL, this
situation is fixed.

Fixed: 1039149
Change-Id: I0f3d9b5c00e7c4e9e8fa0a9767119a2ab5d6b01f
Bug: 1039149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003637
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732686}

All changes were performed by clang-tidy except for the following:
  * Reverted windows_types.h as they need to appear exactly as they do
    in windows.h and there isn't anyway to exclude files from
    clang-tidy (https://reviews.llvm.org/D26418)
  * clang-tidy doesn't quite handle WINAPI and cdecl rewrites correctly.
    Those are manually fixed up in
      * scoped_handle_unittest.cc
      * win_util.cc
      * wrapped_window_proc.h

BUG=1034666

Change-Id: I20921cd09922072767caaed4a79de179e8bf4819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989979
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732685}

Since |service_handle| from Android might be invalid, we need an early
return instead of DCHECK().

BUG=b:147707738
TEST=When Fitbit is installed, no crash in cts test now.

Change-Id: Ia9aa8402960bb40457bd81a3d09b26a41aa27601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000401Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Jie Jiang <jiejiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732684}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57a0ce4db871..32e07f0513b0


Created with:
  gclient setdep -r src-internal@32e07f0513b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588,chromium:1035235,chromium:1042439
Tbr: jbudorick@google.com
Change-Id: I489f25aa09d63e86a40e4b60e2eabcd8a25fef14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005968Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732683}

Previously, document policy class is designed to hold a field for each
feature's policy value. Those fields are supposed to be generated from
document_policy_features.json5. Such design minimizes both speed and
memory overhead but adds complexity to the system by introducing code
generation.

This CL uses array to represent internal feature state, which still
minimizes speed overhead as indexing into array is the same as indexing
into memory, and adds very little memory overhead(Each PolicyValue
instance contains extra information).

Change-Id: I4bc5e9b4383c628018e2605ad896e31b17c9c0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003436
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732682}

Replace the PrintMsg_PrintNodeUnderContextMenu IPC message with a new
Mojo method, and update RenderViewContextMenu to use this method.

Bug: 1008939
Change-Id: I6cf5e4429c7c057b8b48d386177daf3989a3988d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999322Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732681}

Previously within the cache logic if we had an indefinite initial
block-size we would compute a new final block-size based on the layout
results IntrinsicBlockSize().

For flex-boxes the IntrinsicBlockSize may depend on a previous
fixed-block-size (if present).

This resulted in an incorrect cache-hit.

A slightly more optimal version of this patch would be to set a bit on
this layout result named something like:
IntrinsicBlockSizeDependsOnInitialBlockSize().

This bit would be set if that layout had any child had its size based
on the initial-block-size. e.g. within the flex algorithm:

if (is_column_) {
  if (child.Style().ResolvedFlexGrow(Style()) > 0 ||
      child.Style().ResovledFlexShrink(Style()) > 0)
    container_builder_.SetIntrinsicBlockSizeDependsOnInitialBlockSize();
} else {
  if (DoesItemStretch(child))
    container_builder_.SetIntrinsicBlockSizeDependsOnInitialBlockSize();
}

... and within the cache logic:

if (layout_result.IntrinsicBlockSizeDependsOnInitialBlockSize())
  return NGLayoutCacheStatus::kNeedsLayout;

Bug: 845235
Change-Id: Iad4c5984ed894192a20d02303596d8fb9f71d036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002893
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732680}

This cl moves the logic for back gesture from
ToplevelWindowEventHandler to the new created BackGestureEventHandler.
This is done to make sure the gesture events will not be dispatched to
arc apps if they have been handled by back gesture, also make
ToplevelWindowEventHalder clearer.

The gesture events can still be dispatched to arc apps is because
exo::Touch is a PreTargetEventHandler of Shell
(https://cs.chromium.org/chromium/src/components/exo/touch.cc?rcl=74853d8d13a89431bd0ea7e843279f0bcee2ac7f&l=53)
but ToplevelWindowEventHandler is a PreTargetEventHandler of root window
(https://cs.chromium.org/chromium/src/ash/shell.cc?rcl=74853d8d13a89431bd0ea7e843279f0bcee2ac7f&l=1229)
This means the gesture event will be received by arc apps before
ToplevelWindowEventHandler.
This cl creates BackGestureEventHandler, which is also a
PreTargetEventHandler of Shell and being added inside Shell::Init.


Bug: 1026321
Change-Id: Ie7ae2ce7fdfb8e8efa17ffd82f31b8098c01c0d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006012
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732679}

Add shortcut keys AltGr+Left/Right for nagivating back and forth among
pages. This allows users of some European keyboards to navigate with one
hand key operations.

BUG=613201

Change-Id: I5eceeaacf0df8029f2b1d6f7dd6a2d85e1100682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993845Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732678}

For child users, mature extensions should be force-disabled with a
tool-tip explanation. Commit the required string for the tool-tip
before feature freeze on January 17, 2020, so that the translation
team has adequate time to translate the string.

Bug: 1040614
Change-Id: Ide909d6e4f02ff201e2aa5cfd13d11dde1de2df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006112
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#732677}

Today the code sets a primary account on every login. This should not
be necessary, but there is a comment saying it is done to ensure
the google service username is set. That code dates back to 2012 and
was apparently added for migration to a new pref. All users should be
migrated by now.

Remove the comment and only SetPrimaryAccount() for new logins.
Add CHECKs that a primary account exists for existing logins.

No behavior changes are expected.

See comments on this code review for details:
https://chromium-review.googlesource.com/c/chromium/src/+/2001018

Bug: none
Change-Id: I61e68c38a52a16b11508fb75fe0df8c9391645fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006261
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732676}

Change-Id: I394b76031279554998e5a801970db2e12a6c6cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006250Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732675}

This CL moves the IsCtrlExposed function to the V4L2 device, so it can be
reused at other places. Additionally this reduces the number of IOCTLS executed
directly inside the VEA, to provide a better abstraction of the V4L2 device.

TEST=./video_encode_accelerator_unittest on hana

BUG=None

Change-Id: I37981e0b75adcd386a6065f25560dd89dce41791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969083Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732674}

The SmoothnessHelper now measures how many consecutive windows have
a proportion of dropped frames that's over a threshold.  It outputs
a training example with maximum such number found over a playback.

Additionally, it now assumes that it will be created when playback
starts, and will be destroyed when it ends, rather than taking an
explicit "is playing" signal.  If the feature vector changes, then
the SmoothnessHelper should be destroyed / reconstructed too.

Change-Id: I8ceef55f33d6d8164f4a6e2d0e1c77fdbbce53e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004071
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732673}

Share some of the helper macros from MediaLogProperties with these two
new types in the media_log_type_enforcement.h file, which replaces
media_log_properties_helper.h

Bug: 794255
Change-Id: I7c709c5ac881b3bf03ba327d850e0c58824cec57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006130
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732672}

This is similar to crrev.com/c/1999974 but for
FindRegistrationForId{,Only}().

ServiceWorkerStorage::DidFindRegistrationForId() became identical
to DidFindRegistration() so it was merged into a single method.

This CL also changes some tests not to use
ServiceWorkerStorage directly. Use ServiceWorkerRegistry
instead.

FindInstallingRegistrationXXX() are now private methods because
ServiceWorkerStorage doesn't use them anymore.

Bug: 1039200
Change-Id: Ia218afc7109b5f697933956719890442de68d51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004350Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732671}

- Change handleUpdateIntent to onUpdateAvailable, and pull it out
to UpdateUtils for both implementation to use.

Bug: 1013685
Change-Id: I5474e4c8c025ce97b8cec74dfa7bbfb0f9f7bcef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001065
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732670}

BUG=1042946

Change-Id: I665dbfa33d041c870a18433c7f69225cc4e00c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006192
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732669}

Currently, if we can't retrieve the app's icon or the app has no icons,
we use the app's start URL to generate an icon. This change use the
app's name when available to generate the icon.

Bug: 904280
Change-Id: I6233ea5ee90f32de6e270123239055f425edd257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989435Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com>
Cr-Commit-Position: refs/heads/master@{#732668}

This CL:
- Adds @Inject constructor to WebApkUpdateManager
- Makes WebApkUpdateManager listen for activity destruction instead of having
WebApkActivity call WebApkUpdateManager#destroy()

BUG=1042147

Change-Id: I803900ffe2eaf7c8999dc54248676c93caf5b0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001360
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732667}

This updates the parsing of the feature policy parts of the origin policy manifest to mostly match the latest spec draft at https://wicg.github.io/origin-policy/, in particular https://wicg.github.io/origin-policy/#parsing. That is, it moves away from "content-security-policy": [{ "policy": "string", "report-only": boolean }] to "content_security": { "policies": ["...CSP strings"], "policies_report_only": ["...CSP strings"] }.

Additionally, it removes the failure on parsing errors, as those are no longer in the spec.

This does not yet properly parse the CSP string as a CSP; instead it still treats it as a header (so, commas are allowed inside). A failing test is added for that case, which will be addressed in a followup CL.

Bug: 751996
Change-Id: I8d14815b486afd4a5622bc4b25874c81418fd38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977148
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732666}

Currently when |use_media_player| is true, we'll add
FactoryType::kMediaPlayer as the base factory type. But we didn't set
|use_default_renderer_factory| to be false, so later we'll add
FactoryType::kDefault as the base factory type again, which overrides
the FactoryType::kMediaPlayer one we just added.

This CL makes sure we set |use_default_renderer_factory| to be false so
that this bug doesn't happen.

This function is still hard to read and error prone. In the future we
should improve this function further.

Bug: 1040456
Test: Manually tested.
Change-Id: Iade8a45426b3ff9835bb2b6cbc415f4df8a0cf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005090Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732665}

Bug: 891999
Change-Id: I028fc04d68a5a1c7da1c44933346001630274235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997651
Auto-Submit: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732664}

This just helps out the next CL in line which adds the new types for
media log and needs to serialize some of the buffering state types.

Bug: 794255
Change-Id: Id83d79108edc0021316fc362a222eadab7d3f032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005818Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732663}

Bug: 873114
Change-Id: I05cef0d2a7e53c1bc965764e2b83aefd502753cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993828Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#732662}

Enables memoryMetric when a benchmark argument is provided, setting the
appropriate options. These metrics are put behind a flag as it adds over
300 metrics, which may crowd the output unnecessarily.

Bug: 1042404
Change-Id: I05c5e9d2434c5a07a3d2aa632c64f0d077c2443c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002761
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732661}

TBR=kbr@chromium.org

Bug: 1042897
Change-Id: I0c3d58eae57c808afdcd4569e154038db595f609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005826Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#732660}

Bug: 1034579
Change-Id: I0e1b87efb157b2117b04d49e5888f29bc84edfbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978425
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732659}

Bug: 951969, 936273, 933656
Change-Id: I9101d47dddd434f9a4c756bc3153d2980d2b2686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980508
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732658}

Plumbs AudioCodecProfile into AudioDecoderConfig and uses it in a few
key locations:
- FFmpegAudioDecoder will now reject xHE-AAC content to ensure we get
faster startup of MediaCodecAudioDecoder for this content.
- MediaCodecBridgeImpl will use this to avoid parsing the ESDS extra
data on its own.

Bug: 1019299
Change-Id: Ib9c3da758ca2520e70569e73037217843a2d2a04
Tests: Updated unittests.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999625
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732657}

No functional change.

Change-Id: I3c60d5c1f8b2f2f750c61137cc3db6d2d9744b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005824
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732656}

Change-Id: I35f0290322be962918a92a1866974ffe61b955ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006448
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732655}

This reverts commit ffff10c5.

Reason for revert: Temporary CL served it's purpose. ScrollNodes marked as inner_viewport aren't the same as InnerViewportScrollNode.

Original change's description:
> Add CHECKs to debug crash
> 
> It looks like this crashes because of a null outer viewport scroll node.
> That should never happen here because we have an inner viewport scroll
> node.
> 
> There's a few ways this could be going wrong:
> 
> - A ScrollNode is marked as the inner scroll node even though it wasn't
>   registered as one in viewport_property_ids_
> - The ScrollNode doesn't exist in the property tree even though it was
>   registered.
> - We're getting this bad combination from Blink.
> 
> I've turned a few DCHECKs into release CHECKs to narrow down which of
> these it might be.
> 
> Bug: 1037759
> Change-Id: I972582da6e18725557859063da0889d465063c77
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981268
> Commit-Queue: David Bokan <bokan@chromium.org>
> Auto-Submit: David Bokan <bokan@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728220}

TBR=wangxianzhu@chromium.org,bokan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1037759
Change-Id: I64811d9a30b6ba98b395f6e4ea434958afa0b706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006248Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732654}

HistoryNavigationLayout is a top level layout class of gesture
navigation feature, and is a child view of Tab's
ContentView. This CL moves it one level up in the view hierarchy
so that it becomes a child of CompositorViewHolder instead. This
has a few benefits:

1) Many native pages included HistoryNavigationLayout in its
layout definition. This caused undesirable dependencies on
gesture navigation, blocking component-wise modularization
efforts. Once it is removed from native page layout, it becomes
much easier to build each component as its own target.

2) Gesture navigation-related UI doesn't have to be instantiated
for each tab. A single set of instances can be used for all, each
tab only needing to provide with navigation delegate objects that
have dependency on tab when it goes foreground.

3) When the layout is added to Tab's content view, the
UI (especially arrow's fade-away animation when navigation
starts) is visible as long as its parent view is alive, but
navigation between rendered and native page swaps out the content
view. This keeps the navigation and animation from starting
simultaneously. The refactoring gets rid of this limitation.

Major changes are:

- CompositorViewHolder dispatches touch event to
HistoryNavigationLayout. If the right gesture is detected, lets
it consume the following events.

- HistoryNavigationLayout in native pages are either removed or all
replaced with FrameLayout. This is basically reverting relevant
parts of the past CLs:

https://crrev.com/c/1249530 Implement gesture navigation on Android
https://crrev.com/c/1423477 Android: More native pages become navigable
https://crrev.com/c/1547547 Android: Trigger history navigation with edge swipe
https://crrev.com/c/1554200 Android: Enable overscroll navigation in explore site page

- Rendered pages also make use of
HistoryNavigationLayout (previously SwipeRefreshHandler had its
own NavigationHandler) and reference the NavigationHandler that
the layout provides. This helps consolidate most of the
navigation event handling logic in the layout.

Bug: 1003914
Change-Id: I62ed28bd8f6aab39ca7a47f2e3fdce7a131fbfb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961351
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732653}

https://chromium.googlesource.com/angle/angle.git/+log/bdb0f8a52414..d968972519ba

git log bdb0f8a52414..d968972519ba --date=short --first-parent --format='%ad %ae %s'
2020-01-16 jonahr@google.com Suppress UniformsBenchmark perftest on Win/NVIDIA/Vulkan
2020-01-16 m.maiya@samsung.com EGL: Add support for EGL_EXT_pixel_format_float extension
2020-01-16 sugoi@google.com Blendable check
2020-01-16 jmadill@chromium.org Vulkan: Make ContextVk own ResourceUseList.
2020-01-16 jdarpinian@chromium.org Require DEBUG_TRACE to enable expensive state validation
2020-01-16 jdarpinian@chromium.org Remove literal tab characters from generate_parser_tools.py
2020-01-16 jmadill@chromium.org Vulkan: Add ResourceUseList helper.

Created with:
  gclient setdep -r src/third_party/angle@d968972519ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1041672
Tbr: jonahr@google.com
Change-Id: Ia0f06af0bc2907b9450fe060b331dc482a14eb20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732652}

Change-Id: I0b35b89c0b9721b11932925451e2e8a2c5024740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005825
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732651}

The onEnrolling_() method and its EnrollmentStatus argument type were
conflating two logically separate events: fingerprint sample status
updates ("sensor was touched") and handling the final enrollment
response. Splitting the type in two (SampleResponse / EnrollmentResponse),
and handle them in separate methods simplifies the code.

Also improve error handling in both cases:
- failure status codes in a SampleResponse cause a "try again"
  message in the enrollment sheet to be shown
- CTAP2 errors on the EnrollmentResponse make the dialog proceed to the
  error sheet

Bug: 974046
Change-Id: Ib8492aae493374f84b368bb6eca6b9eb439af685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999268
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732650}

glyph_cache_max_texture_bytes was passed to PaintOpBufferSerializer as
max_texture_bytes in RasterImplementation::RasterCHROMIUM().
max_texture_bytes is not actually used for anything after
crrev.com/688282. This means that max_texture_bytes doesn't need to
be passed to PaintOpBuffer and glyph_cache_max_texture_bytes() can be
removed as well.

Change-Id: Id13234fbfcf4ece578fbd89d57fd15a018590444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995614
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732649}